Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/512
+1 looks good
---
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/503
+1 looks good
---
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/500
I'm +1. Thanks Bogdan for making the PR.
---
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/438#discussion_r179363930
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
@@ -1183,8 +1183,10 @@ public long getEpochToPropose(long sid, long
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/411#discussion_r148117464
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java ---
@@ -246,33 +246,51 @@ public void run
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/411#discussion_r147854385
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
@@ -376,4 +377,123 @@ public void
GitHub user shralex opened a pull request:
https://github.com/apache/zookeeper/pull/328
ZOOKEEPER-2865: Reconfig Causes Inconsistent Configuration file amongâ¦
⦠the nodes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/315#discussion_r129148693
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1451,7 +1452,12 @@ public synchronized void
restartLeaderElection
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/292
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125805265
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,263 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125806082
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,263 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125806125
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,263 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125120823
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRecoveryTest.java ---
@@ -28,9 +28,15 @@
import
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125126374
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125125684
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125121157
--- Diff:
src/java/test/org/apache/zookeeper/test/ReconfigExceptionTest.java ---
@@ -89,6 +89,7 @@ public void tearDown() throws Exception
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125126799
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125124612
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r125127752
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/ReconfigRollingRestartCompatibilityTest.java
---
@@ -0,0 +1,275 @@
+/**
+ * Licensed
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/297
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/297#discussion_r124709964
--- Diff:
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
@@ -590,14 +590,13 @@ public boolean
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/292
Michael, thanks for the changes. Do we need some tests that can catch the
issue I pointed out - one server is getting rebooted with a new config file,
but other servers push old config to that
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/292#discussion_r124183585
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -1744,9 +1744,14 @@ public void setAcceptedEpoch(long e) throws
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/215#discussion_r110712848
--- Diff: src/java/test/org/apache/zookeeper/test/ShedClientsTest.java ---
@@ -0,0 +1,161 @@
+/**
--- End diff --
This test uses a single
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/215#discussion_r110710035
--- Diff: src/docs/src/documentation/content/xdocs/zookeeperAdmin.xml ---
@@ -1974,6 +1974,31 @@ server.3=zoo3:2888:3888
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/213
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shralex commented on the issue:
https://github.com/apache/zookeeper/pull/190
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/190#discussion_r105828217
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/StandaloneDisabledTest.java ---
@@ -102,6 +102,8 @@ public void startSingleServerTest() throws
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100683078
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
@@ -106,6 +106,7 @@ public void shutdown
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100486141
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java ---
@@ -251,27 +252,29 @@ public void run
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100486359
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java ---
@@ -251,27 +252,29 @@ public void run
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100486610
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/CommitProcessorConcurrencyTest.java
---
@@ -106,6 +106,7 @@ public void shutdown
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/167#discussion_r100486459
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/CommitProcessor.java ---
@@ -251,27 +252,29 @@ public void run
Github user shralex commented on the pull request:
https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20584642
In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java:
In src/java/main/org/apache/zookeeper/server
Github user shralex commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/92#discussion_r97266698
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -468,31 +469,33 @@ synchronized private boolean connectOne(long sid
35 matches
Mail list logo
