Re: [DISCUSS] QA github pre-commit queue

2016-11-18 Thread Patrick Hunt
On Wed, Nov 9, 2016 at 6:46 PM, Flavio Junqueira wrote: > > > On 09 Nov 2016, at 10:39, Patrick Hunt wrote: > > > > What are the implications of moving away from JIRA patches? Any legal/IP? > > Also PRs are through github.com, which is not infra owned by Apache. > > This is supported by infra: >

Re: [DISCUSS] QA github pre-commit queue

2016-11-09 Thread Flavio Junqueira
> On 09 Nov 2016, at 10:39, Patrick Hunt wrote: > > What are the implications of moving away from JIRA patches? Any legal/IP? > Also PRs are through github.com, which is not infra owned by Apache. This is supported by infra: https://reference.apache.org/pmc/github > If > that service ever goe

Re: [DISCUSS] QA github pre-commit queue

2016-11-09 Thread Patrick Hunt
What are the implications of moving away from JIRA patches? Any legal/IP? Also PRs are through github.com, which is not infra owned by Apache. If that service ever goes away we'll lose that information. What are other projects doing in this regard? Any impact on our workflows outside of qabot? e.g

Re: [DISCUSS] QA github pre-commit queue

2016-11-08 Thread Flavio P JUNQUEIRA
I don't have any strong argument for keeping the Jira patches other than the fact that this is what we have been doing since the project was created. If there is anyone who do not want to use github in the community, please speak up. -Flavio On Mon, Nov 7, 2016 at 9:49 AM, Michael Han wrote: >

Re: [DISCUSS] QA github pre-commit queue

2016-11-08 Thread Flavio P JUNQUEIRA
My bad, I made the build parameterized to see if I could trigger it manually. I have disabled the parameters and should be back to normal now. -Flavio On Tue, Nov 8, 2016 at 4:00 PM, Michael Han wrote: > Git PR bot builds > ha

Re: [DISCUSS] QA github pre-commit queue

2016-11-08 Thread Michael Han
Git PR bot builds have been failing after build 44. From the log it looks like for some reasons, variables like 'GIT_PR_NUMBER', 'GIT_PR_TITLE' etc were undefined. Is this a configuration issue of build bot? On Mon, Nov 7, 2016 a

Re: [DISCUSS] QA github pre-commit queue

2016-11-07 Thread Michael Han
+1 for disabling jira qa and only support pull request for code change contributions. Besides making support easier this approach is also aligned with what Spark and Kafka is doing, and being consistent across Apache projects regarding how to use PR seems a good thing to do. >> have the tool uploa

Re: [DISCUSS] QA github pre-commit queue

2016-11-07 Thread Edward Ribeiro
I am +1 about having patches submitted via PRs. IMHO, we should disable the Jira QA altogether, but have the tool upload the *.patch file to Jira for archiving purposes. On Sun, Nov 6, 2016 at 6:42 PM, Raúl Gutiérrez Segalés wrote: > On 6 November 2016 at 11:54, Flavio Junqueira wrote: > > > ZO

Re: [DISCUSS] QA github pre-commit queue

2016-11-06 Thread Raúl Gutiérrez Segalés
On 6 November 2016 at 11:54, Flavio Junqueira wrote: > ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for reviewing. > > The QA for pull requests should be working for pull requests agains > master, but let's keep an eye and polish any rough edges that might still > be there. > > Wit

[DISCUSS] QA github pre-commit queue

2016-11-06 Thread Flavio Junqueira
ZOOKEEPER-2624 has been merged, thank Raul, Ben and Michael for reviewing. The QA for pull requests should be working for pull requests agains master, but let's keep an eye and polish any rough edges that might still be there. With ZOOKEEPER-2624 in, there is one last major decision we need to m