anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-462297430
Committed to master. Thanks @nkalmar !
This is an automated m
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-461042144
@nkalmar So this patch can be merged as it is if I understood you correctly.
(once you removed the empty jar)
---
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-460967355
@nkalmar @eolivelli @tamaashu Where are we with this patch? Is it ready to
be committed or something is missing?
Source tar
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-459359173
@nkalmar README.md file is not the best place to document the release
process with Maven. I see that it already has a section
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-458489578
@nkalmar
- Jars look good to me now,
- source descriptor xml has been moved to project dir which is fine,
Issues:
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-457153960
Thanks @nkalmar !
The build works as expected now. However that top level `src` directory is a
little bit ugly. Can we put
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456802034
Hi @eolivelli @nkalmar .
I did another test today by rebasing this patch on latest master and running
`mvn clean package -D
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456539873
Thanks @nkalmar @eolivelli will try that. Btw you're not on the same page
regarding further PR. Norber said this should be the
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456460799
@eolivelli Rebased on current master and tried with the command you
suggested.
Now the artifacts contain "SNAPSHOT" in
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456427738
It was my fault, I got it working now.
I'm trying to compare the artifacts generated by this process:
https://cwiki.apa
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456418732
It'd be nice to add some guidance to this PR or the Jira. How can test the
package / What's the expected output of the command
anmolnar commented on issue #776: MAVEN MIGRATION - ZOOKEEPER-3028 - Create
maven assembly
URL: https://github.com/apache/zookeeper/pull/776#issuecomment-456417929
@nkalmar @eolivelli
I'm trying to test this patch by running `mvn release:prepare` and got the
following error message:
12 matches
Mail list logo
