Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
As per the offline discussion with @afine, identified that `checkstyle ant
task` is not working in branch-3.4 and will be raising a new jira task to
correct this.
```
checkstyle.check:
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/178
Sorry @rakeshadr, I misunderstood your previous comment.
So I have concerns about changing the way dependencies are pulled for the
test build for what is a very minor developer
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
> I did not add the transitive="false" because we are not using it for the
default configuration on the previous line. If you feel strongly about it I
will add it.
As we know, earlier
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/178
I did not add the `transitive="false"` because we are not using it for the
`default` configuration on the previous line. If you feel strongly about it I
will add it.
In addition, since
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
Please add `transitive="false"` explicitly to checkstyle artifcat.
```
```
Otw, this is pulling the following dependencies to the `.classpath`, which
is not required.
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/178
You are correct @rakeshadr , that test fails. I will change the patch to
just removing `transitive="false"`
---
If your project is set up for it, you can reply to this email and have your
reply
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
>> I was able to run the unit tests within eclipse or idea (I used
WatcherTest as my example) using just the dependencies I added in the patch.
@afine , Probably, you can run
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/178
Hi @rakeshadr
I was able to run the unit tests within eclipse or idea (I used WatcherTest
as my example) using just the dependencies I added in the patch.
That being said I
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/178
Thanks @afine for reporting this. With newly added dependencies, the
compilation error will be resolved. But, I could see while running unit test
case in eclipse, it needed all the transitive
Github user afine commented on the issue:
https://github.com/apache/zookeeper/pull/178
Hoping you can take a look @rakeshadr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
10 matches
Mail list logo
