Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm Got a few spare cycles to address my comments?
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Agreed @zodvik . The scope of this Jira is to limit it to a generic slow
query log and identify the outliers if any. For that reason, I am printing the
actual request to the log as well. An
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm Thank you! I have rebased the patch. The jenkins build has been
failing for a while and my patch doesn't introduce new failure. Thanks once
again!
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/307
looks like the branch has merge conflicts. do you mind update your patch
with latest master and I'll review @karanmehta93
---
Github user zodvik commented on the issue:
https://github.com/apache/zookeeper/pull/307
> reasons why any given read or write operation may become slow: a software
bug, a protocol problem, a hardware issue with the commit log(s), a network
issue. If the problem is constant it is
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Hello everyone,
Appreciate your efforts in reviewing this patch. @hanm @tdunning @eribeiro
@skamille
Is there any possibility that the patch will get merged in (with minor
changes
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
> Can we at least make it so that the process of "push a metric to a
buffer, have a thread that wakes up periodically and flushes information out of
that buffer" is usable by multiple parts
Github user skamille commented on the issue:
https://github.com/apache/zookeeper/pull/307
I appreciate the work that you are trying to do here, and this still feels
like an incomplete approach to a problem that would be worth investing further
into. It seems like we all agree that it
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Ping @hanm @tdunning @eribeiro @skamille for a review if you got some time.
Thanks!
---
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
Due to some reason, Jenkins didn't build it automatically. I triggered a
manual build with my latest commit ID SHA1 and the results are at
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@tdunning Sorry about this. I rebased my branch with the current master and
pushed my patch along with it. Now it is showing up all those commits as my
commits. Let me try to figure out a
Github user tdunning commented on the issue:
https://github.com/apache/zookeeper/pull/307
What is this pull request? 45 commits? 95 changed files? Lots of commits
without associated issues?
(danger, danger)
---
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/307
There are -1 on findbugs, release audits, and test failures reported by
Jekins. Please investigate.
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm @eribeiro @tdunning @skamille
Please review.
Now that I have added rate limiting to logging, can we also turn this on by
default?
---
If your project is set up for it, you
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm @eribeiro @tdunning
I have fixed the whitespace issues and final patch is ready, Please review
whenever convenient.
---
If your project is set up for it, you can reply to this
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm
> I think at some point after merge this you need create another pull
request targeting stable branch (branch-3.4) where the version number should be
3.4.11 (hopefully, if this
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/307
>> And for the documentation, this property is being introduced from 3.5.4
version, Is that correct?
Yes, for this specific pull request targeting master. I think at some point
after merge
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@eribeiro Thank you for your comments. Will post an updated patch soon.
A small concern regarding the `ServerStats.updateLatency()` method.
Should the updated patch have both the
Github user eribeiro commented on the issue:
https://github.com/apache/zookeeper/pull/307
@karanmehta93 hi, mate.
You don't need to touch `ZooKeeperAdmin.html` You change
`ZooKeeperAdmin.xml` **only** and Apache Forrest generate html anf PDF. Also,
this xml change should be
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
@hanm @eribeiro
Thank you for your comments. I have added a rebased patch with a test in
`ZooKeeperServerMainTest` class. Please review whenever convenient.
> It's odd to have
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/307
I think we should consolidate the latency check in
`zks.serverStats().updateLatency`. It's odd to have two (or in future even
more) types of latency checks scattered around which creates
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/307
@karanmehta93 Thanks for update the pull request with more context
information. Do you mind put the context description in the pull request
description?
Regarding test cases, I think you
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
From my understanding, `QuorumPeer` class will be the candidate class to
maintain this data structure. Let me know alternatives.
I will look into the data-structure ideas you provided
Github user tdunning commented on the issue:
https://github.com/apache/zookeeper/pull/307
So here is an alternative suggestion.
For each class of operation (GET, PUT, MULTIPUT, DELETE and so on) maintain
a data structure (such as t-digest or Floathistogram see
Github user karanmehta93 commented on the issue:
https://github.com/apache/zookeeper/pull/307
ZooKeeper is a complex distributed application. There are many reasons why
any given read or write operation may become slow: a software bug, a protocol
problem, a hardware issue with the
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/307
General comment: please add more description on the pull request on what's
the motivation of change and how it impacts performance / improve debugging
etc. Or add those to the JIRA and post a digest
26 matches
Mail list logo
