Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Are you still working on this?
or someone else can pick up this?
---
Github user sumitagrawl commented on the issue:
https://github.com/apache/zookeeper/pull/474
@maoling @afine Comments are fixed, please check
---
Github user maoling commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Can we move on?
---
Github user sumitagrawl commented on the issue:
https://github.com/apache/zookeeper/pull/474
@rakeshadr @anmolnar @afine
Changes are done creating separate ServerCnxnTest.java for this purpose to
avoid test duplicates. Also all above review comments are handled.
---
Github user rakeshadr commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Good analysis and fix. Few minor comments,
- Please take care indentation in the tests. Presently, it uses tab.
- Please add comments in test as a quick reference to the
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/474
@sumitagrawl Thanks for opening this pull request and thanks for the
contribution.
This stuff with the test looks good to me.
Given that this is a fix in base class (ServerCnxn) rather
