[GitHub] zookeeper issue #533: ZOOKEEPER-2989:IPv6 literal address causes problems fo...

2018-06-04 Thread nkalmar
Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/533 I agree with @anmolnar in that the methods are a little robust and test multiple things. Whether it should be refactored whenever we touch a unit test, that's a tough question. But I

[GitHub] zookeeper issue #533: ZOOKEEPER-2989:IPv6 literal address causes problems fo...

2018-05-30 Thread maoling
Github user maoling commented on the issue: https://github.com/apache/zookeeper/pull/533 @anmolnar **InitialMessage** is a inner-class of **QuorumCnxManager**. Is it necessary to a separate test file? @phunt @hanm What's your opinion? ---