[GitHub] zookeeper pull request #:

2017-07-03 Thread eribeiro
Github user eribeiro commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886375 In src/java/main/org/apache/zookeeper/ZooKeeper.java: In src/java/main/org/apache/zookeeper/ZooKeeper.java on line 1538:

[GitHub] zookeeper pull request #:

2017-07-03 Thread eribeiro
Github user eribeiro commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886369 In src/java/main/org/apache/zookeeper/ZooKeeper.java: In src/java/main/org/apache/zookeeper/ZooKeeper.java on line 1439:

[GitHub] zookeeper pull request #:

2017-07-03 Thread eribeiro
Github user eribeiro commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886377 In src/java/main/org/apache/zookeeper/ZooKeeper.java: In src/java/main/org/apache/zookeeper/ZooKeeper.java on line 2380:

[GitHub] zookeeper pull request #:

2017-07-03 Thread eribeiro
Github user eribeiro commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886435 In src/java/test/org/apache/zookeeper/test/ACLTest.java: In src/java/test/org/apache/zookeeper/test/ACLTest.java on line 21

[GitHub] zookeeper pull request #:

2017-07-03 Thread eribeiro
Github user eribeiro commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886495 In src/java/test/org/apache/zookeeper/test/ACLTest.java: In src/java/test/org/apache/zookeeper/test/ACLTest.java on line 19

[GitHub] zookeeper pull request #:

2017-07-03 Thread eribeiro
Github user eribeiro commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22886506 In src/java/test/org/apache/zookeeper/test/ACLTest.java: In src/java/test/org/apache/zookeeper/test/ACLTest.java on line 23

[GitHub] zookeeper pull request #:

2017-07-05 Thread jainbhupendra24
Github user jainbhupendra24 commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22943164 In src/java/test/org/apache/zookeeper/test/ACLTest.java: In src/java/test/org/apache/zookeeper/test/ACLTest.java on

[GitHub] zookeeper pull request #:

2017-07-06 Thread jainbhupendra24
Github user jainbhupendra24 commented on the pull request: https://github.com/apache/zookeeper/commit/15d9a574edeaeef1c43937833cef44584115cd3d#commitcomment-22946367 In src/java/test/org/apache/zookeeper/test/ACLTest.java: In src/java/test/org/apache/zookeeper/test/ACLTest.java on

[GitHub] zookeeper pull request #:

2018-06-24 Thread meteorfreeze1234
Github user meteorfreeze1234 commented on the pull request: https://github.com/apache/zookeeper/commit/3952f4579cb55602fecc002804e3d40aa1196ccc#commitcomment-29479708 dfsfdsf ---

[GitHub] zookeeper pull request #:

2018-06-26 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/cac68c3503d207c5f7d955ba582dfe3bfa22cb9b#commitcomment-29499666 Interesting so the test used 3 zeroes ---

[GitHub] zookeeper pull request #:

2018-06-26 Thread nkalmar
Github user nkalmar commented on the pull request: https://github.com/apache/zookeeper/commit/cac68c3503d207c5f7d955ba582dfe3bfa22cb9b#commitcomment-29499851 Yes, but the intention was to use unique port numbers, although the test still passed with 3 zeros. Also, I'm not sure why

[GitHub] zookeeper pull request #:

2018-07-29 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29873077 @nkalmar Could you plz create a JIRA to document this metric `zk_fsync_threshold_exceed_count` in the part of `mntr` of `zoo

[GitHub] zookeeper pull request #:

2018-07-30 Thread nkalmar
Github user nkalmar commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29880817 @maoling It has been intentionally removed from 3.6 and 3.5, as I was told the 4 letter words is deprecated, and it will be rem

[GitHub] zookeeper pull request #:

2018-07-30 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29885683 @nkalmar Thanks for your ACK. 4 letter words will be deprecated? why? ---

[GitHub] zookeeper pull request #:

2018-07-30 Thread anmolnar
Github user anmolnar commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29886282 Insecure. JMX and Jetty are the future for 3.5+ JMX is also questionable. Not sure if we could drop that too. ---

[GitHub] zookeeper pull request #:

2018-07-31 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29915646 @anmolnar Sir, Could you plz tell me why the 4 letter words is insecure? ---

[GitHub] zookeeper pull request #:

2018-08-01 Thread nkalmar
Github user nkalmar commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29917129 @maoling , the problem is, there is no security implemented. Anyone user who can access ZooKeeper, can send commands to the ens

[GitHub] zookeeper pull request #:

2018-08-01 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29922823 @nkalmar Thanks for your nice explain. these security problems can also exist in the JMX and Jetty? ---

[GitHub] zookeeper pull request #:

2018-08-02 Thread nkalmar
Github user nkalmar commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29934308 Both JMX and Jetty can be secured. The problem here is, as of my understanding, is that 4ltw command uses the client port. You

[GitHub] zookeeper pull request #:

2018-08-02 Thread maoling
Github user maoling commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29935400 wonderful explain.thanks @nkalmar ---

[GitHub] zookeeper pull request #:

2018-08-06 Thread anmolnar
Github user anmolnar commented on the pull request: https://github.com/apache/zookeeper/commit/a2623a625a4778720f7d5482d0a66e9b37ae556f#commitcomment-29970536 @maoling Trying to find the best email thread in MarkMail for you, but @nkalmar gave you a very good reasoning. It's a long ou

[GitHub] zookeeper pull request #:

2018-10-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/c57b62d57b8b22d568b1cea3b8039566936e0558#commitcomment-30735811 In src/java/main/org/apache/zookeeper/SaslServerPrincipal.java: In src/java/main/org/apache/zookeeper/SaslServerPrincipal.

[GitHub] zookeeper pull request #:

2018-11-01 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31139343 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/

[GitHub] zookeeper pull request #:

2018-11-01 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31139412 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/

[GitHub] zookeeper pull request #:

2018-11-01 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31139429 In zookeeper-server/src/test/java/org/apache/zookeeper/common/FileChangeWatcherTest.java: In zookeeper-server/src/test/j

[GitHub] zookeeper pull request #:

2018-11-01 Thread ivmaykov
Github user ivmaykov commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31143262 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/z

[GitHub] zookeeper pull request #:

2018-11-01 Thread ivmaykov
Github user ivmaykov commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31143267 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/z

[GitHub] zookeeper pull request #:

2018-11-01 Thread ivmaykov
Github user ivmaykov commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31143275 In zookeeper-server/src/test/java/org/apache/zookeeper/common/FileChangeWatcherTest.java: In zookeeper-server/src/test/ja

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151383 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151424 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151441 In zookeeper-server/src/test/java/org/apache/zookeeper/common/FileChangeWatcherTest.java: In zookeeper-server/src/test/j

[GitHub] zookeeper pull request #:

2018-11-02 Thread ivmaykov
Github user ivmaykov commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151782 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/z

[GitHub] zookeeper pull request #:

2018-11-02 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/232232e7f338a9eca440d89dcfc8ed22e0336e60#commitcomment-31151817 In zookeeper-server/src/main/java/org/apache/zookeeper/common/X509Util.java: In zookeeper-server/src/main/java/org/apache/

[GitHub] zookeeper pull request #:

2018-11-17 Thread eolivelli
Github user eolivelli commented on the pull request: https://github.com/apache/zookeeper/commit/82da83a7176bbdd73dedb6fc3d96dac706cefad3#commitcomment-31339939 In zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java: In zookeeper-server/src/main/java/org/apache/

[GitHub] zookeeper pull request #:

2018-11-18 Thread asdf2014
Github user asdf2014 commented on the pull request: https://github.com/apache/zookeeper/commit/82da83a7176bbdd73dedb6fc3d96dac706cefad3#commitcomment-31341678 In zookeeper-server/src/main/java/org/apache/zookeeper/jmx/ManagedUtil.java: In zookeeper-server/src/main/java/org/apache/z

[GitHub] zookeeper pull request #:

2017-01-04 Thread sgrillon14
Github user sgrillon14 commented on the pull request: https://github.com/apache/zookeeper/commit/eb38f5b5db860a35c58dde976dce540d7958fdba#commitcomment-20356354 Hello cnauroth, You change "Win32 is supported as a **development platform only** for both server and client." by "

[GitHub] zookeeper pull request #:

2017-01-04 Thread cnauroth
Github user cnauroth commented on the pull request: https://github.com/apache/zookeeper/commit/eb38f5b5db860a35c58dde976dce540d7958fdba#commitcomment-20365123 Hello @sgrillon14 . I am aware of multiple projects running ZooKeeper on Windows in production. (Unfotunately, I can't reall

[GitHub] zookeeper pull request #:

2017-01-23 Thread shralex
Github user shralex commented on the pull request: https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20584642 In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java: In src/java/main/org/apache/zookeeper/server/quor

[GitHub] zookeeper pull request #:

2017-01-23 Thread hanm
Github user hanm commented on the pull request: https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20584729 In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java: In src/java/main/org/apache/zookeeper/server/quorum/

[GitHub] zookeeper pull request #:

2017-01-23 Thread hanm
Github user hanm commented on the pull request: https://github.com/apache/zookeeper/commit/de367bf0694ba8adb11d42b4fc07f6e6a851b782#commitcomment-20585960 In src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java: In src/java/main/org/apache/zookeeper/server/quorum/

[GitHub] zookeeper pull request: Master

2016-05-27 Thread Felix-Pobaby
GitHub user Felix-Pobaby opened a pull request: https://github.com/apache/zookeeper/pull/69 Master Can'I update the ZooKeeper Sessions state diagram? You can merge this pull request into a Git repository by running: $ git pull https://github.com/Felix-Pobaby/zookeeper master

[GitHub] zookeeper pull request #269: Sugon

2017-05-31 Thread JiangJiafu
GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/269 Sugon You can merge this pull request into a Git repository by running: $ git pull https://github.com/JiangJiafu/zookeeper sugon Alternatively you can review and apply these changes as

[GitHub] zookeeper pull request #269: Sugon

2017-05-31 Thread JiangJiafu
Github user JiangJiafu closed the pull request at: https://github.com/apache/zookeeper/pull/269 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request #494: xx

2018-03-26 Thread brettKK
Github user brettKK closed the pull request at: https://github.com/apache/zookeeper/pull/494 ---

[GitHub] zookeeper pull request #646: Reconnect

2018-09-27 Thread roodkcab
GitHub user roodkcab opened a pull request: https://github.com/apache/zookeeper/pull/646 Reconnect You can merge this pull request into a Git repository by running: $ git pull https://github.com/roodkcab/zookeeper reconnect Alternatively you can review and apply these changes

[GitHub] zookeeper pull request #646: Reconnect

2018-09-27 Thread roodkcab
Github user roodkcab closed the pull request at: https://github.com/apache/zookeeper/pull/646 ---

[GitHub] zookeeper pull request #732: typo

2018-12-06 Thread stanlyDoge
GitHub user stanlyDoge opened a pull request: https://github.com/apache/zookeeper/pull/732 typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/stanlyDoge/zookeeper patch-1 Alternatively you can review and apply these changes as

[GitHub] zookeeper pull request: Branch 3.5

2015-06-13 Thread leoricxu
GitHub user leoricxu opened a pull request: https://github.com/apache/zookeeper/pull/35 Branch 3.5 git-svn-id: https://svn.apache.org/repos/asf/zookeeper/branches/branch-3.5@1684112 13f79535-47bb-0310-9956-ffa450edef68 You can merge this pull request into a Git repository by runni

[GitHub] zookeeper pull request: ZOOKEEPER-2255

2015-08-19 Thread YvonneIronberg
GitHub user YvonneIronberg opened a pull request: https://github.com/apache/zookeeper/pull/41 ZOOKEEPER-2255 You can merge this pull request into a Git repository by running: $ git pull https://github.com/YvonneIronberg/zookeeper zk-2255 Alternatively you can review and apply

[GitHub] zookeeper pull request: Update zookeeperOver.html

2015-10-31 Thread stevejs
GitHub user stevejs opened a pull request: https://github.com/apache/zookeeper/pull/47 Update zookeeperOver.html Type fix You can merge this pull request into a Git repository by running: $ git pull https://github.com/stevejs/zookeeper patch-1 Alternatively you can review and

[GitHub] zookeeper pull request: Zookeeper 1045

2015-12-12 Thread rakeshadr
GitHub user rakeshadr opened a pull request: https://github.com/apache/zookeeper/pull/49 Zookeeper 1045 QuorumPeer mutual auth using SASL - Kerberos, DIgest mechanisms. TODO: Upgrade path has to be discussed. You can merge this pull request into a Git repository by running:

[GitHub] zookeeper pull request: Update zookeeper.h

2016-03-09 Thread itayB
GitHub user itayB opened a pull request: https://github.com/apache/zookeeper/pull/56 Update zookeeper.h Typo fix (Comments) You can merge this pull request into a Git repository by running: $ git pull https://github.com/itayB/zookeeper trunk Alternatively you can review and ap

[GitHub] zookeeper pull request: Branch 3.1

2016-03-24 Thread karanmarjara
GitHub user karanmarjara opened a pull request: https://github.com/apache/zookeeper/pull/60 Branch 3.1 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/zookeeper branch-3.1 Alternatively you can review and apply these chan

[GitHub] zookeeper pull request: ZOOKEEPER-2247

2016-04-19 Thread rakeshadr
GitHub user rakeshadr opened a pull request: https://github.com/apache/zookeeper/pull/65 ZOOKEEPER-2247 Created this PR using proposed "ZOOKEEPER-2247-15.patch" in the jira. You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakeshad

[GitHub] zookeeper pull request: Branch 3.4

2016-04-23 Thread ralic
Github user ralic closed the pull request at: https://github.com/apache/zookeeper/pull/66 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is ena

[GitHub] zookeeper pull request: Branch 3.4

2016-04-23 Thread ralic
GitHub user ralic opened a pull request: https://github.com/apache/zookeeper/pull/66 Branch 3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/zookeeper branch-3.4 Alternatively you can review and apply these changes as

[GitHub] zookeeper pull request: Update Op.java

2016-04-27 Thread buptUnixGuys
GitHub user buptUnixGuys opened a pull request: https://github.com/apache/zookeeper/pull/67 Update Op.java A minor bug. You can merge this pull request into a Git repository by running: $ git pull https://github.com/buptUnixGuys/zookeeper patch-1 Alternatively you can review a

[GitHub] zookeeper pull request: Update NIOServerCnxnFactory.java

2014-05-02 Thread kouchengkun
GitHub user kouchengkun opened a pull request: https://github.com/apache/zookeeper/pull/12 Update NIOServerCnxnFactory.java workPool may be multi-thread, so the IO event of different connection should be handled by different thread. You can merge this pull request into a Git reposi

[GitHub] zookeeper pull request #226: merge Request

2017-04-11 Thread tianrobin
GitHub user tianrobin opened a pull request: https://github.com/apache/zookeeper/pull/226 merge Request merge from You can merge this pull request into a Git repository by running: $ git pull https://github.com/tianrobin/zookeeper trunk Alternatively you can review and apply

[GitHub] zookeeper pull request #226: merge Request

2017-04-11 Thread tianrobin
Github user tianrobin closed the pull request at: https://github.com/apache/zookeeper/pull/226 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature i

[GitHub] zookeeper pull request #210: Fix typo

2017-04-14 Thread jeffwidman
Github user jeffwidman closed the pull request at: https://github.com/apache/zookeeper/pull/210 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request #206: Branch 3.5

2017-04-18 Thread gstein
Github user gstein closed the pull request at: https://github.com/apache/zookeeper/pull/206 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zookeeper pull request #212: Branch 3.4

2017-04-18 Thread gstein
Github user gstein closed the pull request at: https://github.com/apache/zookeeper/pull/212 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] zookeeper pull request #250: Branch 3.4

2017-05-11 Thread JiangJiafu
GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/250 Branch 3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/zookeeper branch-3.4 Alternatively you can review and apply these chang

[GitHub] zookeeper pull request #250: Branch 3.4

2017-05-11 Thread JiangJiafu
Github user JiangJiafu closed the pull request at: https://github.com/apache/zookeeper/pull/250 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request #253: ZOOKEEPER-2774

2017-05-13 Thread JiangJiafu
GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/253 ZOOKEEPER-2774 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JiangJiafu/zookeeper ZOOKEEPER-2774 Alternatively you can review and apply

[GitHub] zookeeper pull request #253: ZOOKEEPER-2774

2017-05-15 Thread afine
Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/253#discussion_r116588671 --- Diff: src/java/main/org/apache/zookeeper/ZKUtil.java --- @@ -120,5 +120,4 @@ public static void deleteRecursive(ZooKeeper zk, final String pathRoot, Voi

[GitHub] zookeeper pull request #253: ZOOKEEPER-2774

2017-05-18 Thread JiangJiafu
Github user JiangJiafu closed the pull request at: https://github.com/apache/zookeeper/pull/253 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request #261: Branch 3.4

2017-05-22 Thread JiangJiafu
GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/261 Branch 3.4 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JiangJiafu/zookeeper branch-3.4 Alternatively you can review and apply these c

[GitHub] zookeeper pull request #261: Branch 3.4

2017-05-26 Thread JiangJiafu
Github user JiangJiafu closed the pull request at: https://github.com/apache/zookeeper/pull/261 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] zookeeper pull request #308: ZOOKEEPER-2842

2017-07-12 Thread maoling
GitHub user maoling opened a pull request: https://github.com/apache/zookeeper/pull/308 ZOOKEEPER-2842 1.optimize the finish() of Send/RecvWorker in QuorumCnxManager 2.remove testInitiateConnection() 3. formates some codes You can merge this pull request into a Git reposit

[GitHub] zookeeper pull request #376: Update OutputArchive.java

2017-09-22 Thread 20100507
GitHub user 20100507 opened a pull request: https://github.com/apache/zookeeper/pull/376 Update OutputArchive.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/20100507/zookeeper master Alternatively you can review and apply

[GitHub] zookeeper pull request #380: Develeper shonminh

2017-09-24 Thread Shonminh
GitHub user Shonminh opened a pull request: https://github.com/apache/zookeeper/pull/380 Develeper shonminh You can merge this pull request into a Git repository by running: $ git pull https://github.com/BeautifulCodingLife/zookeeper develeper-shonminh Alternatively you can

[GitHub] zookeeper pull request #386: Cmake fixes

2017-09-28 Thread proller
GitHub user proller opened a pull request: https://github.com/apache/zookeeper/pull/386 Cmake fixes 1. decrease cmake version (to allow compile on some old systems) 2. do not use global include_directories (and auto include when linking to external projects) 3. replace CMAKE

[GitHub] zookeeper pull request #386: Cmake fixes

2017-09-28 Thread phunt
Github user phunt commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/386#discussion_r141674581 --- Diff: src/c/CMakeLists.txt --- @@ -14,14 +14,13 @@ # See the License for the specific language governing permissions and # limitations under th

[GitHub] zookeeper pull request #403: Zookeeper 2923

2017-10-22 Thread JiangJiafu
GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/403 Zookeeper 2923 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JiangJiafu/zookeeper ZOOKEEPER-2923 Alternatively you can review and apply

[GitHub] zookeeper pull request #408: ZOOKEEPER-2923

2017-10-26 Thread JiangJiafu
GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/408 ZOOKEEPER-2923 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JiangJiafu/zookeeper ZOOKEEPER-2923 Alternatively you can review and apply

[GitHub] zookeeper pull request #403: Zookeeper 2923

2017-10-26 Thread JiangJiafu
Github user JiangJiafu closed the pull request at: https://github.com/apache/zookeeper/pull/403 ---

[GitHub] zookeeper pull request #408: ZOOKEEPER-2923

2017-11-15 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/408 ---

[GitHub] zookeeper pull request #380: Develeper shonminh

2017-11-27 Thread Shonminh
Github user Shonminh closed the pull request at: https://github.com/apache/zookeeper/pull/380 ---

[GitHub] zookeeper pull request #442: Update zookeeperOver.html

2018-01-06 Thread MichaelYgZhang
GitHub user MichaelYgZhang opened a pull request: https://github.com/apache/zookeeper/pull/442 Update zookeeperOver.html You can merge this pull request into a Git repository by running: $ git pull https://github.com/MichaelYgZhang/zookeeper master Alternatively you can revie

[GitHub] zookeeper pull request #442: Update zookeeperOver.html

2018-01-07 Thread MichaelYgZhang
Github user MichaelYgZhang closed the pull request at: https://github.com/apache/zookeeper/pull/442 ---

[GitHub] zookeeper pull request #376: Update OutputArchive.java

2018-01-09 Thread 20100507
Github user 20100507 closed the pull request at: https://github.com/apache/zookeeper/pull/376 ---

[GitHub] zookeeper pull request #460: missing list

2018-02-11 Thread seunghoo
GitHub user seunghoo opened a pull request: https://github.com/apache/zookeeper/pull/460 missing list In ZooKeeper.java, `existWatches.remove(clientPath;` removes watches for clientPath and next `existWatches.remove(clientPath)` returns anything. You can merge this pull request int

[GitHub] zookeeper pull request #460: missing list

2018-02-11 Thread seunghoo
Github user seunghoo closed the pull request at: https://github.com/apache/zookeeper/pull/460 ---

[GitHub] zookeeper pull request #461: missing list

2018-02-11 Thread achimbab
GitHub user achimbab opened a pull request: https://github.com/apache/zookeeper/pull/461 missing list At line 518, 'existWatches.remove(clientPath)' is null because watches for clientPath is already removed. You can merge this pull request into a Git repository by running: $ g

[GitHub] zookeeper pull request #480: c++ zookeeper

2018-03-04 Thread cxxjava
GitHub user cxxjava opened a pull request: https://github.com/apache/zookeeper/pull/480 c++ zookeeper c++ zookeeper base java zookeeper v3.4.11 You can merge this pull request into a Git repository by running: $ git pull https://github.com/cxxjava/zookeeper CxxZookeeper Altern

[GitHub] zookeeper pull request #386: Cmake fixes

2018-03-09 Thread andschwa
Github user andschwa commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/386#discussion_r173568056 --- Diff: src/c/CMakeLists.txt --- @@ -14,14 +14,13 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] zookeeper pull request #386: Cmake fixes

2018-03-09 Thread andschwa
Github user andschwa commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/386#discussion_r173569107 --- Diff: src/c/CMakeLists.txt --- @@ -14,14 +14,13 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] zookeeper pull request #386: Cmake fixes

2018-03-09 Thread andschwa
Github user andschwa commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/386#discussion_r173571281 --- Diff: src/c/CMakeLists.txt --- @@ -14,14 +14,13 @@ # See the License for the specific language governing permissions and # limitations under

[GitHub] zookeeper pull request #494: Branch 3.5

2018-03-26 Thread brettKK
GitHub user brettKK opened a pull request: https://github.com/apache/zookeeper/pull/494 Branch 3.5 callee BinaryInputArchive#startVector will return null: ``` // code placeholder public Index startVector(String tag) throws IOException { int len = readInt(tag);

[GitHub] zookeeper pull request #81: Update Watcher.java

2016-09-17 Thread Rumo-Arf
GitHub user Rumo-Arf opened a pull request: https://github.com/apache/zookeeper/pull/81 Update Watcher.java Switch case clause, may wrote like this. Isn't it? The other switch case clause wrote like that so... You can merge this pull request into a Git repository by running

[GitHub] zookeeper pull request #86: zookeeper pull

2016-10-09 Thread fairliang
GitHub user fairliang opened a pull request: https://github.com/apache/zookeeper/pull/86 zookeeper pull You can merge this pull request into a Git repository by running: $ git pull https://github.com/fairliang/zookeeper trunk Alternatively you can review and apply these chang

[GitHub] zookeeper pull request #86: zookeeper pull

2016-10-09 Thread fairliang
Github user fairliang closed the pull request at: https://github.com/apache/zookeeper/pull/86 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] zookeeper pull request #98: ZOOKEEPER-2479

2016-11-03 Thread rakeshadr
GitHub user rakeshadr opened a pull request: https://github.com/apache/zookeeper/pull/98 ZOOKEEPER-2479 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakeshadr/zookeeper-1 ZK-2479 Alternatively you can review and apply these c

[GitHub] zookeeper pull request #98: ZOOKEEPER-2479

2016-11-03 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/98#discussion_r86415195 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){

[GitHub] zookeeper pull request #98: ZOOKEEPER-2479

2016-11-03 Thread rakeshadr
Github user rakeshadr commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/98#discussion_r86483860 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){

[GitHub] zookeeper pull request #98: ZOOKEEPER-2479

2016-11-04 Thread eribeiro
Github user eribeiro commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/98#discussion_r86502042 --- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java --- @@ -520,6 +520,12 @@ public synchronized void setCurrentVote(Vote v){

[GitHub] zookeeper pull request #101: ZOOKEEPER-2383

2016-11-06 Thread rakeshadr
GitHub user rakeshadr opened a pull request: https://github.com/apache/zookeeper/pull/101 ZOOKEEPER-2383 You can merge this pull request into a Git repository by running: $ git pull https://github.com/rakeshadr/zookeeper-1 ZK-2383 Alternatively you can review and apply these

[GitHub] zookeeper pull request #107: Branch 3.3

2016-11-17 Thread benjiazhen
GitHub user benjiazhen opened a pull request: https://github.com/apache/zookeeper/pull/107 Branch 3.3 You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/zookeeper branch-3.3 Alternatively you can review and apply these chang

  1   2   3   4   5   6   7   8   9   10   >