[GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/297#discussion_r124907405 --- Diff: src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java --- @@ -590,18 +590,15 @@ public boolean clientTunneledAuthenticationInProgres

[GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...

Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/297#discussion_r124907017 --- Diff: src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java --- @@ -590,18 +590,15 @@ public boolean clientTunneledAuthenticationInProgres

[GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...

Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/297#discussion_r124757125 --- Diff: src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java --- @@ -590,14 +590,13 @@ public boolean clientTunneledAuthenticationInProg

[GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...

Github user asdf2014 commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/297#discussion_r124721264 --- Diff: src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java --- @@ -590,14 +590,13 @@ public boolean clientTunneledAuthenticationInProg

[GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...

Github user shralex commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/297#discussion_r124709964 --- Diff: src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java --- @@ -590,14 +590,13 @@ public boolean clientTunneledAuthenticationInProgr

[GitHub] zookeeper pull request #297: ZOOKEEPER-2825: 1. Remove unnecessary import; 2...

GitHub user asdf2014 opened a pull request: https://github.com/apache/zookeeper/pull/297 ZOOKEEPER-2825: 1. Remove unnecessary import; 2. `contains` instead of `indexOf > -1` for more readable; 3. Standardize `StringBuilder#append` usage for CLI module * Remove unnecessary import;