Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 3

2019-10-07 Thread Enrico Olivelli
PR for the fix https://github.com/apache/zookeeper/pull/ as soon as it lands to 3.5.6 I will send a new RC out for vote in BookKeeper we have a validation script that checks for license files, but it depends on the repository layout. it should be easy to set up such validation, it will also h

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 3

2019-10-07 Thread Norbert Kalmar
Oh, bummer, I totally overlooked the version in the configs. We should maybe add some automated config checks to the build... :) This is not the first time an RC is cancelled because of the License files. Norbert On Mon, Oct 7, 2019 at 3:13 PM Enrico Olivelli wrote: > Andor, Norbert, > I have

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 3

2019-10-07 Thread Enrico Olivelli
Andor, Norbert, I have fixed the tag https://github.com/apache/zookeeper/commits/release-3.5.6-rc3 Explanation of what happeed: I had created the original tag as 'release-3.5.6rc3' (without the dash sign) and when I re-created it I was on the master branch. I apologize for the mistake. Binaries a

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 3

2019-10-07 Thread Norbert Kalmar
+1 (non-binding) - once tag is fixed, which has the extra commit Andor mentioned. I verified that the RC does not contain the commit, so it's just the tag. But the RC looks good to me! - unit tests pass - built and started ZK + run few commands from source tarball - checked bin tarball, license fi

Re: [VOTE] Apache ZooKeeper release 3.5.6 candidate 3

2019-10-07 Thread Andor Molnar
+0 Release artifacts looks good to me: - verified Release Notes, - verified signatures, checksum, - code built on Mac, Centos7 - tests were successful, including C++ tests, - verified 3-node cluster non-ssl, ssl mode with some basic cli commands. However the git tag “release-3.5.6-rc3” does not s

[VOTE] Apache ZooKeeper release 3.5.6 candidate 3

2019-10-05 Thread Enrico Olivelli
This is a bugfix release candidate for 3.5.6. It fixes 29 issues, including upgrade of third party libraries, TTL Node APIs for C API, support for PCKS12 Keystores, upgrade of Netty 4 and better procedure for the upgrade of servers from 3.4 to 3.5. The full release notes is available at: https:/