Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

See my comments I just sent to Flavio. I agree, if we go with something like maven we should be able to have a source only release artifact, plus a number of binary artifacts (push to maven, a separate binary artifact, etc...). I've proposed maven in the past, but not gotten much interest. Now that

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

On Wed, Feb 23, 2011 at 3:21 AM, Flavio Junqueira wrote: > The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper" > containing build.xml and source code. If you try to run from there, it will > fail. I'm actually wondering why we have the source code both under contrib/ > and un

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Thanks a lot Vishal. I have reviewed the patch already. Ill let ben decide how/when to commit to 3.3.3 branch. Ben let me know if you want me to commit the patch to 3.3 branch. thanks mahadev On Wed, Feb 23, 2011 at 10:33 AM, Vishal Kher wrote: > Hi Mahadev, > > I have submitted the patch to th

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Hi Mahadev, I have submitted the patch to the jira. -Vishal On Tue, Feb 22, 2011 at 11:14 PM, Mahadev Konar wrote: > Thanks Ben. Vishal, would you be able to upload the patch today/tomm? > I can review and commit. > > thanks > mahadev > > On Tue, Feb 22, 2011 at 7:38 PM, Benjamin Reed wrote:

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Yes, hopefully by EOD today. On Wed, Feb 23, 2011 at 6:21 AM, Flavio Junqueira wrote: > The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper" > containing build.xml and source code. If you try to run from there, it will > fail. I'm actually wondering why we have the source co

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Flavio Junqueira: > The problem is that there is a path "zookeeper-3.3.3/contrib/ > bookkeeper" containing build.xml and source code. If you try to run > from there, it will fail. I'm actually wondering why we have the > source code both under contrib/ and under src/contrib/. The folder > structure

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

The problem is that there is a path "zookeeper-3.3.3/contrib/bookkeeper" containing build.xml and source code. If you try to run from there, it will fail. I'm actually wondering why we have the source code both under contrib/ and under src/contrib/. The folder structure under contrib/ is different

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

in step 3 under building you say "Tar/GZ the release directory as zookeeper-X.Y.Z.tar.gz". the release directory refers the directory you untared the tar.gz file into in step 2. right? ben On Tue, Feb 22, 2011 at 9:02 AM, Patrick Hunt wrote: > Done. (hopefully this gives you some insight into w

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Thanks Ben. Vishal, would you be able to upload the patch today/tomm? I can review and commit. thanks mahadev On Tue, Feb 22, 2011 at 7:38 PM, Benjamin Reed wrote: > sorry i didn't respond earlier. i've been off the grid today. (tahoe) since > i have to roll a new release anyway. i'd be glad to

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

sorry i didn't respond earlier. i've been off the grid today. (tahoe) since i have to roll a new release anyway. i'd be glad to put it in. i just don't want to delay the release any longer. ben On Tue, Feb 22, 2011 at 2:45 PM, Mahadev Konar wrote: > Hi Vishal, > 900 seems like a biigger chang

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Hi Vishal, 900 seems like a biigger change. I think just 880 should be fine, so that folks dont hit the thread blow up issue. BTW, all depends on Ben if he is willing to get 880 in 3.3.3 release. If not we'll have to wait for 3.4 or another release like 3.3.4 (which i personally would like to av

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira wrote: > I'm not sure why you say it is fine, Pat. If I try to compile with the > candidate release, ant complains that build-contrib.xml is missing (and it > is not where it is supposed to be). Compiling from trunk or one of the > branches works

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Hi Flavio, I haven't posted a patch for for ZOOKEEPER-900 branch 3.3. I think the bug was originally marked for 3.4.0. On Tue, Feb 22, 2011 at 4:24 PM, Flavio Junqueira wrote: > Hi Vishal, ZOOKEEPER-900 has been committed to trunk, but not to branch > 3.3, correct? You have not uploaded a patch

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Hi Vishal, ZOOKEEPER-900 has been committed to trunk, but not to branch 3.3, correct? You have not uploaded a patch for ZOOKEEPER-900 branch 3.3, right?-FlavioOn Feb 22, 2011, at 10:09 PM, Vishal Kher wrote:Hi Mahadev,I can certainly work on getting 880 in the release. I would like to know if 900 n

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Hi Mahadev, I can certainly work on getting 880 in the release. I would like to know if 900 needs to go in 3.3.3 or not. If I remember correctly, merging patch for 880 failed when I tired last time because the fix for 900 was not committed to 3.3.If 900 is not needed, then I can do the fix only f

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Ben/Vishal, Is there any possibility of getting ZOOKEEPER-880 in 3.3.3 release? The Hbase guys had been asking for it. thanks mahadev On Tue, Feb 22, 2011 at 9:38 AM, Flavio Junqueira wrote: > I'm not sure why you say it is fine, Pat. If I try to compile with the > candidate release, ant comp

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

I'm not sure why you say it is fine, Pat. If I try to compile with the candidate release, ant complains that build-contrib.xml is missing (and it is not where it is supposed to be). Compiling from trunk or one of the branches works fine, though.-FlavioOn Feb 22, 2011, at 6:04 PM, Patrick Hunt wrote

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

I think it's fine - it's in src/contrib not contrib. On Tue, Feb 22, 2011 at 8:00 AM, Benjamin Reed wrote: > i don't know why build-contrib.xml is missing. pat do you have any ideas? > ant tar should grab it right? > > ben > > > On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira wrote: > >> Ben,

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

done On Tue, Feb 22, 2011 at 7:59 AM, Benjamin Reed wrote: > can you add this to the how to release wiki as well? > > ben > > On Mon, Feb 21, 2011 at 9:38 AM, Patrick Hunt wrote: > >> FYI: if you make bulk changes (greater than 5 or so, typically this happens >> during release time) to JIRA plea

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Done. (hopefully this gives you some insight into why I've been pushing for maven, not perfect but it does alot of this for you). Patrick On Tue, Feb 22, 2011 at 7:58 AM, Benjamin Reed wrote: > pat, do you mind updating the building section of > https://cwiki.apache.org/confluence/display/ZOOKEE

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

i would like to get 880 in, but it is far from settled. the changes going in for 880 and related patches could be destabilizing. as vishal points out, one of the related patches isn't even committed to trunk yet. ben On Mon, Feb 21, 2011 at 3:46 AM, Flavio Junqueira wrote: > Hi again, I'm sorry

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

i don't know why build-contrib.xml is missing. pat do you have any ideas? ant tar should grab it right? ben On Mon, Feb 21, 2011 at 2:02 AM, Flavio Junqueira wrote: > Ben, I have a question. Even though the bookkeeper jar is there, > build-contrib.xml is missing (ZOOKEEPER-956), and compiling f

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

can you add this to the how to release wiki as well? ben On Mon, Feb 21, 2011 at 9:38 AM, Patrick Hunt wrote: > FYI: if you make bulk changes (greater than 5 or so, typically this happens > during release time) to JIRA please do use the bulk change feature, and in > particular turn OFF email no

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

pat, do you mind updating the building section of https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToRelease with these three items. signing the jar files is very unclear in the original doc. do i untar, sign, and retar? we

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

-1, in general looks good but I did notice a few things: * the "zookeeper_version.h" file needs to be updated to version 3.3.3 * same with configure.ac (http://wiki.apache.org/hadoop/ZooKeeper/HowToRelease) * the toplevel zk jar and all jars in dist-maven have not been signed, they need to be RAT

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

FYI: if you make bulk changes (greater than 5 or so, typically this happens during release time) to JIRA please do use the bulk change feature, and in particular turn OFF email notification. Subsequently send out a single email detailing the changes. Patrick On Mon, Feb 21, 2011 at 3:46 AM, Flavi

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Hi again, I'm sorry for raising yet another point. I also wanted to point out that we have a few jiras marked as blocked not included in the current candidate. ZOOKEEPER-880 is one of them, and Vishal asked us to consider it for 3.3.3. I think that either we conclude that it is not a blocker and le

Re: [VOTE] Release ZooKeeper 3.3.3 (candidate 0)

Ben, I have a question. Even though the bookkeeper jar is there, build-contrib.xml is missing (ZOOKEEPER-956), and compiling fails without it. Is it supposed to be this way?-FlavioOn Feb 19, 2011, at 3:27 PM, Benjamin Reed wrote:(the previous email had the URL slightly incorrect)after much struggle

[VOTE] Release ZooKeeper 3.3.3 (candidate 0)

(the previous email had the URL slightly incorrect) after much struggle! i've created a candidate build for ZooKeeper 3.3.3. this is a bug fix release addressing 13 issues (two of them extremely critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote

[VOTE] Release ZooKeeper 3.3.3 (candidate 0)

after much struggle! i've created a candidate build for ZooKeeper 3.3.3. this is a bug fix release addressing 13 issues (two of them extremely critical) -- see the release notes for details. *** Please download, test and VOTE before the *** vote closes 11pm pacific time, Tuesday, February 22.***