[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14066285#comment-14066285
]
Hudson commented on ZOOKEEPER-1683:
---
SUCCESS: Integrated in ZooKeeper-trunk #2376 (S
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14054242#comment-14054242
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052952#comment-14052952
]
Rakesh R commented on ZOOKEEPER-1683:
-
Sorry for pitch in late. Thanks [~shralex]
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052064#comment-14052064
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
Looks fine now, not sure bu
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052058#comment-14052058
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14052052#comment-14052052
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051925#comment-14051925
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14051855#comment-14051855
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045089#comment-14045089
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14045036#comment-14045036
]
Camille Fournier commented on ZOOKEEPER-1683:
-
[~shralex] This looks like
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13704154#comment-13704154
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
Shevek, did this patch reso
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634385#comment-13634385
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
very glad to hear you're ru
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13634365#comment-13634365
]
Shevek commented on ZOOKEEPER-1683:
---
I think it looks OK.
We put the code into prod
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13633751#comment-13633751
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
Shevek, can you please see
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630952#comment-13630952
]
Hadoop QA commented on ZOOKEEPER-1683:
--
+1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630903#comment-13630903
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13630868#comment-13630868
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13629780#comment-13629780
]
Shevek commented on ZOOKEEPER-1683:
---
It's going to be a while, I'm afraid; I'm flyin
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628654#comment-13628654
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
you're right of course. do
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628652#comment-13628652
]
Shevek commented on ZOOKEEPER-1683:
---
volatile causes a write-read pair of the variab
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628640#comment-13628640
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
I see. There's actually a c
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628622#comment-13628622
]
Shevek commented on ZOOKEEPER-1683:
---
I think you can't just check isConnected() / so
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628603#comment-13628603
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
thanks Shevek and Marshall!
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628094#comment-13628094
]
Marshall McMullen commented on ZOOKEEPER-1683:
--
The C client code doesn't
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13628075#comment-13628075
]
Marshall McMullen commented on ZOOKEEPER-1683:
--
I reviewed these changes
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627495#comment-13627495
]
Shevek commented on ZOOKEEPER-1683:
---
sockKey == null, because previously:
2013-04-1
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13627493#comment-13627493
]
Shevek commented on ZOOKEEPER-1683:
---
Actual testing failed, when first connected to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625605#comment-13625605
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
exactly. thanks for reviewi
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625598#comment-13625598
]
Shevek commented on ZOOKEEPER-1683:
---
Withdraw that; it's the previous server list.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13625596#comment-13625596
]
Shevek commented on ZOOKEEPER-1683:
---
+ if (lastIndex >=0) {
+
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624992#comment-13624992
]
Hadoop QA commented on ZOOKEEPER-1683:
--
+1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624784#comment-13624784
]
Hadoop QA commented on ZOOKEEPER-1683:
--
-1 overall. Here are the results of test
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624089#comment-13624089
]
Shevek commented on ZOOKEEPER-1683:
---
TL;DR: It should never be null. That's the bug.
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624086#comment-13624086
]
Shevek commented on ZOOKEEPER-1683:
---
The trouble is that there's hidden state in fli
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624048#comment-13624048
]
Alexander Shraer commented on ZOOKEEPER-1683:
-
Thanks Shevek. I'd like to
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624042#comment-13624042
]
Shevek commented on ZOOKEEPER-1683:
---
Note that since connect() is called by SendThre
[
https://issues.apache.org/jira/browse/ZOOKEEPER-1683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13624039#comment-13624039
]
Shevek commented on ZOOKEEPER-1683:
---
This may be caused by ClientCnxnSocketNIO.java:
37 matches
Mail list logo
