[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2018-10-26 Thread Andor Molnar (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16664954#comment-16664954 ] Andor Molnar commented on ZOOKEEPER-2218: - I think this is a nice improvement, but given that

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2016-09-07 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15472573#comment-15472573 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of testing the latest

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607996#comment-14607996 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607887#comment-14607887 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608011#comment-14608011 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-30 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14608033#comment-14608033 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Tang Xinye (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605235#comment-14605235 ] Tang Xinye commented on ZOOKEEPER-2218: --- Thanks a lot. It's finished according

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Tang Xinye (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605236#comment-14605236 ] Tang Xinye commented on ZOOKEEPER-2218: --- Thanks a lot. It's finished according

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605239#comment-14605239 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606787#comment-14606787 ] Raul Gutierrez Segales commented on ZOOKEEPER-2218: --- The patch fails

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14606788#comment-14606788 ] Raul Gutierrez Segales commented on ZOOKEEPER-2218: --- i.e.: there are

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Michi Mutsuzaki (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607546#comment-14607546 ] Michi Mutsuzaki commented on ZOOKEEPER-2218: Thank you for the patch Tang!

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-29 Thread Hadoop QA (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14607525#comment-14607525 ] Hadoop QA commented on ZOOKEEPER-2218: -- -1 overall. Here are the results of

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-28 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14605090#comment-14605090 ] Raul Gutierrez Segales commented on ZOOKEEPER-2218: --- could you

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597030#comment-14597030 ] ASF GitHub Bot commented on ZOOKEEPER-2218: --- GitHub user sugartxy opened a

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Raul Gutierrez Segales (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597125#comment-14597125 ] Raul Gutierrez Segales commented on ZOOKEEPER-2218: --- Thanks for the

[jira] [Commented] (ZOOKEEPER-2218) Close IO Streams in finally block

2015-06-22 Thread Tang Xinye (JIRA)
[ https://issues.apache.org/jira/browse/ZOOKEEPER-2218?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14597135#comment-14597135 ] Tang Xinye commented on ZOOKEEPER-2218: --- oops! still learning, sorry for the