Re: Drop ANT build pull request

2019-11-25 Thread Andor Molnar
Great! I created the following Jiras to create the missing Maven jobs: Windows: https://issues.apache.org/jira/browse/ZOOKEEPER-3631 Java13: https://issues.apache.org/jira/browse/ZOOKEEPER-3632 Thanks, Andor > On 2019. Nov 24., at 22:43, Michael Han wrote: > >>> ZooKeeper_UT_Stress (hanm’s

Re: Drop ANT build pull request

2019-11-24 Thread Michael Han
>> ZooKeeper_UT_Stress (hanm’s private job - not sure if needed) I just deleted it. Thanks guys for taking care of the build system. On Fri, Nov 22, 2019 at 3:05 AM Enrico Olivelli wrote: > Il giorno ven 22 nov 2019 alle ore 11:16 Andor Molnar > ha > scritto: > > > Here’s another thing. (Maybe

Re: Drop ANT build pull request

2019-11-22 Thread Enrico Olivelli
Il giorno ven 22 nov 2019 alle ore 11:16 Andor Molnar ha scritto: > Here’s another thing. (Maybe I should open a new thread) > > I’m disabled Ant-based trunk jobs in Jenkins and found the following which > doesn’t have Maven alternative: > > - ZooKeeper-trunk-java13 > I would keep this, in Maven

Re: Drop ANT build pull request

2019-11-22 Thread Andor Molnar
Here’s another thing. (Maybe I should open a new thread) I’m disabled Ant-based trunk jobs in Jenkins and found the following which doesn’t have Maven alternative: - ZooKeeper-trunk-java13 - Zookeeper-trunk-single-thread - ZooKeeper-trunk-windows-cmake - ZooKeeper_UT_Stress (hanm’s private job -

Re: Drop ANT build pull request

2019-11-21 Thread Enrico Olivelli
Andor You are totally right. I will investigate today Enrico Il ven 22 nov 2019, 07:13 Andor Molnar ha scritto: > Though the job is still running on master. This ran 13 hours ago: > > https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-github-pr-build/4259/ > > But the re

Re: Drop ANT build pull request

2019-11-21 Thread Andor Molnar
Though the job is still running on master. This ran 13 hours ago: https://builds.apache.org/view/S-Z/view/ZooKeeper/job/PreCommit-ZOOKEEPER-github-pr-build/4259/ But the result is not reported on the pull request. The latest 2 Maven builds are reported as “Jenkins” and “JenkinsMaven”. Andor >

Re: Drop ANT build pull request

2019-11-21 Thread Andor Molnar
Hi Enrico, Looks like a previous Maven build has been reported as “Jenkins” on this patch: https://github.com/apache/zookeeper/pull/1147 So it’s not the Ant build which still running on master. Andor > On 2019. Nov 15., at 16:41, Andor Molnar wrote: > > Yes we do. > > We just discussed on

Re: Drop ANT build pull request

2019-11-15 Thread Andor Molnar
Yes we do. We just discussed on the PR that Maven surefire plugin cannot be configured to report crashed tests as build errors. As I highlighted although tests were crashed during the build process, Maven still reports as a green build: https://builds.apache.org/view/S-Z/view/ZooKeeper/job/zook

Re: Drop ANT build pull request

2019-11-15 Thread Enrico Olivelli
One annoying problem is that I am not able to disable the ANT "precommit" for master branch https://builds.apache.org/view/ZK%20All/job/PreCommit-ZOOKEEPER-github-pr-build/ ideally it should run only for 3.4, maybe 3.5. Enrico Il giorno ven 15 nov 2019 alle ore 16:01 Enrico Olivelli < eolive..

Re: Drop ANT build pull request

2019-11-15 Thread Enrico Olivelli
Il ven 15 nov 2019, 15:28 Andor Molnar ha scritto: > Hi, > > I noticed that PR#1139 has been merged. As a consequence I have to > remove/disable all of the Ant-based build jobs in this Jenkis dashboard: > https://builds.apache.org/view/S-Z/view/ZooKeeper/ > > Which also means that we don’t have a

Re: Drop ANT build pull request

2019-11-15 Thread Andor Molnar
Hi, I noticed that PR#1139 has been merged. As a consequence I have to remove/disable all of the Ant-based build jobs in this Jenkis dashboard: https://builds.apache.org/view/S-Z/view/ZooKeeper/ Which also means that we don’t have a build job which is able to alert when a test has crashed. Is

Re: Drop ANT build pull request

2019-11-15 Thread Andor Molnar
Original patch: "ZOOKEEPER-3598: Fix potential data inconsistency issue due to has been reverted. Fangmin, my apologies for the inconvenience. Would you please create another PR with different solution or with Enrico’s workaround? Regards, Andor > On 2019. Nov 14., at 7:54, Andor Molnar wr

Re: Drop ANT build pull request

2019-11-13 Thread Andor Molnar
Hi Enrico, +1 for the idea I think the best would be to do this before we cut the first version of 3.6.0. Btw I noticed that the trunk build is completely broken since https://builds.apache.org/view/S-Z/view/ZooKeeper/job/ZooKeeper-trunk/769/ It’s failing on Java versions since we introduced th

Drop ANT build pull request

2019-11-11 Thread Enrico Olivelli
Hi community, I have just sent a PR to drop ANT from main build (not from recipes/contrib) and keep only Maven build. We are already releasing 3.5 branch with Maven, this is only the final step of this long story. Once we have only Maven it will be super easy to refactor the layout of the codebase