Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-05 Thread Patrick Hunt
+1, having sonar would be nice although I've found that having tools that no one pays attention to is not useful. The best way to combat that is to integrate it into the build (e.g. hadoop QA bot). On Mon, Sep 5, 2011 at 1:27 AM, Thomas Koch wrote: > Hi Camille, >> We already have a reviewboard s

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-05 Thread Thomas Koch
Hi Camille, > We already have a reviewboard set up for zookeeper which you should plan to > use, and of course the hadoop build farm. If you believe additional > analysis tools would be useful in our build, please work with our > build.xml and the infra team to get the necessary tools installed. It

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Patrick Hunt
Hey Thomas! I've raised a scala port a number of times previously, most recently at the post-summit meetup: http://markmail.org/message/t32x22hmifo3urxk We discussed this shortly both at the meetup and subsequently on list. Unfortunately there was no consensus around building ZK on scala (or any ot

RE: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Fournier, Camille F.
Hi Thomas, Here's my feedback: 1. For any useful fixes you find here, please follow the normal procedures of raising a ticket and attaching a patch. In my experience, static analysis tools often carry with them a lot of irrelevant noise, but as long as the changes you propose are clean and do

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Thomas Koch
Andrew Finnell: > Thomas, > > Upfront warning. I am not in charge of ZooKeeper or affiliated with them > except for submitting patches. > > While I understand the power of Scala, what is the major benefit of > changing all of the Java code over to Scala? Will this outweigh the > decrease in skill

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Andrew Finnell
Thomas, Upfront warning. I am not in charge of ZooKeeper or affiliated with them except for submitting patches. While I understand the power of Scala, what is the major benefit of changing all of the Java code over to Scala? Will this outweigh the decrease in skill sets that a language such a