Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-27 Thread Patrick Hunt
On Mon, Jun 25, 2018 at 10:34 PM Michael Han wrote: > Since pkg-config has been available for a long time, what's the drawback in > terms of compatibilities if we choose only support pkg-config moving > forward? > > It could break existing downstream build infra. Also the issue is not super

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-25 Thread Michael Han
Since pkg-config has been available for a long time, what's the drawback in terms of compatibilities if we choose only support pkg-config moving forward? For cmake, if we choose only to support cmake, then that's another dependency users that consumes release tarball have to install on their OS

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-25 Thread Andor Molnar
Does anybody else has strong or not that strong opinion? Andor On Wed, Jun 20, 2018 at 8:30 PM, Andor Molnar wrote: > What do you think @andschwa? > You did some contribution on CMake recently. > > Andor > > > > On Wed, Jun 20, 2018 at 8:09 PM, Patrick Hunt wrote: > >> Hm. Not directly on

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-20 Thread Andor Molnar
What do you think @andschwa? You did some contribution on CMake recently. Andor On Wed, Jun 20, 2018 at 8:09 PM, Patrick Hunt wrote: > Hm. Not directly on point but related - should we move off auto* tools at > some point and just use cmake? (which is already in the codebase) Or some > other

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-20 Thread Patrick Hunt
Hm. Not directly on point but related - should we move off auto* tools at some point and just use cmake? (which is already in the codebase) Or some other option? Patrick On Wed, Jun 20, 2018 at 11:05 AM Andor Molnar wrote: > "When is pkg-config needed?" > > Both. You need the macro to generate

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-20 Thread Andor Molnar
"When is pkg-config needed?" Both. You need the macro to generate ./configure and you need pkg-config and cppunit.pc (part of cppunit package) to compile the tests. "Do we already do something special like generate the configure script and ship that as part of the release?" That's correct. We

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-20 Thread Patrick Hunt
When is pkg-config needed? If you want to compile from source or if you want to compile from the release artifact? Do we already do something special like generate the configure script and ship that as part of the release? Patrick On Fri, Jun 8, 2018 at 6:44 AM Andor Molnar wrote: > This PR is

Re: ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-08 Thread Andor Molnar
This PR is also related: https://github.com/apache/zookeeper/pull/362 Andor On Fri, Jun 8, 2018 at 3:18 PM, Andor Molnar wrote: > Hi devs, > > I'm having problems resolving the issue mentioned in this Jira and need > some feedback from you: > >

ZK-3034 Unable to compile C++ test files with cppunit-1.14.0

2018-06-08 Thread Andor Molnar
Hi devs, I'm having problems resolving the issue mentioned in this Jira and need some feedback from you: https://issues.apache.org/jira/browse/ZOOKEEPER-3034 In a nutshell the situation with *cppunit* is as follows: LibreOffice team confirmed that from version *1.14.0* they will no longer ship