Re: ZOOKEEPER pre-commit fails if patch contains binary file

2016-08-16 Thread Chris Nauroth
The last time we discussed this, consensus in the community was that our most effective roadmap for build toolchain improvements would be: 1) Migrate to Maven. This is tracked in ZOOKEEPER-1078, and I know you’re interested in pushing that one ahead too. 2) Migrate to Yetus after the switch to

Re: ZOOKEEPER pre-commit fails if patch contains binary file

2016-08-16 Thread Arshad Mohammad
Thanks Chris, for clarification and suggestion. I will submit the patch without binary file. Seems Yetus is very important and necessary for ZooKeeper and I have heard many times in community discussion that a particular problem can be solved with Yetus Is there any plan for migration like in 3.5.

Re: ZOOKEEPER pre-commit fails if patch contains binary file

2016-08-16 Thread Chris Nauroth
Unfortunately, I don’t think it’s possible for the current ZooKeeper test-patch.sh to work with a binary file. If we eventually migrate to Apache Yetus, then its version of pre-commit has the capability to run “git apply”, which can handle binary diffs generated by “git diff”. For ZOOKEEPER-12

ZOOKEEPER pre-commit fails if patch contains binary file

2016-08-16 Thread Mohammad arshad
Hello everyone In ZooKeeper pre-commit patch apply has failed for the patch ZOOKEEPER-1260-01.patch. This patch applies on trunk locally ZOOKEEPER-1260-01.patch contains a binary file. This patch is generated with "git diff --no-prefix --binary HEAD > ZOOKEEPER-1260-01.patch" command I think the