Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-05 Thread Patrick Hunt
+1, having sonar would be nice although I've found that having tools that no one pays attention to is not useful. The best way to combat that is to integrate it into the build (e.g. hadoop QA bot). On Mon, Sep 5, 2011 at 1:27 AM, Thomas Koch wrote: > Hi Camille, >> We already have a reviewboard s

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-05 Thread Thomas Koch
Hi Camille, > We already have a reviewboard set up for zookeeper which you should plan to > use, and of course the hadoop build farm. If you believe additional > analysis tools would be useful in our build, please work with our > build.xml and the infra team to get the necessary tools installed. It

Re: Reviewboard, Gerrit was: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Patrick Hunt
Thomas, checkout post-review from https://github.com/reviewboard/rbtools I haven't used it against Apache rb, however I use it to great effect inside Cloudera. It will allow you to cut the number of steps significantly (I have small bash scripts wrapping post-review for the various projects I cont

Reviewboard, Gerrit was: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Thomas Koch
Fournier, Camille F.: > We already have a reviewboard set up for zookeeper which you should plan to Hi Fournier, I'll use reviewboard for patches targeted for inclusion. However just for reference and to make you curious, I compare the steps necessary to create a review in reviewboard and in ge

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Patrick Hunt
ercise for you. Maybe you could start with a > Scala client that we could support. Not sure there's any benefit since Scala > can run Java code, but it could be interesting and maybe something we could > take back as a contribution if you wanted. > > C > > -----Original Me

RE: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Fournier, Camille F.
ibution if you wanted. C -Original Message- From: Thomas Koch [mailto:tho...@koch.ro] Sent: Friday, September 02, 2011 9:16 AM To: dev@zookeeper.apache.org Subject: ZooKeeper cleanup / refactoring / scala migration Hi, my university labs work has started yesterday. In the next two months I&#x

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Thomas Koch
Andrew Finnell: > Thomas, > > Upfront warning. I am not in charge of ZooKeeper or affiliated with them > except for submitting patches. > > While I understand the power of Scala, what is the major benefit of > changing all of the Java code over to Scala? Will this outweigh the > decrease in skill

Re: ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Andrew Finnell
Thomas, Upfront warning. I am not in charge of ZooKeeper or affiliated with them except for submitting patches. While I understand the power of Scala, what is the major benefit of changing all of the Java code over to Scala? Will this outweigh the decrease in skill sets that a language such a

ZooKeeper cleanup / refactoring / scala migration

2011-09-02 Thread Thomas Koch
Hi, my university labs work has started yesterday. In the next two months I'll work on ZooKeeper. This work has three major goals - improve the maintainability of the code base - migrate ZooKeeper to scala and use actors for reliable concurrency - find other developers to collaborate on the s