[b2g] Settings API queries fail after inner-window-destroyed

2014-09-25 Thread Kyle Machulis
Looking at Bug 1070066 today, I found an interesting issue. Pretty much everywhere in gaia, it's assumed that the settings API will never fail on a query call. There's lots of calls to mozSettings.createLock().get()/set() that just expect to get back a DOMRequest no matter what. The problem in

Re: [b2g] Settings API queries fail after inner-window-destroyed

2014-09-25 Thread Kyle Huey
On Thu, Sep 25, 2014 at 6:08 PM, Kyle Machulis wrote: > Looking at Bug 1070066 today, I found an interesting issue. Pretty much > everywhere in gaia, it's assumed that the settings API will never fail on a > query call. There's lots of calls to mozSettings.createLock().get()/set() > that just e

Re: [b2g] Settings API queries fail after inner-window-destroyed

2014-09-25 Thread James Burke
On Thu, Sep 25, 2014 at 6:08 PM, Kyle Machulis wrote: > > Return fake DOMRequest-like objects that instantly fail? I favor this, although not sure what is meant by fake vs. just a real DOMRequest that doesn’t do anything special/will not call onsuccess, just onerror. Expressing the failure via a

Re: [b2g] Settings API queries fail after inner-window-destroyed

2014-09-26 Thread Jonas Sicking
On Thu, Sep 25, 2014 at 7:16 PM, Kyle Huey wrote: > Why are we running callbacks after the app has closed anyways? Indeed. I'm wondering the same thing. / Jonas ___ dev-b2g mailing list dev-b2g@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-b