Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread ishikawa
On (2014年01月08日 10:38), Mike Hommey wrote: > On Wed, Jan 08, 2014 at 10:23:28AM +0900, ISHIKAWA,chiaki wrote: >> (2013/09/10 19:17), ishikawa wrote: >> >> [ omissions ] >>> >>> I am getting the hang of emacs mode line. >>> >>> /* -*- Mode: javascript; tab-width: 8; indent-tabs-mode: nil; >>> c-ba

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Neil
Blair McBride wrote: I'd like to see the removal of the modelines also. A root config file is much cleaner. For the widest possible support of editors, I'd love to see a root .editorconfig file. See http://editorconfig.org/ - it's an editor-neutral config, with plugins for many editors/IDEs

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Gervase Markham
On 07/01/14 22:26, Jeff Walden wrote: > which was unreadable. You simply can't easily skim and see where the body > starts and where the condition ends, even with braces. We shoved the opening > brace to its own line: > > if (somethingHere() && > somethingElse()) > { > doSomething(); >

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Mike de Boer
Awesome idea! It also supports per-directory settings, so a style difference for any module can be recorded as well. Filed as https://bugzilla.mozilla.org/show_bug.cgi?id=957564 Whatever comes out of these discussions, they can be recorded & enforced with this in-tree and not just in a wiki. C

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Till Schneidereit
On Wed, Jan 8, 2014 at 9:25 AM, ishikawa wrote: > BTW, do java or javascript programmers use Eclipse with its built-in editor > with suitable editor configuration, > and that is the end of the story for such Eclipse users when they tinker > with Mozilla source code? > I use Eclipse for working o

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread Neil
Neil wrote: I tried to check in a reftest today. Apparently it fails on Android and b2g. The failure mode appears to be that the reftest takes a screenshot before the test has loaded (the page is still blank, whereas it should have a red square for failure or a green square for success). Do r

Web APIs documentation meeting Friday at 9 AM PST

2014-01-08 Thread Eric Shepherd
The Web API documentation meeting is Friday at 9 AM Pacific Time. Everyone's welcome to attend; if you're interested in ensuring that these APIs are properly documented, we'd love your input. We have an agenda, as well as details on how to join, here: https://etherpad.mozilla.org/WebAPI-docs-2

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread Ehsan Akhgari
On Wed, Jan 8, 2014 at 10:06 AM, Neil wrote: > Neil wrote: > > I tried to check in a reftest today. Apparently it fails on Android and >> b2g. The failure mode appears to be that the reftest takes a screenshot >> before the test has loaded (the page is still blank, whereas it should have >> a re

Re: List of deprecated constructs [was Re: A proposal to reduce the number of styles in Mozilla code]

2014-01-08 Thread Benjamin Smedberg
On 1/7/2014 8:04 PM, Kyle Huey wrote: Since we seem to be voting now, I am moderately opposed to making XPCOM method calls more boilerplate-y, and very opposed to removing NS_ENSURE_SUCCESS without some sort of easy shorthand to test an nsresult and print to the console if it is a failure. We ar

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Nick Alexander
> BTW, do java or javascript programmers use Eclipse with its built-in editor > with suitable editor configuration, > and that is the end of the story for such Eclipse users when they tinker > with Mozilla source code? Android Background Services are developed in a separate git repo that we then m

Re: Bug 641509

2014-01-08 Thread Matteo Sisti Sette
On 07/01/14 13:02, Till Schneidereit wrote: The discussion has happened in bug 588292[1]. For a succinct summary, see tha bug's comment 37[2]. No, that doesn't respond to my point. I did read the discussion in the bug I commented on (not the other one I admit) and the "security reasons" argume

Re: Bug 641509

2014-01-08 Thread Mike Hoye
On 1/7/2014, 11:40 AM, Matteo Sisti Sette wrote: Oh now I see, 'the *confusion* of the "OMG YOUR COMPUTER IS INFECTED BY A VIRUS" messages were causing', that's the point! LOL Yeah, I think we're done here. - mhoye ___ dev-platform mailin

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread Andrew Halberstadt
On 01/07/2014 07:23 PM, Neil wrote: I tried to check in a reftest today. Apparently it fails on Android and b2g. The failure mode appears to be that the reftest takes a screenshot before the test has loaded (the page is still blank, whereas it should have a red square for failure or a green squar

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Martin Thomson
On 2014-01-07, at 17:49, Joshua Cranmer wrote: > Since I'm seeing a lot of people advocating that the wrap margin should be > 100, > let me reiterate > David Baron's comment that the wrap margin must either be 80 or infinite […] I have always preferred no wrapping, with the line length limit b

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Adam Roach
On 1/8/14 11:28, Martin Thomson wrote: So maybe this can bifurcate the bike shedding discussion further: do you want to have a tool wrap to X, or do you want a tool to block patches that exceed X? Automated wrapping to a column width is less than optimal. If you look back at bz's example abou

CPP_UNIT_TESTS being removed from "make check"

2014-01-08 Thread Ted Mielczarek
Hello, Just a heads up that very soon we'll be removing CPP_UNIT_TESTS from the "make check" target[1]. The tests have been split out into a separate test job on TBPL[2] (labelled Cpp) for almost a month now without issue, and we've also added a mach command--"mach cppunittests"[3]--to facilitate

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Martin Thomson
On 2014-01-08, at 09:57, Adam Roach wrote: > Automated wrapping to a column width is less than optimal. If you look back > at bz's example about how he would chose to wrap a specific conditional, it's > based on semantic intent, not the language syntax. By and large, this goes to > author's in

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Garrett Robinson
On 01/08/2014 12:25 AM, ishikawa wrote: > That vim mode line is useless for a large percentage of user > community is a news to me. (But I don't use vim myself.) It's disabled by default because it's a security concern (modelines can execute arbitrary vimscript, IIRC). Can an emacs modeline exec

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Adam Roach
On 1/8/14 12:03, Martin Thomson wrote: On 2014-01-08, at 09:57, Adam Roach wrote: Automated wrapping to a column width is less than optimal. If you look back at bz's example about how he would chose to wrap a specific conditional, it's based on semantic intent, not the language syntax. By an

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Martin Thomson
On 2014-01-08, at 10:06, Adam Roach wrote: > The second is that we need to be careful if we decide to run a reformatter > over the code wholesale, since you can actually lose useful information about > author's intent. I'm not the first to raise that point in this discussion; > I'm simply agr

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Boris Zbarsky
On 1/8/14 1:08 PM, Garrett Robinson wrote: > Can an emacs modeline execute arbitrary elisp? It can if it uses certain modeline features. The default behavior of emacs is to silently apply the modelines that don't use those features and for the ones to do not apply them unless the user explicitly

Re: Style guide clarity on C++-isms

2014-01-08 Thread Ehsan Akhgari
On 1/7/2014, 7:00 PM, Cameron McCormack wrote: Ehsan Akhgari wrote: Exactly. If we require braces on their own lines for function bodies everywhere, we wouldn't need to solve this! Are you sure? :) There are a bunch of instances of class A { A(int aMember) : mMember(aMamber

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread Neil
Andrew Halberstadt wrote: On 01/07/2014 07:23 PM, Neil wrote: I tried to check in a reftest today. Apparently it fails on Android and b2g. The failure mode appears to be that the reftest takes a screenshot before the test has loaded (the page is still blank, whereas it should have a red squa

Re: Style guide clarity on C++-isms

2014-01-08 Thread Trevor Saunders
On Wed, Jan 08, 2014 at 02:24:46PM -0500, Ehsan Akhgari wrote: > On 1/7/2014, 7:00 PM, Cameron McCormack wrote: > >Ehsan Akhgari wrote: > >>Exactly. If we require braces on their own lines for function bodies > >>everywhere, we wouldn't need to solve this! > > > >Are you sure? :) There are a bunch

[Planned Maintenance Notification] Tree Closure, 2014-01-11

2014-01-08 Thread Hal Wine
Short Summary : This is our once in every six weeks planned maintenance window, where IT and Release Engineering perform maintenance work on critical parts of Mozilla Infrastructure. As part of this window, we will begin the move of the tegra infrastructure from Mountain View to the Santa Clar

Re: clang-format

2014-01-08 Thread Anthony Jones
clang-format-3.5 is now available for Windows using the updated patch in bug 952379. Anthony On 08/01/14 15:31, Anthony Jones wrote: > I have been doing some testing with clang-format and formatting only the > lines that have been modified. > > Version 3.5 is good enough for Mozilla style althou

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread Neil
Neil wrote: XHR's XML parsing blocks onload but its HTML parsing does not. Actually neither block onload, at least not the way I'm calling it, although the site manages to, so I'm not sure what's going on there... -- Warning: May contain traces of nuts. _

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread L. David Baron
On Wednesday 2014-01-08 19:22 +, Neil wrote: > I've tried switching to XHTML to avoid the problem, and the good > news is that my XHR now loads before the screenshot is taken. The > bad news is that the test still fails, as if the patch wasn't in > place. I guess I need to test with a server ra

Re: Reftests execute differently on Android or b2g?

2014-01-08 Thread Neil
L. David Baron wrote: On Wednesday 2014-01-08 19:22 +, Neil wrote: I've tried switching to XHTML to avoid the problem, and the good news is that my XHR now loads before the screenshot is taken. The bad news is that the test still fails, as if the patch wasn't in place. I guess I need t

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Anthony Jones
On 08/01/14 11:49, Nicholas Nethercote wrote: > If you're just distinguishing members, then |foo_| is good. But if > you're distinguishing parameters and globals/statics as well (which I > think is a good idea), then mFoo/aFoo/gFoo/sFoo makes more sense. If you want to be precise you would use thi

Re: Mozilla style guide issues, from a JS point of view

2014-01-08 Thread Anthony Jones
On 09/01/14 06:57, Adam Roach wrote: > Automated wrapping to a column width is less than optimal. If you look > back at bz's example about how he would chose to wrap a specific > conditional, it's based on semantic intent, not the language syntax. By > and large, this goes to author's intent and hi

Re: JavaScript Style Guide. Emacs mode line.

2014-01-08 Thread Anthony Jones
On 08/01/14 15:04, Chris Peterson wrote: > 1. Finish bikeshedding coding style > 2. Update official style guide (owner=bsmedberg?) > 3. Add style config files for vim/emacs/clang-format in mozilla-central > 4. Reformat mozilla-central code (piecemeal or big bang) > 5. Remove modelines from mozilla-