Re: ICU proposing to drop support for WinXP (and OS X 10.6)

2016-04-29 Thread Henri Sivonen
On Thu, Apr 28, 2016 at 8:51 PM, Jeff Walden wrote: > On 04/28/2016 10:00 AM, Jonathan Kew wrote: >> Thoughts? > > Another option is to ship a WinXP-specific Firefox build that doesn't provide > ICU and ECMAScript's Intl functionality. I'm very opposed to this (unless the XP-specific thing isn't

Re: Intent to ship: Speech synthesis API

2016-04-29 Thread Gijs Kruitbosch
There are still quite a number of bugs on file for this feature: https://bugzilla.mozilla.org/buglist.cgi?quicksearch=speech%20synthesis&list_id=12990930 one of which seems to suggest we want to switch to a different system API for synthesis on Windows. Are we sure none of these other bugs need

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Nicholas Nethercote
On Fri, Apr 29, 2016 at 10:25 AM, Nicholas Nethercote wrote: > > I just landed on inbound the patches in bug 1267550, which renamed > MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. > > A shorter name was in order because it's an attribute that is already > used widely, and should be used even more, becau

MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Nicholas Nethercote
Hi, I just landed on inbound the patches in bug 1267550, which renamed MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. A shorter name was in order because it's an attribute that is already used widely, and should be used even more, because it catches real problems. In fact, any function that is fallible

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Gerald Squelart
On Friday, April 29, 2016 at 8:04:46 PM UTC+10, Nicholas Nethercote wrote: > On Fri, Apr 29, 2016 at 10:25 AM, Nicholas Nethercote > wrote: > > > > I just landed on inbound the patches in bug 1267550, which renamed > > MOZ_WARN_UNUSED_RESULT as MOZ_MUST_USE. > > > > A shorter name was in order bec

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Nathan Froyd
On Fri, Apr 29, 2016 at 7:54 AM, Gerald Squelart wrote: > Now, for maximum defensiveness, shouldn't we go even further? > > How about: Make 'MOZ_MUST_USE' implicit for all functions/methods (except > void of course, probably methods returning T&, and maybe more as they come > up). > When a resul

Re: Static analysis for "use-after-move"?

2016-04-29 Thread Michael Layzell
I have already written a basic analysis for use-after-move semantics which just hasn't been reviewed yet. I'm not sure if it's what you'd be looking for (take a look at the tests). https://bugzilla.mozilla.org/show_bug.cgi?id=1186706 Michael On Fri, Apr 29, 2016 at 12:14 AM, Jim Blandy wrote:

Re: Intent to ship: Speech synthesis API

2016-04-29 Thread Gregory Szorc
On Thu, Apr 28, 2016 at 12:52 PM, Eitan Isaacson wrote: > Hello, > > In Firefox 49 I intend to turn on the speech synthesis API on by default in > desktop. > > For those paying close attention, this is not the first mail like this. > Last time I turned it on in Nightly only to allow some fuzz tes

Re: ICU proposing to drop support for WinXP (and OS X 10.6)

2016-04-29 Thread snorp
On Friday, April 29, 2016 at 2:44:25 AM UTC-5, Henri Sivonen wrote: > > > Given it's WinXP only (and Firefox for Android's recalcitrance ;-) > > I think the situation where Firefox for Android is holding back > Gecko's ability to improve the codebase by getting rid of Netscape-era > code makes n

Intent to unship support for altGlyph

2016-04-29 Thread longsonr
Hello, We have had minimal support for altGlyph for some time now as an alias for tspan. altGlyph has been dropped from SVG 2 and neither Chrome nor Edge support the -> fallback behaviour, though Safari still does. The patch to remove it from the tree is available at [1]. Best regards, Robe

Re: Intent to unship support for altGlyph

2016-04-29 Thread Eric Shepherd
Added dev-doc-needed. *From:* longs...@gmail.com *Sent:* Friday, Apr 29, 2016 1:40:00 PM EDT *To:* dev-platform@lists.mozilla.org *Subject:* Intent to unship support for altGlyph > We have had minimal support for altGlyph fo

Re: Intent to ship: Speech synthesis API

2016-04-29 Thread Eitan Isaacson
> > Are we shipping extra data files to enable speech synthesis? If so, how > large are they? If so, why aren't we using the speech synthesis APIs built > into the underlying OS (especially on Windows, which is where most of our > users are)? > > We are doing the latter (relying on platform tts sup

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Chris Peterson
On 4/29/16 5:53 AM, Nathan Froyd wrote: This is a noble goal, but there is an enormous amount of code that would need to be modified to make this feasible. Perhaps if you exempted nsresult from MOZ_MUST_USE types. In theory, nsresult seems like an important type to check. That said, I once tr

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Kyle Huey
On Fri, Apr 29, 2016 at 1:46 PM, Chris Peterson wrote: > On 4/29/16 5:53 AM, Nathan Froyd wrote: > >> This is a noble goal, but there is an enormous amount of code that >> would need to be modified to make this feasible. Perhaps if you >> exempted nsresult from MOZ_MUST_USE types. >> > > In theo

Re: Static analysis for "use-after-move"?

2016-04-29 Thread Gerald Squelart
On Friday, April 29, 2016 at 2:15:03 PM UTC+10, Jim Blandy wrote: > On Thu, Apr 28, 2016 at 8:22 PM, wrote: > > > Jim Blandy於 2016年4月28日星期四 UTC+8下午1時51分15秒寫道: > > > I don't really think it's a good example. TakeMediaIfKnown is accepting a > > > UniquePtr as an inout parameter: it uses, and may mo

Re: Static analysis for "use-after-move"?

2016-04-29 Thread Gerald Squelart
On Saturday, April 30, 2016 at 9:43:46 AM UTC+10, Gerald Squelart wrote: > On Friday, April 29, 2016 at 2:15:03 PM UTC+10, Jim Blandy wrote: > > On Thu, Apr 28, 2016 at 8:22 PM, wrote: > > > > > Jim Blandy於 2016年4月28日星期四 UTC+8下午1時51分15秒寫道: > > > > I don't really think it's a good example. TakeMed

Re: MOZ_WARN_UNUSED_RESULT has been renamed as MOZ_MUST_USE

2016-04-29 Thread Nicholas Nethercote
On Sat, Apr 30, 2016 at 6:46 AM, Chris Peterson wrote: > > In theory, nsresult seems like an important type to check. > > That said, I once tried building Gecko with `#define NS_IMETHOD > MOZ_WARN_UNUSED_RESULT NS_IMETHOD_(nsresult)`. There were over 10,000 > warnings for XPCOM method callers not

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-04-29 Thread Kohei Yoshino
Today's announcement from Mozilla: https://blog.mozilla.org/futurereleases/2016/04/29/update-on-firefox-support-for-os-x/ The decision is fine but why don't they update this thread? (I know, Mozilla is very bad at communication.) -Kohei ___ dev-platfo

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-04-29 Thread Lawrence Mandel
Hi Kohei, I had planned to update the thread after the post went live so that I had the link. Thank you for posting it. Lawrence On Sat, Apr 30, 2016 at 12:38 AM, Kohei Yoshino wrote: > Today's announcement from Mozilla: > > https://blog.mozilla.org/futurereleases/2016/04/29/update-on-firefox-

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-04-29 Thread Mike Hommey
On Sat, Apr 30, 2016 at 12:38:37AM -0400, Kohei Yoshino wrote: > Today's announcement from Mozilla: > https://blog.mozilla.org/futurereleases/2016/04/29/update-on-firefox-support-for-os-x/ > > The decision is fine but why don't they update this thread? (I know, Mozilla > is very bad at communicat

Re: Intent to deprecate: MacOS 10.6-10.8 support

2016-04-29 Thread Lawrence Mandel
On Sat, Apr 30, 2016 at 1:37 AM, Mike Hommey wrote: > On Sat, Apr 30, 2016 at 12:38:37AM -0400, Kohei Yoshino wrote: > > Today's announcement from Mozilla: > > > https://blog.mozilla.org/futurereleases/2016/04/29/update-on-firefox-support-for-os-x/ > > > > The decision is fine but why don't they