Re: Please do NOT hand-edit web platform test MANIFEST.json files

2017-03-18 Thread Andrew Sutherland
On Sun, Mar 19, 2017, at 12:36 AM, Nils Ohlmeier wrote: > Wouldn’t it make more sense to let the build system detect and > reject/warn about (?) such a manual modification? > My assumption here is that mailing list archives are not a good place to > document processes or systems. I think some addi

Re: Please do NOT hand-edit web platform test MANIFEST.json files

2017-03-18 Thread Nils Ohlmeier
> On Mar 17, 2017, at 11:01, Boris Zbarsky wrote: > > We have tools for this: "mach wpt-manifest-update" will do the right thing. > > The typical result of hand-edits is that later changesets that do use the > tools end up conflicting with each other, as they all fix up the incorrect > hand-e

Re: Third Party Library Alert Service

2017-03-18 Thread Daniel Veditz
On Fri, Mar 17, 2017 at 3:26 PM, Ehsan Akhgari wrote: > We have library imports that are forks, for example > ​ ​ > dom/media/webaudio/blink, as the README file explains. That should > probably be removed from that list. > ​Forks are tricky. Just because we can't directly import the upstream do

Re: Tracking bug for removals after XPCOM extensions are no more?

2017-03-18 Thread Frank-Rainer Grahl
Firefox will probably loose enough usera already because of the webextensions only policy so you might rather add something to the api instead of taking things away. If its a useful api someone will use it when writing extensions. FRG Benjamin Smedberg wrote: On Wed, Mar 15, 2017 at 4:24 PM,