Re: Investigating leaks using DMD heap scan mode

2018-05-08 Thread Kris Maglione
On Tue, May 08, 2018 at 04:08:27PM -0700, Andrew McCreight wrote: A few years ago I came up with an approach for using a combination of cycle collector logs and DMD (which tracks all live blocks of heap allocated memory) to investigate leaks of refcounted objects. I've only had to use it about a

Investigating leaks using DMD heap scan mode

2018-05-08 Thread Andrew McCreight
A few years ago I came up with an approach for using a combination of cycle collector logs and DMD (which tracks all live blocks of heap allocated memory) to investigate leaks of refcounted objects. I've only had to use it about a half dozen times (most recently in bug 1451985), but it is very

PSA: Please use ChromeUtils.generateQI for JS QueryInterface methods

2018-05-08 Thread Kris Maglione
Bug 1456035 added a ChromeUtils.generateQI helper to create QueryInterface methods for JS objects. The QueryInterface methods generated by this function are highly optimized, and have a fast path for calls from XPConnect. Which is to say, please use this method rather than manually writing

Re: Uploading symbols from try builds

2018-05-08 Thread Aaron Klotz
This is awesome, Ted, THANK YOU! \o/ -Aaron On 5/8/2018 11:37 AM, Ted Mielczarek wrote: Hello, I landed some patches yesterday[1] that have now merged to m-c to allow uploading symbols from try builds to the symbol server. Previously if you wanted to debug a try server build it involved a

Uploading symbols from try builds

2018-05-08 Thread Ted Mielczarek
Hello, I landed some patches yesterday[1] that have now merged to m-c to allow uploading symbols from try builds to the symbol server. Previously if you wanted to debug a try server build it involved a bunch of annoying manual steps, but now you can simply ask for symbol upload tasks to run

Re: PSA: Avoid Visual Studio 2017 15.7.0

2018-05-08 Thread Frank-Rainer Grahl
Make sure you also disable the autoupdate in the task scheduler! "VSIX Auto Update 14 under Microsoft VisualStudio". FRG Ryan VanderMeulen wrote: Yesterday, Microsoft released Visual Studio 2017 15.7.0. Unfortunately, it is currently not usable for building Firefox due to bug 1458247

PSA: Avoid Visual Studio 2017 15.7.0

2018-05-08 Thread Ryan VanderMeulen
Yesterday, Microsoft released Visual Studio 2017 15.7.0. Unfortunately, it is currently not usable for building Firefox due to bug 1458247 (internal compiler errors in WebRTC code). The bug was already reported and confirmed upstream during the 15.7 preview cycle, but unfortunately the final