Re: Largest chunks of code that are likely to be removable?

2015-06-30 Thread kgupta
On Tuesday, June 30, 2015 at 3:41:43 AM UTC-4, Kearwood "Kip" Gilbert wrote: > Would anyone be opposed to combining the Matrix4x4 class and gfx3DMatrix? > Rather than adding support for transforms and projections that involve > vertices behind the w=0 plane to gfx3DMatrix, it may be cleaner to r

Re: Revisiting modelines in source files

2015-06-19 Thread kgupta
On Thursday, June 18, 2015 at 8:36:09 PM UTC-4, Eric Rahm wrote: > Can we sidestep this by punting on enforcing a line length restriction with > clang-format? > > I think it would be reasonably uncontroversial to just do the following > initially: > - spacing > - indentation > - bracing I

Re: Revisiting modelines in source files

2015-06-18 Thread kgupta
On Wednesday, June 17, 2015 at 9:57:12 PM UTC-4, Gregory Szorc wrote: > First thing is first: what are the blockers to mass rewriting > mozilla-central with clang-format's output? For the record I'm in favour of auto-clang-formatting the codebase, but the last time I tried running clang-format on

Re: The War on Warnings

2015-06-17 Thread kgupta
> 4606 [N] WARNING: No widget found in TabParent::UpdateDimensions: file > dom/ipc/TabParent.cpp, line 974 Do you know if this one occurs on b2g or also on other platforms? I added this warning recently in bug 1125325 after smaug said [1]. It seems to be happening a lot, so we should inves

Re: Per-test chaos mode now available, use it to help win the war on orange!

2015-06-08 Thread kgupta
On Thursday, June 4, 2015 at 5:30:32 PM UTC-4, Chris Peterson wrote: > > Will chaos mode enabled tests run on Try and release branches? If a test has chaos mode enabled, then it will have chaos mode enabled on all branches, including Try and release branches. > We don't know if chaos mode test

Re: Per-test chaos mode now available, use it to help win the war on orange!

2015-06-08 Thread kgupta
On Thursday, June 4, 2015 at 6:15:35 PM UTC-4, Chris AtLee wrote: > Very interesting, thank you! > > Would there be a way to add an environment variable or harness flag to run > all tests in chaos mode? > There isn't at the moment but one can definitely be added if there is a use for it. At the

Per-test chaos mode now available, use it to help win the war on orange!

2015-06-04 Thread kgupta
I just landed bug 1164218 on inbound, which adds the ability to run individual mochitests and reftests in chaos mode. (For those unfamiliar with chaos mode, it's a feature added by roc a while back that makes already-random things more random; see [1] or bug 955888 for details). The idea with m

Re: PSA: wiki page for platform-specific defines

2015-06-04 Thread kgupta
On Wednesday, June 3, 2015 at 9:16:46 PM UTC-4, Xidorn Quan wrote: > I guess it is probably better to add different color on "true" and "false", > which should improve the readability. Or probably just remove all "false"? > Looks like Mike and Adam cleaned it to be much more readable, thanks! I a

PSA: wiki page for platform-specific defines

2015-06-03 Thread kgupta
I created a new wiki page to document which platform/widget defines are true where: https://wiki.mozilla.org/Platform/Platform-specific_build_defines Please review and correct anything I got wrong, and add any additional defines as necessary. Thanks!

Re: Updated mozilla-central code coverage

2015-05-26 Thread kgupta
Does this coverage info also include gtests? From a quick glance it looks like not. On Tuesday, May 26, 2015 at 2:59:16 PM UTC-4, Joshua Cranmer 🐧 wrote: > I've posted updated code coverage information for mozilla-central to > . This data is accurate as

Re: It is now possible to apply arbitrary tags to tests/manifests and run all tests with a given tag

2015-05-04 Thread kgupta
On Thursday, April 30, 2015 at 7:22:26 PM UTC-4, Christopher Manchester wrote: > You can now add "--tag" arguments to try syntax and they will get passed to > test harnesses in your try push. Details of the implementation are in bug > 978846, but if you're interested in passing other arguments from

Re: AsyncPanZoom enabled for one Nightly - 4/22/2015 - Windows E10S only

2015-04-22 Thread kgupta
On Tuesday, April 21, 2015 at 10:51:58 PM UTC-4, David Anderson wrote: > We're interested in any significant behavior changes with APZ, and especially > any situations in which we can't pre-render content fast enough. In this case > you might see blank white areas of the screen while scrolling (a

Re: Intent to Ship: 3rd Party Install Tracking

2015-03-18 Thread kgupta
On Wednesday, March 18, 2015 at 2:29:32 PM UTC-4, Mark Finkle wrote: > There are good reasons for wanting to collect the data. Our marketing and > growth goals for 2015 will require spending non-trivial amounts of money. > The data will help us spend the money responsibly and efficiently. > We sti

Re: What are your pain points when running unittests?

2015-03-13 Thread kgupta
On Thursday, March 12, 2015 at 6:51:26 PM UTC-4, Jonathan Griffin wrote: > The quintessential use case here is making it easy to reproduce a try run > locally, without a local build, using a syntax something like: > > * runtests --try 2844bc3a9227 > > Ideally, this would download the appropriate

Re: Syncing 2 scrolling operations

2015-03-02 Thread kgupta
On Sat, Feb 28, 2015 at 3:47 AM, Paul Rouget wrote: > > How much work is that? Is it just a matter of "piping" things together > to expose an JS method to privileged code? > Not really - I think we would have to add new APIs to manipulate the layer tree of child processes from the parent process

Re: Syncing 2 scrolling operations

2015-02-26 Thread kgupta
On Thursday, February 26, 2015 at 1:06:15 PM UTC-5, Paul Rouget wrote: > I need a pretty picture to explain my problem: > http://people.mozilla.org/~prouget/scrollIssue.png Thanks for the pretty picture! It makes it much easier to visualize the problem :) > I tried to scroll the parent and > the

Re: APZC + onscroll

2015-02-25 Thread kgupta
On Wednesday, February 25, 2015 at 10:13:20 AM UTC-5, kgu...@mozilla.com wrote: > The scroll event is fired every time APZC sends a repaint request to the main > thread (which is what changes the scroll position). To clarify, by "changes the scroll position" here I mean "changes the main-thread

Re: APZC + onscroll

2015-02-25 Thread kgupta
On Wednesday, February 25, 2015 at 2:40:12 AM UTC-5, Paul Rouget wrote: > When is onscroll called if apzc is enabled? The scroll event is fired every time APZC sends a repaint request to the main thread (which is what changes the scroll position). > How often? Generally this is controlled by th

Re: Reconciling async scrolling with onscroll handlers

2015-02-16 Thread kgupta
On Sunday, February 15, 2015 at 4:48:06 PM UTC-5, Robert O'Callahan wrote: > Their current idea is to add a new CSS property "scroll-blocks-on" to let a > page opt into sync scrolling: > https://docs.google.com/document/d/1aOQRw76C0enLBd0mCG_-IM6bso7DxXwvqTiRWgNdTn8/edit# > In pages that drop below

Re: AreWeSlimYet, now with marionette and try integration

2015-02-13 Thread kgupta
On Thursday, February 12, 2015 at 8:58:42 PM UTC-5, Eric Rahm wrote: > Over the past month or so quite a few enhancements have been made to your > favorite memory regression website, https://areweslimyet.com. This is great to hear, thanks a lot for all your work on this! :) __

Re: gecko-dev and Git replication will be broken for a little while

2015-01-30 Thread kgupta
On Friday, January 30, 2015 at 5:30:52 AM UTC-5, 陳侃如 Kan-Ru Chen wrote: > > I use this alias in ~/.gitconfig > > [alias] > hg-format-patch = !sh -c 'git format-patch -kp -U8 "$@"|tee > /dev/stderr|xargs git-patch-to-hg-patch' git > > Get git-patch-to-hg-patch from https://github.com/mozil

Re: e10s content processes and coordinate systems

2015-01-16 Thread kgupta
On Thursday, January 15, 2015 at 3:24:03 PM UTC-5, Handyman wrote: > and the compositor... I'm not sure how it compensates but it must use a > different mechanism for Compositors and CrossProcessCompositors, probably at > the Layer level?). I believe this happens in RenderFrameParent::BuildLayer,