Re: Help ridding tests of unsafe CPOWs

2016-10-19 Thread Blake Kaplan
On Wed, Oct 19, 2016 at 10:19 AM, Chris Hutten-Czapski wrote: > Things that would help me help with this endeavour: > > 1: A bug to file patches against > ​I debated this, but given the number of tests involved that seemed like a bunch of overhead. I've been filing bugs as

Re: Help ridding tests of unsafe CPOWs

2016-10-19 Thread Blake Kaplan
On Wed, Oct 19, 2016 at 2:00 AM, Gabriele Svelto wrote: > I remember we did a big push in the War on Orange maybe three (or four?) > years ago. We could do it again; calling out to everybody to take > intermittent tests in the modules they're familiar with and start fixing >

Re: Help ridding tests of unsafe CPOWs

2016-10-19 Thread Dave Townsend
I am working on a patch that takes care of most of the warnings in toolkit/mozapps/extensions/test/xpinstall in https://bugzilla.mozilla.org/show_bug.cgi?id=1311459 On Tue, Oct 18, 2016 at 3:28 PM, Blake Kaplan wrote: > Hello everybody, > > I've been seeing a pattern of

Re: Help ridding tests of unsafe CPOWs

2016-10-19 Thread Chris Hutten-Czapski
Things that would help me help with this endeavour: 1: A bug to file patches against 2: A method for detecting if our fix actually fixes the problem I presume a skeleton of what we're looking for is: 1) Use DXR/ls -r/whatever to find the test file in the tree 2) On the line number(s) mentioned,

Re: Help ridding tests of unsafe CPOWs

2016-10-19 Thread Gabriele Svelto
Hi Blake, On 19/10/2016 00:28, Blake Kaplan wrote: > I've been seeing a pattern of "unsafe" CPOWs causing our browser-chrome > mochitests to go intermittently orange. Generally, it seems that a test > randomly turns orange, gets starred and ignored until RyanVM or another one > of our sheriffs

Help ridding tests of unsafe CPOWs

2016-10-18 Thread Blake Kaplan
Hello everybody, I've been seeing a pattern of "unsafe" CPOWs causing our browser-chrome mochitests to go intermittently orange. Generally, it seems that a test randomly turns orange, gets starred and ignored until RyanVM or another one of our sheriffs gets tired of seeing it and needinfos