Re: Profiling nightlies on Mac - what tools are used?

2017-06-23 Thread Chris Cooper
On Wednesday, June 21, 2017 at 12:56:10 PM UTC-4, Chris Peterson wrote: > i.e. Mike Shal's patch here fixed multiple 30% Talos regressions! > > -: WORKSPACE ${WORKSPACE:=/home/worker/workspace} > +: WORKSPACE ${WORKSPACE:=/builds/slave/try-m64-00} We're still working to get

Re: Profiling nightlies on Mac - what tools are used?

2017-06-23 Thread Mike Hommey
On Mon, Jun 19, 2017 at 10:21:14PM -0400, Boris Zbarsky wrote: > On 6/19/17 6:03 PM, Chris Cooper wrote: > > If you profile on Mac, now is your chance to speak up. What other profiling > > tools do you use that we should be aware of? > > Instruments for targeted profiling, though I mostly do

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Steve Fink
On 06/21/2017 09:56 AM, Chris Peterson wrote: On 6/21/17 8:06 AM, Boris Zbarsky wrote: On 6/21/17 10:44 AM, Ehsan Akhgari wrote: It seems like that we have an answer now in the bug! https://bugzilla.mozilla.org/show_bug.cgi?id=1338651#c129 Just for clarity, so people don't have to read the

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Chris Peterson
On 6/21/17 8:06 AM, Boris Zbarsky wrote: On 6/21/17 10:44 AM, Ehsan Akhgari wrote: It seems like that we have an answer now in the bug! https://bugzilla.mozilla.org/show_bug.cgi?id=1338651#c129 Just for clarity, so people don't have to read the whole bug, changing the _path_ the build is at

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Boris Zbarsky
On 6/21/17 10:44 AM, Ehsan Akhgari wrote: It seems like that we have an answer now in the bug! https://bugzilla.mozilla.org/show_bug.cgi?id=1338651#c129 Just for clarity, so people don't have to read the whole bug, changing the _path_ the build is at when it's compiled/linked results in the

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Ehsan Akhgari
On 06/21/2017 06:19 AM, Chris Cooper wrote: On Tuesday, June 20, 2017 at 1:28:50 PM UTC-4, Ehsan Akhgari wrote: My understanding is that the slowdown cannot be reproduced on local developer machines, but can be reproduced on loaner machines from infra. Huh. That's interesting and even more

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Ehsan Akhgari
On 06/20/2017 04:42 PM, Gregory Szorc wrote: On Tue, Jun 20, 2017 at 10:28 AM, Ehsan Akhgari > wrote: On 06/20/2017 12:28 PM, Nathan Froyd wrote: On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari

Re: Profiling nightlies on Mac - what tools are used?

2017-06-21 Thread Chris Cooper
On Tuesday, June 20, 2017 at 1:28:50 PM UTC-4, Ehsan Akhgari wrote: > > My understanding is that the slowdown cannot be reproduced on local > > developer machines, but can be reproduced on loaner machines from > > infra. > Huh. That's interesting and even more puzzling... > > I don't think

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Gregory Szorc
On Tue, Jun 20, 2017 at 10:28 AM, Ehsan Akhgari wrote: > On 06/20/2017 12:28 PM, Nathan Froyd wrote: > >> On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari >> wrote: >> >>> On 06/20/2017 08:34 AM, Nathan Froyd wrote: >>> There is some kind of

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Jeff Muizelaar
Very much so yes. Even if having unstripped builds were universally slower (they only seem to be only slower on the ci machines) any performance impact is likely to not impact the distribution of samples substantially. On Tue, Jun 20, 2017 at 2:09 PM, Chris Peterson wrote:

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Nathan Froyd
On Tue, Jun 20, 2017 at 12:19 PM, Ehsan Akhgari wrote: > On 06/20/2017 08:34 AM, Nathan Froyd wrote: >> There is some kind of interaction with the underlying machine (see >> comment 104 in said bug, where the binaries perform identically on a >> local machine, but

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Nathan Froyd
On Tue, Jun 20, 2017 at 3:59 AM, Julian Seward wrote: > On 20/06/17 05:58, Boris Zbarsky wrote: >> On 6/19/17 11:22 PM, Gregory Szorc wrote: >>> The decision to strip Nightly builds does not come lightly. Read 1338651 >>> comment 111 and later for the ugly backstory. >> >> It's

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Ted Mielczarek
On Tue, Jun 20, 2017, at 03:59 AM, Julian Seward wrote: > I've used VTune on Linux and have some idea what it can and can't do. > I have tried it on Mac, but my impression, from the Intel web site, is > that it is at least available for Mac. Apparently the version for Mac is just a GUI for

Re: Profiling nightlies on Mac - what tools are used?

2017-06-20 Thread Julian Seward
On 20/06/17 05:58, Boris Zbarsky wrote: > On 6/19/17 11:22 PM, Gregory Szorc wrote: >> The decision to strip Nightly builds does not come lightly. Read 1338651 >> comment 111 and later for the ugly backstory. > > It's still really confusing to me that not stripping symbols has a significant >

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Boris Zbarsky
On 6/19/17 11:22 PM, Gregory Szorc wrote: The decision to strip Nightly builds does not come lightly. Read 1338651 comment 111 and later for the ugly backstory. It's still really confusing to me that not stripping symbols has a significant performance impact. That's not the case in any other

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Gregory Szorc
On Mon, Jun 19, 2017 at 7:06 PM, Jeff Muizelaar wrote: > Yes. I use Instruments on Nightly builds extensively. It would really > be a loss to lose this functionality. I think it's important to weigh > the performance improvements that we get from easy profiling against >

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Boris Zbarsky
On 6/19/17 6:03 PM, Chris Cooper wrote: If you profile on Mac, now is your chance to speak up. What other profiling tools do you use that we should be aware of? Instruments for targeted profiling, though I mostly do that on my own builds, not mozilla.org nightlies. The sampling tool in

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Jeff Muizelaar
Yes. I use Instruments on Nightly builds extensively. It would really be a loss to lose this functionality. I think it's important to weigh the performance improvements that we get from easy profiling against any advantage we get from stripping the symbols. -Jeff On Mon, Jun 19, 2017 at 6:07 PM,

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Eric Rahm
DMD [1], although it's a bit busted on mac right now [2] I'd prefer if it didn't get more busted :) -e [1] https://developer.mozilla.org/en-US/docs/Mozilla/Performance/DMD [2] https://bugzilla.mozilla.org/show_bug.cgi?id=1371397 On Mon, Jun 19, 2017 at 3:03 PM, Chris Cooper

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Felipe G
library/content/technotes/tn2178 > > Cheers, > - Kip > > From: Bobby Holley > Sent: June 19, 2017 3:08 PM > To: Chris Cooper > Cc: dev-platform@lists.mozilla.org > Subject: Re: Profiling nightlies on Mac - what tools are used? > > Instruments is the big one that I'm awar

RE: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Kearwood Kip Gilbert
I would add to this Apple’s “OpenGL Profiler”: https://developer.apple.com/library/content/technotes/tn2178 Cheers, - Kip From: Bobby Holley Sent: June 19, 2017 3:08 PM To: Chris Cooper Cc: dev-platform@lists.mozilla.org Subject: Re: Profiling nightlies on Mac - what tools are used

Re: Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Bobby Holley
Instruments is the big one that I'm aware of. On Mon, Jun 19, 2017 at 3:03 PM, Chris Cooper wrote: > Hey all, > > The build peers are looking to change the way that nightlies are created > on Mac as we switch to cross-compilation. Specifically, we're looking at > stripping the

Profiling nightlies on Mac - what tools are used?

2017-06-19 Thread Chris Cooper
Hey all, The build peers are looking to change the way that nightlies are created on Mac as we switch to cross-compilation. Specifically, we're looking at stripping the nightlies to avoid an as-of-yet undiagnosed performance discrepancy vs native builds[1], but also to make the nightly