Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Niveditha Shankar
Could you please brief us a little on "Bluez(Arc), Android(Arc)... " so that we can get an idea of how they should be declared in trait. Since the implementation has to be per platform, I understand that the function calls for say, get_id() should be direct like - bluez.get_id(). It would be helpf

Re: [dev-servo] println!("Hello from NCSU");

2019-03-31 Thread Akhilesh Venkatasubramanian
Hi Josh, I have some questions regarding how the params.rs code works as I was not able to find the answers to these online. *1. *When I run an example to setValueCurve with start_time = 1 with a duration of 5 (shown here

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Josh Bowman-Matthews
The devices crate is a crates.io dependency rather than a github one, since we publish new changes to crates.io. That means adding an entry to the existing [patch.crates-io] category instead of creating a new category for the github repository. On 3/31/19 6:56 PM, Niveditha Shankar wrote: Tha

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Niveditha Shankar
Thank you , I will look into it and see if I can fix them. We referred to the links you sent us on overriding dependancies and tried them. We are unable to run it. We get the error *error:* failed to resolve patches for `https://github.com/servo/devices` Caused by: patch for `devices` in `ht

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Josh Bowman-Matthews
Those errors are difficult to diagnose without seeing the rest of the code. However, given that BluetoothAdapter is supposed to be a trait now, the second function does not look like it is using trait objects correctly. As for the first function, the error message appears to be describing a con

Re: [dev-servo] println!("Hello from NCSU");

2019-03-31 Thread Akhilesh Venkatasubramanian
Hi Josh, What are your thought on this question : > 1. Is it necessary we define and initialize the values and duration parameter > that we are using inside SetValueCurveAtTime inside the struct Param > ? > We assume that th

Re: [dev-servo] Fwd: println!("Hello from NCSU");

2019-03-31 Thread BAlaji
Hi Josh I am doing as in here https://github.com/servo/servo/blob/master/appveyor.yml#L57 so I would update to , installing 1.14.3, and report back then. Thanks Balaji Janakarajan Hari Graduate Student - IMSE Program NC State linkedin/com/in/jhbalaji 903.600.0091 From: Josh Bowman-Matthews S

Re: [dev-servo] Fwd: println!("Hello from NCSU");

2019-03-31 Thread Josh Bowman-Matthews
gstwebrtc-1.0.lib is a library that is part of GStreamer, which Servo relies upon for media playback. To my best knowledge, the build environment setup instructions have been enough to allow other people to build on Windows without encountering this error. The code that instructs the build to i

Re: [dev-servo] Regarding CSC 517 OSS project

2019-03-31 Thread Niveditha Shankar
Hello Josh We are trying to fix the errors we got in adapter.rs. We fixed most of them. The errors that are left are due to the changes we made to the init functions. We are not sure about the following errors, could you help us with this? error[E0407]: method `get_modalias` is not a member of t

Re: [dev-servo] ConstantSourceNode DOM Build Error

2019-03-31 Thread Josh Bowman-Matthews
OscillatorNodeOptions has a `parent` field because the OscillatorNodeOptions dictionary in the WebIDL declaration inherits from the AudioScheduledNodeOptions dictionary. Since the ConstantSourceOptions dictionary does not inherit from anything, it has no parent field. On 3/31/19 3:26 PM, Chri

Re: [dev-servo] Fwd: println!("Hello from NCSU");

2019-03-31 Thread BAlaji
Hi Josh Does Rust has issues with building with IntelliJ and Rust Up installed? I came across several Rust build errors and were able to lookup and fix throughout with Github issues posted. But this one is driving me crazy error: linking with `link.exe` failed: exit code: 1181 = note: LINK : f

[dev-servo] ConstantSourceNode DOM Build Error

2019-03-31 Thread Chris Benfante
Hi all, We've been working on implementing ConstantSourceNode (#21803 ), but have run into some build issues that we're having trouble identifying. We've model our code on the OscillatorNode implementation, but can't find what we're missing. Currently, w

Re: [dev-servo] Fwd: println!("Hello from NCSU");

2019-03-31 Thread BAlaji
Hi Josh Does Rust has issues with building with IntelliJ and Rust Up installed? I came across several Rust build errors and were able to lookup and fix throughout with Github issues posted. But this one is driving me crazy error: linking with `link.exe` failed: exit code: 1181   = note: LINK : f

Re: [dev-servo] Incremental compilation is very slow

2019-03-31 Thread Yu Feng
I restarted my machine to free the memory and now it took 8 mins to recompile the code. Any faster way to debug the layout crate? On Sun, Mar 31, 2019 at 12:04 AM Yu Feng wrote: > Hi Josh, > > I am modifying the layout crate: > https://github.com/servo/servo/tree/master/components/layout > > [im

Re: [dev-servo] Incremental compilation is very slow

2019-03-31 Thread Yu Feng
Hi Josh, I am modifying the layout crate: https://github.com/servo/servo/tree/master/components/layout [image: image.png] On Fri, Mar 29, 2019 at 9:26 PM Josh Bowman-Matthews wrote: > Hi Yu, > Servo can take a long time to build on machines that do not have many > CPUs or have less than 8GB of