Re: [dev-servo] Merging mozjs and rust-mozjs

2020-01-10 Thread Josh Matthews
Correct. On 2020-01-10 6:23 p.m., Alan Jeffrey wrote: Would the idea be to have two top-level dirs, `mozjs` and `mozjs_sys` each of which has its own `Cargo.toml`? So the crates would be the same, it's just the repos that are merging? On Fri, Jan 10, 2020 at 10:31 AM Manish Goregaokar wrote:

Re: [dev-servo] Merging mozjs and rust-mozjs

2020-01-10 Thread Alan Jeffrey
Would the idea be to have two top-level dirs, `mozjs` and `mozjs_sys` each of which has its own `Cargo.toml`? So the crates would be the same, it's just the repos that are merging? On Fri, Jan 10, 2020 at 10:31 AM Manish Goregaokar wrote: > This seems good to me. > > > On Fri, Jan 10, 2020, 9:59

Re: [dev-servo] Merging mozjs and rust-mozjs

2020-01-10 Thread Manish Goregaokar
This seems good to me. On Fri, Jan 10, 2020, 9:59 PM Josh Matthews wrote: > Given how closely intertwined the two repositories are, and especially > given we can no longer publish them to crates.io and have a pinned git > revision in rust-mozjs's Cargo.toml, I propose that we merge the > servo/

[dev-servo] Merging mozjs and rust-mozjs

2020-01-10 Thread Josh Matthews
Given how closely intertwined the two repositories are, and especially given we can no longer publish them to crates.io and have a pinned git revision in rust-mozjs's Cargo.toml, I propose that we merge the servo/mozjs and servo/rust-mozjs repositories into servo/mozjs. We can follow https://s

Re: [dev-servo] Re-enable non_snake_case warnings?

2020-01-10 Thread Josh Matthews
If they are direct FFI bindings then we can't rename them, since those are the actual exported symbols names from mozjs. If they are custom glue code we've written, my preference is to keep the UpperCamelCase format if they are only transparent wrappers around C++ methods like https://github.co