Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-30 Thread Anthony Ramine
"Backed out changeset 90036d4d378e (bug 17564) because gecko-side patch caused bustage on Windows. r=backout on a CLOSED TREE" I see issues in that: - Mentioning a Mercurial changeset hash when just a PR number is enough - Putting the reason of the backout directly in the title instead of the me

Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-30 Thread Simon Sapin
On 19/06/2017 20:48, Lars Bergstrom wrote: tldr: If you see some PRs from the moz-servo-sync GitHub user with a priority of "treeclosed," it's because those must be landed into Servo ASAP to support Firefox backouts. Where do we file bugs on this tool? It creates a new PR that mentions the nu

Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-30 Thread Byron Jones
Anthony Ramine wrote: "Backed out changeset 90036d4d378e (bug 17564) because gecko-side patch caused bustage on Windows. r=backout on a CLOSED TREE" I see issues in that: - Mentioning a Mercurial changeset hash when just a PR number is enough this is true for the servo side. we need it on

Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-30 Thread Byron Jones
Simon Sapin wrote: On 19/06/2017 20:48, Lars Bergstrom wrote: tldr: If you see some PRs from the moz-servo-sync GitHub user with a priority of "treeclosed," it's because those must be landed into Servo ASAP to support Firefox backouts. Where do we file bugs on this tool? It creates a new PR

Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-20 Thread Lars Bergstrom
Opinions vary. From my point of view, if we attempt another subsystem transplant across a code boundary that lacks clean separation (e.g., parallel layout), then we will continue to need this coupling in the future. If we instead get to a point where most of the modules that Firefox is using from

Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-20 Thread Anthony Ramine
In the future, will we try to uncouple servo from mozilla-central? I understand that it is needed now, but I don't see how such coupling is a good thing on the long term. > Le 19 juin 2017 à 21:25, Jack Moffitt a écrit : > > Thank for everyone's efforts here. There never seems to be a perfect

Re: [dev-servo] [stylo-team] Mozilla central backout support arriving to Servo later this week

2017-06-19 Thread Jack Moffitt
Thank for everyone's efforts here. There never seems to be a perfect solution in technology, but I am happy we've found a solution that satisfies most of the constraints and were able to deploy it in time. For anyone that didn't already see it, glob wrote about the design here: https://blog.glob.c