Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-27 Thread Manish Goregaokar
Yeah, please leave a todo comment. Currently there's no way to validate this, in the future the DOM side will also have a timeline struct so that it can do this. Thanks, -Manish Goregaokar On Sat, Apr 27, 2019 at 6:52 AM Josh Bowman-Matthews wrote: > It's not clear to me how to obtain the

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-27 Thread Josh Bowman-Matthews
It's not clear to me how to obtain the information about whether a value curve is active. I recommend making a pull request with the rest of the changes and adding a TODO comment about the missing check. On 4/26/19 6:01 PM, Srivatsan Narasimhan wrote: Hi Josh, I wrote the two methods with the

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Srivatsan Narasimhan
Hi Josh, I wrote the two methods with the help of the links you gave before and it is building without anu errors. Now i have some doubts regarding the NotSupportedError message. I am not sure when to call that because in the method description it says that it should be thrown if any of the

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Josh Bowman-Matthews
To throw a NotSupportedError, you can use https://dxr.mozilla.org/servo/source/components/script/dom/audionode.rs#280 as an example, and see that the WebIDL contains either [Throws] (for a method) or [SetterThrows]/[GetterThrows] for an attribute

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Akhilesh Venkatasubramanian
HI CYBAI, 1. We are trying to implement the SetOrientation and the SetPosition methods as here . We tried quite a few variations, but not able to store the passed function value into forwardX

Re: [dev-servo] Doubts regarding the subsequent steps.

2019-04-26 Thread Cheng You Bai
Hi Srivatsan, This is CYBAI who is a Servo contributor. I think you can try to read this blogpost . It explains how to add a new DOM API for Servo from scratch and also includes the uncomment methods part. Hope it help! Cheers,

[dev-servo] Doubts regarding the subsequent steps.

2019-04-25 Thread Srivatsan Narasimhan
Hi Josh, This is Srivatsan Narasimhan from NCSU currently working on this issue https://github.com/servo/servo/issues/22898 along with my team mates akhilesh, balaji and arjun as a part of the course OODD. I uncommented the methods in the AudioListener.webidl and currently i am having some