Re: [dev-servo] Error during compilation

2018-12-09 Thread Manish Goregaokar
Not in the example you're using. -Manish Goregaokar On Thu, Dec 6, 2018 at 5:09 PM Avanthikaa Ravichandran wrote: > Is it necessary to send any message to the GainNode? > > > On Dec 6, 2018, at 11:04 AM, Manish Goregaokar > wrote: > > > > Sorry, to clarify: this was a bug in the existing code,

Re: [dev-servo] Error during compilation

2018-12-06 Thread Avanthikaa Ravichandran
Is it necessary to send any message to the GainNode? > On Dec 6, 2018, at 11:04 AM, Manish Goregaokar wrote: > > Sorry, to clarify: this was a bug in the existing code, not your code. > -Manish Goregaokar > > > On Thu, Dec 6, 2018 at 11:04 AM Manish Goregaokar > wrote: > >> I pushed a fix,

Re: [dev-servo] Error during compilation

2018-12-06 Thread Manish Goregaokar
Sorry, to clarify: this was a bug in the existing code, not your code. -Manish Goregaokar On Thu, Dec 6, 2018 at 11:04 AM Manish Goregaokar wrote: > I pushed a fix, please rebase your pull request to master to pull it in. > > Thanks, > -Manish Goregaokar > > > On Wed, Dec 5, 2018 at 10:08 PM Av

Re: [dev-servo] Error during compilation

2018-12-06 Thread Manish Goregaokar
I pushed a fix, please rebase your pull request to master to pull it in. Thanks, -Manish Goregaokar On Wed, Dec 5, 2018 at 10:08 PM Avanthikaa Ravichandran wrote: > We pushed the final changes in the code and we have the same issue still. > On running with backtrace, I got the following output

Re: [dev-servo] Error during compilation

2018-12-05 Thread Avanthikaa Ravichandran
We pushed the final changes in the code and we have the same issue still. On running with backtrace, I got the following output: RUST_BACKTRACE=1 ./target/debug/constant_source thread 'AudioRenderThread' panicked at 'index 128 out of range for slice of length 0', libcore/slice/mod.rs:1932:5 note

Re: [dev-servo] Error during compilation

2018-11-30 Thread Manish Goregaokar
It would be helpful to see what your changes are and what test command you're running (along with a full backtrace, setting RUST_BACKTRACE=1 will let you get one). I'm unable to get this same error when I test your pull request locally. (Which github issue are you talking about?) -Manish Goregaoka

[dev-servo] Error during compilation

2018-11-30 Thread Avanthikaa Ravichandran
I made changes to the ConstantSourceNode example as suggested in the review for the pull request. However, I am getting the following error while running the file: thread 'AudioRenderThread' panicked at 'index 128 out of range for slice of length 0', libcore/slice/mod.rs:1932:5 note: Run with `RUS