Re: [JS-internals] Clang-format

2016-05-11 Thread Jim Blandy
On Wed, May 11, 2016 at 11:31 AM, Bill McCloskey wrote: > I'm sorry to be so corny and didactic, but I've been feeling really > strongly about this problem given all the troubles that have arisen between > the platform and front-end teams lately. We all need to stick together and > be one Mozilla

Re: [JS-internals] Clang-format

2016-05-11 Thread Jason Orendorff
On Wed, May 11, 2016 at 1:31 PM, Bill McCloskey wrote: > I'm sorry to be so corny and didactic, but I've been feeling really > strongly about this problem given all the troubles that have arisen between > the platform and front-end teams lately. We all need to stick together and > be one Mozilla.

Re: [JS-internals] Clang-format

2016-05-11 Thread Luke Wagner
Very much agreed on all these points. Also, beyond fixing bugs, crossing components often allows for fundamentally simpler and more efficient designs. (Also, fwiw, 2-space indent seems fine, even preferable, to me.) On Wed, May 11, 2016 at 1:31 PM, Bill McCloskey wrote: > On Wed, May 11, 2016 a

Re: [JS-internals] Clang-format

2016-05-11 Thread Bill McCloskey
On Wed, May 11, 2016 at 5:01 AM, Nicolas B. Pierron < nicolas.b.pier...@mozilla.com> wrote: If the problem are the pointless arguments on dev.platform, which are > mistakenly considering SpiderMonkey as Gecko's property, I would totally > agree on moving SpiderMonkey into its own repository. > > I

Re: [JS-internals] Generating an ErrorReport from a thrown value

2016-05-11 Thread Jason Orendorff
Yeah, you're right. There's one usage pattern in particular where you grab the pending exception state, set it aside, clear the context's pending exception, and do some stuff; then possibly put the originally-pending exception back. `finally` blocks are like this. Putting it back is the problem: y

Re: [JS-internals] Rust JSAPI bindings in js/src?

2016-05-11 Thread Jim Blandy
On Wed, May 11, 2016 at 1:45 AM, Anthony Ramine wrote: > > Le 11 mai 2016 à 08:36, Jim Blandy a écrit : > > The SpiderMonkey engineers build the library separately from the rest of > Firefox all the time; the "JS shell" is the preferred development vehicle. > So we can trust that the stand-alone

Re: [JS-internals] Rust JSAPI bindings in js/src?

2016-05-11 Thread Steve Fink
On 05/11/2016 02:42 AM, Ms2ger wrote: On 11/05/16 08:36, Jim Blandy wrote: It looks like the lack of any CI of the SM-only distribution is a non-trivial source of pain. That seems independent of where the Rust JSAPI bindings live, and indeed, independent of Rust altogether. The SpiderMonkey eng

Re: [JS-internals] Rust JSAPI bindings in js/src?

2016-05-11 Thread Anthony Ramine
> Le 11 mai 2016 à 08:36, Jim Blandy a écrit : > > The SpiderMonkey engineers build the library separately from the rest of > Firefox all the time; the "JS shell" is the preferred development vehicle. So > we can trust that the stand-alone SM builds work. That means that the > difficulties are

Re: [JS-internals] Clang-format

2016-05-11 Thread Nicolas B. Pierron
On 05/11/2016 02:15 AM, Jason Orendorff wrote: instead go with Terrence’s suggestion and simply adopt the same style as the rest of Gecko, including the 2-space indent. I've said before that we won't do this without talking it over as a team. Well, team? What do you think? Massive changes ar

Re: [JS-internals] Rust JSAPI bindings in js/src?

2016-05-11 Thread Ms2ger
On 11/05/16 08:36, Jim Blandy wrote: > It looks like the lack of any CI of the SM-only distribution is a > non-trivial source of pain. That seems independent of where the Rust JSAPI > bindings live, and indeed, independent of Rust altogether. > > The SpiderMonkey engineers build the library separa

Re: [JS-internals] Clang-format

2016-05-11 Thread David Anderson
Surely the 80 column limit can be changed in Gecko? Does anyone have 80-column monitors still? -David On Tue, May 10, 2016 at 11:25 PM, Jan de Mooij wrote: > On Wed, May 11, 2016 at 4:15 AM, Jason Orendorff > wrote: > > > I've said before that we won't do this without talking it over as a team