RE: [VFS]HttpConnectionManager
Hi! -Original Message- From: Ralph Goers [mailto:ralph.go...@dslextreme.com] Sent: Monday, February 23, 2009 8:29 AM Thanks Mario. VFS-164 wasn't really clear. Was the problem the limit to 2 connections per host that MultiThreadedHttpConnectionManager has by default? Sorry, I can't remember :-( Yes, I think it hang, and I am not sure if the maxConnectionsPerHost existed at this time, or probably I just overlooked it *grmpf*. I've added maxConnectionsPerHost and maxTotalConnections to HttpFileSystemConfigBuilder and also allowed them to be specified as system properties. You would make a lot of people happy (I think) if you implement this in a commons way, so that every FileSystemOption can also be specified using system properties. Or did you already? :-) Something like -Dvfsopt.ftp.passiveMode=true You can use the DelegatingFileSystemOptionsBuilder to help you here. FileSystemOptions fso = new FileSystemOptions(); DelegatingFileSystemOptionsBuilder delegate = new DelegatingFileSystemOptionsBuilder(VFS.getManager()); delegate.setConfigString(fso, sftp, identities, c:/tmp/test.ident); delegate.setConfigString(fso, http, proxyPort, 8080); delegate.setConfigClass(fso, sftp, userinfo, TrustEveryoneUserInfo.class); by iterating over the System properties, taking each vfsopt.* and split it so taht you can pass it to setConfigString. This can do the trick. Ciao, Mario - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VFS]HttpConnectionManager
On Feb 23, 2009, at 12:18 AM, Mario Ivankovits wrote: I've added maxConnectionsPerHost and maxTotalConnections to HttpFileSystemConfigBuilder and also allowed them to be specified as system properties. You would make a lot of people happy (I think) if you implement this in a commons way, so that every FileSystemOption can also be specified using system properties. Or did you already? :-) Something like -Dvfsopt.ftp.passiveMode=true You can use the DelegatingFileSystemOptionsBuilder to help you here. FileSystemOptions fso = new FileSystemOptions(); DelegatingFileSystemOptionsBuilder delegate = new DelegatingFileSystemOptionsBuilder(VFS.getManager()); delegate.setConfigString(fso, sftp, identities, c:/tmp/ test.ident); delegate.setConfigString(fso, http, proxyPort, 8080); delegate.setConfigClass(fso, sftp, userinfo, TrustEveryoneUserInfo.class); by iterating over the System properties, taking each vfsopt.* and split it so taht you can pass it to setConfigString. This can do the trick. Thanks. No, I hadn't done that but I will definitely give it a try! Ralph - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
RE: [VFS]HttpConnectionManager
Hi! -Original Message- From: Ralph Goers [mailto:ralph.go...@dslextreme.com] Sent: Monday, February 23, 2009 7:28 AM What I'd like to know is, was there more to VFS-164 than is stated in the issue and is this change sufficient? Or do I need to create yet another HttpConnectionManager? No, it was just VFS-164 and if you found another solution to that which allows multiple files now it is good! :-) Ciao, Mario - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
Re: [VFS]HttpConnectionManager
Thanks Mario. VFS-164 wasn't really clear. Was the problem the limit to 2 connections per host that MultiThreadedHttpConnectionManager has by default? I changed VFS to have it default to 5 and the unit tests pass - including ContentTests.testConcurrentRead() which would hang with only 2 connections. I've added maxConnectionsPerHost and maxTotalConnections to HttpFileSystemConfigBuilder and also allowed them to be specified as system properties. Ralph On Feb 22, 2009, at 11:15 PM, Mario Ivankovits wrote: Hi! -Original Message- From: Ralph Goers [mailto:ralph.go...@dslextreme.com] Sent: Monday, February 23, 2009 7:28 AM What I'd like to know is, was there more to VFS-164 than is stated in the issue and is this change sufficient? Or do I need to create yet another HttpConnectionManager? No, it was just VFS-164 and if you found another solution to that which allows multiple files now it is good! :-) Ciao, Mario - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org
