Re: [VOTE] svn-keywords and @author tags
+1 regards, gerhard 2013/10/14 Gerhard Petracek gpetra...@apache.org hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS
Result (was: Re: [VOTE] svn-keywords and @author tags)
thank you for voting! 5 binding +1 votes for removing both (pmc): - Bernd Bohmann - Jakob Korherr - Mark Struberg - Matthias Wessendorf - Gerhard Petracek 2 binding +1 votes for removing both with exceptions (pmc): - Mike Kienenberger - Udo Schnurpfeil 1 binding +1 vote for removing svn-keywords (pmc): - Leonardo Uribe 1 binding +0 vote for removing @author tags with exceptions (pmc): - Leonardo Uribe 1 binding +0 vote (pmc): - Werner Punz no -1 votes regards, gerhard 2013/10/14 Gerhard Petracek gpetra...@apache.org hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS
Re: [VOTE] svn-keywords and @author tags
+1 but I've no problem with leaving code like it is for special situations Leonardo described. Udo Am 14.10.13 17:32, schrieb Werner Punz: +0 from my side, I simply do not care, I can live with both solutions. Werner Am 14.10.13 16:18, schrieb Leonardo Uribe: +0 for removing author tags. Note there is code licensed under ASL that was originally taken from other sources, and it is a good idea to keep the references of where that code came from. For example: http://svn.apache.org/repos/asf/myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StreamCharBuffer.java I don't like the idea of remove the @author tag in those places. But if people wants to get rid of @author tag, I will not object that. +1 for remove svn tags (not used at all). 2013/10/14 Mike Kienenberger mkien...@gmail.com mailto:mkien...@gmail.com +1 for removing author tags. +1 for removing most svn tags There's value in having the svn version tag as you can't tell what version of the file you are working with once the file is used outside of svn. On the other hand, having the svn version tag can make diffing changes more difficult. So I guess I'm +0.01 on keeping the svn version tags, but I could easily go the other way. On Mon, Oct 14, 2013 at 9:49 AM, Jakob Korherr jakob.korh...@gmail.com mailto:jakob.korh...@gmail.com wrote: +1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org mailto:gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [VOTE] svn-keywords and @author tags
+1 On Oct 14, 2013 3:46 PM, Gerhard Petracek gpetra...@apache.org wrote: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS
Re: [VOTE] svn-keywords and @author tags
+1 On Mon, Oct 14, 2013 at 5:20 PM, Matthias Wessendorf mat...@apache.org wrote: +1 On Oct 14, 2013 3:46 PM, Gerhard Petracek gpetra...@apache.org wrote: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS
Re: [VOTE] svn-keywords and @author tags
+1 All the 'hard facts' (means who committed what and when) are in our SCM anyway. Noone need to fear that his merrit vanishes only because we remove the @author tags. People know exactly who does the vast majority of the work - so it's also time to say txs to Leo and all other passionate MyFaces hackers for putting so much heart into it :) LieGrue, strub From: Matthias Wessendorf mat...@apache.org To: MyFaces Development dev@myfaces.apache.org Sent: Monday, 14 October 2013, 17:20 Subject: Re: [VOTE] svn-keywords and @author tags +1 On Oct 14, 2013 3:46 PM, Gerhard Petracek gpetra...@apache.org wrote: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS
Re: [VOTE] svn-keywords and @author tags
+1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [VOTE] svn-keywords and @author tags
+1 for removing author tags. +1 for removing most svn tags There's value in having the svn version tag as you can't tell what version of the file you are working with once the file is used outside of svn. On the other hand, having the svn version tag can make diffing changes more difficult. So I guess I'm +0.01 on keeping the svn version tags, but I could easily go the other way. On Mon, Oct 14, 2013 at 9:49 AM, Jakob Korherr jakob.korh...@gmail.com wrote: +1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [VOTE] svn-keywords and @author tags
+0 for removing author tags. Note there is code licensed under ASL that was originally taken from other sources, and it is a good idea to keep the references of where that code came from. For example: http://svn.apache.org/repos/asf/myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StreamCharBuffer.java I don't like the idea of remove the @author tag in those places. But if people wants to get rid of @author tag, I will not object that. +1 for remove svn tags (not used at all). 2013/10/14 Mike Kienenberger mkien...@gmail.com +1 for removing author tags. +1 for removing most svn tags There's value in having the svn version tag as you can't tell what version of the file you are working with once the file is used outside of svn. On the other hand, having the svn version tag can make diffing changes more difficult. So I guess I'm +0.01 on keeping the svn version tags, but I could easily go the other way. On Mon, Oct 14, 2013 at 9:49 AM, Jakob Korherr jakob.korh...@gmail.com wrote: +1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [VOTE] svn-keywords and @author tags
+0 from my side, I simply do not care, I can live with both solutions. Werner Am 14.10.13 16:18, schrieb Leonardo Uribe: +0 for removing author tags. Note there is code licensed under ASL that was originally taken from other sources, and it is a good idea to keep the references of where that code came from. For example: http://svn.apache.org/repos/asf/myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StreamCharBuffer.java I don't like the idea of remove the @author tag in those places. But if people wants to get rid of @author tag, I will not object that. +1 for remove svn tags (not used at all). 2013/10/14 Mike Kienenberger mkien...@gmail.com mailto:mkien...@gmail.com +1 for removing author tags. +1 for removing most svn tags There's value in having the svn version tag as you can't tell what version of the file you are working with once the file is used outside of svn. On the other hand, having the svn version tag can make diffing changes more difficult. So I guess I'm +0.01 on keeping the svn version tags, but I could easily go the other way. On Mon, Oct 14, 2013 at 9:49 AM, Jakob Korherr jakob.korh...@gmail.com mailto:jakob.korh...@gmail.com wrote: +1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org mailto:gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
Re: [VOTE] svn-keywords and @author tags
@imported code: please never import code without ip clearance. if there is an issue with the imported code, the @author tag won't help you at all. (if you would like to have the information for other reasons, just add it to the commit-message.) regards, gerhard 2013/10/14 Leonardo Uribe lu4...@gmail.com +0 for removing author tags. Note there is code licensed under ASL that was originally taken from other sources, and it is a good idea to keep the references of where that code came from. For example: http://svn.apache.org/repos/asf/myfaces/core/trunk/shared/src/main/java/org/apache/myfaces/shared/util/StreamCharBuffer.java I don't like the idea of remove the @author tag in those places. But if people wants to get rid of @author tag, I will not object that. +1 for remove svn tags (not used at all). 2013/10/14 Mike Kienenberger mkien...@gmail.com +1 for removing author tags. +1 for removing most svn tags There's value in having the svn version tag as you can't tell what version of the file you are working with once the file is used outside of svn. On the other hand, having the svn version tag can make diffing changes more difficult. So I guess I'm +0.01 on keeping the svn version tags, but I could easily go the other way. On Mon, Oct 14, 2013 at 9:49 AM, Jakob Korherr jakob.korh...@gmail.com wrote: +1 Regards, Jakob 2013/10/14 Gerhard Petracek gpetra...@apache.org: hi @ all, we already had a discussion as well as an agreement about it (starting point: [1]). in several modules the cleanup is finished. however, since we still have (even new) parts which contain svn-keywords and/or @author tags, i start this formal vote. please vote with - [ ] +1 for: stop using svn-keywords and @author tags (+ remove the remaining) [ ] +0 [ ] -1 for: we should keep svn-keywords and @author tags - regards, gerhard [1] http://s.apache.org/ZtS -- Jakob Korherr blog: http://www.jakobk.com twitter: http://twitter.com/jakobkorherr work: http://www.irian.at
