Re: [edk2-devel] [PATCH V2 0/2] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Friday, April 12, 2019 8:14 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Wu, Hao A; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; > Michael Turner; Bret Barkelew >

Re: [edk2-devel] [platforms: PATCH] Marvell/Armada7k8k: Remove UefiDecompressLib

2019-04-11 Thread Ard Biesheuvel
On Thu, 11 Apr 2019 at 16:30, Marcin Wojtas wrote: > > Recent changes in EDK2 moved UefiDecompressLib from the > IntelFrameworkModulePkg, breaking the compilation of > Armada platforms. It turned out it is not needed, so fix it by > safely removing references to the problematic library. > >

[edk2-devel] [PATCH 2/2] MdeModulePkg/GraphicsConsoleDxe: Do not clean the screen

2019-04-11 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1412 For now, most platform support to display during PEIM. It means the logo can show at PEI phase. But the screen would be cleared at BDS connect console phase. That may make the screen flush and turn into black screen. So

[edk2-devel] [PATCH 0/2] MdeModulePkg: Make the screen seamless

2019-04-11 Thread Gao, Zhichao
For now most platforms support display function at PEI phase. But the conspliter and graphics console driver would clear the screen at BDS connect console phase. Maybe some platforms would show logo in the next or maybe not. For consumers, it looks like the screen flashed. So change the behavior

[edk2-devel] [PATCH 1/2] MdeModulePkg/ConSplitterDxe: Optimize the ConSplitterTextOutSetMode

2019-04-11 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1412 For Console Out device, it would always set all present devices' text out mode again through ConSplitterTextOutSetMode while adding devices. That may cause the screen cleared for serval times. So add a BOOLEAN to judge

Re: [edk2-devel] [edk2-platforms/devel-MinPlatform][Patch v2] AdvancedFeaturePkg/AcpiDebug: Add new AcpiDebug modules.

2019-04-11 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Dong, Eric > Sent: Sunday, April 7, 2019 9:50 PM > To: devel@edk2.groups.io > Cc: Wu, Hao A ; Kubacki, Michael A > > Subject: [edk2-devel]

[edk2-devel] [Patch] BaseTools: Remove the unnecessary copy action for module output files

2019-04-11 Thread Liming Gao
BZ:https://bugzilla.tianocore.org/show_bug.cgi?id=1673 Signed-off-by: Liming Gao Cc: Bob Feng --- BaseTools/Conf/build_rule.template | 19 +-- 1 file changed, 1 insertion(+), 18 deletions(-) diff --git a/BaseTools/Conf/build_rule.template b/BaseTools/Conf/build_rule.template

[edk2-devel] [PATCH V2 5/5] MdePkg/UefiDebugLibStdErr: Make it runtime safe

2019-04-11 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 After ExitBootServices, some pointer would be invalid such as the Protocol pointer and gST. The function depend on those should be prevent. So disable the related function while after ExitBootServices. Change the gST to

[edk2-devel] [PATCH V2 1/5] MdeModulePkg: Change the SMM debug lib instance

2019-04-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 The UefiDebugLibConOut will not support DXE_SMM_DRIVER, change UefiDebugLibConOut to BaseDebugLibNull. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew

[edk2-devel] [PATCH V2 3/5] MdePkg/UefiDebugLibDebugPortProtocol: Make it runtime safe

2019-04-11 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 After ExitBootServices, some pointer would be invalid such as the Protocol pointer and gBS. The function depend on those should be prevent. So disable the related function while after ExitBootServices. Change the gBS to

[edk2-devel] [PATCH V2 2/5] SignedCapsulePkg: Change the SMM debug lib instance

2019-04-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 The UefiDebugLibConOut will not support DXE_SMM_DRIVER, change UefiDebugLibConOut to BaseDebugLibNull. Cc: Jiewen Yao Cc: Chao Zhang Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao ---

[edk2-devel] [PATCH V2 4/5] MdePkg/UefidebugLibConOut: Make it runtime safe

2019-04-11 Thread Gao, Zhichao
From: Aaron Antone REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1416 After ExitBootServices, some pointer would be invalid such as the Protocol pointer and gST. The function depend on those should be prevent. So disable the related function while after ExitBootServices. Change the gST to

[edk2-devel] [PATCH V2 2/2] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Gao, Zhichao
From: Bret Barkelew REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1677 For some pointer and UINT64 data, the debug code print with '%x'. Which would loss the upper 32bit data. So update '%x' to '%lx' for these data. And change the pointer value from '%x' to '%p'. Cc: Jian J Wang Cc: Hao

[edk2-devel] [PATCH V2 0/2] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Gao, Zhichao
Change the EFI_D_ version debug MACRO to DEBUG_ version. And change the UINT64 value from '%x' to '%lx'. V2: Seperate one patch to two to view different change goal. Change the pointer value from '%x' to '%p'. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean

[edk2-devel] [PATCH V2 1/2] MdeModulePkg/CapsulePei: Change debug MACRO

2019-04-11 Thread Gao, Zhichao
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1677 Change debug printlevel from EFI_D_ to DEBUG_. DEBUG_ version is recommanded to use. Cc: Jian J Wang Cc: Hao Wu Cc: Ray Ni Cc: Star Zeng Cc: Liming Gao Cc: Sean Brogan Cc: Michael Turner Cc: Bret Barkelew Signed-off-by: Zhichao Gao

[edk2-devel] [platforms: PATCH] Marvell/Armada7k8k: Remove UefiDecompressLib

2019-04-11 Thread Marcin Wojtas
Recent changes in EDK2 moved UefiDecompressLib from the IntelFrameworkModulePkg, breaking the compilation of Armada platforms. It turned out it is not needed, so fix it by safely removing references to the problematic library. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

Re: [edk2-devel] [PATCH edk2-platforms] Platform/DeveloperBox: actually enable secure boot checking

2019-04-11 Thread Ard Biesheuvel
On Thu, 11 Apr 2019 at 12:29, Leif Lindholm wrote: > > On Wed, Apr 10, 2019 at 11:06:02AM -0700, Ard Biesheuvel wrote: > > The current secure boot enabled DeveloperBox build contains all the > > pieces to maintain the authenticated variable store, but doesn't > > actually bother to check the

Re: [edk2-devel] [PATCH v5 5/7] MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol

2019-04-11 Thread Michael D Kinney
Ard, Comment below on a VS2015x86 build issue. Mike > -Original Message- > From: devel@edk2.groups.io > [mailto:devel@edk2.groups.io] On Behalf Of Ard > Biesheuvel > Sent: Thursday, April 11, 2019 11:58 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Zimmer, > Vincent ; Richardson,

Re: [edk2-devel] [PATCH v5 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images

2019-04-11 Thread Michael D Kinney
Ard, A could small comments below on use of sizeof(). Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Thursday, April 11, 2019 11:58 AM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; Zimmer, > Vincent ; Richardson, Brian > ; Kinney, Michael

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread Philippe Mathieu-Daudé
On 4/11/19 9:58 PM, Rebecca Cran wrote: > On 2019-04-11 13:55, Philippe Mathieu-Daudé wrote: >> >> With the work around link added: >> Reviewed-by: Philippe Mathieu-Daude > > > > But it's _not_ working around that bug. That was about "uname -p", but > the patch is about "uname -m". Ah you are

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2019-04-11 Thread Philippe Mathieu-Daudé
On 4/11/19 9:53 PM, Rebecca Cran wrote: > On 2019-04-11 13:30, Rebecca Cran via Groups.Io wrote: >> >> I'm sending emails on Thunderbird via Postfix, so there's no Outlook >> involved. >> > > Let's try again: I've unset the groups.io fields, so I wonder if that'll > change things. Yes, I see

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread rebecca via Groups.Io
On 2019-04-11 13:55, Philippe Mathieu-Daudé wrote: With the work around link added: Reviewed-by: Philippe Mathieu-Daude But it's _not_ working around that bug. That was about "uname -p", but the patch is about "uname -m". -- Rebecca Cran -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread Philippe Mathieu-Daudé
On 4/11/19 7:52 PM, Laszlo Ersek wrote: > On 04/11/19 16:23, Philippe Mathieu-Daudé wrote: >> On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: >>> Some systems such as FreeBSD identify the platform as 'arm64' >>> and not 'aarch64' as Linux does. >> >> Per

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread Rebecca Cran via Groups.Io
On 2019-04-11 11:52, Laszlo Ersek wrote: On 04/11/19 16:23, Philippe Mathieu-Daudé wrote: On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: Some systems such as FreeBSD identify the platform as 'arm64' and not 'aarch64' as Linux does. Per

[edk2-devel] [PATCH v5 4/7] MdeModulePkg/UefiBootManagerLib: allow foreign Driver#### images

2019-04-11 Thread Ard Biesheuvel
Allow PE/COFF images that must execute under emulation for Driver options, by removing the redundant machine type check from the BDS code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Library/UefiBootManagerLib/BmLoadOption.c | 6

[edk2-devel] [PATCH v5 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images

2019-04-11 Thread Ard Biesheuvel
When encountering PE/COFF images that cannot be supported natively, attempt to locate an instance of the PE/COFF image emulator protocol, and if it supports the image, proceed with loading it and register it with the emulator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by:

[edk2-devel] [PATCH v5 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2019-04-11 Thread Ard Biesheuvel
Add the basic plumbing to DXE core, the PCI bus driver and the boot manager to allow PE/COFF images to be dispatched that target an architecture that is not native for the platform, but which is supported by one of potentially several available emulators. One implementation of such an emulator

[edk2-devel] [PATCH v5 6/7] MdePkg/UefiBaseType.h: treat EBC as a non-native machine type

2019-04-11 Thread Ard Biesheuvel
Instead of classifying EBC as a supported machine type and have special handling in DXE core for loading EBC images, make it a foreign type and rely on the EDK2 PE/COFF image emulator protocol to claim the image when the DXE core finds that it cannot be supported natively. Contributed-under:

[edk2-devel] [PATCH v5 7/7] MdeModulePkg/DxeCore: remove explicit EBC handling

2019-04-11 Thread Ard Biesheuvel
Now that the EBC machine type is no longer classified as a natively supported machine type on the architectures that can support it via the EBC interpreter, the EBC specific handling in DXE core is no longer used and can be removed. Contributed-under: TianoCore Contribution Agreement 1.1

[edk2-devel] [PATCH v5 5/7] MdeModulePkg/EbcDxe: implement the PE/COFF emulator protocol

2019-04-11 Thread Ard Biesheuvel
Implement the new EDK2 PE/COFF image emulator protocol so that we can remove the EBC specific handling in the DXE core and other places in the core code. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 3

[edk2-devel] [PATCH v5 1/7] MdeModulePkg: introduce PE/COFF image emulator protocol

2019-04-11 Thread Ard Biesheuvel
Introduce a protocol that can be invoked by the image loading services to execute foreign architecture PE/COFF images via an emulator. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel --- MdeModulePkg/Include/Protocol/PeCoffImageEmulator.h | 107

[edk2-devel] [PATCH v5 3/7] MdeModulePkg/PciBusDxe: dispatch option ROMs for foreign architectures

2019-04-11 Thread Ard Biesheuvel
Delete the explicit machine type check for option ROM images, and instead, rely on the LoadImage() boot service to decide whether an option ROM can be dispatched or not. This permits platforms to ship with emulators to execute option ROMs that are not native to the processor architecture.

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread Laszlo Ersek
On 04/11/19 16:23, Philippe Mathieu-Daudé wrote: > On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: >> Some systems such as FreeBSD identify the platform as 'arm64' >> and not 'aarch64' as Linux does. > > Per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220297 > this seems to be a

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2019-04-11 Thread Laszlo Ersek
On 04/11/19 16:32, Philippe Mathieu-Daudé wrote: > Hi Liming, Rebecca. > > On 4/11/19 3:52 PM, Liming Gao wrote: >> Phil: >> I use Outlook to receive the patch mail, and save as mail file. This file >> shows From: Rebecca Cran via Groups.Io . So, >> I use it as patch author. I also check my

Re: [edk2-devel] [edk2] [PATCH v4 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2019-04-11 Thread Ard Biesheuvel
On Wed, 10 Apr 2019 at 23:23, Kinney, Michael D wrote: > > Ard, > > Thank you for the update on this patch series. > This design is very clean. One logic issue for > protocol notifications, but that should be only > require a small update. > Thanks Mike I'll get that fixed and send out v5

[edk2-devel] The rumours of Leif Lindholm's early retirement have been greatly exaggerated

2019-04-11 Thread Ard Biesheuvel
He is here at UEFI Plugfest, but suffering from a nasty case of food poisoning and hiding in his room. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#38895): https://edk2.groups.io/g/devel/message/38895 Mute This Topic:

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2019-04-11 Thread Philippe Mathieu-Daudé
Hi Liming, Rebecca. On 4/11/19 3:52 PM, Liming Gao wrote: > Phil: > I use Outlook to receive the patch mail, and save as mail file. This file > shows From: Rebecca Cran via Groups.Io . So, > I use it as patch author. I also check my patch with the same way. It shows > From: Liming Gao . This

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread Philippe Mathieu-Daudé
On 4/11/19 5:16 AM, Rebecca Cran via Groups.Io wrote: > Some systems such as FreeBSD identify the platform as 'arm64' > and not 'aarch64' as Linux does. Per https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220297 this seems to be a FreeBSD bug. > Signed-off-by: Rebecca Cran > --- >

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2019-04-11 Thread Liming Gao
Phil: I use Outlook to receive the patch mail, and save as mail file. This file shows From: Rebecca Cran via Groups.Io . So, I use it as patch author. I also check my patch with the same way. It shows From: Liming Gao . This is correct. So, I don't know this is user setting issue or group.io

Re: [edk2-devel] [PATCH] BaseTools: support arm64 as a platform name in addition to aarch64

2019-04-11 Thread Liming Gao
Reviewed-by: Liming Gao > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Rebecca > Cran via Groups.Io > Sent: Thursday, April 11, 2019 11:17 AM > To: devel@edk2.groups.io; Gao, Liming ; Zhu, Yonghong > > Cc: Rebecca Cran > Subject:

Re: [edk2-devel] [PATCH v2 1/3] OvmfPkg/XenSupport: remove usage of prefetchable PCI host bridge aperture

2019-04-11 Thread Anthony PERARD
On Tue, Apr 09, 2019 at 04:12:38AM +0100, Igor Druzhinin wrote: > This aperture doesn't exist in QEMU-XEN and hvmloader places BARs > in arbitrary order disregarding prefetchable bit. This makes > prefetchable and non-prefetchable BARs to follow each other that's > quite likely with PCI

Re: [edk2-devel] [PATCH] IntelFrameworkModulePkg: Fix comments and improve E820 debug output

2019-04-11 Thread Philippe Mathieu-Daudé
Hi Liming, On 4/11/19 2:32 AM, Liming Gao wrote: > Push on commit ddb8cedce7e07b87c0ac6b84cd750a6d3dac47c8 I see in the git history the authorship passed from: rebe...@bluestop.org to: Rebecca Cran via Groups.Io I wonder if we shouldn't block pushes until the BaseTools/Scripts/PatchCheck.py

Re: [edk2-devel] [RFC] Propose to remove IpSecDxe

2019-04-11 Thread Siyuan, Fu
Bugzilla created for this https://bugzilla.tianocore.org/show_bug.cgi?id=1697 BestRegards Fu Siyuan From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Siyuan, Fu Sent: Thursday, April 11, 2019 6:39 PM To: devel@edk2.groups.io Cc: Wu, Jiaxin ; Gao, Liming Subject: [edk2-devel]

Re: [edk2-devel] [RFC] Propose to remove IpSecDxe

2019-04-11 Thread Siyuan, Fu
Bugzilla created for this https://github.com/tianocore/edk2/releases/tag/edk2-stable201903 BestRegards Fu Siyuan From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Siyuan, Fu Sent: Thursday, April 11, 2019 6:39 PM To: devel@edk2.groups.io Cc: Wu, Jiaxin ; Gao, Liming

[edk2-devel] [RFC] Propose to remove IpSecDxe

2019-04-11 Thread Siyuan, Fu
All, You might notice that some activities about reducing edk2 repo happened or are happening. I propose to remove the IpSecDxe driver from NetworkPkg. Anyone who wants to use IpSecDxe can fetch it from stable tag https://github.com/tianocore/edk2/releases/tag/edk2-stable201903 If you have

Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Philippe Mathieu-Daudé
Hi Zhichao, This is not a technical comment related to your patch. I understand the migration from lists.01.org to edk2.groups.io was in part motivated to help developpers having a restricted email setup to easily use a mailing list. I see you top posting your replies so I wonder if groups.io is

Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Gao, Zhichao
Thanks for you advices. I would better to keep the 'UINTN' with '%x' because PEIM is compiled as 32 bit object. And lots of PEIMs keep this combine. Thanks, Zhichao > -Original Message- > From: Wu, Hao A > Sent: Thursday, April 11, 2019 4:12 PM > To: Gao, Zhichao ; Philippe

Re: [edk2-devel] [PATCH 1/5] MdeModulePkg: Change the SMM debug lib instance

2019-04-11 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, April 10, 2019 3:03 PM > To: devel@edk2.groups.io > Cc: Wang, Jian J; Ni, Ray; Zeng, Star; Gao, Liming; Sean Brogan; Michael > Turner; Bret Barkelew > Subject:

Re: [edk2-devel] [PATCH 0/5] Make some DebugLib instance runtime safe

2019-04-11 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, April 10, 2019 3:03 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen; Zhang, Chao B; Wang, Jian J; Ni, Ray; Zeng, Star; Gao, > Liming; > Sean Brogan; Michael

Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Wu, Hao A
> -Original Message- > From: Gao, Zhichao > Sent: Thursday, April 11, 2019 3:47 PM > To: Philippe Mathieu-Daudé; devel@edk2.groups.io > Cc: Bret Barkelew; Michael Turner; Gao, Liming; Zeng, Star; Wu, Hao A; Wang, > Jian J > Subject: RE: [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the

Re: [edk2-devel] [PATCH 1/5] OvmfPkg/build.sh: Require QEMU 1.6 or newer and always enable flash

2019-04-11 Thread Laszlo Ersek
On 04/10/19 22:18, Jordan Justen wrote: > On 2019-04-10 07:16:34, Laszlo Ersek wrote: >> Hi Jordan, >> >> I've asked Phil (CC'd) to review this series in my stead. I'll be happy >> to provide an ACK when Phil gives his R-b (if I should forget, please >> ping me separately). >> >> In the future,

Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Gao, Zhichao
Sorry for missing this email. While I change the code, it couldn't pass the Patchcher.py because of the 'EFI_D_" version MACRO. So I change all the debug message in this driver. Maybe that is a redundant work. Thanks, Zhichao > -Original Message- > From: Philippe Mathieu-Daudé

Re: [edk2-devel] [edk2] [PATCH] MdeModulePkg/CapsulePei: Update the debug code to print 64bit data

2019-04-11 Thread Gao, Zhichao
Resend to gourps.io. And add the missing people. Thanks, Zhichao > -Original Message- > From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of > Zhichao Gao > Sent: Tuesday, April 2, 2019 1:50 PM > To: edk2-de...@lists.01.org > Cc: Bret Barkelew ; Michael Turner > ; Gao,

Re: [edk2-devel] [Patch] BaseTools/PatchCheck: Generate error if Contributed under found

2019-04-11 Thread Michael D Kinney
Liming, Yes. I have that patch queued and will be sent out tomorrow. There are other Wiki changes for the preferred license. Mike > -Original Message- > From: Gao, Liming > Sent: Wednesday, April 10, 2019 6:37 PM > To: devel@edk2.groups.io; Kinney, Michael D > > Subject: RE:

Re: [edk2-devel] [edk2] [PATCH v4 0/7] MdeModulePkg: add support for dispatching foreign arch PE/COFF images

2019-04-11 Thread Michael D Kinney
Ard, Thank you for the update on this patch series. This design is very clean. One logic issue for protocol notifications, but that should be only require a small update. Mike > -Original Message- > From: edk2-devel [mailto:edk2-devel- > boun...@lists.01.org] On Behalf Of Ard

Re: [edk2-devel] [patch] CorebootPayloadPkg: Remove the dependency of ShellBinPkg

2019-04-11 Thread Benjamin You
Reviewed-by: Benjamin You Thanks, - ben > -Original Message- > From: Bi, Dandan > Sent: Wednesday, April 10, 2019 1:34 PM > To: devel@edk2.groups.io > Cc: Ma, Maurice ; Agyeman, Prince > ; You, Benjamin > Subject: [patch] CorebootPayloadPkg: Remove the dependency of ShellBinPkg > >

Re: [edk2-devel] [PATCH v4 2/7] MdeModulePkg/DxeCore: invoke the emulator protocol for foreign images

2019-04-11 Thread Michael D Kinney
Ard, Resend to devel@edk2.groups.io One comment below on a logic issue that would be exposed if multiple emulators are present. Mike > -Original Message- > From: Ard Biesheuvel [mailto:ard.biesheu...@linaro.org] > Sent: Sunday, March 31, 2019 8:27 PM > To: edk2-de...@lists.01.org >

[edk2-devel] [Patch V2] BaseTools: Add a build option to treat DynPcd as DynExPcd

2019-04-11 Thread BobCF
From: BobCF BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1688 In order to support binary build, build tool add a flag to convert type of Dynamic Pcd to DynamicEx Pcd User can append -D PCD_DYNAMIC_AS_DYNAMICEX to build command to enable this function. Also, user can add