Re: [edk2-devel] [PATCH V4 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-15 Thread Wang, Jian J
The comments are for VariableRuntimeCache.c only. Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wang, Jian > J > Sent: Wednesday, October 16, 2019 2:46 PM > To: Kubacki, Michael A ; devel@edk2.groups.io > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ; Las

Re: [edk2-devel] [edk2-test] [PATCH V4] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

2019-10-15 Thread Eric Jin
Adjust the prefix to [edk2-devel] [edk2-test] [PATCH V4] in subject Reviewed-by: Eric Jin > -Original Message- > From: Chen, ArvinX > Sent: Wednesday, October 16, 2019 2:33 PM > To: devel@edk2.groups.io > Cc: Jin, Eric > Subject: [PATCH] uefi-sct/SctPkg: Auto gen result of "EFIComplian

Re: [edk2-devel] [PATCH V4 07/10] MdeModulePkg/Variable: Add RT GetVariable() cache support

2019-10-15 Thread Wang, Jian J
Hi Michael, Please see my inline comments. > -Original Message- > From: Kubacki, Michael A > Sent: Tuesday, October 15, 2019 7:30 AM > To: devel@edk2.groups.io > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ; Laszlo Ersek > ; Gao, Liming ; Kinney, Michael D > ; Ni, Ray ; Wang, Jian J >

[edk2-devel] [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

2019-10-15 Thread Chen, ArvinX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155 Now the test item "EFICompliantTest" will be gen in the XXX.csv. However, I find most of the SCT user will not know what platform config they test is, so I think we can independently generate a file of the "EFICompliantTest" tests, then t

Re: [edk2-devel] [edk2-test] [PATCH V3] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

2019-10-15 Thread Eric Jin
Adjust the prefix to [edk2-devel] [edk2-test] [PATCH V3] in subject Hi Arvin, Still have one comment in the GenTestConfigTitle() > -Original Message- > From: Chen, ArvinX > Sent: Tuesday, October 15, 2019 4:53 PM > To: devel@edk2.groups.io > Cc: Jin, Eric > Subject: [PATCH] uefi-sct/Sct

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API

2019-10-15 Thread Ni, Ray
> My concerns with that approach: > > 1. In general, I believe it is better if the library reads the value once and > caches it. The firmware boot media is fixed after power-on by nature and in > some platforms, boot media information may be provided to the IBB in a > temporary SRAM (or other vola

[edk2-devel] [PATCH] BaseTools: Fix an incremental build issue caused by macro in #include

2019-10-15 Thread Lin, Derek (HPS SW)
When c/h file use macro after #include, for example, In this case, GenMake is not able to create a healthy dependency for the c file. GenMake used to add $(FORCE_REBUILD) dependency in the c file, this guarantee the c file is always compiled in incremental build. But, this function is broken since

Re: [edk2-devel] [edk2-platforms: PATCH v5 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD

2019-10-15 Thread Marcin Wojtas
Hi Leif, wt., 15 paź 2019 o 20:07 Leif Lindholm napisał(a): > > On Mon, Oct 14, 2019 at 03:25:04PM +0200, Marcin Wojtas wrote: > > From: Patryk Duda > > > > This patch implements convenient way of changing strings included > > in SMBIOS Table1, Table2, Table3. > > > > Strings can be altered by d

Re: [edk2-devel] Use a pcd to control PlatformRecovery

2019-10-15 Thread Gao, Zhichao
> -Original Message- > From: Gao, Zhichao > Sent: Wednesday, October 16, 2019 10:09 AM > To: 'Wang, Sunny (HPS SW)' ; devel@edk2.groups.io; > Ni, Ray > Cc: Wang, Jian J ; Wu, Hao A ; > Zeng, Star ; Gao, Liming ; > Sean Brogan ; Michael Turner > ; Bret Barkelew > ; Li, Walon ; Wei, Kent >

Re: [edk2-devel] [RFC v1 5/4] CryptoPkg/TlsLib: accept peer certs via both DNS names and IP addresses

2019-10-15 Thread Wu, Jiaxin
These days I'm too busy with other things. Just take the time to review the email discussion & researched the correct behavior of HTTPS cert verification. I did never though my patch caused the function regression, and I'm also not loop in the long ago email discussion reported from AMI. Now,

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 24/29] BaseTools: BaseTools changes for RISC-V platform.

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 15, 2019 6:57 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 24/29]

Re: [edk2-devel] [PATCH v4 2/2] MdeModulePkg/XhciPei: Fix Aligned Page Allocation

2019-10-15 Thread Wu, Hao A
> -Original Message- > From: Ashish Singhal [mailto:ashishsin...@nvidia.com] > Sent: Wednesday, October 16, 2019 1:21 AM > To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; jbra...@nvidia.com > Cc: Ashish Singhal > Subject: [PATCH v4 2/2] MdeModulePkg/XhciPei: Fix Aligned Page > Allocation > >

Re: [edk2-devel] [PATCH v4 1/2] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-15 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Ashish Singhal > Sent: Wednesday, October 16, 2019 1:21 AM > To: devel@edk2.groups.io; Wu, Hao A; Ni, Ray; jbra...@nvidia.com > Cc: Ashish Singhal > Subject: [edk2-devel] [PATCH v4 1/2] MdeModuleP

Re: [edk2-devel] Use a pcd to control PlatformRecovery

2019-10-15 Thread Gao, Zhichao
First of all, the patch didn't aim to change the other part of the boot flow except PlatformRecovery. Local variable PlatformRecovery is controlled by OsIndications variable. When the EFI_OS_INDICATIONS_START_PLATFORM_RECOVERY is set, the firmware should try to platform specific recovery. But t

Re: [edk2-devel] [Patch v2 07/11] MdeModulePkg RegularExpressionDxe: Disable warning for CLANG9 tool chain

2019-10-15 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, October 15, 2019 8:27 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v2 07/11] MdeModulePkg > RegularExpressionDxe: Disable warning for CLANG9 tool chain

Re: [edk2-devel] [Patch v2 06/11] MdeModulePkg LzmaCustomDecompressLib: Update macro to be same in CLANG tool

2019-10-15 Thread Wu, Hao A
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Liming Gao > Sent: Tuesday, October 15, 2019 8:27 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v2 06/11] MdeModulePkg > LzmaCustomDecompressLib: Update macro to be same in CLANG to

[edk2-devel] [PATCH 0/3] MdeModulePkg: Initialize variables

2019-10-15 Thread Zhang, Shenglei
Initialize the variables before used. Cc: Hao A Wu Cc: Ray Ni Cc: Dandan Bi Cc: Liming Gao Shenglei Zhang (3): MdeModulePkg/EhciPei: Initialize the variable Map MdeModulePkg/UhciPei: Initialize the variable RequestMap MdeModulePkg/Mem: Initialize the variable MapMemory MdeModulePkg/Bus

[edk2-devel] [PATCH 2/3] MdeModulePkg/UhciPei: Initialize the variable RequestMap

2019-10-15 Thread Zhang, Shenglei
RequestMap is used but not Initialized. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Shenglei Zhang --- MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c b/MdeModulePkg/Bus/Pci/UhciPei/UhcPeim.c index b897c3f82ce6..a0

[edk2-devel] [PATCH 3/3] MdeModulePkg/Mem: Initialize the variable MapMemory

2019-10-15 Thread Zhang, Shenglei
Initialize MapMemory to 0 in HeapGuard.c. Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdeModulePkg/Core/Dxe/Mem/HeapGuard.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c b/MdeModulePkg/Core/Dxe/Mem/HeapGuard.c index 9477b94044ba

[edk2-devel] [PATCH 1/3] MdeModulePkg/EhciPei: Initialize the variable Map

2019-10-15 Thread Zhang, Shenglei
Map is used but not Initialized. Cc: Hao A Wu Cc: Ray Ni Signed-off-by: Shenglei Zhang --- MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c b/MdeModulePkg/Bus/Pci/EhciPei/EhciUrb.c index 7c6a6a5f9716..995ccd246

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 02/14] Silicon/SiFive: Add library module of SiFive RISC-V cores

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Wednesday, October 2, 2019 5:15 AM > To: devel@edk2.groups.io; Chen, Gilbert > Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 02/14] > Silicon/SiFive: Add lib

Re: [edk2-devel] [Patch v2 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

2019-10-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Tuesday, October 15, 2019 8:27 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v2 08/11] CryptoPkg: Append options to make > CLANG9 tool chain pass build > > Disable

Re: [edk2-devel] [Patch v2 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-10-15 Thread Wang, Jian J
Reviewed-by: Jian J Wang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Liming Gao > Sent: Tuesday, October 15, 2019 8:27 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [Patch v2 09/11] CryptoPkg IntrinsicLib: Make _fltused > always be used > > With this change,

Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

2019-10-15 Thread Liming Gao
Good catch. I will correct it when I push this patch set. >-Original Message- >From: Laszlo Ersek [mailto:ler...@redhat.com] >Sent: Tuesday, October 15, 2019 3:37 PM >To: devel@edk2.groups.io; Gao, Liming >Cc: Yao, Jiewen ; Shi, Steven >; Justen, Jordan L ; >Andrew Fish ; Ni, Ray ; Ard B

Re: [edk2-devel] [PATCH v7 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

2019-10-15 Thread Gao, Zhichao
> -Original Message- > From: Abner Chang [mailto:abner.ch...@hpe.com] > Sent: Tuesday, October 15, 2019 3:46 PM > To: devel@edk2.groups.io > Cc: abner.ch...@hpe.com; Carsey, Jaben ; Ni, > Ray ; Gao, Zhichao ; Leif > Lindholm ; Gilbert Chen > Subject: [PATCH v7 3/3] ShellPkg/UefiShellDeb

[edk2-devel] [RFC v1 5/4] CryptoPkg/TlsLib: accept peer certs via both DNS names and IP addresses

2019-10-15 Thread Laszlo Ersek
SSL_set1_host() in TlsSetVerifyHost() ignores GEN_IP entries in the peer certificate's Subject Alternative Name (SAN) extension. This leads to the rejection of any valid peer certificate that matches the dot-decimal IPv4, or colon-hexadecimal IPv6, host part of an URL *only* through SAN/GEN_IP, and

[edk2-devel] [edk2-platforms] [PATCH v2 3/4] WhiskeylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-15 Thread Agyeman, Prince
Added BIOS Info PEIM to publish Bios Info HOB. This PEIM currently publishes the microcode FV information. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../BiosInfo/BiosInfo.c | 93 +++ .../BiosInfo/BiosInfo.i

[edk2-devel] [edk2-platforms] [PATCH v2 1/4] BoardModulePkg: Add BIOS Info HOB

2019-10-15 Thread Agyeman, Prince
Added gBiosInfoGuid to be used in publishing the BIOS information HOB which is needed in FIT generation Also added the BIOS Info header file BiosInfo.h that defines the BIOS info struct and GUID Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../In

[edk2-devel] [edk2-platforms] [PATCH v2 0/4] Add FIT support using FitGen

2019-10-15 Thread Agyeman, Prince
Changes in v2: - Moved BIOS Info PEIM to KabylakeOpenBoardPkg shared by both KabylakeRvp3, GalagoPro3 - Moved BIOS Info PEIM to WhiskeylakeOpenBoardPkg used by WhiskeylakeURvp - Moved BiosInfo.h to BoardModulePkg/Include/Guid - Fixed typos, cleaned up commit messages and comments Prince Agyema

[edk2-devel] [edk2-platforms] [PATCH v2 2/4] KabylakeOpenBoardPkg: Add BIOS Info PEIM

2019-10-15 Thread Agyeman, Prince
Added BIOS Info PEIM to KabylakeRvp3 and GalagoPro3 to publish the BIOS info HOB. This PEIM currently publishes the board's microcode region information. Cc: Ankit Sinha Cc: Nate DeSimone Cc: Kubacki Michael A Signed-off-by: Prince Agyeman --- .../KabylakeOpenBoardPkg/BiosInfo/BiosInfo.c |

[edk2-devel] [edk2-platforms] [PATCH v2 4/4] Platform/Intel: Add FIT generation tool

2019-10-15 Thread Agyeman, Prince
Added FitGen tool build and FIT generation to the BIOS build process. What was done: - Build the FIT generation tool - Added default/empty BIOS_INFO_GUID to the build.cfg - Added BIOS_INFO_GUID to GalagoPro3,KabylakeRvp3 and WhiskeylakeURvp's build_config.cfg This allows a board to specify the GU

Re: [edk2-devel] [edk2-platforms][PATCH v3 0/5] Various SMBIOS improvements

2019-10-15 Thread Leif Lindholm
On Fri, Oct 11, 2019 at 12:07:41PM +0100, Pete Batard wrote: > Changes from v2: > - Consistent use of curly brackets for if statements > - Remove unused variables that may produce an issue with git bisect > - Use gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVendor to populate vendor > > Note that 5/5

Re: [edk2-devel] [edk2-platforms: PATCH v5 8/9] Marvell/Drivers: SmbiosPlatformDxe: Load SMBIOS strings from PCD

2019-10-15 Thread Leif Lindholm
On Mon, Oct 14, 2019 at 03:25:04PM +0200, Marcin Wojtas wrote: > From: Patryk Duda > > This patch implements convenient way of changing strings included > in SMBIOS Table1, Table2, Table3. > > Strings can be altered by defining following PCDs: > gMarvellTokenSpaceGuid.PcdProductManufacturer >

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread Laszlo Ersek
On 10/15/19 18:56, Laszlo Ersek wrote: > On 10/15/19 15:54, Laszlo Ersek wrote: >> On 10/15/19 13:03, David Woodhouse wrote: > >>> The "app callback" in my OpenConnect example is set on the SSL_CTX not >>> the SSL object, and is called from the top-level >>> ssl_verify_cert_chain() function *inste

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread Laszlo Ersek
On 10/15/19 17:57, David Woodhouse wrote: > On Thu, 2019-10-10 at 20:03 +0200, Laszlo Ersek wrote: >> (I can't test it easily myself, as I don't even know how to create a >> server certificate with a SAN -- any kind of SAN, let alone GEN_IP.) > > I had to look it up again, but here goes... > > $

[edk2-devel] [PATCH v4 0/2] Fix Aligned Page Allocation For XHCI

2019-10-15 Thread Ashish Singhal
This patch set is an attempt to fix the error where we allocate incorrectly aligned memory for XHCI PEI and DXE. The change for DXE phase has been verified already but change for PEI needs to be verified by Hao as I do not have a setup to be able to verify that. The change in DXE just updates a pa

[edk2-devel] [PATCH v4 2/2] MdeModulePkg/XhciPei: Fix Aligned Page Allocation

2019-10-15 Thread Ashish Singhal
Add support for allocating aligned pages at an alignment higher than 4K. The new function allocated memory taking into account the padding required and then frees up unused pages before mapping it. Change-Id: I32d36bfbff0eee93d14a9a1a86e5ce7635251b64 Signed-off-by: Ashish Singhal --- MdeModulePk

[edk2-devel] [PATCH v4 1/2] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-15 Thread Ashish Singhal
While allocating pages aligned at an alignment higher than 4K, allocate memory taking into consideration the padding required for that alignment. The calls to free pages takes care of this already. Signed-off-by: Ashish Singhal --- MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c | 2 +- 1 file changed,

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API

2019-10-15 Thread Chaganty, Rangasai V
Thanks for reducing the redundant APIs. Reviewed-by: Sai Chaganty -Original Message- From: Kubacki, Michael A Sent: Monday, October 14, 2019 2:26 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray Subject: [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduc

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Fix Aligned Page Allocation

2019-10-15 Thread Ashish Singhal
Hello Hao, Thanks for the clarification. I have made the changes and submitted a new patch. Also, in case the IOMMU PPI does not exist, we are now allocating the memory and adjust return pointers to be aligned. There is no freeing of unaligned pages here as PEI framework does not provide a mech

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread Laszlo Ersek
On 10/15/19 15:54, Laszlo Ersek wrote: > On 10/15/19 13:03, David Woodhouse wrote: >> The "app callback" in my OpenConnect example is set on the SSL_CTX not >> the SSL object, and is called from the top-level >> ssl_verify_cert_chain() function *instead* of X509_verify_cert(). >> >> It is X509_ver

Re: [edk2-devel] [edk2-platforms][PATCH V1 1/1] IntelSiliconPkg/BootMediaLib: Reduce library API

2019-10-15 Thread Kubacki, Michael A
My concerns with that approach: 1. In general, I believe it is better if the library reads the value once and caches it. The firmware boot media is fixed after power-on by nature and in some platforms, boot media information may be provided to the IBB in a temporary SRAM (or other volatile memo

Re: [edk2-devel] [PATCH V4 00/10] UEFI Variable SMI Reduction

2019-10-15 Thread Kubacki, Michael A
That sounds good to me. Thanks, Michael > -Original Message- > From: Gao, Liming > Sent: Monday, October 14, 2019 5:50 PM > To: Kubacki, Michael A ; > devel@edk2.groups.io > Cc: Bi, Dandan ; Ard Biesheuvel > ; Dong, Eric ; Laszlo Ersek > ; Kinney, Michael D ; Ni, > Ray ; Wang, Jian J ; W

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread David Woodhouse
On Thu, 2019-10-10 at 20:03 +0200, Laszlo Ersek wrote: > (I can't test it easily myself, as I don't even know how to create a > server certificate with a SAN -- any kind of SAN, let alone GEN_IP.) I had to look it up again, but here goes... $ cat v3.ext subjectAltName = @alt_names [alt_names] DN

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread David Woodhouse
On Tue, 2019-10-15 at 15:54 +0200, Laszlo Ersek wrote: > On 10/15/19 13:03, David Woodhouse wrote: > > On Mon, 2019-10-14 at 18:15 +0200, Laszlo Ersek wrote: > > > My understanding is that a fix purely in edk2 -- that is, without > > > advancing our openssl submodule reference at once -- is possibl

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 06/14] RiscV/Universal: Initial version of common RISC-V SEC module

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 3, 2019 3:43 AM > To: devel@edk2.groups.io; Chen, Gilbert > Cc: Palmer Dabbelt > Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 06/14] > Ri

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 05/14] RiscV/Library: Initial version of libraries introduced in RISC-V platform package

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Thursday, October 3, 2019 1:05 AM > To: devel@edk2.groups.io; Chen, Gilbert > Cc: Palmer Dabbelt > Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 05/14] > Ri

[edk2-devel] [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

2019-10-15 Thread Chen, ArvinX
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2155 Now the test item "EFICompliantTest" will be gen in the XXX.csv. However, I find most of the SCT user will not know what platform config they test is, so I think we can independently generate a file of the "EFICompliantTest" tests, then t

Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 03/14] platforms/RiscV: Initial version of RISC-V platform package

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Wednesday, October 2, 2019 5:08 PM > To: devel@edk2.groups.io; Chen, Gilbert > Subject: Re: [edk2-devel] [plaforms/devel-riscv-v2 PATCHv2 03/14] > platforms/RiscV: Initia

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread Laszlo Ersek
On 10/15/19 13:03, David Woodhouse wrote: > On Mon, 2019-10-14 at 18:15 +0200, Laszlo Ersek wrote: >> My understanding is that a fix purely in edk2 -- that is, without >> advancing our openssl submodule reference at once -- is possible, based >> on your comment >> >> https://bugzilla.tianocore.or

Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build

2019-10-15 Thread Laszlo Ersek
On 10/15/19 13:07, Ard Biesheuvel wrote: > DynamicTablesPkg can be built for ARM as well as for AARCH64, but on > the former, doing so will result in a build failure due to the lack > of 64-bit division helpers provided by the ArmPkg intrinsics library. > So add the missing reference, for both ARM

Re: [edk2-devel] [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build

2019-10-15 Thread Sami Mujawar
Reviewed-by: Sami Mujawar Regards, Sami Mujawar -Original Message- From: Ard Biesheuvel Sent: 15 October 2019 12:08 PM To: devel@edk2.groups.io Cc: ler...@redhat.com; Sami Mujawar ; leif.lindh...@linaro.org; Ard Biesheuvel Subject: [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics

Re: [edk2-devel] [PATCH V2 3/8] MdePkg/UefiDebugLibStdErr: Decrease the name collisions

2019-10-15 Thread Leif Lindholm
(Ancient thread, responding due to finding this when looking at recent BZ activity.) On Wed, Apr 24, 2019 at 05:31:36PM +, Michael D Kinney wrote: > I see no issues with using 'static' on more symbols. > > I am not sure how to enforce it, so it would be a good > recommendation for code style

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 24/29] BaseTools: BaseTools changes for RISC-V platform.

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 15, 2019 6:57 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 24/29]

[edk2-devel] [PATCH 1/1] DynamicTablesPkg: include ARM intrinsics library to fix 32-bit build

2019-10-15 Thread Ard Biesheuvel
DynamicTablesPkg can be built for ARM as well as for AARCH64, but on the former, doing so will result in a build failure due to the lack of 64-bit division helpers provided by the ArmPkg intrinsics library. So add the missing reference, for both ARM and AARCH64 (which may start relying on intrinsic

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread David Woodhouse
On Tue, 2019-10-15 at 12:03 +0100, David Woodhouse wrote: > > Something like this... and instead of calling SSL_set1_host(ssl, host) > your own code now has to call > SSL_set_ex_data(ssl, ssl_target_idx, strdup(host)); Here's how I tested that in the OpenSSL tree in userspace, FWIW... diff --git

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 25/29] BaseTools/Scripts

2019-10-15 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, October 15, 2019 7:00 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 25/29] > BaseTools/Scripts > > On T

Re: [edk2-devel] [PATCH v1 0/4] Support HTTPS HostName validation feature(CVE-2019-14553)

2019-10-15 Thread David Woodhouse
On Mon, 2019-10-14 at 18:15 +0200, Laszlo Ersek wrote: > My understanding is that a fix purely in edk2 -- that is, without > advancing our openssl submodule reference at once -- is possible, based > on your comment > > https://bugzilla.tianocore.org/show_bug.cgi?id=960#c32 > > Namely, edk2 comm

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 25/29] BaseTools/Scripts

2019-10-15 Thread Leif Lindholm
On Tue, Oct 15, 2019 at 06:31:06AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Friday, September 27, 2019 4:51 AM > > To: devel@edk2.groups.io; Chang, Abner

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

2019-10-15 Thread Abner Chang
> -Original Message- > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > Sent: Tuesday, October 15, 2019 6:42 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] > MdePkg/BasePeCoff: Add RISC

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

2019-10-15 Thread Abner Chang
> -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Leif Lindholm > Sent: Tuesday, October 15, 2019 6:32 PM > To: Chang, Abner (HPS SW/FW Technologist) > Cc: devel@edk2.groups.io > Subject: Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/2

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 24/29] BaseTools: BaseTools changes for RISC-V platform.

2019-10-15 Thread Leif Lindholm
On Tue, Oct 15, 2019 at 06:18:29AM +, Abner Chang wrote: > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Friday, September 27, 2019 6:10 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) >

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

2019-10-15 Thread Leif Lindholm
On Tue, Oct 15, 2019 at 04:26:12AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Abner Chang > > Sent: Tuesday, October 15, 2019 12:03 PM > > To: devel@edk2.groups.io; leif.lind

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 10/29] MdePkg/BasePeCoff: Add RISC-V PE/Coff related code.

2019-10-15 Thread Leif Lindholm
On Tue, Oct 15, 2019 at 04:02:47AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > > Leif Lindholm > > Sent: Friday, September 27, 2019 7:46 AM > > To: devel@edk2.groups.io; Chang, Abner

Re: [edk2-devel] [Patch v2 04/11] MdePkg Base.h: Add definition for CLANG9 tool chain

2019-10-15 Thread Philippe Mathieu-Daudé
On 10/15/19 2:26 AM, Liming Gao wrote: CLANG9 tool chain defines __clang__ macro only, doesn't define __GNUC__ macro. But, it uses some same definitions with GCC. So, update base definition for CLANG9 tool chain. Signed-off-by: Liming Gao --- MdePkg/Include/Base.h | 6 +++--- M

Re: [edk2-devel] [Patch v2 09/11] CryptoPkg IntrinsicLib: Make _fltused always be used

2019-10-15 Thread Philippe Mathieu-Daudé
On 10/15/19 2:26 AM, Liming Gao wrote: With this change, global variable _fltused will not be removed by LTO Signed-off-by: Liming Gao --- CryptoPkg/Library/IntrinsicLib/MemoryIntrinsics.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/CryptoPkg/Library/Intrin

Re: [edk2-devel] [Patch v2 08/11] CryptoPkg: Append options to make CLANG9 tool chain pass build

2019-10-15 Thread Philippe Mathieu-Daudé
Hi Liming, On 10/15/19 2:26 AM, Liming Gao wrote: Disable warning reported from CLANG9. Signed-off-by: Liming Gao --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf| 1 + CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 1 + CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf | 1 +

Re: [edk2-devel] [Patch v2 05/11] MdePkg BaseIoLibIntrinsic: Remove __inline__ attribute for IO functions

2019-10-15 Thread Philippe Mathieu-Daudé
On 10/15/19 2:26 AM, Liming Gao wrote: __inline__ has no functional difference effect with the GCC48 / GCC49 / GCC5 toolchains, but it breaks the build with CLANG9. Remove __inline__. I never understod how the compiler can optimize inlining such functions, and always considered this behavior b

Re: [edk2-devel] [Patch v2 03/11] BaseTools GenFw: Fix the issue to update the wrong size as SectionSize

2019-10-15 Thread Philippe Mathieu-Daudé
On 10/15/19 2:26 AM, Liming Gao wrote: Signed-off-by: Liming Gao --- BaseTools/Source/C/GenFw/GenFw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/BaseTools/Source/C/GenFw/GenFw.c b/BaseTools/Source/C/GenFw/GenFw.c index c99782b78e..d8d3360c24 100644 --- a/BaseT

[edk2-devel] Use a pcd to control PlatformRecovery

2019-10-15 Thread Wang, Sunny (HPS SW)
Hi Zhichao and Ray, I have some questions about this code change. Sorry for being late to bring my questions here. For now, the code block for iterating the PlatformRecovery variables is controlled by OsIndications variable. However, it looks to me like that the PlatformRecovery shoul

Re: [edk2-devel] [edk2-staging/RISC-V-V2 PATCH v2 18/29] RiscVPkg/Library: Add EDK2 RISC-V OpenSBI library.

2019-10-15 Thread Leif Lindholm
On Tue, Oct 15, 2019 at 01:21:35AM +, Chang, Abner (HPS SW/FW Technologist) wrote: > > > > -Original Message- > > From: Leif Lindholm [mailto:leif.lindh...@linaro.org] > > Sent: Tuesday, October 1, 2019 4:04 AM > > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > >

Re: [edk2-devel] [PATCH v6 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

2019-10-15 Thread Abner Chang
I got it, v7 just sent. Please check it out. Thanks Abner > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Gao, Zhichao > Sent: Wednesday, October 9, 2019 3:46 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > > Cc: Carse

[edk2-devel] [PATCH v7 3/3] ShellPkg/UefiShellDebug1CommandsLib: Update to support SmBios 3.3.0

2019-10-15 Thread Abner Chang
Shell command smbiosview updates for SMBIOS 3.3.0 spec. Bugzilla link, https://bugzilla.tianocore.org/show_bug.cgi?id=2202 Signed-off-by: Abner Chang Cc: Jaben Carsey Cc: Ray Ni Cc: Zhichao Gao Cc: Leif Lindholm Cc: Gilbert Chen --- .../SmbiosView/PrintInfo.c | 21

Re: [edk2-devel] [edk2-test] [PATCH V2] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest".

2019-10-15 Thread Eric Jin
Adjust the prefix to [edk2-devel] [edk2-test] [PATCH V2] in subject Hi Arvin, > -Original Message- > From: Chen, ArvinX > Sent: Monday, October 14, 2019 5:02 PM > To: devel@edk2.groups.io > Cc: Jin, Eric > Subject: [PATCH] uefi-sct/SctPkg: Auto gen result of "EFICompliantTest". > > REF

Re: [edk2-devel] [Patch v2 00/11] New Cross OS tool chain CLANG9

2019-10-15 Thread Laszlo Ersek
On 10/15/19 02:26, Liming Gao wrote: > In v2, drop patch 12, and update commit message for 5 & 11. Thank you, Liming. In patch 11, there is a small typo in the commit message, "crush" vs. "crash". If you get the chance, please correct that just before pushing. Thanks! Laszlo -=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH V4 10/10] MdeModulePkg: Enable variable runtime cache by default

2019-10-15 Thread Laszlo Ersek
On 10/15/19 01:30, Michael Kubacki wrote: > This change enables the variable runtime cache by default by setting > gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache in > MdeModulePkg.dec to TRUE. > > Cc: Dandan Bi > Cc: Ard Biesheuvel > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Liming

Re: [edk2-devel] [PATCH V4 09/10] OvmfPkg: Disable variable runtime cache

2019-10-15 Thread Laszlo Ersek
On 10/15/19 01:30, Michael Kubacki wrote: > Sets gEfiMdeModulePkgTokenSpaceGuid.PcdEnableVariableRuntimeCache > to FALSE in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc, and OvmfPkgX64.dsc > so that when SMM_REQUIRE is TRUE, the SMM variable driver will not > use the runtime variable cache. > > This is don