Re: [edk2-devel] Flush on main exit?

2019-10-18 Thread Doran, Mark
I think the ISO C standard is actually the governing spec for exit() now. However, it more or less says the same thing as POSIX.1. I actually recall some of the early input to POSIX discussions about exit() and flushing behavior (fflush() got lumped in to the same conversation). It was somewh

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

2019-10-18 Thread Michael D Kinney
Devices with FMP instances below version 3 do not support a HardwareInstance so they can only support single device for each GUID. FMP implementations with versions below 3 that want to support multiple devices need to use multiple GUIDs. The ASSERT() is still be correct if there are multiple

Re: [edk2-devel] Recent changes to EsrtFmp causing ASSERTs

2019-10-18 Thread scott . wiginton
Hi Michael, I'm not sure that I agree with your last statement.  The says that HardwareInstance is "Only present in version 3 or higher" in reference to the  EFI_FIRMWARE_IMAGE_DESCRIPTOR.  Isn't that the point of the DescriptorVersion parameter in FMP.GetImageInfo?  To know if that field is eve

[edk2-devel] Flush on main exit?

2019-10-18 Thread Tim Lewis
I have noticed recently, when porting BSD applications, that if main exits normally, the buffers are not flushed. This is most obvious when using StdLib along with printf or fprintf to stdout. Has anyone else noticed this? If there is a \n in the output, it gets flushed to stdout, but if the st

[edk2-devel] [Patch] MdePkg: Add UefiFileHandleLib to DSC file

2019-10-18 Thread Michael D Kinney
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2261 Add the UefiFileHandleLib to the [Components] section of the MdePkg DSC file to support full build testing of the MdePkg. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael D Kinney --- MdePkg/MdePkg.dsc | 1 + 1

[edk2-devel] [Patch] FmpDevicePkg: Fix spelling errors

2019-10-18 Thread Michael D Kinney
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2262 Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Michael D Kinney --- .../CapsuleUpdatePolicyDxe/CapsuleUpdatePolicyDxe.c | 4 ++-- .../CapsuleUpdatePolicyDxe.inf | 2 +- FmpDevicePkg/FmpDevicePk

[edk2-devel] [Patch] PcAtChipsetPkg: Fix spelling errors

2019-10-18 Thread Michael D Kinney
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2263 Cc: Ray Ni Signed-off-by: Michael D Kinney --- PcAtChipsetPkg/HpetTimerDxe/HpetTimer.c | 12 ++-- PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.inf | 2 +- PcAtChipsetPkg/HpetTimerDxe/HpetTimerDxe.u

[edk2-devel] [Patch] FatPkg: Fix spelling errors

2019-10-18 Thread Michael D Kinney
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2264 Cc: Ray Ni Signed-off-by: Michael D Kinney --- FatPkg/EnhancedFatDxe/DirectoryManage.c | 8 FatPkg/EnhancedFatDxe/DiskCache.c | 2 +- FatPkg/EnhancedFatDxe/Fat.h | 20 ++-- FatPk

[edk2-devel] [Patch] SecurityPkg: Fix spelling errors

2019-10-18 Thread Michael D Kinney
From: Sean Brogan https://bugzilla.tianocore.org/show_bug.cgi?id=2265 Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Michael D Kinney --- SecurityPkg/FvReportPei/FvReportPei.c | 4 ++-- SecurityPkg/Hash2DxeCrypto/Driver.c | 6 ++--- SecurityPkg/Hash2DxeCryp

[edk2-devel] [v8 v8] IntelSiliconPkg-Vtd: A new PMR interface

2019-10-18 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Platforms may request no overlap between PMR regions and system reserve memory. Create an interface to publish PLMR/PHMR regions. It allows silicon code to ad

[edk2-devel] [v9 v9] IntelSiliconPkg-Vtd: A new PMR interface

2019-10-18 Thread Evelyn Wang
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1770 1) IOMMU PMR feature should be generic to support different hardware architecture. Platforms may request no overlap between PMR regions and system reserve memory. Create an interface to publish PLMR/PHMR regions. It allows silicon code to ad

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Leif Lindholm
On Fri, Oct 18, 2019 at 04:05:59PM +0200, Philippe Mathieu-Daudé wrote: > On 10/18/19 3:25 PM, Pete Batard wrote: > > On 2019.10.18 13:52, Leif Lindholm wrote: > > > On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: > > > > TFTP support, which is enabled by default, can be disabled by se

Re: [edk2-devel] [Patch v3 10/11] EmulatorPkg: Enable CLANG9 tool chain

2019-10-18 Thread Liming Gao
Andrew: Here is the cover letter on CLANG9 introduction. https://edk2.groups.io/g/devel/message/49157 1) Yes. CLANG9 tool chain is added to directly generate PE/COFF image (EFI image). This tool chain uses LLVM clang C compiler and lld linker, generates PE/COFF image and PDB compatible de

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Philippe Mathieu-Daudé
On 10/18/19 3:25 PM, Pete Batard wrote: On 2019.10.18 13:52, Leif Lindholm wrote: On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: TFTP support, which is enabled by default, can be disabled by setting INCLUDE_TFTP_COMMAND to FALSE. Would you be OK with flipping the default to FALS

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Pete Batard
On 2019.10.18 13:52, Leif Lindholm wrote: On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: TFTP support, which is enabled by default, can be disabled by setting INCLUDE_TFTP_COMMAND to FALSE. Would you be OK with flipping the default to FALSE? Yes, I have no issue with a default

Re: [edk2-devel] [RFC v1 5/4] CryptoPkg/TlsLib: accept peer certs via both DNS names and IP addresses

2019-10-18 Thread Laszlo Ersek
On 10/17/19 17:49, David Woodhouse wrote: > On Thu, 2019-10-17 at 17:35 +0200, Laszlo Ersek wrote: >> Reference [2] advises to put the IP address in both CN and >> SAN.iPAddress >> for best compatibility, and that would be fine, for >> X509_VERIFY_PARAM_set1_ip(). But the word "only" in [3] is real

Re: [edk2-devel] [Patch v3 00/11] New Cross OS tool chain CLANG9

2019-10-18 Thread Liming Gao
Leif: >-Original Message- >From: Leif Lindholm [mailto:leif.lindh...@linaro.org] >Sent: Friday, October 18, 2019 12:31 AM >To: devel@edk2.groups.io; Gao, Liming >Cc: Yao, Jiewen ; Shi, Steven >; Justen, Jordan L ; Laszlo >Ersek ; Andrew Fish ; Ni, Ray >; Ard Biesheuvel ; Wang, Jian >J ; W

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Leif Lindholm
On Fri, Oct 18, 2019 at 01:41:30PM +0100, Pete Batard wrote: > TFTP support, which is enabled by default, can be disabled by setting > INCLUDE_TFTP_COMMAND to FALSE. Would you be OK with flipping the default to FALSE? It is a custom extension not described by the UEFI Shell Specification. I could

[edk2-devel] [edk2-platforms][PATCH v2 0/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Pete Batard
Previous version had '!ifdef $(INCLUDE_TFTP_COMMAND)' in the .fdf whereas it was supposed to be '!if $(INCLUDE_TFTP_COMMAND) == TRUE'. This v2 fixes that. Pete Batard (1): Platform/RPi3: Add TFTP command to UEFI Shell Platform/RaspberryPi/RPi3/RPi3.dsc | 8 Platform/RaspberryPi/RPi3/

[edk2-devel] [edk2-platforms][PATCH v2 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Pete Batard
TFTP support, which is enabled by default, can be disabled by setting INCLUDE_TFTP_COMMAND to FALSE. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 8 Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ 2 files changed, 11 insertions(+) diff --git a/Platform/RaspberryPi/RP

[edk2-devel] [edk2-platforms][PATCH 1/1] Platform/RPi3: Add TFTP command to UEFI Shell

2019-10-18 Thread Pete Batard
TFTP support, which is enabled by default, can be disabled by setting INCLUDE_TFTP_COMMAND to FALSE. Signed-off-by: Pete Batard --- Platform/RaspberryPi/RPi3/RPi3.dsc | 8 Platform/RaspberryPi/RPi3/RPi3.fdf | 3 +++ 2 files changed, 11 insertions(+) diff --git a/Platform/RaspberryPi/RP

Re: [edk2-devel] [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build

2019-10-18 Thread Leif Lindholm
On Fri, Oct 18, 2019 at 11:20:19AM +, Yao, Jiewen wrote: > Reviewed-by: Jiewen Yao Thanks! Pushed as 0f28c513d392. BZ closed. / Leif > > -Original Message- > > From: Leif Lindholm > > Sent: Friday, October 18, 2019 5:43 PM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen ; Zha

Re: [edk2-devel] [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build

2019-10-18 Thread Yao, Jiewen
Reviewed-by: Jiewen Yao > -Original Message- > From: Leif Lindholm > Sent: Friday, October 18, 2019 5:43 PM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Zhang, Chao B > ; Laszlo Ersek > Subject: [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build > > BZ: https://bugzilla.tianocore.org/sh

[edk2-devel] [PATCH 1/1] SignedCapsulePkg: fix AARCH64 build

2019-10-18 Thread Leif Lindholm
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2252 Add NULL library resolution of CompilerIntrinsicsLib and BaseStackCheckLib for AARCH64 as well as ARM in order to fix "undefined reference to `memcpy'" build errors. Cc: Jiewen Yao Cc: Chao Zhang Cc: Laszlo Ersek Signed-off-by: Leif Lindh