Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h

2019-11-05 Thread Ni, Ray
> + /// > + /// Type of the device. > + /// This field is also served as a device Access protocol GUID. > + /// The device access protocol is installed on the DeviceHandle. > + /// The device access protocol is device specific. > + /// EDKII_DEVICE_IDENTIFIER_TYPE_PCI_GUID means the device

Re: [edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support

2019-11-05 Thread Tiger Liu(BJ-RD)
Got it. Thank you very much. Best wishes, -邮件原件- 发件人: Kubacki, Michael A 发送时间: 2019年11月6日 15:05 收件人: devel@edk2.groups.io; Tiger Liu(BJ-RD) 主题: RE: [edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support Unfortunately not. That's why we're trying to add support for these

Re: [edk2-devel] [PATCH V2 1/6] IntelSiliconPkg/Include: Add Intel PciSecurity definition.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ;

Re: [edk2-devel] [PATCH V2 3/6] IntelSiliconPkg/dec: Add ProtocolGuid definition.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ;

Re: [edk2-devel] [PATCH V2 3/4] MdeModulePkg/dec: Add EdkiiDeviceSecurityProtocolGuid.

2019-11-05 Thread Yao, Jiewen
Hi Jian/Hao/Ray Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Wang, Jian

Re: [edk2-devel] [PATCH V2 6/6] IntelSiliconPkg/dsc: Add Device Security component.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ;

Re: [edk2-devel] [PATCH V2 4/6] IntelSiliconPkg/IntelPciDeviceSecurityDxe: Add PciSecurity.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ;

Re: [edk2-devel] [PATCH V2 5/6] IntelSiliconPkg/SamplePlatformDevicePolicyDxe: Add sample policy.

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ;

Re: [edk2-devel] [PATCH V2 4/4] MdeModulePkg/Pci: Add DeviceSecurity support.

2019-11-05 Thread Yao, Jiewen
Hi Jian/Hao/Ray Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Wang, Jian

Re: [edk2-devel] [PATCH V2 2/4] MdeModulePkg/Include: Add DeviceSecurity.h

2019-11-05 Thread Yao, Jiewen
Hi Jian/Hao/Ray Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Wang, Jian

Re: [edk2-devel] [PATCH V2 2/6] IntelSiliconPkg/Include: Add Platform Device Security Policy protocol

2019-11-05 Thread Yao, Jiewen
Hi Ray/Sai Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:31 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ;

Re: [edk2-devel] [PATCH V2 1/4] MdePkg/Include: Add DMTF SPDM definition.

2019-11-05 Thread Yao, Jiewen
Hi Liming/Michael Would you please review this patch? We need this feature in next stable tag as planned. Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Thursday, October 31, 2019 8:30 PM > To: devel@edk2.groups.io > Cc: Kinney,

Re: [edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support

2019-11-05 Thread Tiger Liu(BJ-RD)
Hi, Michael: Got it. Thanks For "Reference and Validation Platform" motherboard, could user buy it at open market? For example, buy it on Amazon. Thanks -邮件原件- 发件人: devel@edk2.groups.io 代表 Kubacki, Michael A 发送时间: 2019年11月6日 10:12 收件人: Tiger Liu(BJ-RD) ; devel@edk2.groups.io 主题: Re:

Re: [edk2-devel] [PATCH] SecurityPkg: Fix TPM2 ACPI measurement.

2019-11-05 Thread Wang, Jian J
Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Derek Lin > Sent: Wednesday, November 06, 2019 9:01 AM > To: derek.l...@hpe.com; devel@edk2.groups.io > Cc: jason.spottsw...@hpe.com; Yao, Jiewen ; Wang, > Jian J ; Zhang, Chao B > Subject: [PATCH] SecurityPkg: Fix

Re: [edk2-devel] [PATCH V2 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add value HBM and Die for type 17

2019-11-05 Thread Gao, Zhichao
Resend to the maintainers and skate holders. Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gao, > Zhichao > Sent: Monday, November 4, 2019 6:13 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH V2 3/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Add > value

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Ni, Ray
Andrew, I agree with your opinion. It's expected that Platform Boot Manager lib calls EfiBootManagerRefreshAllBootOption() only in full configuration boot path. The full configuration boot path is chosen when hardware changes happen. So it's not expected EfiBootManagerRefresh...() be called in

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Andrew Fish via Groups.Io
> On Nov 5, 2019, at 7:34 PM, Jeff Brasen wrote: > > > Wouldn't having a variable that we create and delete on every boot put > unnecessary stress on the SPI-NOR that the variable store lives on? > What about the alternative approach where we allow the platform code to > modify the

Re: [edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support

2019-11-05 Thread Kubacki, Michael A
No other OCP support at the moment. Current board support is summarized in this Readme.md: https://github.com/tianocore/edk2-platforms/blob/master/Readme.md#intel Newer Intel platform firmware is following the EDK II Minimum Platform specification and the boards supported are documented here:

Re: [edk2-devel] [edk2-platforms] [Patch v2 3/9] BoardModulePkg: Add Super I/O driver

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 3/9] BoardModulePkg: Add Super I/O >

Re: [edk2-devel] [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 keyboard Support

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 >

Re: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: Add Ps2 Keyboard Support

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: devel@edk2.groups.io On Behalf Of Agyeman, > Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Subject: [edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: > Add Ps2 Keyboard Support >

Re: [edk2-devel] [edk2-platforms] [Patch v2 9/9] WhiskeylakeOpenBoardPkg: Add Ps2 Keyboard Support

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 9/9] WhiskeylakeOpenBoardPkg: Add Ps2

Re: [edk2-devel] [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build Pcds

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 4/9] BoardModulePkg: Add fix at build

Re: [edk2-devel] [edk2-platforms] [Patch v2 6/9] BoardModulePkg: Add Ps2 Keyboard Library

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 6/9] BoardModulePkg: Add Ps2

Re: [edk2-devel] [edk2-platforms] [Patch v2 1/9] BoardModulePkg: Add gBoardModulePkgTokenSpaceGuid

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 1/9] BoardModulePkg: Add >

Re: [edk2-devel] [edk2-platforms] [Patch v2 5/9] BoardModulePkg: Added Pcds to Super I/O driver

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 5/9] BoardModulePkg: Added Pcds to >

Re: [edk2-devel] [edk2-platforms] [Patch v2 2/9] SimicsOpenBoardPkg: Remove Super I/O DXE driver

2019-11-05 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu > -Original Message- > From: Agyeman, Prince > Sent: Wednesday, November 6, 2019 9:26 AM > To: devel@edk2.groups.io > Cc: Kubacki, Michael A ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [edk2-platforms] [Patch v2 2/9] SimicsOpenBoardPkg: Remove Super

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Jeff Brasen
Wouldn't having a variable that we create and delete on every boot put unnecessary stress on the SPI-NOR that the variable store lives on? What about the alternative approach where we allow the platform code to modify the attributes of the auto created variable to disable it with hidden/!active

Re: [edk2-devel] [edk2-platforms] [PATCH v2] SimicsOpenBoardPkg: Add CmosAccessLib to BoardX58Ich10

2019-11-05 Thread Nate DeSimone
It looks like there are a bunch of magical CMOS locations hardcoded in here... specifically 0x34, 0x5B, and 0x5C. I would prefer that these were converted into #defines. That can be done in a separate patch though since it is not related to your change here. Reviewed-by: Nate DeSimone

Re: [edk2-devel] [PATCH] SecurityPkg: Fix TPM2 ACPI measurement.

2019-11-05 Thread Yao, Jiewen
Reviewed by: Jiewen Yao > -Original Message- > From: Derek Lin > Sent: Wednesday, November 6, 2019 9:01 AM > To: derek.l...@hpe.com; devel@edk2.groups.io > Cc: jason.spottsw...@hpe.com; Yao, Jiewen ; Wang, > Jian J ; Zhang, Chao B > Subject: [PATCH] SecurityPkg: Fix TPM2 ACPI

Re: [edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support

2019-11-05 Thread Tiger Liu(BJ-RD)
Hi, Michael: Thanks for your reply! Is there any other project For Intel open source platform firmware? KabylakeOpenBoardPkg / WhiskeylakeOpenBoardPkg is also for OCP platform board? Thanks -邮件原件- 发件人: Kubacki, Michael A 发送时间: 2019年11月6日 2:38 收件人: devel@edk2.groups.io; Tiger Liu(BJ-RD)

[edk2-devel] [edk2-platforms] [Patch v2 5/9] BoardModulePkg: Added Pcds to Super I/O driver

2019-11-05 Thread Agyeman, Prince
Included PCDs to the Super I/O DXE driver, to allow the enable/disable of Ps2 keyboard/mouse, UART1 and UART2 ports. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../LegacySioDxe/LegacySioDxe.inf | 12

[edk2-devel] [edk2-platforms] [Patch v2 8/9] SimicsOpenBoardPkg: Add Ps2 keyboard Support

2019-11-05 Thread Agyeman, Prince
Added BIOS keyboard support to BoardX58Ich10 * Included BoardModulePkg's generic Super I/O DXE driver * Configured Super I/O and Ps2 keyboard related PCD to enable Ps2 keyboard Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman ---

[edk2-devel] [edk2-platforms] [Patch v2 3/9] BoardModulePkg: Add Super I/O driver

2019-11-05 Thread Agyeman, Prince
Added a generic Super I/O driver that produces the Sio protocol. This driver was moved from the SimicsOpenBoardPkg. Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Intel/BoardModulePkg/BoardModulePkg.dsc | 5 + .../LegacySioDxe/ComponentName.c

[edk2-devel] [edk2-platforms] [Patch v2 0/9] Enable Ps2 keyboard

2019-11-05 Thread Agyeman, Prince
This patch series enables BIOS Ps2 keyboard in GalagoPro3 Changes in v2: * fixed typos * fixed discriptions * broke patches down as per recommendation from Michael Kubacki * renamed the Ps2KbcLib to BdsPs2KbcLib * moved BdsPs2KbcLib to BoardModulePkg as it is generic and can be shared What was

[edk2-devel] [edk2-platforms] [Patch v2 7/9] KabylakeOpenBoardPkg: Add Ps2 Keyboard Support

2019-11-05 Thread Agyeman, Prince
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2228 What was done: * Added BDS Ps2 keyboard DXE driver. * Added Super I/O DXE driver to publish the SIO protocol needed by the Ps2 keyboard DXE driver. * Included a Ps2 Library to BdsDxe driver to add the Ps2 device path to ConIn and

[edk2-devel] [edk2-platforms] [Patch v2 1/9] BoardModulePkg: Add gBoardModulePkgTokenSpaceGuid

2019-11-05 Thread Agyeman, Prince
Added gBoardModulePkgTokenSpaceGuid to BoardModulePkg Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- Platform/Intel/BoardModulePkg/BoardModulePkg.dec | 4 1 file changed, 4 insertions(+) diff --git

[edk2-devel] [edk2-platforms] [Patch v2 2/9] SimicsOpenBoardPkg: Remove Super I/O DXE driver

2019-11-05 Thread Agyeman, Prince
Removed the Super I/O DXE driver from SimicsOpenBoardPkg. This driver will be added to the BoardModulePky as it is generic and can be shared by other open board packages Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman ---

[edk2-devel] [edk2-platforms] [Patch v2 9/9] WhiskeylakeOpenBoardPkg: Add Ps2 Keyboard Support

2019-11-05 Thread Agyeman, Prince
What was done: * Added BDS Ps2 keyboard DXE driver. * Included Super I/O DXE driver to publish the SIO protocol needed by the Ps2 keyboard DXE driver. * Included a Ps2 Library to BdsDxe driver to add the Ps2 device path to ConIn and ConInDev variables * Configured the Super I/O Pci to Isa

[edk2-devel] [edk2-platforms] [Patch v2 6/9] BoardModulePkg: Add Ps2 Keyboard Library

2019-11-05 Thread Agyeman, Prince
Added a generic Ps2 keyboard library that adds ps2 device path to ConIn and ConInDev Uefi variables Cc: Michael Kubacki Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Prince Agyeman --- .../Intel/BoardModulePkg/BoardModulePkg.dsc | 1 + .../Library/BdsPs2KbcLib/BdsPs2KbcLib.c |

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Ashish Singhal
Reconciling the email chain from devel.io portal as it does not send email to individual participants. On Nov 5, 2019, at 5:19 PM, Jeff Brasen wrote: Wouldn't having a variable that we create and delete on every boot put unnecessary stress on the SPI-NOR that the variable store lives on? What

[edk2-devel] [PATCH] SecurityPkg: Fix TPM2 ACPI measurement.

2019-11-05 Thread Lin, Derek (HPS SW)
We have discussed in this thread. https://edk2.groups.io/g/devel/topic/32205028 Before the change, TPM FW upgrade will impact TPM2 ACPI PCR value because TPM2 ACPI HID include FW version. This change make the measurement before TPM2 HID fixup. So, after TPM FW upgrade, the ACPI PCR record

Re: [edk2-devel] [PATCH v1 1/1] Maintainers.txt: Adding new NetworkPkg reviewer.

2019-11-05 Thread Wu, Jiaxin
Reviewed-by: Jiaxin Wu Thanks, Jiaxin > -Original Message- > From: Rabeda, Maciej > Sent: Wednesday, November 6, 2019 1:07 AM > To: devel@edk2.groups.io > Cc: Wu, Jiaxin ; Fu, Siyuan > Subject: [PATCH v1 1/1] Maintainers.txt: Adding new NetworkPkg reviewer. > > Add Maciej Rabeda as

Re: [edk2-devel] [edk2-platforms] Update Intel Packages on Bugzilla

2019-11-05 Thread Michael D Kinney
Michael, I have disabled those 4 components for bugs. Thanks, Mike From: Kubacki, Michael A Sent: Tuesday, November 5, 2019 1:48 PM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Lu, Shifei A ; Zhou, Bowen ; Oram, Isaac W ; Piwko, Maciej ; Bu, Daocheng ; Gillispie, Thad Subject:

Re: [edk2-devel] [Patch v3 22/22] Readme.md: Add CI build status badges

2019-11-05 Thread Michael D Kinney
Liming, The Azure Pipelines config is vm_image: 'ubuntu-latest' The documentation on available vm_image settings is here: https://docs.microsoft.com/en-us/azure/devops/pipelines/agents/hosted?view=azure-devops Currently ubuntu-latest is same as ubuntu-18.04. Mike > -Original

Re: [edk2-devel] [Patch v3 12/22] MdePkg: Add YAML file for CI builds

2019-11-05 Thread Michael D Kinney
Yes. Mike > -Original Message- > From: Gao, Liming > Sent: Tuesday, November 5, 2019 4:21 PM > To: Kinney, Michael D ; > devel@edk2.groups.io; Sean Brogan > > Subject: RE: [Patch v3 12/22] MdePkg: Add YAML file for > CI builds > > Mike: > So, github plugin (.azurepipelines,

Re: [edk2-devel] [Patch v3 12/22] MdePkg: Add YAML file for CI builds

2019-11-05 Thread Liming Gao
Mike: So, github plugin (.azurepipelines, .mergify) uses .yml files. Edk2 pytool plugin uses .yaml. Right? Thanks Liming >-Original Message- >From: Kinney, Michael D >Sent: Wednesday, November 06, 2019 1:05 AM >To: Gao, Liming ; devel@edk2.groups.io; Kinney, >Michael D ; Sean Brogan >

Re: [edk2-devel] [Patch v3 22/22] Readme.md: Add CI build status badges

2019-11-05 Thread Liming Gao
Mike: How to know Ubuntu OS version? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Michael D Kinney >Sent: Wednesday, October 30, 2019 3:55 AM >To: devel@edk2.groups.io >Cc: Andrew Fish ; Laszlo Ersek ; Leif >Lindholm

Re: [edk2-devel] [PATCH] SecurityPkg/OpalPassword: Remove dependency on EFI_BLOCK_IO_PROTOCOL

2019-11-05 Thread Dong, Eric
Reviewed-by: Eric Dong -Original Message- From: Chu, Maggie Sent: Monday, November 4, 2019 12:04 PM To: devel@edk2.groups.io Cc: Dong, Eric ; Zhang, Chao B ; Yao, Jiewen Subject: [PATCH] SecurityPkg/OpalPassword: Remove dependency on EFI_BLOCK_IO_PROTOCOL

[edk2-devel][edk2-staging/EdkRepo][PATCH 2/8] EdkRepo: Argument String Refactor Manifest Command

2019-11-05 Thread Desimone, Ashley E
Update setup.py to add edkrepo.commands.arguments. Move all argument strings for manifest_command.py to edkrepo/commands/arguments/manifest_args.py and remove unused strings. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/commands/arguments/__init__.py |

[edk2-devel][edk2-staging/EdkRepo][PATCH 8/8] EdkRepo: Argument Strings Refactor - EdkRepo Command

2019-11-05 Thread Desimone, Ashley E
Move all argument strings for edkrepo_command.py to edkrepo/commands/arguments/edkrepo_cmd_args.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- .../arguments/edkrepo_cmd_args.py} | 9 +++-- edkrepo/commands/edkrepo_command.py

[edk2-devel][edk2-staging/EdkRepo][PATCH 7/8] EdkRepo: Argument Strings Refactor - Clone Command

2019-11-05 Thread Desimone, Ashley E
Move all argument strings for clone_command.py to edkrepo/commands/arguments/clone_args.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/commands/arguments/clone_args.py | 22 ++ edkrepo/commands/clone_command.py| 24

[edk2-devel][edk2-staging/EdkRepo][PATCH 1/8] EdkRepo: Argument String Refactor - Removed Unused Strings

2019-11-05 Thread Desimone, Ashley E
Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/common/argument_strings.py | 5 - 1 file changed, 5 deletions(-) diff --git a/edkrepo/common/argument_strings.py b/edkrepo/common/argument_strings.py index 0a7db59..93db079 100644 ---

[edk2-devel][edk2-staging/EdkRepo][PATCH 4/8] EdkRepo: Argument String Refactory - Combo Command

2019-11-05 Thread Desimone, Ashley E
Move all argument strings for checkout_command.py to edkrepo/commands/arguments/checkout_args.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/commands/arguments/checkout_args.py | 16 edkrepo/commands/checkout_command.py| 10

[edk2-devel][edk2-staging/EdkRepo][PATCH 6/8] EdkRepo: Argument Strings Refactor - Sync Command

2019-11-05 Thread Desimone, Ashley E
Move all argument strings for sync_command.py to edkrepo/commands/arguments/sparse_args.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/commands/arguments/sync_args.py | 17 + edkrepo/commands/sync_command.py| 13 +

[edk2-devel][edk2-staging/EdkRepo][PATCH 5/8] EdkRepo: Argument Strings Refactor - Sparse Command

2019-11-05 Thread Desimone, Ashley E
Move all argument strings for sparse_command.py to edkrepo/commands/arguments/sparse_args.py Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya --- edkrepo/commands/arguments/sparse_args.py | 16 edkrepo/commands/sparse_command.py| 8

Re: [edk2-devel] [edk2-non-osi][PATCH V1 00/10] Clean up PurleySiliconBinPkg

2019-11-05 Thread Oram, Isaac W
For the patch series... Reviewed-by: Isaac Oram -Original Message- From: Kubacki, Michael A Sent: Tuesday, November 5, 2019 2:38 PM To: devel@edk2.groups.io Cc: Bu, Daocheng ; Desimone, Nathaniel L ; Gillispie, Thad ; Oram, Isaac W Subject: [edk2-non-osi][PATCH V1 00/10] Clean up

Re: [edk2-devel] [edk2-platforms] [PATCH v2] SimicsOpenBoardPkg: Add CmosAccessLib to BoardX58Ich10

2019-11-05 Thread Kubacki, Michael A
Reviewed-by: Michael Kubacki > -Original Message- > From: Agyeman, Prince > Sent: Friday, November 1, 2019 4:44 PM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Desimone, Nathaniel L > ; Kubacki, Michael A > > Subject: [edk2-platforms] [PATCH v2] SimicsOpenBoardPkg: Add >

[edk2-devel] [edk2-non-osi][PATCH V1 10/10] Intel/PurleySiliconBinPkg: Remove FSP_License.pdf

2019-11-05 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322 Removes the FSP_License.pdf file since it is no longer applicable. Cc: Daocheng Bu Cc: Nate DeSimone Cc: Thad Gillispie Cc: Isaac Oram Signed-off-by: Michael Kubacki --- Silicon/Intel/PurleySiliconBinPkg/FSP_License.pdf | Bin 15051 ->

[edk2-devel] [edk2-non-osi][PATCH V1 03/10] Intel/PurleySiliconBinPkg: Remove RELEASE FvTempMemorySilicon

2019-11-05 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322 Removes the FvTempMemorySilicon firmware volume binary since the Purley platform firmware code is no longer maintained in edk2-platforms. Cc: Daocheng Bu Cc: Nate DeSimone Cc: Thad Gillispie Cc: Isaac Oram Signed-off-by: Michael Kubacki

[edk2-devel] [edk2-non-osi][PATCH V1 00/10] Clean up PurleySiliconBinPkg

2019-11-05 Thread Kubacki, Michael A
This patch series removes firmware volumes in PurleySiliconBinPkg that are no longer tested after removal of PurleyOpenBoardPkg in edk2-platforms. In addition, some license files are added that were previously missing. The patch series is broken into a granular set of patches to reduce the size

[edk2-devel] [edk2-non-osi][PATCH V1 07/10] Intel/PurleySiliconBinPkg: Remove RELEASE FvPostMemorySilicon

2019-11-05 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322 Removes the FvPostMemorySilicon firmware volume binary since the Purley platform firmware code is no longer maintained in edk2-platforms. Cc: Daocheng Bu Cc: Nate DeSimone Cc: Thad Gillispie Cc: Isaac Oram Signed-off-by: Michael Kubacki

[edk2-devel] [edk2-non-osi][PATCH V1 02/10] Intel/PurleySiliconBinPkg: Remove DEBUG FvTempMemorySilicon

2019-11-05 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322 Removes the FvTempMemorySilicon firmware volume binary since the Purley platform firmware code is no longer maintained in edk2-platforms. Cc: Daocheng Bu Cc: Nate DeSimone Cc: Thad Gillispie Cc: Isaac Oram Signed-off-by: Michael Kubacki

[edk2-devel] [edk2-non-osi][PATCH V1 01/10] Intel/PurleySiliconBinPkg: Add license files

2019-11-05 Thread Kubacki, Michael A
Adds the Intel license file to PurleySiliconBinPkg and the Intel microcode license file to the Purley microcode directory. Cc: Daocheng Bu Cc: Nate DeSimone Cc: Thad Gillispie Cc: Isaac Oram Signed-off-by: Michael Kubacki --- Silicon/Intel/PurleySiliconBinPkg/License.txt

[edk2-devel] [edk2-non-osi][PATCH V1 06/10] Intel/PurleySiliconBinPkg: Remove DEBUG FvPostMemorySilicon

2019-11-05 Thread Kubacki, Michael A
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2322 Removes the FvPostMemorySilicon firmware volume binary since the Purley platform firmware code is no longer maintained in edk2-platforms. Cc: Daocheng Bu Cc: Nate DeSimone Cc: Thad Gillispie Cc: Isaac Oram Signed-off-by: Michael Kubacki

Re: [edk2-devel] [PATCH V2 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Monday, November 04, 2019 2:13 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Chaganty, Rangasai V Subject: [PATCH V2 2/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add support for CXL Flexbus REF:

Re: [edk2-devel] [PATCH V2 4/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Monday, November 04, 2019 2:13 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Chaganty, Rangasai V Subject: [PATCH V2 4/8] MdePkg/Smbios.h: SMBIOS 3.3.0 Update Intel Persistent Memory string

[edk2-devel] [edk2-platforms] Update Intel Packages on Bugzilla

2019-11-05 Thread Kubacki, Michael A
Hi Mike, The following packages have been removed from edk2-platforms in the patch series below as described in the RFC. * RFC: https://edk2.groups.io/g/devel/message/49360 * Patch series: https://edk2.groups.io/g/devel/message/49843 Packages: * Platform/Intel/PurleyOpenBoardPkg *

Re: [edk2-devel] [PATCH V2 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Monday, November 04, 2019 2:13 AM To: devel@edk2.groups.io Cc: Kinney, Michael D ; Gao, Liming ; Chaganty, Rangasai V Subject: [PATCH V2 1/8] MdePkg/Smbios.h: SMBIOS 3.3.0 add PCI gen4 values for type 9 REF:

Re: [edk2-devel] [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory"

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Sunday, November 03, 2019 11:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH 4/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Update "Intel persistent memory" REF:

Re: [edk2-devel] [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Sunday, November 03, 2019 11:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH 3/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 Add value HBM and Die for type 17 REF:

Re: [edk2-devel] [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Sunday, November 03, 2019 11:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH 2/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add support for CXL Flexbus REF:

Re: [edk2-devel] [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9

2019-11-05 Thread Chaganty, Rangasai V
Reviewed-by: Sai Chaganty -Original Message- From: Gao, Zhichao Sent: Sunday, November 03, 2019 11:21 PM To: devel@edk2.groups.io Cc: Ni, Ray ; Chaganty, Rangasai V Subject: [PATCH 1/4] ShellPkg/SmbiosView: SMBIOS 3.3.0 add PCI gen4 values for type 9 REF:

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Laszlo Ersek
On 11/05/19 19:00, Ashish Singhal wrote: > I agree that I can use the platform boot manager protocol to modify > the boot variable and give the custom optional data I need, but that > would not stop UefiBootManagerLib from creating another boot option > with mBmAutoCreateBootOptionGuid as the

Re: [edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support

2019-11-05 Thread Kubacki, Michael A
Hi, The PurleyOpenBoardPkg code is being removed as noted in the following patch series recently sent to the mailing list - https://edk2.groups.io/g/devel/message/49843. It has not been tested in some time and does not align with our vision for Intel open source platform firmware. The effort

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Ashish Singhal
Hello Andrew/Laszlo, Thank you for walking me through the steps that happen and what I can do in terms of modifying variables. I think I did not do a good job stating the exact issue I see when I try these options so I will try to explain it here. First of all, I do want the boot option to be

[edk2-devel] [[PATCH 1/1]] EmulatorPkg using CpuBreakPoint

2019-11-05 Thread Kilian Kegel
Hi Liming, >Kilian: can you send the patch to edk2 mail list for code review? Regards, Kilian https://bugzilla.tianocore.org/show_bug.cgi?id=2319 diff --git a/EmulatorPkg/Win/Host/WinHost.c b/EmulatorPkg/Win/Host/WinHost.c index 62a89f7617..53cda86f9a 100644 --- a/EmulatorPkg/Win/Host/WinHost.c

[edk2-devel] [PATCH v1 1/1] Maintainers.txt: Adding new NetworkPkg reviewer.

2019-11-05 Thread Rabeda, Maciej
Add Maciej Rabeda as reviewer of NetworkPkg. Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Maciej Rabeda --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 71a34a284567..922cc664ddc3 100644 --- a/Maintainers.txt +++ b/Maintainers.txt

[edk2-devel] [PATCH v1 0/1] Maintainers.txt: Adding new NetworkPkg reviewer.

2019-11-05 Thread Rabeda, Maciej
Add Maciej Rabeda as reviewer of NetworkPkg. Cc: Jiaxin Wu Cc: Siyuan Fu Maciej Rabeda (1): Maintainers.txt: Adding new NetworkPkg reviewer. Maintainers.txt | 1 + 1 file changed, 1 insertion(+) -- 2.17.0.windows.1

Re: [edk2-devel] [Patch v3 18/22] SignedCapsulePkg: Use BaseCryptLibNull to reduce package CI time

2019-11-05 Thread Michael D Kinney
Liming, Not yet. We will add more packages in a future series. Mike > -Original Message- > From: Gao, Liming > Sent: Tuesday, November 5, 2019 12:23 AM > To: devel@edk2.groups.io; Kinney, Michael D > > Cc: Yao, Jiewen ; Zhang, Chao B > > Subject: RE: [edk2-devel] [Patch v3 18/22] >

Re: [edk2-devel] [Patch v3 12/22] MdePkg: Add YAML file for CI builds

2019-11-05 Thread Michael D Kinney
Hi Liming, There are two types of YAML files in this patch series. 1) Azure Piplelines .yml files. https://docs.microsoft.com/en-us/azure/devops/pipelines/yaml-schema?view=azure-devops=schema 2) EDK II Package .yaml files. These specify the set of pytool extensions to use to make

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Andrew Fish via Groups.Io
> On Nov 5, 2019, at 3:54 AM, Laszlo Ersek wrote: > > On 11/05/19 07:15, Andrew Fish via Groups.Io wrote: > >> You could also edit any existing variables that point to your Load File to >> make sure they follow the rules you care about? >> >> It is legal from an UEFI spec point of view

[edk2-devel] TianoCore Community Meeting This Week

2019-11-05 Thread Brian Richardson
Greetings. I will be running TianoCore community meetings this month. Please e-mail me directly if you have any open items to discuss (brian.richard...@intel.com). TianoCore Community Meeting - EMEA/NAMO Thursday, November 7, 2019 9:00 AM-10:00 AM (UTC-08:00) Pacific Time (US &

[edk2-devel] [PATCH] ShellPkg/CommandLib: Use first found UC for unsupported PlatformLang

2019-11-05 Thread Marvin Häuser
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2300 On some firmwares PlatformLang is set to the local language (e.g. ru-RU), however there is no Unicode Collation protocol instance that supports it. As for missing PlatformLang, fall back to the first found instance. Cc: Ray Ni Cc: Zhichao

[edk2-devel] [edk2] OCP : Olympus project's UEFI BIOS code support

2019-11-05 Thread Tiger Liu(BJ-RD)
Hi, Michael: I found edk2-platforms include OCP Olympus board’s support package. edk2-platforms\Platform\Intel\PurleyOpenBoardPkg\BoardMtOlympus In this wiki, https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Platforms It also said,edk2-platform include Project Olympus’s support: EDK

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Laszlo Ersek
On 11/05/19 07:15, Andrew Fish via Groups.Io wrote: > You could also edit any existing variables that point to your Load File to > make sure they follow the rules you care about? > > It is legal from an UEFI spec point of view for a platform to edit the nvram > boot variables based on

Re: [edk2-devel] [PATCH] Support skipping automatic BM enumeration

2019-11-05 Thread Laszlo Ersek
On 11/05/19 04:24, Ashish Singhal wrote: > Hi Ray, > > I did not see any example with which one can tell BDS not to > enumerate a boot option. Can you please point me to an example where > a protocol (Block IO, Simple FS or Load File) does not get enumerated > as a boot option? (I'm going to

Re: [edk2-devel] [Patch v3 18/22] SignedCapsulePkg: Use BaseCryptLibNull to reduce package CI time

2019-11-05 Thread Liming Gao
Mike: Is there the package CI YAML file for SignedCapsulePkg? Thanks Liming >-Original Message- >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >Michael D Kinney >Sent: Wednesday, October 30, 2019 3:55 AM >To: devel@edk2.groups.io >Cc: Yao, Jiewen ; Zhang, Chao B

Re: [edk2-devel] [Patch v3 12/22] MdePkg: Add YAML file for CI builds

2019-11-05 Thread Liming Gao
Mike: Is there some basic introduction for YAML file syntax? Thanks Liming >-Original Message- >From: Kinney, Michael D >Sent: Wednesday, October 30, 2019 3:55 AM >To: devel@edk2.groups.io >Cc: Gao, Liming >Subject: [Patch v3 12/22] MdePkg: Add YAML file for CI builds >

Re: [edk2-devel] [Patch v3 04/22] BaseTools/tools_def.template: Add RC_PATH define

2019-11-05 Thread Liming Gao
Mike: To avoid the impact of the developer, we should update edk2\BaseTools\set_vsprefix_envs.bat to auto set WINSDK_PATH_FOR_RC_EXE env. Thanks Liming >-Original Message- >From: Kinney, Michael D >Sent: Wednesday, October 30, 2019 3:55 AM >To: devel@edk2.groups.io >Cc: Sean Brogan ;