Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/15] MdeModulePkg/PciBusDxe: Enable MaxPayloadSize feature

My response in line. Thanks Ashraf > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 13, 2020 12:16 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/15] > MdeModulePkg/PciBusDxe: Enable MaxP

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 13/15] MdeModulePkg/PciBusDxe: Enable AtomicOp feature

Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 13/15] > MdeModu

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 12/15] MdeModulePkg/PciBusDxe: Enable LTR feature

> +EFI_STATUS > +LtrScan ( > + IN PCI_IO_DEVICE *PciIoDevice, > + IN UINTN Level, > + IN VOID **Context > + ) > +{ > + BOOLEAN *Ltr; > + ASSERT (Level <= PCI_MAX_BUS); > + //ASSERT (Context != NULL); Why the "ASSERT (Context != NULL)" is commented out? Thanks,

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 11/15] MdeModulePkg/PciBusDxe: Enable CompletionTimeout feature

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 11/15] > MdeModulePkg/PciBusDxe: Enable CompletionTimeout featu

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 10/15] MdeModulePkg/PciBusDxe: Enable NoSnoop feature

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 10/15] > MdeModulePkg/PciBusDxe: Enable NoSnoop feature > > RE

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 08/15] MdeModulePkg/PciBusDxe: Enable MaxReadRequestSize feature

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 08/15] > MdeModulePkg/PciBusDxe: Enable MaxReadRequestSize > fe

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 09/15] MdeModulePkg/PciBusDxe: Enable RelaxedOrdering feature

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 09/15] > MdeModulePkg/PciBusDxe: Enable RelaxedOrdering feature

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] MdeModulePkg/PciBusDxe: Add the framework to init PCIe features

Yes, both the comments shall be fixed. Thanks Ashraf > -Original Message- > From: Ni, Ray > Sent: Wednesday, May 13, 2020 12:09 PM > To: Javeed, Ashraf ; devel@edk2.groups.io > Cc: Wang, Jian J ; Wu, Hao A > > Subject: RE: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] > MdeModulePkg/PciB

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 07/15] MdeModulePkg/PciBusDxe: Enable MaxPayloadSize feature

> /** > @@ -220,6 +226,7 @@ PcieNotifyDeviceState ( > >CopyMem (&PcieDeviceState, &PciIoDevice->DeviceState, sizeof > (PciIoDevice->DeviceState)); > > + PcieDeviceState.MaxPayloadSize = > (UINT8)PciIoDevice->PciExpressCapability.DeviceControl.Bits.MaxPayloadSize; My original idea is

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 06/15] MdeModulePkg/PciBusDxe: Add the framework to init PCIe features

> + // " Device MPS MRRS RO NS CTO LTR\n" 1. Can you update above comments to below? // "Device MPS MRRS RO NS CTO LTR AtomicOp ExtTag CCC\n" It explains why "%03x" or "%08x" is chosen in below DEBUG output. > + DEBUG (( > +DEBUG_INFO, " %02x|%

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 05/15] MdeModulePkg/PciBusDxe: Locate PciePlatform/PcieOverride protocol

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 05/15] > MdeModulePkg/PciBusDxe: Locate PciePlatform/PcieOverri

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/15] MdeModulePkg/PciBus: Rename Cache PCIe Capability Structure

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 03/15] MdeModulePkg/PciBus: > Rename Cache PCIe Capability > St

Re: [edk2-devel] [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 04/15] MdeModulePkg/PciBusDxe: Refactor the PCIe Bridge enable

Reviewed-by: Ray Ni > -Original Message- > From: Javeed, Ashraf > Sent: Monday, May 11, 2020 12:14 AM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Wang, Jian J ; Wu, Hao > A > Subject: [edk2-staging/UEFI_PCI_ENHANCE-2 PATCH 04/15] > MdeModulePkg/PciBusDxe: Refactor the PCIe Bridge enabl

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature

"Not sure about the UefiPayloadPkg platforms; please ask their maintainers." UefiPayloadPkg maintainers: what say you? ? - Bret From: devel@edk2.groups.io on behalf of Laszlo Ersek via groups.io Sent: Tuesday, May 12, 2020 4:52:52 AM To: devel@edk2.groups.io ;

Re: [EXTERNAL] Re: [edk2-devel] [PATCH v2 01/12] MdeModulePkg: Define the VariablePolicy protocol interface

I don’t entirely disagree with the name suggestion, but it’s pretty late in the process. If it’s not a hard-stop, I’d rather not. Other change has been made. - Bret From: Laszlo Ersek via groups.io Sent: Tuesday, May 12, 2020 5:19 AM To: devel@edk2.groups.io<

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

Kai, In your case, the two PCD value should be set to 2020/2119. With the new PCD value the issue you see will disappear. I won't approve code changes unless you convince me there is a logic error in code. + Lijian Thanks, Ray > -Original Message- > From: Yau, KaiX > Sent: Wednesday, M

Re: [edk2-devel] BDS Phase Output Menu

Hello, Thank you. The best I can remember is the server I worked on 10 years ago, we could select Linux, Net64, or Windows at the menu. I may have the terminology wrong. Things may have changed in uEFI. I worked in PEI and DXE phases years ago. I am waiting on hardware now. I have been using VM

Re: [edk2-devel] [PATCH] PcAtChipsetPkg: Wrong System YEAR displayed in SETUP

Kai, Can you please explain what logic error in code is wrong? Thanks, Ray > -Original Message- > From: Yau, KaiX > Sent: Tuesday, May 12, 2020 1:52 PM > To: Ni, Ray ; devel@edk2.groups.io; kai...@gmail.com > Cc: Jiang, Guomin ; Gao, Liming > ; Archield, Ralphal > > Subject: RE: [edk2

Re: [edk2-devel] [PATCH v7] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers.

Hi Chasel, I have one comments for your patch. Can you help to add extra notes about what has been done for each version. In this case, review can know what's changed in different versions. You can add this info in below position (just below "> ---" in below patch file, I add a sample in belo

[edk2-devel] [PATCH v7] IntelFsp2Pkg: Support Multi-Phase SiInit and debug handlers.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2698 To enhance FSP silicon initialization flexibility an optional Multi-Phase API is introduced and FSP header needs update for new API offset. Also new SecCore module created for FspMultiPhaseSiInit API New ARCH_UPD introduced for enhancing FS

Re: [edk2-devel] [PATCH v2] BaseTools: Fix parse PCD GUID expression issue

Reviewed-by: Bob Feng -Original Message- From: Feng, YunhuaX Sent: Saturday, May 9, 2020 8:15 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH v2] BaseTools: Fix parse PCD GUID expression issue REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2686 The buil

Re: [edk2-devel] [PATCH v1 1/1] BaseTools/Ecc: Replace deprecated function time.clock()

Reviewed-by: Bob Feng -Original Message- From: michael.kuba...@outlook.com Sent: Saturday, May 9, 2020 10:23 AM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH v1 1/1] BaseTools/Ecc: Replace deprecated function time.clock() From: Michael Kubacki REF:https://bu

Re: [edk2-devel] [PATCH] BaseTools: Fix binary file not generate map file issue

This patch looks fine. Reviewed-by: Bob Feng -Original Message- From: Feng, YunhuaX Sent: Saturday, May 9, 2020 5:34 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH] BaseTools: Fix binary file not generate map file issue REF: https://bugzilla.tianocore.org/s

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Wed, 05/13/2020 9:30am-10:30am #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Wednesday, 13 May 2020, 9:30am to 10:30am, (GMT+08:00) Asia/Chongqing *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=805105 ) *Organizer:* Brian Richardson brian.richard.

Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit

Reviewed-by: Sai Chaganty -Original Message- From: Esakkithevar, Kathappan Sent: Tuesday, May 12, 2020 10:26 AM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel ; Desimone, Nathaniel L ; Kethi Reddy, Deepika Subject: [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build er

Re: [edk2-devel] [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib

Reviewed-by: Chasel Chiu > -Original Message- > From: Vitaly Cheptsov > Sent: Wednesday, May 13, 2020 1:02 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH V5 14/27] IntelFsp2Pkg: Add support for DebugCommonLib > > REF: https:/

Re: [edk2-devel] [PATCH V5 15/27] IntelFsp2WrapperPkg: Add support for DebugCommonLib

Reviewed-by: Chasel Chiu > -Original Message- > From: Vitaly Cheptsov > Sent: Wednesday, May 13, 2020 1:02 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > ; Zeng, Star > Subject: [PATCH V5 15/27] IntelFsp2WrapperPkg: Add support for > DebugCommonLib > > RE

Re: [edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit

Reviewed-by: Chasel Chiu > -Original Message- > From: Esakkithevar, Kathappan > Sent: Wednesday, May 13, 2020 1:26 AM > To: devel@edk2.groups.io > Cc: Chaganty, Rangasai V ; Chiu, Chasel > ; Desimone, Nathaniel L > ; Kethi Reddy, Deepika > > Subject: [Patch V1 1/1] CometlakeOpenBoardP

[edk2-devel] [PATCH V4 5/6] MdeModulePkg: Add FMP Capsule Image Header extension

Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- MdeModulePkg/Application/CapsuleApp/CapsuleDump.c| 1 + .../Library/DxeCaps

[edk2-devel] [PATCH V4 2/6] MdePkg: Fix OUT parameters marked as IN OUT

Some OUT parameters in the specification were mistakenly marked as IN OUT. "IN OUT" replaced with "OUT" in the following interfaces EFI_BOOT_SERVICES.GetMemoryMap():MemoryMap EFI_BOOT_SERVICES.LocateHandleBuffer():NoHandles EFI_SIMPLE_POINTER_PROTOCOL.GetState():State EFI_ABSOLUTE_POINTER_PROTOCOL

[edk2-devel] [PATCH V4 0/6] Add definitions introduced in UEFI 2.8a

Following patches add/update structures/definitions, that were introduced/modified by UEFI Spec v.2.8 errata a from Feb 14. Oleksiy Yakovlev (6): MdePkg: Add new CPER Notification types MdePkg: Fix OUT parameters marked as IN OUT MdePkg: Add EFI_RT_PROPERTIES_TABLE MdePkg: Add FMP Capsule

[edk2-devel] [PATCH V4 3/6] MdePkg: Add EFI_RT_PROPERTIES_TABLE

Define Guid & data structure for EFI_RT_PROPERTIES_TABLE, designed to be published by a platform if it no longer supports all EFI runtime services once ExitBootServices() has been called by the OS. (UEFI 2.8 errata a, mantis 2049) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/RtPropert

[edk2-devel] [PATCH V4 6/6] SignedCapsulePkg: Add FMP Capsule Image Header extension

Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev --- .../RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 14 ++

[edk2-devel] [PATCH V4 4/6] MdePkg: Add FMP Capsule Image Header extension

Add bitmask to structure which gives a binary-inspectable mechanism to determine if a capsule contains an authentication section or depex section. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/FmpCapsule.h | 11 ++- 1 f

[edk2-devel] [PATCH V4 1/6] MdePkg: Add new CPER Notification types

Add SEA, SEI, and PEI CPER Notification types defined in UEFI 2.8 errata a. (UEFI 2.8 errata a, mantis 2026) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/Cper.h | 15 +++ MdePkg/MdePkg.dec | 9 + 2 files changed, 24 insertions(+)

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] BcmGenetDxe: fix reliability issues

On 5/12/20 11:57 PM, Samer El-Haj-Mahmoud wrote: Tested-by: Samer El-Haj-Mahmoud Pushed as 8977ff44a573..3698b912301b Thanks guys -Original Message- From: devel@edk2.groups.io On Behalf Of Andrei Warkentin via groups.io Sent: Tuesday, May 12, 2020 5:53 PM To: devel@edk2.groups.io

Re: [edk2-devel] [edk2-platforms][PATCH 1/1] BcmGenetDxe: fix reliability issues

Tested-by: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Andrei > Warkentin via groups.io > Sent: Tuesday, May 12, 2020 5:53 PM > To: devel@edk2.groups.io > Cc: Ard Biesheuvel ; l...@nuviainc.com; > p...@akeo.ie; phi...@redhat.com > Subject: [edk2-de

Re: [edk2-devel] [PATCH resend 0/7] Add support for MM communicate2 protocol (PI 1.7a)

On 5/11/20 4:32 PM, Gao, Liming wrote: OK. I have no other comment. This patch set is good to me. Reviewed-by: Liming Gao Series pushed as PR #606 Thanks all! -Original Message- From: Ard Biesheuvel Sent: Monday, May 11, 2020 10:10 PM To: Gao, Liming ; devel@edk2.groups.io Cc: K

[edk2-devel] [edk2-platforms][PATCH 1/1] BcmGenetDxe: fix reliability issues

- Failed TFTP boots - Failed HTTP boots The definite problem was that the incorrect PROD index was being written TX ring. The PROD index should be the TxProdIndex (on the scale of 0-0x), not the descriptor index (on the scale of 0-max descs). The other small things were suspect (mod 0x is

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Adding manifest support for submodule init

Pushed: 9106d381b5f22df819ed66e97d6a61f37747262e -Original Message- From: Bjorge, Erik C Sent: Tuesday, May 12, 2020 11:04 AM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATC

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Adding manifest support for submodule init

Reviewed-by: Ashley DeSimone -Original Message- From: Bjorge, Erik C Sent: Tuesday, May 12, 2020 11:04 AM To: devel@edk2.groups.io Cc: Desimone, Ashley E ; Desimone, Nathaniel L ; Pandya, Puja ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Addi

[edk2-devel] [PATCH] OvmfPkg: Skip initrd command on Xcode toolchain

OVMF booting stops with the assert if built with Xcode on macOS: Loading driver at 0x0001FAB8000 EntryPoint=0x0001FABF249 LinuxInitrdDynamicShellCommand.efi InstallProtocolInterface: BC62157E-3E33-4FEC-9920-2D3B36D750DF 1F218398 ProtectUefiImageCommon - 0x1F218140 - 0x1FAB8000 -

[edk2-devel] [PATCH v6 1/7] MdePkg: Extend SERIAL_IO with DeviceTypeGuid

EFI_SERIAL_IO_PROTOCOL_REVISION incremented to 0x00010001. CONST EFI_GUID *DeviceTypeGuid field added to the protocol structure. UEFI 2.8 mantis 1832. Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Protocol/SerialIo.h | 9 + 1 file changed, 9 insertions(+) diff --git a/MdePkg/Includ

[edk2-devel] [PATCH v6 0/7] Add definitions introduced in UEFI 2.8

Following patches add/update structures/definitions, that was introduced/modified by UEFI Spec v.2.8. Oleksiy Yakovlev (7): MdePkg: Extend SERIAL_IO with DeviceTypeGuid BaseTools: REST style formset MdePkg: REST style formset BaseTools: Bootable NVDIMM namespaces MdePkg: Bootable NVDI

[edk2-devel] [PATCH v6 5/7] MdePkg: Bootable NVDIMM namespaces

Provided a mechanism for UEFI FW to identify and hand off bootable NVDIMM namespaces to the OS by standardizing the EFI device path. EFI device path for physical NVDIMM devices changed from an ACPI _ADR device to an ACPI NVDIMM device for correctness. (UEFI 2.8 mantis 1858) Signed-off-by: Oleksiy

[edk2-devel] [PATCH v6 2/7] BaseTools: REST style formset

In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- BaseTools/Source/C/Include/Common/UefiInternalFormRepresentation.h | 1 + 1 file changed, 1 insertion(+) diff --git a/BaseTools/Source/C/Includ

[edk2-devel] [PATCH v6 3/7] MdePkg: REST style formset

New ClassGuid EFI_HII_REST_STYLE_FORMSET_GUID is defined. In question level, a new flag EFI_IFR_FLAG_REST_STYLE is defined. (UEFI 2.8 mantis 1853) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Guid/HiiPlatformSetupFormset.h| 4 MdePkg/Include/Uefi/Uefi

[edk2-devel] [PATCH v6 6/7] MdePkg: Add UEFI Spec Revision 2.8

Added entrie in the EFI_SYSTEM_TABLE related definitions section, to signify UEFI 2.8 spec revision. (UEFI 2.8 mantis 1926) Signed-off-by: Oleksiy Yakovlev Reviewed-by: Liming Gao --- MdePkg/Include/Uefi/UefiSpec.h | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Include/Uefi/UefiSpe

[edk2-devel] [PATCH v6 7/7] MdePkg: UEFI JSON Capsule Support

Added Guids and structures, that defines the work flow to perform capsule update using JSON objects. (UEFI 2.8 mantis 1935) Signed-off-by: Oleksiy Yakovlev --- MdePkg/Include/Guid/CapsuleReport.h | 29 +++ MdePkg/Include/Guid/JsonCapsule.h | 98 + Md

[edk2-devel] [PATCH v6 4/7] BaseTools: Bootable NVDIMM namespaces

Provided a mechanism for UEFI FW to identify and hand off bootable NVDIMM namespaces to the OS by standardizing the EFI device path. EFI device path for physical NVDIMM devices changed from an ACPI _ADR device to an ACPI NVDIMM device for correctness. (UEFI 2.8 mantis 1858) Signed-off-by: Oleksiy

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list

Reviewed-by: Prince Agyeman -Original Message- From: Desimone, Ashley E Sent: Tuesday, May 12, 2020 11:45 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update r

Re: [edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list

Reviewed-by: Erik Bjorge -Original Message- From: Desimone, Ashley E Sent: Tuesday, May 12, 2020 11:45 AM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Pandya, Puja ; Bjorge, Erik C ; Bret Barkelew ; Agyeman, Prince Subject: [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update retu

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

On 5/12/20 12:44 PM, Tom Lendacky wrote: On 5/12/20 11:49 AM, Tom Lendacky wrote: On 5/9/20 2:09 PM, Andrew Fish wrote: On May 9, 2020, at 7:34 AM, Lendacky, Thomas > wrote: On 5/9/20 1:44 AM, Ni, Ray wrote: Tom, Hi Ray, I have a bit concern on your chang

[edk2-devel] [edk2-platforms: PATCH 0/3] Marvell UTMI fixes

Hi, This patchset introduces fixes to the UTMI part of the XHCI interfaces found in Armada/CN913x SoC families, as well as improves the analog PHY settings. The details can be found in the commit logs. The patches are available in the public git branch: https://github.com/Semihalf/edk2-platforms/

[edk2-devel] [edk2-platforms: PATCH 3/3] Marvell/Library: UtmiLib: Fix USB mux configuration

If UTMI connected to USB Device, the MUX must be configured prior to the PHY init. Add missing register update in the relevant code. Signed-off-by: Marcin Wojtas --- Silicon/Marvell/Library/UtmiPhyLib/UtmiPhyLib.c | 1 + 1 file changed, 1 insertion(+) diff --git a/Silicon/Marvell/Library/UtmiPh

[edk2-devel] [edk2-platforms: PATCH 1/3] Marvell/Library: UtmiLib: update USB2.0 analog settings

This patch introduce following modifications, allowing to overcome the instabilities observed with certain USB2.0 endpoints: * Add additional step which enables the Impedance and PLL calibration. * Enable old squelch detector instead of the new analog squelch detector circuit and update host disc

[edk2-devel] [edk2-platforms: PATCH 2/3] Marvell/Library: UtmiLib: fix pll initialization for the second port

According to Design Reference Specification the PHY PLL and Calibration register from PHY0 are shared for multi-port PHY. PLL control registers inside other PHY channels are not used. This fixes issues in scenarios when only UTMI port1 was in use, which resulted with lack of correct PLL initializa

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

Mike, I see what you mean here, but I believe it is absolutely fine to implement DebugCommonLib.h interface within DebugLib without depending on DebugCommonLib if one absolutely desires it (thought I do not think it is a good idea). In this case, perhaps we can avoid adding DebugCommonLib.h head

[edk2-devel] [edk2-staging/EdkRepo] [PATCH] EdkRepo: Update return values of manifest_repo_list

Update the manifest_repo_list property to return an empty list if no [manifest-repos] section was present in the config file. Signed-off-by: Ashley E Desimone Cc: Nate DeSimone Cc: Puja Pandya Cc: Erik Bjorge Cc: Bret Barkelew Cc: Prince Agyeman --- edkrepo/config/config_factory.py | 2 ++

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

Laszlo, A library implementation that uses another library class lists those library classes in the library INF. This is a way a module can inherit the use of a second lib without listing the second lib in the module INF. This is the type of inheritance that is supported by the EDK II build sys

[edk2-devel] [edk2-staging/EdkRepo] [PATCH v1] EdkRepo: Adding manifest support for submodule init

Enabling support for selective submodule initialization in the manifest file. This will allow for more control over the submodules that are initialized. If this section is not present the existing functionality will be used. Signed-off-by: Erik Bjorge Cc: Ashley E Desimone Cc: Nate DeSimone C

Re: [edk2-devel] BDS Phase Output Menu

On 5/12/20 11:23 AM, Andrew Fish via groups.io wrote: For OVMF I think you get the menu if you exit the UEFI Shell. On other platform it works like the old BIOS Setup so you have to hold some vendor specific snag key on boot? I wonder if Jim meant the BootManagerMenuApp from ./MdeModulePkg/Ap

Re: [edk2-devel] [PATCH v7 00/43] SEV-ES guest support

On 5/12/20 11:49 AM, Tom Lendacky wrote: On 5/9/20 2:09 PM, Andrew Fish wrote: On May 9, 2020, at 7:34 AM, Lendacky, Thomas > wrote: On 5/9/20 1:44 AM, Ni, Ray wrote: Tom, Hi Ray, I have a bit concern on your change that directly modifies CpuExceptionHand

Re: [edk2-devel] BDS Phase Output Menu

On 5/12/20 11:23 AM, Andrew Fish via groups.io wrote: For OVMF I think you get the menu if you exit the UEFI Shell. On other platform it works like the old BIOS Setup so you have to hold some vendor specific snag key on boot? On OVMF you can run "exit" or "reset -fwui" in the UEFI Shell, or p

[edk2-devel] [Patch V1 1/1] CometlakeOpenBoardPkg: Fix build error due to Ddr4MixedUDimm2DpcLimit

The Ddr4MixedUDimm2DpcLimit FSP-M Upd has been renamed as Ddr4Mixed2DpcLimit at CometLakeFspBinPkg\CometLake1. FSP wrapper driver need to use FSP-M Upd name Ddr4Mixed2DpcLimit from CometLake1 FSP at CometlakeOpenBoardPkg. REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2714 Signed-off-by: Kath

Re: [edk2-devel] BDS Phase Output Menu

> On May 12, 2020, at 10:06 AM, jim slaughter > wrote: > > Hello, > > I have seen a menu displayed to select which OS you boot (long time ago). > I was told it was from the BDS phase. > How do I turn on this feature or is that vendor specific? Jim, For OVMF I think you get the menu if you ex

Re: [edk2-devel] [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4

On 5/12/20 7:15 PM, Leif Lindholm wrote: On Tue, May 12, 2020 at 18:41:17 +0200, Ard Biesheuvel wrote: This is a followup to Samer's v1 [0], and incorporates all the delta changes posted for review over the past couple of days. This is a roundup of all that work, and therefore supersedes it. It

Re: [edk2-devel] [PATCH v2 00/12] Add the VariablePolicy feature

While most of the feedback in the series is relevant for the author (Bret), this is a change I will make for the patches I generate. Thanks, Michael On 5/12/2020 5:37 AM, Laszlo Ersek wrote: On 05/12/20 14:15, Laszlo Ersek wrote: On 05/12/20 13:52, Laszlo Ersek wrote: On 05/12/20 08:46, Mich

Re: [edk2-devel] [PATCH resend 3/7] ArmPkg/MmCommunicationDxe: expose MM Communicate 2 protocol

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59346): https://edk2.groups.io/g/devel/message/59346 Mute This Topic: https://groups.io/mt/74033569/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH edk2-platforms v3 0/8] Add Broadcom GENET driver for RPi4

On Tue, May 12, 2020 at 18:41:17 +0200, Ard Biesheuvel wrote: > This is a followup to Samer's v1 [0], and incorporates all the delta > changes posted for review over the past couple of days. This is a > roundup of all that work, and therefore supersedes it. > > It provides an implementation of the

Re: [edk2-devel] [PATCH resend 7/7] StandaloneMmPkg: switch to MM communicate 2 protocol

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59343): https://edk2.groups.io/g/devel/message/59343 Mute This Topic: https://groups.io/mt/74033577/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH resend 6/7] MdeModulePkg/VariableSmmRuntimeDxe: switch to MM communicate 2

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59342): https://edk2.groups.io/g/devel/message/59342 Mute This Topic: https://groups.io/mt/74033576/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH resend 2/7] MdeModulePkg/SmmIpl: expose MM communicate 2 protocol

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59339): https://edk2.groups.io/g/devel/message/59339 Mute This Topic: https://groups.io/mt/74033565/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH resend 5/7] MdeModulePkg/FaultTolerantWriteSmmDxe: switch to MM communicate 2

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59341): https://edk2.groups.io/g/devel/message/59341 Mute This Topic: https://groups.io/mt/74033575/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH resend 4/7] MdeModulePkg/VariableInfo: switch to MM communicate 2 protocol

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59340): https://edk2.groups.io/g/devel/message/59340 Mute This Topic: https://groups.io/mt/74033571/21656 Group Owner: devel+ow...@edk2.grou

Re: [edk2-devel] [PATCH resend 1/7] MdePkg: introduce MM communicate 2 protocol

Reviewed-by: Sami Mujawar Regards, Sami Mujawar -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#59338): https://edk2.groups.io/g/devel/message/59338 Mute This Topic: https://groups.io/mt/74033564/21656 Group Owner: devel+ow...@edk2.grou

[edk2-devel] BDS Phase Output Menu

Hello, I have seen a menu displayed to select which OS you boot (long time ago). I was told it was from the BDS phase. How do I turn on this feature or is that vendor specific? Thanks. -- Jim Slaughter -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/R

[edk2-devel] [PATCH V5 11/27] EmulatorPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jordan Justen CC: Andrew Fish CC: Ray Ni Signed-off-by: Vitaly Cheptsov --- EmulatorPkg/EmulatorPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc index 1fc924ae5a..

[edk2-devel] [PATCH V5 18/27] ShellPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 Signed-off-by: Vitaly Cheptsov --- ShellPkg/ShellPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ShellPkg/ShellPkg.dsc b/ShellPkg/ShellPkg.dsc index b7ee856b3a..27b148e6b2 100644 --- a/ShellPkg/ShellPkg.dsc +++ b/ShellPkg/Shell

[edk2-devel] [PATCH V5 02/27] UnitTestFrameworkPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Michael D Kinney CC: Sean Brogan CC: Bret Barkelew Signed-off-by: Vitaly Cheptsov --- UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/DebugLibPosix.c | 94 UnitTestFrameworkPkg/Library/Posix/DebugLibPosix/De

[edk2-devel] [PATCH V5 24/27] UefiCpuPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Eric Dong CC: Ray Ni CC: Laszlo Ersek Signed-off-by: Vitaly Cheptsov --- UefiCpuPkg/UefiCpuPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/UefiCpuPkg/UefiCpuPkg.dsc b/UefiCpuPkg/UefiCpuPkg.dsc index d28cb5cccb..f5f407ad2

[edk2-devel] [PATCH V5 27/27] MdePkg: Use assertion on constraint violation bit in SafeString

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This change allows using SafeString interfaces for untrusted data checking when constraint violation assertions are disabled. Note, for packages with constraint assertions disabled this change turn off the assertions on constraint violation

[edk2-devel] [PATCH V5 06/27] ArmPlatformPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Leif Lindholm CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- ArmPlatformPkg/ArmPlatformPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/ArmPlatformPkg/ArmPlatformPkg.dsc b/ArmPlatformPkg/ArmPlatformPkg.dsc index 53

[edk2-devel] [PATCH V5 15/27] IntelFsp2WrapperPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Chasel Chiu CC: Nate DeSimone CC: Star Zeng Signed-off-by: Vitaly Cheptsov --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dsc b/IntelFsp2W

[edk2-devel] [PATCH V5 17/27] NetworkPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Maciej Rabeda CC: Jiaxin Wu CC: Siyuan Fu Signed-off-by: Vitaly Cheptsov --- NetworkPkg/NetworkPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/NetworkPkg/NetworkPkg.dsc b/NetworkPkg/NetworkPkg.dsc index 503d828f91..6018b

[edk2-devel] [PATCH V5 20/27] PcAtChipsetPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ray Ni Signed-off-by: Vitaly Cheptsov --- PcAtChipsetPkg/PcAtChipsetPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/PcAtChipsetPkg/PcAtChipsetPkg.dsc b/PcAtChipsetPkg/PcAtChipsetPkg.dsc index 01a3ee716a..89d66744eb 100644

[edk2-devel] [PATCH V5 12/27] FatPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ray Ni Signed-off-by: Vitaly Cheptsov --- FatPkg/FatPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/FatPkg/FatPkg.dsc b/FatPkg/FatPkg.dsc index d86256068b..f811964085 100644 --- a/FatPkg/FatPkg.dsc +++ b/FatPkg/FatPkg.dsc

[edk2-devel] [PATCH V5 05/27] ArmPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Leif Lindholm CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc | 1 + ArmPkg/Library/SemiHostingDebug

[edk2-devel] [PATCH V5 01/27] MdePkg: Introduce DebugCommonLib interface and BaseDebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This library allows to make a common part of all DebugLib instances and avoid the need to update every DebugLib on extending a new debug mask PCD bit. CC: Michael D Kinney CC: Liming Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Include

[edk2-devel] [PATCH V5 16/27] OvmfPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jordan Justen CC: Laszlo Ersek CC: Ard Biesheuvel Signed-off-by: Vitaly Cheptsov --- OvmfPkg/Library/PlatformDebugLibIoPort/DebugLib.c | 98 OvmfPkg/Library/PlatformDebugLibIoPort/Plat

[edk2-devel] [PATCH V5 23/27] StandaloneMmPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Ard Biesheuvel CC: Sami Mujawar CC: Jiewen Yao CC: Supreeth Venkatesh Signed-off-by: Vitaly Cheptsov --- StandaloneMmPkg/StandaloneMmPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/StandaloneMmPkg/StandaloneMmPkg.dsc b

[edk2-devel] [PATCH V5 08/27] CryptoPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jian J Wang CC: Xiaoyu Lu Signed-off-by: Vitaly Cheptsov --- CryptoPkg/CryptoPkg.dsc | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CryptoPkg/CryptoPkg.dsc b/CryptoPkg/CryptoPkg.dsc index f79ff331cf..72c8429c0a 100644 --- a/Cr

[edk2-devel] [PATCH V5 00/27] Disabling safe string constraint assertions

CC: Michael Kinney CC: Laszlo Ersek CC: Andrew Fish CC: Marvin Häuser CC: Liming Gao CC: Zhichao Gao This changeset hopefully finally resolves the longstanding https://bugzilla.tianocore.org/show_bug.cgi?id=2054 V5 changeset addressed the review comments of V4. For more details see: https:/

[edk2-devel] [PATCH V5 09/27] DynamicTablesPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Sami Mujawar CC: Alexei Fedorov Signed-off-by: Vitaly Cheptsov --- DynamicTablesPkg/DynamicTablesPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc b/DynamicTablesPkg/DynamicTablesPkg.d

[edk2-devel] [PATCH V5 04/27] MdeModulePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jian J Wang CC: Hao A Wu Signed-off-by: Vitaly Cheptsov --- MdeModulePkg/Library/PeiDebugLibDebugPpi/DebugLib.c | 100 MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebug

[edk2-devel] [PATCH V5 25/27] UefiPayloadPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Maurice Ma CC: Guo Dong CC: Benjamin You Signed-off-by: Vitaly Cheptsov --- UefiPayloadPkg/UefiPayloadPkgIa32.dsc| 1 + UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc | 1 + 2 files changed, 2 insertions(+) diff --git a/UefiPayloadPk

[edk2-devel] [PATCH V5 26/27] MdePkg: Introduce assertion on constraint debug mask bit

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 This bit allows to control assertion on constraint violation. CC: Michael D Kinney CC: Liming Gao Signed-off-by: Vitaly Cheptsov --- MdePkg/Include/Library/DebugCommonLib.h| 18 ++ MdePkg/Include/Library/Debu

[edk2-devel] [PATCH V5 22/27] SourceLevelDebugPkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Hao A Wu Signed-off-by: Vitaly Cheptsov --- SourceLevelDebugPkg/SourceLevelDebugPkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc b/SourceLevelDebugPkg/SourceLevelDebugPkg.dsc ind

[edk2-devel] [PATCH V5 21/27] SignedCapsulePkg: Add support for DebugCommonLib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2054 CC: Jiewen Yao CC: Chao Zhang Signed-off-by: Vitaly Cheptsov --- SignedCapsulePkg/SignedCapsulePkg.dsc | 1 + 1 file changed, 1 insertion(+) diff --git a/SignedCapsulePkg/SignedCapsulePkg.dsc b/SignedCapsulePkg/SignedCapsulePkg.dsc ind

Re: [edk2-devel] [PATCH V4 00/27] Disabling safe string constraint assertions

Hello everyone, Let me try in order. After an internal review I added the following to SafeString commit message: Note, for packages with constraint assertions disabled this change turn off the assertions on constraint violations. This is obvious, and I believe everyone agreed it is not healthy e

  1   2   >