[edk2-devel] [PATCH 4/6] MdeModulePkg/DxeIplPeim: Register for shadow on S3 shadowed boot (CVE-2019-11098)

From: Jian J Wang REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Cc: Jian J Wang Cc: Hao A Wu Cc: Dandan Bi Cc: Liming Gao Signed-off-by: Jian J Wang --- MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 3 +++ MdeModulePkg/Core/DxeIplPeim/DxeLoad.c | 2 +- 2 files changed, 4 insertions(

[edk2-devel] [PATCH 0/6] Migrate Pointer from flash to permanent memory (CVE-2019-11098)

The TOCTOU vulnerability allow that the physical present person to replace the code with the normal BootGuard check and PCR0 value. The issue occur when BootGuard measure IBB and access flash code after NEM disable. the reason why we access the flash code is that we have some pointer to flash. To

[edk2-devel] [PATCH 3/6] UefiCpuPkg/SecMigrationPei: Add initial PEIM (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Adds a PEIM that republishes structures produced in SEC. This is done because SEC modules may not be shadowed in some platforms due to space constraints or special alignment requirements. The SecMigrationPei module loc

[edk2-devel] [PATCH 1/6] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Introduces new changes to PeiCore to move the contents of temporary RAM visible to the PeiCore to permanent memory. This expands on pre-existing shadowing support in the PeiCore to perform the following additional acti

[edk2-devel] [PATCH 5/6] MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098)

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 When we allocate pool to save rebased the PEIMs, the address will change randomly, therefore the hash will change and result PCR0 change as well. To avoid this, we save the raw PEIMs and use it to calculate hash. Cc: Jian J Wang Cc: Hao A W

[edk2-devel] [PATCH 2/6] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

From: Michael Kubacki REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 Moves the GDT and IDT to permanent memory in a memory discovered callback. This is done to ensure the GDT and IDT authenticated in pre-memory is not fetched from outside a verified location after the permanent memory t

[edk2-devel] [PATCH 6/6] SecurityPkg/Tcg2Pei: Use Migrated FV Info Hob for calculating hash (CVE-2019-11098)

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 When we allocate pool to save rebased the PEIMs, the address will change randomly, therefore the hash will change and result PCR0 change as well. To avoid this, we save the raw PEIMs and use it to calculate hash. The Tcg2Pei calculate the has

Re: [edk2-devel] [PATCH] FmpDevicePkg: Enhance capsule verification with secure boot keys

Liming, The end user have the ability to enroll their DB without too many effort. And I think some end user also have the ability to get insecure firmware which not from the device vendor. I suggest that tell the device vendor that it is critical that set the PcdFmpDevicePkcs7CertBufferXdr rat

[edk2-devel] [PATCH v1 1/2] EmbeddedPkg: Fix build error for MmcDxe

From: Pierre Gondois The following command line: build -b NOOPT -a IA32 -t VS2017 -p edk2\EmbeddedPkg\EmbeddedPkg.dsc Generates the following error: MmcDxe.lib(Diagnostics.obj) : error LNK2001: unresolved external symbol __allshl MmcDxe.lib(Diagnostics.obj) : error LNK2001: unresolved external s

[edk2-devel] [PATCH v1 0/2] Fix VS2017 build errors

Building edk2\EmbeddedPkg\EmbeddedPkg.dsc with VS2017 triggered some errors. This patch set is intended to fix them. The changes can be seen at: https://github.com/PierreARM/edk2/commits/831_Fix_VS2017_build_error_v1 Pierre Gondois (2): EmbeddedPkg: Fix build error for MmcDxe EmbeddedPkg: Ad

[edk2-devel] [PATCH v1 2/2] EmbeddedPkg: Add cast from (void*) for VS2017 build

From: Pierre Gondois The following build configrations: build -b DEBUG -a AARCH64 -t VS2017 -p edk2\EmbeddedPkg\EmbeddedPkg.dsc build -b NOOPT -a AARCH64 -t VS2017 -p edk2\EmbeddedPkg\EmbeddedPkg.dsc build -b RELEASE -a AARCH64 -t VS2017 -p edk2\EmbeddedPkg\EmbeddedPkg.dsc are generating the fol

Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file

Hi Pierre, I think we need to update the PatchCheck.py script. The comments says, "Do not enforce CR/LF line endings for linux shell scripts.", but that only check the file ext is .sh is not enough. if self.filename.endswith('.sh'): # # Do not enforce CR/

Re: [edk2-devel] [PATCH v1 2/3] DynamicTablesPkg: Add EDK2 Core CI support

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61834): https://edk2.groups.io/g/devel/message/61834 Mute This Topic: https://groups.io/mt/75191115/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 1/3] DynamicTablesPkg: Fix issues reported by EDKII CI

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61837): https://edk2.groups.io/g/devel/message/61837 Mute This Topic: https://groups.io/mt/75191113/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 3/3] .pytool: CI Settings to support DynamicTablesPkg

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61835): https://edk2.groups.io/g/devel/message/61835 Mute This Topic: https://groups.io/mt/75191117/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

Re: [edk2-devel] [PATCH v1 0/3] Add EDKII CI support for DynamicTablesPkg

Reviewed-by: Alexei Fedorov -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#61836): https://edk2.groups.io/g/devel/message/61836 Mute This Topic: https://groups.io/mt/75191110/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: htt

[edk2-devel] [PATCH v5 01/15] .pytool/Plugin: Add a plugin EccCheck

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 EccCheck is a plugin to report Ecc issues for code in pull request , which will be run on open ci. But note not each kind of issue could be reported out. It can only handle the issues, whose line number in CSV report accurately map with their

[edk2-devel] [PATCH v5 02/15] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MdeMo

[edk2-devel] [PATCH v5 00/15] Add a plugin to check Ecc issues for edk2 on open ci

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now. I appreciate receiving feedback and comments if someone find errors or false positive issues. I created a pipline of EccCheck for my forked edk2. https://dev.azu

[edk2-devel] [PATCH v5 04/15] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- CryptoPkg/CryptoPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(

[edk2-devel] [PATCH v5 03/15] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +++ 1 file

[edk2-devel] [PATCH v5 10/15] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.ci.yaml | 11 +++ 1 file chang

[edk2-devel] [PATCH v5 08/15] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdePkg/MdePkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MdePkg/Mde

[edk2-devel] [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Shenglei Zhang --- EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) dif

[edk2-devel] [PATCH v5 09/15] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Shenglei Zhang Reviewed-by: Maciej Rabeda --- NetworkPkg/NetworkPkg.ci.yaml | 11 +++ 1 file cha

[edk2-devel] [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff -

[edk2-devel] [PATCH v5 07/15] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v5 12/15] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- SecurityPkg/SecurityPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) di

[edk2-devel] [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v5 15/15] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Shenglei Zhang --- UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10 ++ 1 file cha

[edk2-devel] [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang Acked-by: Zhichao gao --- ShellPkg/ShellPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff

[edk2-devel] [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- FatPkg/FatPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/FatPkg/Fa

Re: [edk2-devel] [PATCH edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

在 2020/6/30 8:58, Jiang, Guomin 写道: > Hi Huang, > >>From issue statement, I guess that > 1. AutoUpdateLangVariable() invoked, and it will invoke FindVariable() first, > at the same time, reclaim occur and Variable.CurrPtr is invalid, it return > with success > 2. UpdateVariable() is invoked w

Re: [edk2-devel] [PATCH] FmpDevicePkg: Enhance capsule verification with secure boot keys

Thanks Guomin. I still have one question. Let's assume we're the device vendor and we let customer to enroll their keys. Once the keys are enrolled, the device will be in secure boot mode. Are you saying that the end user could "have the ability to enroll their DB without too many effort" even

Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file

I agree that PatchCheck.py needs to be updated. However, this is difficult for PatchCheck.py to know whether a file should be allowed to have LF line endings or not. Some files currently in edk2 have LF line endings and: - have a ".sh" extension (EmulatorPkg/build.sh), some other don't (BaseToo

Re: [edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/30/2020 6:30pm-7:30pm #cal-reminder

Those bugs will be discussed this week. 2830 EDK2 Code unassig...@tianocore.org UNCO --- ECC parse struct member include keyword string issue 02:29:18 2829

[edk2-devel] [PATCH v1] BaseTools: Add gcc flag to warn on void* pointer arithmetic

From: Pierre Gondois By default, gcc allows void* pointer arithmetic. This is a GCC extension. However: - the C reference manual states that void* pointer "cannot be operands of addition or subtraction operators". Cf s5.3.1 "Generic Pointers"; - Visual studio compiler treat such operat

Re: [EXTERNAL] [edk2-devel] [PATCH v1] BaseTools: Add gcc flag to warn on void* pointer arithmetic

Reviewed-by: Bret Barkelew - Bret From: PierreGondois via groups.io Sent: Tuesday, June 30, 2020 8:24 AM To: devel@edk2.groups.io Cc: Pierre Gondois; Feng, Bob C; li

Re: [edk2-devel] [PATCH v1] BaseTools: Add gcc flag to warn on void* pointer arithmetic

It looks like GCC5_X64_CC_FLAGS pick up GCC48_ALL_CC_FLAGS as the lowest level flag list, so this change will not apply to compilations on the X64 architecture. That said, I suspect that X64 architecture will likely have the biggest issues with disallowing void* arithmetic, so we either: 1. Me

Re: [edk2-devel] [edk2][PATCH 1/1] MdeModulePkg/UefiBootManagerLib: Signal ReadyToBoot on platform recovery

Please note that I have created a bug report (https://bugzilla.tianocore.org/show_bug.cgi?id=2831) to address the non-compliance issue was raised during the course of the discussion below. Regards, /Pete On 2020.06.17 18:06, Samer El-Haj-Mahmoud wrote: I worked with Pete offline on this..

Re: [edk2-devel] [PATCH v1 0/3] Add EDKII CI support for DynamicTablesPkg

Hi Sean, Thank you for the inputs. Please find my response inline marked [SAMI]. Regards, Sami Mujawar -Original Message- From: Sean Brogan Sent: 29 June 2020 07:56 PM To: devel@edk2.groups.io; Sami Mujawar Cc: Alexei Fedorov ; sean.bro...@microsoft.com; liming@intel.com; micha

[edk2-devel] [PATCH v2 0/3] Add EDKII CI support for DynamicTablesPkg

The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules. This patch series adds support for building DynamicTablesPkg using the EKDII Core CI. The review feedback from the v1 series has also been addressed. The changes can be seen at: https://gi

[edk2-devel] [PATCH v2 3/3] .pytool: CI Settings to support DynamicTablesPkg

Update pytools configuration to enable DynamicTablesPkg and update package status in documentation. Signed-off-by: Sami Mujawar --- Notes: v2: - No change, resend patch with v2 series [Sami] v1: - Add CI settings to support DynamicTablesPkg [Sami] .p

[edk2-devel] [PATCH v2 1/3] DynamicTablesPkg: Fix issues reported by EDKII CI

The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules: * https://pypi.org/project/edk2-pytool-library/ * https://pypi.org/project/edk2-pytool-extensions/ More information on configuring the environment and running the builds can be found in edk

[edk2-devel] [PATCH v2 4/4] .azurepipelines: Add DynamicTablesPkg to CI matrix

Add DynamicTablesPkg to the Core CI matrix. Signed-off-by: Sami Mujawar Suggested-by: Sean Brogan --- Notes: v2: - New patch in series to add DynamicTablesPkg to Core CI matrix [Sami] - Add DynamicTablesPkg to Core CI matrix [Sean] .azurepipelines/templa

[edk2-devel] [PATCH v2 2/3] DynamicTablesPkg: Add EDK2 Core CI support

The TianoCore EDKII project has introduced a Core CI infrastructure using TianoCore EDKII Tools PIP modules: * https://pypi.org/project/edk2-pytool-library/ * https://pypi.org/project/edk2-pytool-extensions/ The edk2\.pytool\Readme.md provides information to configure the environment and to ru

Re: [edk2-devel] [PATCH V2 3/3] UefiCpuPkg: Add New Memory Attributes

Hi Laszlo. I think WP should be included also. Spec says that WP "typically used as a cacheability attribute today". Do you want me to submit just additional patch for CpuDxe.h, or resubmit the whole series adding this inclusion of WP to EFI_MEMORY_CACHETYPE_MASK in CpuDxe.h? Regards, Oleksi

Re: [edk2-devel] [PATCH v1 1/1] MdePkg : UefiFileHandleLib: fix buffer overrun in FileHandleReadLine()

Hi Zhiguang, Thank you for reviewing my commit. I thought, the variable was used only once in the if {} statement, so had it declared only there. I will declare it in the beginning of the function if it is a standard. Will submit patch v2. Thank you, Vladimir > -Original Message- > From:

Re: [edk2-devel] [PATCH edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

So I think the key point is why AutoUpdateLangVariable() return success rather than fail, if is it reasonable for this case or we need other error handing? I am glad to help you but I can't reproduce it until now, can you provide a step to reproduce it in simulation platform. If it is urgent, I

Re: [edk2-devel] [PATCH] FmpDevicePkg: Enhance capsule verification with secure boot keys

I want to ask your one question: are you sure that every mother board which deliver to customer will enable the secure boot mode? I just emphasize that I want to make sure that the device firmware come from the device vendor. Thanks for your effort, the patch is good, I just think it is not sui

Re: [edk2-devel] [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

Acked-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, June 30, 2020 8:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Gao, Zhichao > Subject: [PATCH v5 13/15] ShellPkg/ShellPkg.ci.yaml: Add configuration for > Ecc check > > Add configuration ExceptionList and

Re: [edk2-devel] [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

Acked-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, June 30, 2020 8:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [PATCH v5 06/15] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc > check > > Add configuration ExceptionList and IgnoreFiles for pa

Re: [edk2-devel] [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check

Acked-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, June 30, 2020 8:00 PM > To: devel@edk2.groups.io > Cc: Justen, Jordan L ; Andrew Fish > ; Ni, Ray > Subject: [PATCH v5 05/15] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration > for Ecc check > > Add conf

Re: [edk2-devel] [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check

Acked-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, June 30, 2020 8:00 PM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Laszlo > Ersek > Subject: [PATCH v5 14/15] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration > for Ecc check > > Add configurati

Re: [edk2-devel] [PATCH v3 0/4] Compile AML bytecode array into OBJ file

Hi Pierre, Yes. if the patch set can't pass CI, it can't be merged. I think we can add a check for the file path. The scripts under BinWrappers\PosixLike are all linux shell scripts. Thanks, Bob -Original Message- From: devel@edk2.groups.io On Behalf Of PierreGondois Sent: Tuesday, J

Re: [edk2-devel] [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

Acked-by: Ray Ni > -Original Message- > From: Zhang, Shenglei > Sent: Tuesday, June 30, 2020 8:00 PM > To: devel@edk2.groups.io > Cc: Ni, Ray > Subject: [PATCH v5 11/15] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add > configuration for Ecc check > > Add configuration ExceptionList and Ig

[edk2-devel] Upcoming Event: TianoCore Bug Triage - APAC / NAMO - Tue, 06/30/2020 6:30pm-7:30pm #cal-reminder

*Reminder:* TianoCore Bug Triage - APAC / NAMO *When:* Tuesday, 30 June 2020, 6:30pm to 7:30pm, (GMT-07:00) America/Los Angeles *Where:* https://bluejeans.com/889357567?src=join_info View Event ( https://edk2.groups.io/g/devel/viewevent?eventid=816014 ) *Organizer:* Brian Richardson brian.richa

[edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 As planed we will enable Ecc check for edk2 on open ci. And they are ready now. I appreciate receiving feedback and comments if someone find errors or false positive issues. I created a pipline of EccCheck for my forked edk2. Welcome everyon

[edk2-devel] [PATCH v6 15/16] UefiCpuPkg/UefiCpuPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Eric Dong Cc: Ray Ni Cc: Laszlo Ersek Signed-off-by: Shenglei Zhang Acked-by: Ray Ni --- UefiCpuPkg/UefiCpuPkg.ci.yaml | 11 +++ 1 file changed, 11 inser

[edk2-devel] [PATCH v6 02/16] .pytool/Plugin: Add a plugin EccCheck

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2606 EccCheck is a plugin to report Ecc issues for code in pull request , which will be run on open ci. But note not each kind of issue could be reported out. It can only handle the issues, whose line number in CSV report accurately map with their

[edk2-devel] [PATCH v6 01/16] pip-requirements.txt: Add Ecc required lib

antlr4-python3-runtime is a lib to support Ecc run with Py3.x. Cc: Sean Brogan Cc: Bret Barkelew Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- pip-requirements.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/pip-requirements.txt b/pip-requirements.txt index 57

[edk2-devel] [PATCH v6 04/16] ArmVirtPkg/ArmVirtPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- ArmVirtPkg/ArmVirtPkg.ci.yaml | 11 +++ 1 file

[edk2-devel] [PATCH v6 06/16] EmulatorPkg/EmulatorPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Shenglei Zhang Acked-by: Ray Ni --- EmulatorPkg/EmulatorPkg.ci.yaml | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v6 10/16] NetworkPkg/NetworkPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Maciej Rabeda Cc: Jiaxin Wu Cc: Siyuan Fu Signed-off-by: Shenglei Zhang Reviewed-by: Maciej Rabeda --- NetworkPkg/NetworkPkg.ci.yaml | 11 +++ 1 file cha

[edk2-devel] [PATCH v6 09/16] MdePkg/MdePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Shenglei Zhang --- MdePkg/MdePkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/MdePkg/Mde

[edk2-devel] [PATCH v6 05/16] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jian J Wang Cc: Xiaoyu Lu Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- CryptoPkg/CryptoPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(

[edk2-devel] [PATCH v6 03/16] MdeModulePkg/MdeModulePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Change-Id: I55c78eed392a8354a7201d17a591e4ff8dc3d6e9 Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Shenglei Zhang --- MdeModulePkg/MdeModulePkg.ci.yaml | 11 +++

[edk2-devel] [PATCH v6 14/16] ShellPkg/ShellPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Shenglei Zhang Acked-by: Ray Ni --- ShellPkg/ShellPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git

[edk2-devel] [PATCH v6 11/16] OvmfPkg/OvmfPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Shenglei Zhang Acked-by: Laszlo Ersek --- OvmfPkg/OvmfPkg.ci.yaml | 11 +++ 1 file chang

[edk2-devel] [PATCH v6 07/16] FatPkg/FatPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- FatPkg/FatPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/FatPkg/Fa

[edk2-devel] [PATCH v6 08/16] FmpDevicePkg/FmpDevicePkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Shenglei Zhang Reviewed-by: Guomin Jiang --- FmpDevicePkg/FmpDevicePkg.ci.yaml | 11 +++ 1 file changed, 11

[edk2-devel] [PATCH v6 12/16] PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Ray Ni Signed-off-by: Shenglei Zhang Acked-by: Ray Ni --- PcAtChipsetPkg/PcAtChipsetPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) diff --git a/Pc

[edk2-devel] [PATCH v6 16/16] UnitTestFrameworkPkg: Add configuration for Ecc check in yaml file

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Michael D Kinney Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Shenglei Zhang Acked-by: Ray Ni --- UnitTestFrameworkPkg/UnitTestFrameworkPkg.ci.yaml | 10

[edk2-devel] [PATCH v6 13/16] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check

Add configuration ExceptionList and IgnoreFiles for package config files. So users can rely on this to ignore some Ecc issues. Cc: Jiewen Yao Cc: Jian J Wang Cc: Chao Zhang Signed-off-by: Shenglei Zhang --- SecurityPkg/SecurityPkg.ci.yaml | 11 +++ 1 file changed, 11 insertions(+) di

Re: [edk2-devel] [PATCH v6 13/16] SecurityPkg/SecurityPkg.ci.yaml: Add configuration for Ecc check

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: devel@edk2.groups.io On Behalf Of Zhang, > Shenglei > Sent: Wednesday, July 01, 2020 9:55 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Chao B > Subject: [edk2-devel] [PATCH v6 13/16] Secu

Re: [edk2-devel] [PATCH v6 05/16] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for Ecc check

Reviewed-by: Jian J Wang Regards, Jian > -Original Message- > From: Zhang, Shenglei > Sent: Wednesday, July 01, 2020 9:55 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J ; Lu, XiaoyuX > Subject: [PATCH v6 05/16] CryptoPkg/CryptoPkg.ci.yaml: Add configuration for > Ecc check > > Add

Re: [edk2-devel] [PATCH v2 3/3] .pytool: CI Settings to support DynamicTablesPkg

Reviewed-by: Shenglei Zhang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Wednesday, July 1, 2020 3:37 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; alexei.fedo...@arm.com; > sean.bro...@microsoft.com; Gao, Liming ; Kinney, > Michael D ; bret.

Re: [edk2-devel] [PATCH v2 4/4] .azurepipelines: Add DynamicTablesPkg to CI matrix

Reviewed-by: Shenglei Zhang > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sami > Mujawar > Sent: Wednesday, July 1, 2020 3:37 AM > To: devel@edk2.groups.io > Cc: Sami Mujawar ; alexei.fedo...@arm.com; > sean.bro...@microsoft.com; Gao, Liming ; Kinney, > Michael D ; bret.

[edk2-devel] [PATCH 07/11] OvmfPkg/LsiScsiDxe: Open PciIo protocol and initialize the device

Open PciIo protocol and use it to initialize the device. The initialization of LSI 53C895A is simple: just set the SRST bit in Interrupt Status Zero register to reset the device. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/Include/IndustryStandard

[edk2-devel] [PATCH 02/11] OvmfPkg/LsiScsiDxe: Install the skeleton of driver binding

Implement the dummy functions for EFI Driver Binding protocol. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 72 ++- OvmfPkg/LsiScsiDxe/LsiScsi.h | 50 + OvmfPkg/LsiScs

[edk2-devel] [PATCH 06/11] OvmfPkg/LsiScsiDxe: Report Targets and LUNs

Implement LsiScsiGetNextTargetLun(), LsiScsiBuildDevicePath(), LsiScsiGetTargetLun(), and LsiScsiGetNextTarget() to report Targets and LUNs and build the device path. This commit also introduces two PCD value: PcdLsiScsiMaxTargetLimit and PcdLsiScsiMaxLunLimit as the limits for Targets and LUNs.

[edk2-devel] [PATCH 11/11] Maintainers.txt: Add myself as the reviewer for LsiScsi driver

Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- Maintainers.txt | 4 1 file changed, 4 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index 32c9003a6209..666d3af4d76a 100644 --- a/Maintainers.txt +++ b/Maintainers.txt @@ -400,6 +400,10 @@ O

[edk2-devel] [PATCH 05/11] OvmfPkg/LsiScsiDxe: Install stubbed EXT_SCSI_PASS_THRU

Partially implement LsiScsiControllerStart() and LsiScsiControllerStop() to insert the scaffolding of EXT_SCSI_PASS_THRU functions. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 171 +- OvmfPkg

[edk2-devel] [PATCH 00/11] Introduce LsiScsi driver to OvmfPkg

This patch series implement the driver for LSI 53C895A SCSI controller for OVMF so that the user can access the storage devices connected to QEMU "lsi" controller. The driver is disabled by default since LSI 53C895A is considered as a legacy device. To enable the driver, please add "-D LSI_SCSI_ENA

[edk2-devel] [PATCH 08/11] OvmfPkg/LsiScsiDxe: Map DMA buffer

Map DMA buffer and perpare for the implementation of LsiScsiPassThru(). Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 85 +++- OvmfPkg/LsiScsiDxe/LsiScsi.h | 10 + 2 files changed, 94 insert

[edk2-devel] [PATCH 01/11] OvmfPkg/LsiScsiDxe: Create the empty driver

Create the driver with only a dummy LsiScsiEntryPoint() for the further implementation of the driver for LSI 53C895A SCSI controller. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 25 + OvmfPkg/Lsi

[edk2-devel] [PATCH 10/11] OvmfPkg/LsiScsiDxe: Process the SCSI Request Packet

This is the second part of LsiScsiPassThru(). LsiScsiProcessRequest() is added to translate the SCSI Request Packet into the LSI 53C895A commands. This function utilizes the so-called Script buffer to transmit a series of commands to the chip and then polls the DMA Status (DSTAT) register until the

[edk2-devel] [PATCH 03/11] OvmfPkg/LsiScsiDxe: Report the name of the driver

Implement LsiScsiGetDriverName() and LsiScsiGetDeviceName() to report the name of the driver. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 69 ++-- OvmfPkg/LsiScsiDxe/LsiScsi.h | 31 +++

[edk2-devel] [PATCH 04/11] OvmfPkg/LsiScsiDxe: Probe PCI devices and look for LsiScsi

Implement LsiScsiControllerSupported() to probe the PCI ID and look for LSI 53C895A. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/Include/IndustryStandard/LsiScsi.h | 20 + OvmfPkg/LsiScsiDxe/LsiScsi.c | 48 +++

[edk2-devel] [PATCH 09/11] OvmfPkg/LsiScsiDxe: Examine the incoming SCSI Request Packet

This is the first part of LsiScsiPassThru(). Before processing the SCSI Request packet, we have to make sure whether the packet is valid or not. Cc: Jordan Justen Cc: Laszlo Ersek Cc: Ard Biesheuvel Signed-off-by: Gary Lin --- OvmfPkg/LsiScsiDxe/LsiScsi.c | 100 +++