[edk2-devel] [edk2-platforms][PATCH v3 3/4] Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library

From: Deepak Pandey Neoverse N1 SoC includes a PCIe root complex to which a AHCI, GbE and USB controllers are attached as an endpoint. So implement the PciHostBridgeLib glue layer and enable support for PCIe controller and all the devices connected over the PCIe bus. Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board

Changes since v2: - Addressed comments from Thomas. - Renamed Silicon/ARM/N1Sdp to Silicon/ARM/NeoverseN1Soc. Changes since v1: - Addressed comments from Ard. - Split the code between Silicon and Platform directories. Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform pri

[edk2-devel] [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add platform library implementation

From: Deepak Pandey Add the initial Arm's Neoverse N1 System-on-Chip platform library support. This includes the virtual memory map and helper functions for platform initialization. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pranav Madhu diff --git a/Silicon/ARM/NeoverseN1Soc/Neover

[edk2-devel] [edk2-platforms][PATCH v3 4/4] Platform/ARM/N1SDP: Add initial N1SDP platform support

From: Deepak Pandey Neoverse N1 System Development Platform (N1SDP) is an infrastructure segment development platform. It includes a Neoverse N1 SoC and an IOFPGA that provides access to low-bandwidth peripherals. It also enables development of CCIX-enabled FPGA accelerators. Cc: Ard Biesheuvel

[edk2-devel] [edk2-platforms][PATCH v3 2/4] Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib

From: Deepak Pandey A slave error is generated when host accesses the config space of non-available device or unimplemented function on a given bus. So implement a n1sdp specific PciExpressLib library with a workaround to return 0x for all such access. Cc: Ard Biesheuvel Cc: Leif Lindho

Re: [edk2-devel] [PATCH 0/2] BaseTools: minor PatchCheck.py fixes/changes

Merged. -Original Message- From: Leif Lindholm Sent: Thursday, July 2, 2020 11:40 PM To: devel@edk2.groups.io Cc: Feng, Bob C ; Gao, Liming Subject: [PATCH 0/2] BaseTools: minor PatchCheck.py fixes/changes 1: https://github.com/tianocore/edk2/pull/549 failed to merge, since PatchChe

Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

Thank you very much Liming and Zhichao for your time to discuss this case. Hello Liming, As discussed, please help to raise the BZ to enhance PatchCheck.py and kindly help to submit our Edk2 patch to Edk2 Repo. [EDK2 Change BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=2818] Also, please

[edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2818 For better memory management, re-ordered the DestroyRamDisk and ReportStatusCode calls inside the EfiBootManagerBoot() function. This will help to clean the unused memory before reporting the failure status, so that OEMs can use RSC Listener

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add platform library implementation

Please repost this series with a cover letter, and without stripping the diffstats from the patches. Are you using git format-patch? On 7/3/20 9:02 AM, Pranav Madhu wrote: From: Deepak Pandey Add the initial Arm's Neoverse N1 System-on-Chip platform library support. This includes the virtua

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On Fri, Jul 03, 2020 at 01:40:26 +, Gao, Liming wrote: > > >>> *Reads patch* > > >>> *Figuratively spits coffee all over keyboard* > > >>> > > >>> No, this is not OK. > > >>> > > >>> We *STILL* have no agreed process for accepting non bsd+patent content > > >>> since we dropped the contribution

Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

On Fri, Jul 03, 2020 at 06:02:12 +, Gao, Liming wrote: > Signed-off-by line is too long and exceeds 80 characters requirement. But, it > is valid. > > So, I suggest to enhance PatchCheck.py and skip the check for the lines with > Signed-off-by, Ack-by:, Reviewed-by:, and Tested-By:. Acked

[edk2-devel] [edk2-platforms][PATCH v3 4/4] Platform/ARM/N1SDP: Add initial N1SDP platform support

From: Deepak Pandey Neoverse N1 System Development Platform (N1SDP) is an infrastructure segment development platform. It includes a Neoverse N1 SoC and an IOFPGA that provides access to low-bandwidth peripherals. It also enables development of CCIX-enabled FPGA accelerators. Cc: Ard Biesheuvel

[edk2-devel] [edk2-platforms][PATCH v3 3/4] Silicon/ARM/N1SoC: Implement the PciHostBridgeLib library

From: Deepak Pandey Neoverse N1 SoC includes a PCIe root complex to which a AHCI, GbE and USB controllers are attached as an endpoint. So implement the PciHostBridgeLib glue layer and enable support for PCIe controller and all the devices connected over the PCIe bus. Cc: Ard Biesheuvel Cc: Leif

[edk2-devel] [edk2-platforms][PATCH v3 2/4] Silicon/ARM/N1SoC: Implement Neoverse N1 Soc specific PciExpressLib

From: Deepak Pandey A slave error is generated when host accesses the config space of non-available device or unimplemented function on a given bus. So implement a n1sdp specific PciExpressLib library with a workaround to return 0x for all such access. Cc: Ard Biesheuvel Cc: Leif Lindho

[edk2-devel] [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add platform library implementation

From: Deepak Pandey Add the initial Arm's Neoverse N1 System-on-Chip platform library support. This includes the virtual memory map and helper functions for platform initialization. Cc: Ard Biesheuvel Cc: Leif Lindholm Signed-off-by: Pranav Madhu --- Silicon/ARM/NeoverseN1Soc/NeoverseN1SocPl

[edk2-devel] [edk2-platforms][PATCH v3 0/4] Platform: Add initial support for N1SDP board

Changes since v2: - Addressed comments from Thomas. - Renamed Silicon/ARM/N1SDP to Silicon/ARM/NeoverseN1Soc. Changes since v1: - Addressed comments from Ard. - Split the code between Silicon and Platform directories. Arm's N1SDP is a Arm v8.2-A Neoverse N1 CPU based reference design platform pri

Re: [edk2-devel] [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add platform library implementation

Hi Ard, > -Original Message- > From: Ard Biesheuvel > Sent: Friday, July 3, 2020 4:05 PM > To: Pranav Madhu ; devel@edk2.groups.io > Cc: Leif Lindholm > Subject: Re: [edk2-platforms][PATCH v3 1/4] Silicon/ARM/N1SoC: Add > platform library implementation > > Please repost this series with

Re: [edk2-devel] [PATCH v2 2/9] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

Hi, this patch contains a bunch of changes that are not related to the main purpose of the patch. See below. On 07/02/20 07:15, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Moves the GDT and IDT to permanent memory in a memory disc

Re: [edk2-devel] [PATCH v2 3/9] UefiCpuPkg/SecMigrationPei: Add initial PEIM (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Adds a PEIM that republishes structures produced in SEC. This > is done because SEC modules may not be shadowed in some platforms > due to space constraints or special a

Re: [edk2-devel] [PATCH v2 2/9] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

Hi, more comments on the MigrateGdt() function: On 07/03/20 13:36, Laszlo Ersek wrote: > Hi, > > this patch contains a bunch of changes that are not related to the main > purpose of the patch. See below. > > On 07/02/20 07:15, Guomin Jiang wrote: >> From: Michael Kubacki >> >> REF:https://bugz

Re: [edk2-devel] [PATCH v2 1/9] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > diff --git a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c > b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c > index cca57c4c0686..802cd239e2eb 100644 > --- a/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c > +++ b/MdeModulePkg/Core/Pei/PeiMain/PeiMain.c > @@ -418,6 +418,22 @

Re: [edk2-devel] [PATCH edk2 v1 1/1] MdeModulePkg/Variable: Move FindVariable after AutoUpdateLangVariable

在 2020/7/1 8:22, Jiang, Guomin 写道: > So I think the key point is why AutoUpdateLangVariable() return success > rather than fail, if is it reasonable for this case or we need other error > handing? I don't think AutoUpdateLangVariable() should return fail while occur reclaim internal in AutoU

Re: [edk2-devel] [PATCH v2 7/9] MdeModulePkg/Core: Add switch to enable or disable TOCTOU feature (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Add total switch to enable or disable TOCTOU feature, the vulnerability is > critical, so the switch is on normally but if you can disable it according > to your needs. > > Cc: Jian J Wang > Cc:

Re: [edk2-devel] [PATCH v2 9/9] UefiCpuPkg/CpuMpPei: Enable paging and set NP flag to avoid TOCTOU (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > To avoid the TOCTOU, enable paging and set Not Present flag so when > access any code in the flash range, it will trigger #NP exception. > > Cc: Eric Dong > Cc: Ray Ni > Cc: Laszlo Ersek > Cc:

Re: [edk2-devel] [PATCH v2 1/9] MdeModulePkg/PeiCore: Enable T-RAM evacuation in PeiCore (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Introduces new changes to PeiCore to move the contents of temporary > RAM visible to the PeiCore to permanent memory. This expands on > pre-existing shadowing support in

Re: [edk2-devel] [PATCH v2 2/9] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > From: Michael Kubacki > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Moves the GDT and IDT to permanent memory in a memory discovered > callback. This is done to ensure the GDT and IDT authenticated in > pre-memory is not fetched from out

Re: [edk2-devel] [PATCH v2 4/9] MdeModulePkg/DxeIplPeim: Register for shadow on S3 shadowed boot (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > From: Jian J Wang > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > Cc: Jian J Wang > Cc: Hao A Wu > Cc: Dandan Bi > Cc: Liming Gao > Signed-off-by: Jian J Wang > --- > MdeModulePkg/Core/DxeIplPeim/DxeIpl.inf | 3 +++ > MdeModulePkg/Co

Re: [edk2-devel] [PATCH v2 5/9] MdeModulePkg/Core: Create Migrated FV Info Hob for calculating hash (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > When we allocate pool to save rebased the PEIMs, the address will change > randomly, therefore the hash will change and result PCR0 change as well. > To avoid this, we save the raw PEIMs and use it

Re: [edk2-devel] [PATCH v2 8/9] UefiCpuPkg/SecMigrationPei: Add switch to control if produce PPI (CVE-2019-11098)

On 07/02/20 07:15, Guomin Jiang wrote: > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 > > SecMigrationPei create RepublishSecPpi, if the TOCTOU switch is off, > the Ppi is meaningless, so relate it with TOCTOU switch to avoid > producing useless PPI. > > Cc: Eric Dong > Cc: Ray Ni >

Re: [edk2-devel] [PATCH v2 0/9] Migrate Pointer from flash to permanent memory (CVE-2019-11098)

Hi, I'm adding Michael Kubacki's new email address to the "To:" list, as Michael has authored a significant portion of this code, plus he seems to have contributed a large part of the design, in . Also CC'ing Ard. Comments below. On 07/02/20

Re: [edk2-devel] [PATCH 00/11] Introduce LsiScsi driver to OvmfPkg

Hi Gary, On 07/01/20 06:04, Gary Lin wrote: > This patch series implement the driver for LSI 53C895A SCSI controller > for OVMF so that the user can access the storage devices connected to > QEMU "lsi" controller. The driver is disabled by default since LSI > 53C895A is considered as a legacy devi

Re: [edk2-devel] [PATCH v2 4/9] MdeModulePkg/DxeIplPeim: Register for shadow on S3 shadowed boot (CVE-2019-11098)

On 07/03/20 16:00, Laszlo Ersek wrote: > On 07/02/20 07:15, Guomin Jiang wrote: >> From: Jian J Wang >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 >> >> Cc: Jian J Wang >> Cc: Hao A Wu >> Cc: Dandan Bi >> Cc: Liming Gao >> Signed-off-by: Jian J Wang >> --- >> MdeModulePkg/Cor

Re: [edk2-devel] [PATCH v2 2/9] UefiCpuPkg/CpuMpPei: Add GDT and IDT migration support (CVE-2019-11098)

On 07/03/20 15:57, Laszlo Ersek wrote: > On 07/02/20 07:15, Guomin Jiang wrote: >> From: Michael Kubacki >> >> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1614 >> >> Moves the GDT and IDT to permanent memory in a memory discovered >> callback. This is done to ensure the GDT and IDT authenti

Re: [edk2-devel] [PATCH edk2-platforms v2 0/7] NXP: Add PCIe Support for LX2160aRdbPkg

On Mon, Jun 29, 2020 at 12:14:59 +0530, Wasim Khan wrote: > From: Wasim Khan > > LX2160-Rev1 and LX2160-Rev2 has different PCIe controller. > This patch series adds PCIe support for LX2160aRdbPkg which includes > - Add PCIe space in VirtualMemoryMap > - Platform driver to check SoC version and se

Re: [edk2-devel] [PATCH] MdeModulePkg: Upon BootOption failure, Destroy RamDisk memory before RSC.

BZ to enhance PatchCheck is submitted. https://bugzilla.tianocore.org/show_bug.cgi?id=2836 Thanks Liming > -Original Message- > From: devel@edk2.groups.io On Behalf Of Leif Lindholm > Sent: Friday, July 3, 2020 6:43 PM > To: Gao, Liming > Cc: devel@edk2.groups.io; Veliyathuparambil Prak

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

> -Original Message- > From: Leif Lindholm > Sent: Friday, July 3, 2020 6:38 PM > To: Gao, Liming > Cc: devel@edk2.groups.io; ard.biesheu...@arm.com; Laszlo Ersek > ; Rebecca Cran ; > Andrew Fish ; Justen, Jordan L ; > Kinney, Michael D > Subject: Re: [edk2-devel] License Check - was O

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

Include more people and collect the comments. ECC is the source file coding style checker. Here is its wiki page https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool. If the changed code doesn't follow edk2 coding style, ECC will report the error. This patch set enables ECC checker

Re: [edk2-devel] License Check - was OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On 07/03/20 03:40, Gao, Liming wrote: > Besides, there is another new checker of ECC to check coding style for each > patch. Can you give your comment? > https://edk2.groups.io/g/devel/message/61966 I've seen that feature. Importantly, it gives package maintainers package-level exception lists.

Re: [edk2-devel] OvmfPkg: Adding support for bhyve as OvmfPkg/Bhyve

On 07/03/20 05:13, Rebecca Cran wrote: > On 7/2/20 3:27 AM, Laszlo Ersek wrote: > >> I'll look at the patches on the list. (I don't believe in reviewing >> before reviewing. In case I need to make comments for what I find in >> your repo, I could only make them without any context to quote.) > >

Re: [edk2-devel] [PATCH v6 00/16] Add a plugin to check Ecc issues for edk2 on open ci

Hi Liming, On 07/03/20 17:13, Gao, Liming wrote: > Include more people and collect the comments. > > ECC is the source file coding style checker. Here is its wiki page > https://github.com/tianocore/tianocore.github.io/wiki/ECC-tool. > If the changed code doesn't follow edk2 coding style, ECC w

Re: [edk2-devel] [PATCH 0/2] Drop suggestions of alternative acceptable licenses

On 07/02/20 13:24, Leif Lindholm wrote: > (Echoing https://bugzilla.tianocore.org/show_bug.cgi?id=2834:) > In the past, the TianoCore Contribution Agreement provided equal to what > the (+patent) gives us, but also for all the alternative licenses listed > under "Code Contributions". When the contr

Re: [edk2-devel] [PATCH 1/2] Revert "BaseTools/PatchCheck.py: Add LicenseCheck"

On 07/02/20 13:24, Leif Lindholm wrote: > This reverts commit a4cfb842fca9693a330cb5435284c1ee8bfbbace. > This commit suggests inclusion of non-edk2+license content without The expression "non-edk2+license" is a typo. I think you meant "non-BSD-2-Clause-Patent". > a contribution agreement is som

Re: [edk2-devel] [PATCH 2/2] ReadMe.rst: delete statements about other accepted licenses

On 07/02/20 13:24, Leif Lindholm wrote: > In the past, the TianoCore Contribution Agreement provided equal to what > the (+patent) gives us, but also for all the alternative licenses listed > under "Code Contributions". When the contribution agreement was dropped, > no conversation was had about th

[edk2-devel] Question about the OVMF and MTRRs?

I noticed for my version of QEMU that MTRR registers are not supported. Is that expected? Or is it something if you get wrong it does not break in QEMU? Due to no MTRR support the CPU Protocol SetMemoeryAttributes() call is falling [1] and non of the GCD ranges have EFI_MEMORY_UC Attribute. I’

[edk2-devel] 2nd OVMF question about why InitRootBridge does not set ResourceAssigned?

When tacking down the EFI_MEMORY_UC issue I noticed that InitRootBridg() [1] does not set RootBus-> ResourceAssigned = TRUE. If it was TRUE then the entire PCI aptitude would end up in the GCD map. Given it is not set (set by ZeroMem) the EFI_MEMORY_UC only ends up for the actual allocations as

Re: [edk2-devel] UefiPayloadPkg: assert error in PciHostBridgeDxe

On 07/03/20 01:03, Andrew Fish via groups.io wrote: > > >> On Jul 2, 2020, at 3:54 PM, King Sumo wrote: >> >> Hi, >> >> When booting UefiPayloadPkg in my system (x86 Denverton SoC, coreboot) an >> assert error is generated in the PciHostBridgeDxe driver. >> In the InitializePciHostBridge() func

Re: [edk2-devel] UefiPayloadPkg: assert error in PciHostBridgeDxe

> On Jul 3, 2020, at 11:06 AM, Laszlo Ersek wrote: > > On 07/03/20 01:03, Andrew Fish via groups.io wrote: >> >> >>> On Jul 2, 2020, at 3:54 PM, King Sumo wrote: >>> >>> Hi, >>> >>> When booting UefiPayloadPkg in my system (x86 Denverton SoC, coreboot) an >>> assert er