Re: 回复: [edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-18 Thread Ilias Apalodimas
On Thu, Feb 18, 2021 at 11:13:21AM +0800, gaoliming wrote: > I suggest to directly change [FixedPcd] to [Pcd] section. All Pcds can > support FixedAtBuild and PatchableInModule. We can, but is there a reason to do that? Wouldn't we be better of being more strict on the Pcd context we define for e

Re: [edk2-devel] [PATCH - resend] MdeModulePkg/BootLogoLib: Center logo 38.2% from top of screen

2021-02-18 Thread Patrick Rudolph
Hi, Please find the issue created here: https://bugzilla.tianocore.org/show_bug.cgi?id=3226 On Thu, Feb 18, 2021 at 4:32 AM gaoliming wrote: > > Patrick: > I am OK for this extension to meet with Microsoft recommendation. This > change is a new feature. Can you submit one BZ > (https://bugzilla

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-18 Thread Jeremy Linton
Hi, On 2/17/21 11:57 AM, Ard Biesheuvel wrote: On Wed, 17 Feb 2021 at 18:16, Jeremy Linton wrote: Hi, On 2/17/21 1:55 AM, Ard Biesheuvel via groups.io wrote: On Wed, 17 Feb 2021 at 08:30, Jeremy Linton wrote: Hi, On 2/17/21 12:56 AM, Ard Biesheuvel wrote: On Wed, 17 Feb 2021 at 07:18,

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-18 Thread Ard Biesheuvel
On Thu, 18 Feb 2021 at 17:47, Jeremy Linton wrote: > > Hi, > > On 2/17/21 11:57 AM, Ard Biesheuvel wrote: > > On Wed, 17 Feb 2021 at 18:16, Jeremy Linton wrote: > >> > >> Hi, > >> > >> On 2/17/21 1:55 AM, Ard Biesheuvel via groups.io wrote: > >>> On Wed, 17 Feb 2021 at 08:30, Jeremy Linton wrote

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-18 Thread Ard Biesheuvel
On Wed, 17 Feb 2021 at 07:18, jlinton wrote: > > From: Jeremy Linton > > The existing RPi3 ACPI entries for the Arasan > and SDHCI controllers need updating to work > with the RPi4. This is done by adding a caps > override for the legacy Arasan controller and > then adding an entirely new entry f

Re: [edk2-devel] [PATCH v3 0/4] RPi: SD/WiFi ACPI updates

2021-02-18 Thread Jeremy Linton
Hi, On 2/18/21 10:52 AM, Ard Biesheuvel wrote: On Thu, 18 Feb 2021 at 17:47, Jeremy Linton wrote: Hi, On 2/17/21 11:57 AM, Ard Biesheuvel wrote: On Wed, 17 Feb 2021 at 18:16, Jeremy Linton wrote: Hi, On 2/17/21 1:55 AM, Ard Biesheuvel via groups.io wrote: On Wed, 17 Feb 2021 at 08:30,

[edk2-devel] [PATCH 0/2] Improve hibernation safety

2021-02-18 Thread Alexander Graf via groups.io
Operating Systems that get hibernated expect all non-boot-time allocations to be identical before and after hibernation. In edk2, we create pools and allocate pages starting from the highest allowed address for the allocation, usually 0x. Typically, that means we allocate a few pages of bo

[edk2-devel] [PATCH 2/2] OvmfPkg: Make hibernation critical allocations at own ranges

2021-02-18 Thread Alexander Graf via groups.io
Now that we have a framework available to set memory ranges for allocations that break hibernation if they move, let's push them to their own respective memory ranges. This way, they will be unaffected by boot time data allocation changes and we can thus still resume hibernated systems. Signed-off

[edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Allow to force runtime allocations at separate range

2021-02-18 Thread Alexander Graf via groups.io
Operating Systems that get hibernated expect all non-boot-time allocations to be identical before and after hibernation. In edk2, we create pools and allocate pages starting from the highest allowed address for the allocation, usually 0x. Typically, that means we allocate a few pages of bo

Re: [edk2-devel] [PATCH 1/2] MdeModulePkg/Core/Dxe: Allow to force runtime allocations at separate range

2021-02-18 Thread Michael D Kinney
Hi Alex, This feature is already available from the DXE Core using the MemoryTypeInformation and was specifically added to support hibernation use case. There is an optional HOB that is passed into DXE Core that can provide bin sizes for any supported memory types. Not just Runtime and ACPI.

回复: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

2021-02-18 Thread gaoliming
Walon: Can you specify the detail reason why BootManagerMenu should be placed at end of BootOrder? Thanks Liming > -邮件原件- > 发件人: bounce+27952+71766+4905953+8761...@groups.io > 代表 Li, Walon > 发送时间: 2021年2月18日 11:26 > 收件人: devel@edk2.groups.io > 抄送: walon...@hpe.com; sunnyw...@hpe.com; le

回复: 回复: [edk2-devel] [PATCH v4 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-18 Thread gaoliming
Ilias: If you check other Variable module INF file, you can find they all use [Pcd] section. Module provides the flexibility instead of the limitation. In fact, variable module code has no fixed pcd usage. Platform can decide which PCD type should be used. In future, if other PCD is required to

Re: [edk2-devel] [PATCH] MdeModulePkg/UefiBootManagerLib: Put BootMenu at the end of BootOrder

2021-02-18 Thread Li, Walon
Hi Liming, As edk2 design, any new boot options should be put at the end of BootOrder because these are NEW . That means system should "append" BootOrder instead of override original order. For example, if system has three boot options currently - Boot0001, Boot0002, Boot0003 and then one new o

Re: [edk2-devel] Does EDK2 ArmVirtPkg has support for a virtio-mmio-blk device

2021-02-18 Thread Ying Fang
On 2021/2/10 2:32 上午, Laszlo Ersek wrote: > On 02/09/21 16:28, Ard Biesheuvel wrote: >> On Tue, 9 Feb 2021 at 14:41, Laszlo Ersek wrote: >>> >>> On 02/09/21 03:54, Ying Fang wrote: >>> I now realize that we emulate the virtio-blk-device over mmio, and we only emulate virtio-1.0 spec. >

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove 4GB memory WA

2021-02-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma Regards Maurice > -Original Message- > From: Dong, Guo > Sent: Sunday, February 14, 2021 21:13 > To: devel@edk2.groups.io > Cc: Ma, Maurice ; You, Benjamin > > Subject: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadEntry: Remove > 4GB memory WA > > Previous i

[edk2-devel] [edk2-platforms v2 0/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

2021-02-18 Thread Rebecca Cran
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are currentl

[edk2-devel] [edk2-platforms v2 2/3] SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib

2021-02-18 Thread Rebecca Cran
Use the copy of the CountCpusFromFdt function from FdtHelperLib. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 50 +--- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 + 2 files changed, 2 insertions(+

[edk2-devel] [edk2-platforms v2 1/3] SbsaQemu: Add FdtHelperLib

2021-02-18 Thread Rebecca Cran
The CountCpusFromFdt function is now used in two places. Create FdtHelperLib for this and similar functions. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 + Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h| 24 +++ Silicon/Qemu/

[edk2-devel] [edk2-platforms v2 3/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

2021-02-18 Thread Rebecca Cran
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are currentl

[edk2-devel] [edk2-platforms PATCH v3 1/3] SbsaQemu: Add FdtHelperLib

2021-02-18 Thread Rebecca Cran
The CountCpusFromFdt function is now used in two places. Create FdtHelperLib for this and similar functions. Signed-off-by: Rebecca Cran --- Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 2 + Silicon/Qemu/SbsaQemu/Include/Library/FdtHelperLib.h| 24 +++ Silicon/Qemu/

[edk2-devel] [edk2-platforms PATCH v3 3/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

2021-02-18 Thread Rebecca Cran
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are currentl

[edk2-devel] [edk2-platforms PATCH v3 0/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

2021-02-18 Thread Rebecca Cran
o Add SMBIOS 3.4.0 tables using ArmPkg/Universal/Smbios. o Bump the PcdSmbiosVersion PCD from 0x300 to 0x304 to indicate support for SMBIOS 3.4.0, as is required by SBBR. o Add an implementation of OemMiscLib that provides the system information. The serial numbers, asset tags etc. are currentl

[edk2-devel] [edk2-platforms PATCH v3 2/3] SbsaQemu: Update SbsaQemuAcpiDxe to use FdtHelperLib

2021-02-18 Thread Rebecca Cran
Use the copy of the CountCpusFromFdt function from FdtHelperLib. Signed-off-by: Rebecca Cran --- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 50 +--- Silicon/Qemu/SbsaQemu/Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.inf | 1 + 2 files changed, 2 insertions(+

Re: [edk2-devel] [edk2-platforms PATCH v3 0/3] Platform/Qemu/SbsaQemu: Add SMBIOS tables

2021-02-18 Thread Rebecca Cran
On 2/18/21 8:57 PM, Rebecca Cran wrote: Changes between v1 and v2: o Renamed OemMiscLib 'socket' functions to 'processor'. o Added PCDs for the various strings (SN, SKU etc.). o Added FdtHelperLib. o Updated SBSA ACPI Dxe to use FdtHelperLib. o Changed SBSA SMBIOS Processor information to creat

[edk2-devel] [PATCH v4 0/2] Fix CET shadow stack token busy bit clear issue

2021-02-18 Thread Sheng Wei
If CET shadows stack feature enabled in SMM and stack switch is enabled. When code execute from SMM handler to SMM exception, CPU will check SMM exception shadow stack token busy bit if it is cleared or not. If it is set, it will trigger #DF exception. If it is not set, CPU will set the busy bit wh

[edk2-devel] [PATCH v4 2/2] UefiCpuPkg/CpuExceptionHandlerLib: Clear CET shadow stack token busy bit

2021-02-18 Thread Sheng Wei
If CET shadows stack feature enabled in SMM and stack switch is enabled. When code execute from SMM handler to SMM exception, CPU will check SMM exception shadow stack token busy bit if it is cleared or not. If it is set, it will trigger #DF exception. If it is not set, CPU will set the busy bit wh

[edk2-devel] [PATCH v4 1/2] MdePkg/Include: Add CET instructions to Nasm.inc

2021-02-18 Thread Sheng Wei
This is to add instruction SAVEPREVSSP, CLRSSBSY and RSTORSSP_RAX in Nasm. The open CI is using NASM 2.14.02. CET instructions are supported since NASM 2.15.01. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3192 Signed-off-by: Sheng Wei Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Li

[edk2-devel] [PATCH 1/1] ArmPkg: Fix several issues in OemMiscLib

2021-02-18 Thread Rebecca Cran
Update OemMiscLib with the following changes: o Fixed ordering of return type and EFIAPI specifier. o Renamed 'Offset' parameter in OemUpdateSmbiosInfo to 'Field'. o Renamed OemGetProcessorMaxSockets to OemGetMaxProcessors. o Renamed OemIsSocketPresent to OemIsProcessorPresent. o Updated OemGetCha

Re: [edk2-devel] [PATCH v4 0/2] Fix CET shadow stack token busy bit clear issue

2021-02-18 Thread Sheng Wei
Hi All, I update the patch to v4 for refine the comment and commit message. These patches are used to fix SMM CET shadow stack token busy bit issue. Issue description: If CET shadows stack feature enabled in SMM and stack switch is enabled. When code execute from SMM handler to SMM exception, CPU

[edk2-devel] [PATCH v5 00/14] Add support for using FF-A calls

2021-02-18 Thread Sughosh Ganu
The following patch series adds support for using the Firmware Framework(FF-A) as a transport mechanism for requesting services from the Secure Partition Manager(SPM). This is done through a Pcd which can be used to enable the FF-A mechanism or to use the earlier used SVC calls. The patches have b

[edk2-devel] [PATCH v5 01/14] ArmPkg/IndustryStandard: Add barebones FF-A header

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta This patch adds a rudimentary header file with defines for FF-A ABIs that will be used as the transport between S-EL0 and the SPM Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar Reviewed-by: Ard Biesheuvel --- Changes since V4: None ArmPkg/Include/IndustryStandard/Ar

[edk2-devel] [PATCH v5 02/14] ArmPkg/ArmSvcLib: Return x4-x7 in output parameters

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta The Arm SMC calling convention standard v1.2 allows 8 input and output parameter registers. The FF-A specification relies on this communication. This patch extends the number of output registers returned by ArmCallSvc() to match this convention. Signed-off-by: Achin Gupta Revi

[edk2-devel] [PATCH v5 03/14] StandaloneMmPkg: Use FF-A header file in Standalone MM Core entry point

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Add the Firmware Framework(FF-A) header in the StandaloneMm entry point driver. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V4: None StandaloneMmPkg/Library/Sta

[edk2-devel] [PATCH v5 04/14] ArmPkg: Introduce support for PcdFfaEnable

2021-02-18 Thread Sughosh Ganu
The Secure Partition(SP) can request services from the Secure Partition Manager Core(SPMC) either through FF-A calls or through the existing SVC calls. Add a feature flag Pcd for enabling the FF-A method -- when this is set to FALSE, the SP uses the existing SVC calls for making the requests. Sign

[edk2-devel] [PATCH v5 05/14] ArmPkg: Add macros for SPM version

2021-02-18 Thread Sughosh Ganu
Declare the values of SPM major and minor versions as macros which can be used in the module for checking the SPM version compatibility. Signed-off-by: Sughosh Ganu --- Changes since V4: None ArmPkg/Include/IndustryStandard/ArmMmSvc.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/ArmP

[edk2-devel] [PATCH v5 06/14] StandaloneMmPkg: Use macros for SPM version check

2021-02-18 Thread Sughosh Ganu
Declare module wide variables for SPM major and minor versions to be used in checking the SPM version compatibility. Use the SPM major and minor version macros declared in the previous patch for the version check. Signed-off-by: Sughosh Ganu --- Changes since V4: None StandaloneMmPkg/Library/

[edk2-devel] [PATCH v5 08/14] StandaloneMmPkg: Add option to use FF-A calls for getting SPM version

2021-02-18 Thread Sughosh Ganu
With the introduction of Firmware Framework(FF-A), a Secure Partition can get the SPM version either using FF-A calls or through the existing svc calls. Use a runtime check to use either of the two methods based on the Pcd feature flag value. Signed-off-by: Sughosh Ganu Co-developed-by: Achin Gup

[edk2-devel] [PATCH v5 07/14] ArmPkg: Add macros for SPM version with FF-A support enabled

2021-02-18 Thread Sughosh Ganu
Declare the values of SPM major and minor versions as macros with FF-A enabled, which can be used in the module for checking the SPM version compatibility. These SPM major and minor version numbers are mandated for having support for the Firmware Framework(FF-A) feature enabled. Signed-off-by: Sug

[edk2-devel] [PATCH v5 09/14] StandaloneMmPkg: Add option to use FF-A calls for communication with SPM

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Add support for reporting completion of a MM request using either the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V4: None StandaloneMmP

[edk2-devel] [PATCH v5 10/14] ArmPkg: Use FF-A header file in Standalone MM Arm MMU library

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Add the FF-A header for invoking the mmu functions using FF-A calls as the transport mechanism. Support for invoking the functions through FF-A will be added in a subsequent patch. Signed-off-by: Achin Gupta Reviewed-by: Sami Mujawar --- Changes since V4: None ArmPkg/Libra

[edk2-devel] [PATCH v5 11/14] ArmPkg: Allow FF-A calls to get memory region's attributes

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Allow getting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu --- Changes since V4: None ArmPkg/Library/StandaloneMmMmuLib/ArmMmuStandalon

[edk2-devel] [PATCH v5 12/14] ArmPkg: Allow FF-A calls to set memory region's attributes

2021-02-18 Thread Sughosh Ganu
From: Achin Gupta Allow setting memory region's permissions using either of the Firmware Framework(FF-A) ABI transport or through the earlier used SVC calls. Signed-off-by: Achin Gupta Co-developed-by: Sughosh Ganu Reviewed-by: Sami Mujawar --- Changes since V4: None ArmPkg/Library/Standal

[edk2-devel] [PATCH v5 13/14] MdeModulePkg/VariableStandaloneMm: Set PcdFlashNvStorageVariableBase to Pcd

2021-02-18 Thread Sughosh Ganu
From: Ilias Apalodimas Instead of running StMM in SPM, OP-TEE creates a new secure partition, which emulates SPM and isolates StMM from the rest of the Trusted Applications (TAs). We can then compile StMM as an FD image and run it in OP-TEE. With the addition of a new RPMB driver, we can leverage

[edk2-devel] [PATCH v5 14/14] StandaloneMmPkg: Allow sending FFA Direct Request message to StandaloneMm

2021-02-18 Thread Sughosh Ganu
From: Ilias Apalodimas Allow passing of a request to StandaloneMm Core through the Firmware Framework(FF-A) using FFA_MSG_SEND_DIRECT_REQ method. This method is used as a mechanism for requesting some service from StandaloneMm. Signed-off-by: Ilias Apalodimas Signed-off-by: Sughosh Ganu Review