The entire series of patches were already reviewed off line with Daniel
internally.
Reviewed-by: Abner Chang
> -Original Message-
> From: Schaefer, Daniel
> Sent: Wednesday, October 6, 2021 8:03 PM
> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist)
> ; Sunil V L
>
Cover letter should also have signed off and Cc. that's fine for this time.
Did you use patchcheck to check all of your patches includeing the cover letter?
> -Original Message-
> From: Schaefer, Daniel
> Sent: Wednesday, October 6, 2021 8:03 PM
> To: devel@edk2.groups.io; Chang, Abner
On Tue, 5 Oct 2021 at 23:20, Jeremy Linton wrote:
>
> Hi,
>
> On 10/5/21 5:12 AM, Ard Biesheuvel wrote:
> > On Sat, 2 Oct 2021 at 02:52, Jeremy Linton wrote:
> >>
> >> While debugging problems with the GET/SET_CLOCK mailbox calls it appeared
> >> that the locking in most of the mailbox commands
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Introduce the following CmObj in the ArmNameSpaceObjects:
- CM_ARM_PCI_ADDRESS_MAP_INFO
- CM_ARM_PCI_INTERRUPT_MAP_INFO
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
This function allows to add a node as the last node of a parent node
in an AML tree. For instance,
ASL code corresponding to
Hi Pierre,
Thank you for this patch.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
_PRT entries can describe interrupt mapping for Pci devices. The
object is described in ACPI 6.4 s6.2.13 "_PRT (PCI Routing
Hi Pierre,
This patch looks good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenNameResourceTemplate() to generate code for a
ResourceTemplate().
AmlCodeGenNameResourceTemplate ("REST",
Hi Pierre,
Thank you for this patch. These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add AmlCodeGenNamePackage() to generate code for a Package().
AmlCodeGenNamePackage ("PACK",
Hi Pierre,
Please find my feedback marked inline as [SAMI].
Regards,
Sami Mujawar
On 23/06/2021 12:58 PM, pierre.gond...@arm.com wrote:
From: Pierre Gondois
Add helper functions to generate AML Resource Data describing memory
ranges. Memory ranges can be one, double or four words long.
Hi Sami,
Thanks for the review, please find my answer as [Pierre]
On 10/1/21 4:23 PM, Sami Mujawar wrote:
> Hi Pierre,
>
> Please find my response inline marked [SAMI].
>
> Regards,
>
> Sami Mujawar
>
>
> On 23/06/2021 12:40 PM, pierre.gond...@arm.com wrote:
>> From: Pierre Gondois
>>
>> Add
On Wed, Sep 8, 2021 at 07:08 PM, Gao, Zhichao wrote:
>
> Reviewed-by: Zhichao Gao
>
> Thanks,
> Zhichao
Hi Zhichao,
I was about to merge this patch when I noticed there is possibly a typo in your
r-b.
Can you confirm, please?
Regards,
Sami Mujawar
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Hi Leif,
On 06/10/2021 02:59, Leif Lindholm via groups.io wrote:
On Mon, Oct 04, 2021 at 19:03:40 +0700, Nhi Pham wrote:
Hi Leif,
There are two comments that I would like to clarify with you.
On 23/09/2021 20:49, Leif Lindholm wrote:
+VOID
+Ac01PcieMmioWr (
+ UINT64 Addr,
+ UINT32 Val
+
This commit allows to use data in EFI_VARIABLE_AUTHENTICATION_2
structure format to initialize default secure boot variables.
It allows to use revocation list published by UEFI.
Signed-off-by: Grzegorz Bernacki
---
SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.c | 90
Title says v2 but this is the first time I sent it. Sorry.
If there's a next one, it'll be v3, just to be consistent.
On 10/6/21 19:56, Daniel Schaefer wrote:
> OpenSBI can now use a generic platform implementation. The platform
> specific behavior is derived from the device tree.
>
> This
It's a generic platform file. Only the device tree decides what happens.
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/{SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard =>
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/Library/OpensbiPlatformLibNull/Platform.c
| 27 ---
Platform/RISC-V/PlatformPkg/Universal/Sec/Riscv64/SecEntry.S
The Linux EFISTUB reads the FDT from the EFI system configuration
table. Before installing the FDT needs to be patched with the booting
hartid, because the kernel in S-Mode cannot determine it.
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/Library/ResetSystemLib/ResetSystemLib.c | 128
Platform/RISC-V/PlatformPkg/Library/ResetSystemLib/ResetSystemLib.inf | 33
+
New platform files require more space in SEC.
Behavior is determined not by source code but by device tree.
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf.inc
From: Abner Chang
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/Universal/FdtPeim/FdtPeim.c | 70
Platform/RISC-V/PlatformPkg/Universal/FdtPeim/FdtPeim.inf| 49
++
OpenSBI uses the device tree for platform specific initialization, so we
need to have it already in SEC.
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec| 4 ++
Device Tree is taken from Uboot.
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/DeviceTree.fdf.inc
| 35 +++
OpenSBI uses the device tree for platform specific initialization, so we
need to have it already in SEC.
Cc: Daniel Schaefer
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec| 4 ++
From: Abner Chang
Use RISC-V FirmwareContext library to set and get the
pointer of PeiService on SiFive U5 series platforms.
Cc: Sunil V L
Cc: Daniel Schaefer
Signed-off-by: Abner Chang
---
Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 2 ++
1 file changed, 2
The current (and future) RISC-V platforms share a lot of PlatformPei
code that does not need to be duplicated. If we see that they need to
have different behavior in the future, we can add platform specific
libraires for that specific code.
The upcoming RiscvVirt is only 1205 lines with this
From: Abner Chang
Add RISC-V FirmwareContext library for different FirmwareContext
implementations. This instance uses SBI firmware extension to
get the pointer to FirmwareContext.
Cc: Sunil V L
Cc: Daniel Schaefer
Signed-off-by: Abner Chang
---
From: Abner Chang
Use RISC-V FirmwareContext library to set and get the
pointer of PeiService.
Cc: Sunil V L
Cc: Daniel Schaefer
Signed-off-by: Abner Chang
---
Silicon/RISC-V/ProcessorPkg/Library/PeiServicesTablePointerLibOpenSbi/PeiServicesTablePointerLibOpenSbi.inf
| 4 ++--
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/Library/PeiCoreInfoHobLibNull/CoreInfoHob.c
| 37 +
Platform/RISC-V/PlatformPkg/Library/PeiCoreInfoHobLibNull/PeiCoreInfoHobLib.inf
| 43
Cc: Abner Chang
Cc: Sunil V L
Signed-off-by: Daniel Schaefer
---
Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform.c| 17
+-
Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h| 33
OpenSBI can now use a generic platform implementation. The platform
specific behavior is derived from the device tree.
This patchset updates OpenSBI, adds and builds the device tree and does
a lot of deduplication as a result.
Because OpenSBI has done quite a few other changes, Abner will send
Bugzilla: 3578 (https://bugzilla.tianocore.org/show_bug.cgi?id=3579)
Since the Common Memory Device (formerly Memory Aggregator Device) was
introduced in ACPI 5.0, the edk2 type values have not matched the
values defined in the ACPI specification.
Fix this discrepancy by aligning the code to
Hi Ard,
I realized there is a problem if we duplicate ArmPkg defined PCD to under
OvmfPkg (e.g. PcdPciIoTranslate PCD) when I was duplicating this PCD to OvmfPkg.
FdtPciProducerLib is relocated to OvmfPkg/Fdt and uses PcdPciIoTranslate PCD
declared with OvmfPkg namespace. FdtPciProducerLib is
32 matches
Mail list logo
