Re: [edk2-devel] [PATCH V2 21/28] OvmfPkg: Update PlatformPei to support TDX

Ok. Please allow me to clarify my description. "high memory" in this context means the memory region just below the less than 4GiB DRAM limit. In a platform BIOS, it means the memory just below TOLUD (Top of Low Usable DRAM). Usually, the BIOS will reserve a chunk of memory just below TOLUD, in

Re: [edk2-devel] [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot

Reviewed-by: Ray Ni Thanks, Ray -Original Message- From: Dong, Guo Sent: Friday, October 15, 2021 1:08 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot From: Guo Dong

Re: [edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot

Reviewed-by: Ray Ni -Original Message- From: Dong, Guo Sent: Friday, October 15, 2021 8:28 AM To: devel@edk2.groups.io Cc: Dong, Guo ; Ni, Ray ; Ma, Maurice ; You, Benjamin Subject: [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot From: Guo Dong There is typo i

Re: [edk2-devel] [PATCH V2 21/28] OvmfPkg: Update PlatformPei to support TDX

Hi, > The original mailbox location is in low memory. If we do not relocate > to high memory, then the OS will see a hole in low memory. Well, both low and high memory to be exact. qemu maps the whole firmware image below 4G, and mirrors the topmost 128k (including memfd + reset vector) below

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

On Thu, Oct 14, 2021 at 05:11:22PM -0500, Brijesh Singh wrote: > > On 10/14/21 1:58 AM, Gerd Hoffmann wrote: > > On Wed, Oct 13, 2021 at 11:57:11AM -0500, Brijesh Singh wrote: > >> When SEV-SNP is active, the CPUID and Secrets memory range contains the > >> information that is used during the VM b

Re: [edk2-devel] [PATCH v9 04/32] OvmfPkg/ResetVector: introduce SEV metadata descriptor for VMM use

On Thu, Oct 14, 2021 at 02:51:47PM -0500, Brijesh Singh wrote: > > On 10/14/21 12:08 AM, Gerd Hoffmann wrote: > > On Wed, Oct 13, 2021 at 11:56:45AM -0500, Brijesh Singh wrote: > >> BZ: > >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3F

[edk2-devel] [`edk2-devel][PATCH V2] UefiPayloadPkg: Fix the build issue for coreboot

From: Guo Dong V2: Fix GCC build issue. There is typo in previous change caused coreboot build failue. This patch fixed the build issue. Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong --- UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++-- UefiPayloadPkg/UefiPa

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD

On Thu, Oct 14, 2021 at 01:17:11PM -0500, Brijesh Singh wrote: > The commit 80e67af9afca added support for the generic work area concept > used mainly by the encrypted VMs but missed update the AmdSev package. > > Fixes: 80e67af9afca ("OvmfPkg: introduce a common work area") Reviewed-by: Gerd Hof

Re: [edk2-devel] [PATCH 1/2] Ovmfpkg: update Ia32 build to use new work area

On Thu, Oct 14, 2021 at 01:17:10PM -0500, Brijesh Singh wrote: > The commit 80e67af9afca added support for the generic work area concept > used mainly by the encrypted VMs. In the past, the work area was > preliminary used by the SEV-ES VMs. The SEV-ES support is available for > the X64 builds only

Re: [edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

On Fri, Oct 15, 2021 at 03:57:28AM +, Yao, Jiewen wrote: > Would you please help me understand what the relationship is between > VirtioMmio and VirtioFdt ? > > The Bugzilla just states "add support for virtio-mmio devices". How VirtioFdt > comes into this case? The plan is to use an fdt to

Re: [edk2-devel] [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt

On Fri, Oct 15, 2021 at 03:54:19AM +, Yao, Jiewen wrote: > Hi > I am not sure where the problem is. "FdtClient is unhappy without a device > tree, so add an empty fdt" FdtClient throws an assert() in case no device tree is present. > Do we have option 2 to fix the issue? > If no device tree,

[edk2-devel] [PATCH v2 1/1] SecurityPkg/FvReportPei: Remove the ASSERT to allow neither M nor V

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2673 M mean that Measured Boot, V mean that Verified Boot. The FvReport do below: 1. Do nothing if neither M nor V 2. Allocate pages to save the firmware volume and use it to install firmware info Ppi 3. Install PreHashFv Ppi if the FV need m

[edk2-devel] [PATCH 1/1] SecurityPkg/FvReportPei: Remove the ASSERT to allow neither M nor V

REF: https://bugzilla.tiancore.org/show_bug.cgi?id=2673 M mean that Measured Boot, V mean that Verified Boot. The FvReport do below: 1. Do nothing if neither M nor V 2. Allocate pages to save the firmware volume and use it to install firmware info Ppi 3. Install PreHashFv Ppi if the FV need me

Re: [edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

Would you please help me understand what the relationship is between VirtioMmio and VirtioFdt ? The Bugzilla just states "add support for virtio-mmio devices". How VirtioFdt comes into this case? Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd

Re: [edk2-devel] [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt

Hi I am not sure where the problem is. "FdtClient is unhappy without a device tree, so add an empty fdt" Do we have option 2 to fix the issue? If no device tree, why we need FdtClient? Why we need make it happy? Thank you Yao Jiewen > -Original Message- > From: Gerd Hoffmann > Sent: Th

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Sounds good. Then Bret, you may change https://github.com/tianocore/edk2/blob/master/SecurityPkg/SecurityPkg.ci.yaml, to exclude the RC_NV_* naming check. Thank you Yao Jiewen From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Friday, October 15, 2021 9:56 AM To: Yao, Jiewen ; 'Bret Bar

Re: [edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

Patch series pushed: https://github.com/tianocore/edk2-platforms/commit/6b4a1eb461a87811627ee3bfdd847b1117aa155b https://github.com/tianocore/edk2-platforms/commit/59dc66e86afad34293a124b5facecd193ada26c8 https://github.com/tianocore/edk2-platforms/commit/df697c2230f8a0ff6a82bf12164e285c54e27a43

回复: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Jiewen: You can refer to MdeModulePkg\MdeModulePkg.ci.yaml ExceptionList to skip the specific keyword. Thanks Liming 发件人: Yao, Jiewen 发送时间: 2021年10月15日 8:54 收件人: Bret Barkelew ; Liming Gao ; Kinney, Michael D 抄送: devel@edk2.groups.io; Wang, Jian J ; Zhang, Qi1 ; Kumar, Rahul1 主题: RE

[edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

The current UEFI implementation of HTTPS during its TLS configuration uses EFI_TLS_VERIFY_FLAG_NO_WILDCARDS for host name verification. As per the spec this flag does is "to disable the match of any wildcards in the host name". So, certificates which are issued with wildcards(*.dm.corp.net etc) in

[edk2-devel] [PATCH] Add ECC cipher support and Wildcard host name matching in to HTTPS/TLS implementation

Signed-off-by: Vineel Kovvuri --- EDK-II-Release-Planning.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/EDK-II-Release-Planning.md b/EDK-II-Release-Planning.md index 21edc5b..adf0961 100644 --- a/EDK-II-Release-Planning.md +++ b/EDK-II-Release-Planning.md @@ -20,6 +20,8 @@ * [OVMF/Arm

Re: [edk2-devel] [PATCH V2 21/28] OvmfPkg: Update PlatformPei to support TDX

We have to relocate based upon best practice. The mailbox must be in ACPI-NVS. And the ACPI-NVS should be in high memory. The original mailbox location is in low memory. If we do not relocate to high memory, then the OS will see a hole in low memory. That is not preferred. Thank you Yao Jiewen

Re: 回复: [edk2-devel] Python2.7 is not working with the EDK2 build system

I and other people around me met the python2 build failures (crash without clear error message) repeatedly. If we already decided not to support python2, we'd better enforce not to auto set the PYTHON_COMMAND as python2 any longer and give a notice message in the build command against python2 us

Re: [edk2-devel] [PATCH V2 28/28] OvmfPkg: Add LocalApicTimerDxe

Good suggestion, Gerd. I agree with both suggestion. We should rename XenTimerDxe to LocalApicTimerDxe. > -Original Message- > From: Xu, Min M > Sent: Thursday, October 14, 2021 1:20 PM > To: devel@edk2.groups.io; kra...@redhat.com > Cc: Ard Biesheuvel ; Justen, Jordan L > ; Brijesh Sin

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

Pushed as 8194edc4af71799f163fe9735d0059dd90079ecc -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Wednesday, September 22, 2021 2:35 PM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Desimone, Nathaniel L Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1]

Re: [edk2-devel] [PATCH] Add ECC cipher support and Wildcard host name matching in to HTTPS/TLS implementation

I have fixed typo and push to https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > -Original Message- > From: Vineel Kovvuri > Sent: Friday, October 15, 2021 8:54 AM > To: Rabeda, Maciej ; Yao, Jiewen > ; devel@edk2.groups.io > Cc: Vineel Kovvuri > Subject: [P

Re: [edk2-devel] [PATCH] Enable wildcard host name matching in EDK2 HTTPS/TLS implementation

Reviewed-by: Jiewen Yao Since this https://bugzilla.tianocore.org/show_bug.cgi?id=3691 (networkpkg) is separated from https://bugzilla.tianocore.org/show_bug.cgi?id=3679 (cryptopkg), I will handle those two separately. I will only help merge 3679, and I would expect networkpkg maintainer handle

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleyOpenBoardPkg/PlatformHooksLib: Fix eSPI serial debug

Reviewed-by: Nate DeSimone > -Original Message- > From: Oram, Isaac W > Sent: Wednesday, September 22, 2021 2:35 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Desimone, Nathaniel L > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] > WhitleyOpenBoardPkg/PlatformHooksLib: Fix e

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Hi Liming/Mike Do you have any suggestion here? How do we change CI to add the name to exception list ? Thank you Yao Jiewen From: Bret Barkelew Sent: Friday, October 15, 2021 1:07 AM To: Yao, Jiewen Cc: devel@edk2.groups.io; Wang, Jian J ; Zhang, Qi1 ; Kumar, Rahul1 Subject: Re: [edk2-devel

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Pushed: https://github.com/tianocore/edk2-platforms/commit/86916cb > -Original Message- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Reviewed-by: Nate DeSimone > -Original Message- > From: devel@edk2.groups.io On Behalf Of > manickavasakam karpagavinayagam via groups.io > Sent: Thursday, October 14, 2021 3:30 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; fel...@ami.com; DOPPALAPUDI, > H

Re: [edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

For the series... Reviewed-by: Nate DeSimone > -Original Message- > From: Chiu, Chasel > Sent: Thursday, October 14, 2021 2:16 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Oram, Isaac W > ; Desimone, Nathaniel L > ; Luo, Heng ; > Jeremy Soller ; Benjamin Doron > ; Chaganty, Rangas

[edk2-devel] [PATCH] IntelFsp2Pkg: Add support for config editor to handle multiple UPD

BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3692 In several use cases in bootloader, there are multiple instances of UPD with same signature header. As such, using previous version of config editor to edit those will result in only overriding the first found instance. This patch provides th

Re: [edk2-devel] [PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record

Patch has been merged with Change-ID removed from commit message. From: Holland, Michael Sent: Tuesday, October 12, 2021 2:48 PM To: devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Ni, Ray Subject: [PATCH] IntelSiliconPkg/FirmwareInterfaceTable: Define FIT 4 record -=-=-=-=-=-=-=-=-=-=-=- G

[edk2-devel] [`edk2-devel][PATCH] UefiPayloadPkg: Fix the build issue for coreboot

From: Guo Dong There is typo in previous change caused coreboot build failue. This patch fixed the build issue. Cc: Ray Ni Cc: Maurice Ma Cc: Benjamin You Signed-off-by: Guo Dong --- UefiPayloadPkg/Library/CbParseLib/CbParseLib.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

Re: [edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Reviewed-by: Isaac Oram -Original Message- From: manickavasakam karpagavinayagam Sent: Thursday, October 14, 2021 3:30 PM To: devel@edk2.groups.io Cc: Oram, Isaac W ; Desimone, Nathaniel L ; fel...@ami.com; DOPPALAPUDI, HARIKRISHNA ; Jha, Manish ; Bobroff, Zachary ; KARPAGAVINAYAGAM,

Re: [edk2-devel] [PATCH v3] UefiPayloadPkg: Remove SystemTableInfo GUID.

gUefiSystemTableInfoGuid is an internal implementation used between payload entry module and EDKII modules. It is fine to remove it to avoid confusion that someone might think it is the interface between bootloader and payload. Since open sourced SBL already produce the HOBs gUniversalPayload

[edk2-devel] [PATCH] [edk2-platforms] [PATCH V1] Fix for WilsonCitySMT OS boot issue & using proper ASSERT macro

Fix to resolve the OS boot issue when booting on WilsonCitySMT board. ASSERT_EFI_ERROR(StatusParameter) needs to be passed with Error Status code and not with TRUE or FALSE. Replaced ASSERT_EFI_ERROR with ASSERT. Signed-off-by: Manickavasakam Karpagavinayagam --- Platform/Intel/WhitleyOpenBoard

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

On 10/14/21 1:58 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:57:11AM -0500, Brijesh Singh wrote: >> When SEV-SNP is active, the CPUID and Secrets memory range contains the >> information that is used during the VM boot. The content need to be persist >> across the kexec boot. Mark the m

Re: [edk2-devel] [PATCH v9 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status

On 10/14/21 1:41 AM, Gerd Hoffmann via groups.io wrote: > On Wed, Oct 13, 2021 at 11:57:03AM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C45efbf71

Re: [edk2-devel] [PATCH 3/5] Platform/RaspberryPi: Update Linux quirk name

Hi, On 10/1/21 7:52 PM, Jeremy Linton wrote: During review/merge of the linux ecam quirk, some logic was added to require the quirk name to be exactly 6 characters, matching the MADT field its overriding. As such, the rpi quirk here needed to be shorted by a character to avoid confusion. I'm

Re: [edk2-devel] [PATCH] Platform/RaspberryPi: Remove TypeTranslation attribute

Hi, On 10/10/21 4:10 PM, Ard Biesheuvel wrote: On Sun, 10 Oct 2021 at 21:48, Mark Kettenis wrote: The MMIO host bridge window isn't translated as both the primary and secondary side are MMIO. So remove the incorrect TypeTranslation attribute. Signed-off-by: Mark Kettenis Reviewed-by: Ard

Re: [edk2-devel] [PATCH v9 20/32] UefiCpuPkg: Define ConfidentialComputingGuestAttr

On 10/14/21 1:38 AM, Gerd Hoffmann wrote: > Hi, > >> + ## This dynamic PCD indicates the memory encryption attribute of the >> guest. >> + # @Prompt Memory encryption attribute >> + >> gUefiCpuPkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x6017 > See discussion in paral

Re: [edk2-devel] [PATCH v9 17/32] OvmfPkg/MemEncryptSevLib: add support to validate > 4GB memory in PEI phase

On 10/14/21 1:31 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:56:58AM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C82e310da29774221b2e908

Re: [edk2-devel] [PATCH v9 04/32] OvmfPkg/ResetVector: introduce SEV metadata descriptor for VMM use

On 10/14/21 12:08 AM, Gerd Hoffmann wrote: > On Wed, Oct 13, 2021 at 11:56:45AM -0500, Brijesh Singh wrote: >> BZ: >> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7Cee86130b95964399c70b0

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Support CLANGPDB builds

Currently, the flag "-fpie" is passed for all builds with a GCC family toolchain, including CLANGPDB. CLANGPDB however does not support this flag as it generates PE/COFF files directly. As the flag is mostly required for ARM-specific self-relocation, drop it for other architectures and document th

[edk2-devel] [PATCH v2 0/1] StandaloneMmPkg: Support CLANGPDB builds

V2: Update patch to account for ARM support Currently, the flag "-fpie" is passed for all builds with a GCC family toolchain, including CLANGPDB. CLANGPDB however does not support this flag as it generates PE/COFF files directly. As the flag is mostly required for ARM-specific self-relocation, dr

[edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD

The commit 80e67af9afca added support for the generic work area concept used mainly by the encrypted VMs but missed update the AmdSev package. Fixes: 80e67af9afca ("OvmfPkg: introduce a common work area") Cc: James Bottomley Cc: Min Xu Cc: Jiewen Yao Cc: Tom Lendacky Cc: Jordan Justen Cc: Ard

[edk2-devel] [PATCH 1/2] Ovmfpkg: update Ia32 build to use new work area

The commit 80e67af9afca added support for the generic work area concept used mainly by the encrypted VMs. In the past, the work area was preliminary used by the SEV-ES VMs. The SEV-ES support is available for the X64 builds only. But now, that work area header contains fields that nonencrypted VMs

[edk2-devel] [PATCH 0/2] work area fixes

We missed updating the AmdSev package and Ia32 buid to use new work area. Brijesh Singh (2): Ovmfpkg: update Ia32 build to use new work area OvmfPkg/AmdSev: update the fdf to use new workarea PCD OvmfPkg/AmdSev/AmdSevX64.fdf | 9 - OvmfPkg/OvmfPkgIa32X64.fdf| 3 +

Re: [edk2-devel] [edk2-platforms][PATCH 05/15] Platform/ARM: Use PcdPciIoTranslation PCD from MdePkg

Hi Abner, This patch: https://edk2.groups.io/g/devel/message/81310 renames: gArmTokenSpaceGuid.PcdPciMmio32Translation to: gEfiMdePkgTokenSpaceGuid.PcdPciMmio32Translation but gArmTokenSpaceGuid.PcdPciMmio32Translation is still used in ARM platforms, e.g.: SgiPkg/SgiPlatform.dsc.inc:155:  gArm

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

It looks like all errors are still related to ECC and PatchCheck, even though I'm just matching the rest of the file. Please advise if we want to update the entire file. On Thu, Oct 14, 2021 at 3:48 AM Yao, Jiewen wrote: > Hi Bret > I saw PR failure - https://github.com/tianocore/edk2/pull/2066

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

Hi Sami To clarify my description: I am OK to define it in an architecture neutral protocol, such as EFI_TEE_MEASUREMENT_PROTOCOL, or EFI_CCAM_PROTOCOL. I am happy to do that. However, at current point of time, I am not sure how other arch supports those feature, such as AMD SEV (https://www.am

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Marvin, It's fine to use your below patch to fix this issue. Please help to check-in it. https://edk2.groups.io/g/devel/message/78894?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CStandaloneMmPkg%3A+Support+CLANGPDB+X64+builds%2C20%2C2%2C0%2C84754068 Thanks Steven Shi > -Orig

[edk2-devel] [PATCH 5/5] OvmfPkg/Microvm: add README

Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3599 Signed-off-by: Gerd Hoffmann Acked-by: Jiewen Yao --- OvmfPkg/Microvm/README | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 OvmfPkg/Microvm/README diff --git a/OvmfPkg/Microvm/README

[edk2-devel] [PATCH 4/5] OvmfPkg/Microvm/virtio: add virtio-mmio support

Add virtio-mmio support (VirtioMmioDeviceLib and VirtioFdtDxe). https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 2 ++ OvmfPkg/Microvm/MicrovmX64.fdf | 1 + 2 files changed, 3 insertions(+) diff --git a/OvmfPkg/Microvm/Microvm

[edk2-devel] [PATCH 3/5] OvmfPkg/Microvm/fdt: add empty fdt

FdtClient is unhappy without a device tree, so add an empty fdt which we can use in case etc/fdt is not present in fw_cfg. https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/PlatformPei/Platform.c | 26 ++ 1 file changed, 22 inser

[edk2-devel] [PATCH 1/5] OvmfPkg/Microvm/fdt: add device tree support

Add fdt parser from EmbeddedPkg (FdtLib and FdtClientDxe) to MicrovmX64. Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --- OvmfPkg/Microvm/MicrovmX64.dsc | 6 ++ OvmfPkg/Microvm/MicrovmX64.fdf | 2 ++ 2 files changed, 8 insertions(+) diff --git a/Ovmf

[edk2-devel] [PATCH 2/5] OvmfPkg/Microvm/fdt: load fdt from fw_cfg

Needed for hardware detection: virtio-mmio devices for now, later also pcie root bridge. Depends on patched qemu which actually provides an fdt: https://gitlab.com/kraxel/qemu/-/commits/sirius/microvm-device-tree https://bugzilla.tianocore.org/show_bug.cgi?id=3689 Signed-off-by: Gerd Hoffmann --

[edk2-devel] [PATCH 0/5] [RfC] OvmfPkg/Microvm: second batch of microvm patches

Adds support for virtio-mmio devices to microvm. Needs patched qemu, so posting this only for review. Actual merge should wait until the host side changes are accepted to qemu. While being at it also add the README, the patch somehow disappeared from the first batch. Gerd Hoffmann (5): OvmfPkg

[edk2-devel] [PATCH 1/1] DynamicTablesPkg: Fix void pointer arithmetic

From: Pierre Gondois Building the DynamicTablesPkg with the additional -Wpointer-arith flag triggers the following error: "pointer of type ‘void *’ used in arithmetic [-Werror=pointer-arith]" Cast the void pointer to fix the error. Signed-off-by: Pierre Gondois --- .../Common/TableHelperL

Re: [edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

Series Reviewed-by: Isaac Oram -Original Message- From: Chiu, Chasel Sent: Thursday, October 14, 2021 2:16 AM To: devel@edk2.groups.io Cc: Chiu, Chasel ; Oram, Isaac W ; Desimone, Nathaniel L ; Luo, Heng ; Jeremy Soller ; Benjamin Doron ; Chaganty, Rangasai V ; Kethi Reddy, Deepika

Re: [edk2-devel] [edk2-rfc] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

On Mon, Oct 11, 2021 at 21:52:13 +, Samer El-Haj-Mahmoud wrote: > For the RFC itself, I personally do not have any objection, and > welcome the addition of this protocol to AARCH64, as long as it > utilizes the PSCI services to achieve the OS boot requirements. > > It may be worth getting feed

Re: [edk2-devel] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

On 9/28/21 5:14 AM, Leif Lindholm wrote: On Fri, Sep 24, 2021 at 20:17:50 -0600, Rebecca Cran wrote: I'd like to propose adding EFI_MP_SERVICES_PROTOCOL support for AARCH64 systems. I've attached two patches to implement support for it in the DXE phase, based on code in EmulatorPkg and UefiCpuP

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, October 15, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

Reviewed-by: Rebecca Cran On 10/14/21 1:23 AM, Ming Huang wrote: As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 for 64K granularity. Signed-off-by: Ming Huang --- ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

Hi Sami I am not sure if I can understand your comment - "Some interfaces may need to use an architecture specific library, and some configuration options would need to be defined using PCDs." Would you please be more specific? Thank you Yao Jiewen > -Original Message- > From: Xu, Min

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

On Thu, 14 Oct 2021 at 12:14, Chang, Abner (HPS SW/FW Technologist) wrote: > > Hi Are, I am so sorry about that I just merged it two hours ago. Any process > needed if we want to change the commit messages for adding your review tag? > Don't worry about it. > >

Re: [edk2-devel] [PATCH v2 1/1] SecurityPkg/Library: Add Tpm2NvUndefineSpaceSpecial to Tpm2CommandLib

Hi Bret I saw PR failure - https://github.com/tianocore/edk2/pull/2066 Thank you > -Original Message- > From: devel@edk2.groups.io On Behalf Of Bret > Barkelew > Sent: Thursday, October 14, 2021 1:33 AM > To: devel@edk2.groups.io > Cc: Yao, Jiewen ; Wang, Jian J ; > Zhang, Qi1 ; Kumar, R

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

Hi Are, I am so sorry about that I just merged it two hours ago. Any process needed if we want to change the commit messages for adding your review tag? Abner Get Outlook for Android From: Ard Biesheuvel Sent: Thursday, October 14, 2021 5

Re: [edk2-devel] [PATCH v1] ArmPkg/Smbios: Fix max cache size 2 wrong issue

+Rebecca On Thu, Oct 14, 2021 at 15:23:14 +0800, Ming Huang wrote: > As SMBIOS spec, bit-31 of maximum cache size 2 should be 1 > for 64K granularity. > > Signed-off-by: Ming Huang > --- > ArmPkg/Universal/Smbios/ProcessorSubClassDxe/ProcessorSubClass.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [edk2-devel] [PATCH V3 00/12] Migrate ArmVirtPkg modules to OvmfPkg

On Tue, 12 Oct 2021 at 06:17, Abner Chang wrote: > > Hi package maintainers, > > The review process of this patch set is almost done and please allow me to > merge it because the corresponding changes on edk2-platform is also required > to merge. > > > > Ard and Leif, do I need the Reviewed-by o

Re: [edk2-devel] [PATCH] OvmfPkg/Bhyve: Use QemuFwCfg over BhyveFwCtl

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Gerd > Hoffmann > Sent: Thursday, October 14, 2021 1:12 PM > To: Köhne, Corvin > Cc: Corvin Köhne ; Ard Biesheuvel > ; Yao, Jiewen ; Justen, > Jordan L ; Rebecca Cran ; > Peter Grehan ; devel@edk2.groups

Re: [edk2-devel] [PATCH] OvmfPkg/BhyveBhfPkg: install bhyve's ACPI tables

Acked-by: Jiewen Yao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Peter > Grehan > Sent: Thursday, October 14, 2021 1:42 PM > To: Köhne, Corvin > Cc: Ard Biesheuvel ; Yao, Jiewen > ; Justen, Jordan L ; Gerd > Hoffmann ; Rebecca Cran ; > devel@edk2.groups.io; Kinney, Mi

[edk2-devel] [edk2-platforms: PATCH v5 9/9] WhitleySiliconPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Isaac Oram Cc: Nat

[edk2-devel] [edk2-platforms: PATCH v5 8/9] WhitleyOpenBoardPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found. Also added PeiGetLargeVariable () to support the scenarios where the variable data size is bigger

[edk2-devel] [edk2-platforms: PATCH v5 7/9] WhiskeylakeOpenBoardPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Sign

[edk2-devel] [edk2-platforms: PATCH v5 6/9] TigerlakeOpenBoardPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Sai Chaganty Cc: N

[edk2-devel] [edk2-platforms: PATCH v5 5/9] KabylakeOpenBoardPkg/KabylakeRvp3: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Sign

[edk2-devel] [edk2-platforms: PATCH v5 4/9] KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms: PATCH v5 3/9] KabylakeOpenBoardPkg/AspireVn7Dash572G:Use same variable name for FspNvsHob

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms: PATCH v5 2/9] CometlakeOpenBoardPkg: Use same variable name for FspNvsHob.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 To simplify the implementation the variable Name/GUID has been changed to "FspNvsBuffer" and gFspNvsBufferVariableGuid regardless it stores the data from FSP_NON_VOLATILE_STORAGE_HOB2 or FSP_NON_VOLATILE_STORAGE_HOB. Cc: Nate DeSimone Cc:

[edk2-devel] [edk2-platforms: PATCH v5 1/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly and only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found. Also added PeiGetLargeVariable () to support the scenarios where the variable data size is bigger

[edk2-devel] [edk2-platforms: PATCH v5 0/9] MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2.

V5: Fix GCC build failure in LargeVariableWriteLib.c V4: . Switched to LargeVariableRead(Write)Lib in SaveMemoryConfig driver . Fixed tailing white space issue in PeiLib.c/.h . Updated function descriptions for PeiGetVariable() and PeiGetLargeVariable() . Added VariableReadLib to CorePeiLi

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hey Ard, Thanks for commenting! On 14.10.21 11:09, Ard Biesheuvel wrote: On Thu, 14 Oct 2021 at 11:08, Marvin Häuser wrote: Hey Steven, As I said, I prefer my patch, but this would work too of course. I talked about the PIE stuff with Ard before, so maybe he has an opinion on this? :) (Smal

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

On Thu, 14 Oct 2021 at 11:08, Marvin Häuser wrote: > > Hey Steven, > > As I said, I prefer my patch, but this would work too of course. > I talked about the PIE stuff with Ard before, so maybe he has an opinion > on this? :) > > (Small correction for my last e-mail, of course we are not *guarantee

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hey Steven, As I said, I prefer my patch, but this would work too of course. I talked about the PIE stuff with Ard before, so maybe he has an opinion on this? :) (Small correction for my last e-mail, of course we are not *guaranteed* there are *no* relocations in .text, but they'd all point t

Re: [edk2-devel] [PATCH V2 06/28] MdePkg: Update BaseIoLibIntrinsicSev to support Tdx

Hi, > > Hmm, I guess we should move the pcd then so it cam be used more widely. > > Confidential computing has an impact beyond just cpu, it's also memory, io > > and > > more. > How about define ConfidentialComputingAttr PCD in MdePkg.dec? Looks sensible to me. take care, Gerd -=-=-=-=-

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

Hi Marvin, How about we limit the -fno-pie option only apply on IA32 and X64 like below? diff --git a/StandaloneMmPkg/Core/StandaloneMmCore.inf b/StandaloneMmPkg/Core/StandaloneMmCore.inf [BuildOptions] GCC:*_*_*_CC_FLAGS = -fpie GCC:*_*_*_DLINK_FLAGS = -Wl,-z,text,-Bsymbolic,-pie +

Re: [edk2-devel] [PATCH v9 32/32] UefiCpuPkg/MpInitLib: Use SEV-SNP AP Creation NAE event to launch APs

On Wed, Oct 13, 2021 at 11:57:13AM -0500, Brijesh Singh wrote: > From: Tom Lendacky > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Use the SEV-SNP AP Creation NAE event to create and launch APs under > SEV-SNP. This capability will be advertised in the SEV Hypervisor > Feature S

Re: [edk2-devel] [PATCH v9 31/32] OvmfPkg/AmdSev: expose the SNP reserved pages through configuration table

On Wed, Oct 13, 2021 at 11:57:12AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Now that both the secrets and cpuid pages are reserved in the HOB, > extract the location details through fixed PCD and make it available > to the guest OS through the confi

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

On Wed, Oct 13, 2021 at 11:57:11AM -0500, Brijesh Singh wrote: > When SEV-SNP is active, the CPUID and Secrets memory range contains the > information that is used during the VM boot. The content need to be persist > across the kexec boot. Mark the memory range as Reserved in the EFI map > so that

Re: [edk2-devel] [PATCH v9 29/32] OvmfPkg/MemEncryptSevLib: skip page state change for Mmio address

On Wed, Oct 13, 2021 at 11:57:10AM -0500, Brijesh Singh wrote: > The SetMemoryEncDec() is used by the higher level routines to set or clear > the page encryption mask for system RAM and Mmio address. When SEV-SNP is > active, in addition to set/clear page mask it also updates the RMP table. > The R

Re: [edk2-devel] [PATCH v9 28/32] OvmfPkg/MemEncryptSevLib: change the page state in the RMP table

On Wed, Oct 13, 2021 at 11:57:09AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The MemEncryptSev{Set,Clear}PageEncMask() functions are used to set or > clear the memory encryption attribute in the page table. When SEV-SNP > is active, we also need to c

Re: [edk2-devel] [PATCH v9 27/32] UefiCpuPkg/MpInitLib: use BSP to do extended topology check

On Wed, Oct 13, 2021 at 11:57:08AM -0500, Brijesh Singh wrote: > From: Michael Roth > > During AP bringup, just after switching to long mode, APs will do some > cpuid calls to verify that the extended topology leaf (0xB) is available > so they can fetch their x2 APIC IDs from it. In the case of S

Re: [edk2-devel] [PATCH v9 26/32] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled

On Wed, Oct 13, 2021 at 11:57:07AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > An SEV-SNP guest requires that the physical address of the GHCB must > be registered with the hypervisor before using it. See the GHCB > specification section 2.3.2 for more

Re: [edk2-devel] [PATCH v9 25/32] MdePkg/GHCB: increase the GHCB protocol max version

On Wed, Oct 13, 2021 at 11:57:06AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Now that OvmfPkg supports version 2 of the GHCB specification, bump the > protocol version. Acked-by: Gerd Hoffmann -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive

Re: [edk2-devel] [PATCH v9 24/32] OvmfPkg/PlatformPei: set the Hypervisor Features PCD

On Wed, Oct 13, 2021 at 11:57:05AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of the GHCB specification added the support to query the > hypervisor feature bitmap. The feature bitmap provide information > such as whether to use the AP create

Re: [edk2-devel] [PATCH v9 23/32] UefiCpuPkg: add PcdGhcbHypervisorFeatures

On Wed, Oct 13, 2021 at 11:57:04AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of the GHCB specification added a new VMGEXIT that the guest > could use for querying the hypervisor features. One of the immediate > users for it will be an AP cr

Re: [edk2-devel] [PATCH v9 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status

On Wed, Oct 13, 2021 at 11:57:03AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Previous commit introduced a generic confidential computing PCD that can > determine whether AMD SEV-ES is enabled. Update the MpInitLib to drop the > PcdSevEsIsEnabled in f

Re: [edk2-devel] [PATCH v9 21/32] OvmfPkg/PlatformPei: set PcdConfidentialComputingAttr when SEV is active

On Wed, Oct 13, 2021 at 11:57:02AM -0500, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > The MpInitLib uses the ConfidentialComputingAttr PCD to determine whether > AMD SEV is active so that it can use the VMGEXITs defined in the GHCB > specification to create A

  1   2   >