Re: [edk2-devel] [edk2-platforms] [PATCH v3 00/14] Use generic OpenSBI platform

2021-10-18 Thread Abner Chang
Merged. Thanks > -Original Message- > From: Schaefer, Daniel > Sent: Tuesday, October 19, 2021 11:49 AM > To: devel@edk2.groups.io > Cc: Schaefer, Daniel ; Chang, Abner (HPS > SW/FW Technologist) ; Sunil V L > > Subject: [edk2-platforms] [PATCH v3 00/14] Use generic OpenSBI platform >

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Replace MEMROY_ENTRY by MEMORY_ENTRY

2021-10-18 Thread Guo Dong
Sorry I forgot to merge this patch. It was just merged. /Guo -Original Message- From: devel@edk2.groups.io On Behalf Of Moritz Fischer via groups.io Sent: Monday, October 18, 2021 5:39 PM To: devel@edk2.groups.io; Dong, Guo Subject: Re: [edk2-devel] [PATCH] UefiPayloadPkg: Replace

[edk2-devel] [edk2-platforms] [PATCH v3 09/14] RISC-V/PlatformPkg: Add FdtPeim to pass DTB from PEI to DXE via HOB

2021-10-18 Thread Daniel Schaefer
From: Abner Chang Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 5 ++ Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf | 1 +

[edk2-devel] [edk2-platforms] [PATCH v3 13/14] RISC-V: Implement ResetSystem RT call

2021-10-18 Thread Daniel Schaefer
Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc| 12 +- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 12 +-

[edk2-devel] [edk2-platforms] [PATCH v3 10/14] RISC-V/PlatformPkg: Fixup FDT from HOB and install into config table

2021-10-18 Thread Daniel Schaefer
The Linux EFISTUB reads the FDT from the EFI system configuration table. Before installing the FDT needs to be patched with the booting hartid, because the kernel in S-Mode cannot determine it. Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel

[edk2-devel] [edk2-platforms] [PATCH v3 14/14] Move OpenSbiPlatformLib to RISC-V/PlatformPkg

2021-10-18 Thread Daniel Schaefer
It's a generic platform file. Only the device tree decides what happens. Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc

[edk2-devel] [edk2-platforms] [PATCH v3 07/14] U540: Add and build device tree

2021-10-18 Thread Daniel Schaefer
Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 2 + Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf

[edk2-devel] [edk2-platforms] [PATCH v3 12/14] RISC-V: Switch to latest OpenSBI

2021-10-18 Thread Daniel Schaefer
Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Silicon/RISC-V/ProcessorPkg/Library/RiscVOpensbiLib/RiscVOpensbiLib.inf | 13 +++-

[edk2-devel] [edk2-platforms] [PATCH v3 11/14] U5SeriesPkg: Switch to generic OpenSBI platform

2021-10-18 Thread Daniel Schaefer
New platform files require more space in SEC. Behavior is determined not by source code but by device tree. Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer ---

[edk2-devel] [edk2-platforms] [PATCH v3 08/14] RISC-V/PlatformPkg: Build DeviceTree and use that in SEC

2021-10-18 Thread Daniel Schaefer
OpenSBI uses the device tree for platform specific initialization, so we need to have it already in SEC. Cc: Daniel Schaefer Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/RISC-V/PlatformPkg/RiscVPlatformPkg.dec| 4 ++

[edk2-devel] [edk2-platforms] [PATCH v3 04/14] Silicon/RISC-V: Introduce FirmwareContext library

2021-10-18 Thread Daniel Schaefer
From: Abner Chang Add RISC-V FirmwareContext library for different FirmwareContext implementations. This instance uses SBI firmware extension to get the pointer to FirmwareContext. Cc: Sunil V L Cc: Daniel Schaefer Reviewed-by: Abner Chang Reviewed-by: Daniel Schaefer Signed-off-by: Abner

[edk2-devel] [edk2-platforms] [PATCH v3 06/14] SiFive/U5SeriesPkg: Use FirmwareContext library

2021-10-18 Thread Daniel Schaefer
From: Abner Chang Use RISC-V FirmwareContext library to set and get the pointer of PeiService on SiFive U5 series platforms. Cc: Sunil V L Cc: Daniel Schaefer Reviewed-by: Daniel Schaefer Signed-off-by: Abner Chang --- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc |

[edk2-devel] [edk2-platforms] [PATCH v3 05/14] Silicon/RISC-V: PeiServiceTableLib uses RiscVFirmwareContextLib

2021-10-18 Thread Daniel Schaefer
From: Abner Chang Use RISC-V FirmwareContext library to set and get the pointer of PeiService. Cc: Sunil V L Cc: Daniel Schaefer Reviewed-by: Daniel Schaefer Signed-off-by: Abner Chang ---

[edk2-devel] [edk2-platforms] [PATCH v3 03/14] RISC-V: Use U5 SMBIOS library only for those platforms

2021-10-18 Thread Daniel Schaefer
Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 2 +- Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 2 +-

[edk2-devel] [edk2-platforms] [PATCH v3 01/14] U5SeriesPkg: Deduplicate PlatformPei

2021-10-18 Thread Daniel Schaefer
The current (and future) RISC-V platforms share a lot of PlatformPei code that does not need to be duplicated. If we see that they need to have different behavior in the future, we can add platform specific libraires for that specific code. The upcoming RiscvVirt is only 1205 lines with this

[edk2-devel] [edk2-platforms] [PATCH v3 02/14] RISC-V: Split SMBIOS out of PlatformPei

2021-10-18 Thread Daniel Schaefer
Cc: Abner Chang Cc: Sunil V L Reviewed-by: Abner Chang Signed-off-by: Daniel Schaefer --- Platform/SiFive/U5SeriesPkg/Include/SiFiveU5MCCoreplex.h| 33 Platform/RISC-V/PlatformPkg/Universal/Pei/PlatformPei/Platform.c| 17 +-

[edk2-devel] [edk2-platforms] [PATCH v3 00/14] Use generic OpenSBI platform

2021-10-18 Thread Daniel Schaefer
Just fixed up the patches to conform with PatchCheck.py from edk2. Reviewed by Abner, good to merge. Cc: Abner Chang Cc: Sunil V L Abner Chang (4): Silicon/RISC-V: Introduce FirmwareContext library Silicon/RISC-V: PeiServiceTableLib uses RiscVFirmwareContextLib SiFive/U5SeriesPkg: Use

[edk2-devel][PATCH v2] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread Yang Jie
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3655 The code in FmpDevicePkg call the deprecated interface VariableLockRequestToLockc. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. Signed-off-by: Yang Jie Cc: Liming Gao Cc:

[edk2-devel] [PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread Yang Jie
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3655 The code in FmpDevicePkg call the deprecated interface VariableLockRequestToLockc. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. Signed-off-by: Yang Jie Cc: Liming Gao Cc:

Re: [edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread Yang Jie
Thank you very much for your review, but I find I missed something in the definition of the function LockFmpVariable, it is defined as follow: static EFI_STATUS LockFmpVariable ( IN EFI_STATUSPreviousStatus, EDKII_VARIABLE_POLICY_PROTOCOL *VariablePolicy, IN CHAR16

Re: [edk2-devel] [PATCH 0/2] work area fixes

2021-10-18 Thread Yao, Jiewen
Yes, I tried again today. It works. https://github.com/tianocore/edk2/pull/2080 Pushed: 36b561623a4b8a6c7fea0b1b01f6789f2adf97e0.. 11a4af85a438b5b3d8cde942a209908219c57363 Thank you Yao Jiewen > -Original Message- > From: Xu, Min M > Sent: Tuesday, October 19, 2021 8:22 AM > To: Yao,

Re: [edk2-devel] [PATCH v6 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-18 Thread IanX Kuo
@Liming Gao Sorry to bother you. May I get your help for review by again ? Thanks, Ian Kuo -Original Message- From: devel@edk2.groups.io On Behalf Of IanX Kuo Sent: Monday, October 18, 2021 12:21 PM To: devel@edk2.groups.io Cc: Chan, Amy ; Ni, Ray ; Kuo, IanX ; Wang, Jian J ; Liming

Re: [edk2-devel] [PATCH v6 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-18 Thread IanX Kuo
@Yao, Jiewen and @Jiang, Guomin Sorry to bother you. May I get your help for review-by ? Thanks, Ian Kuo -Original Message- From: devel@edk2.groups.io On Behalf Of IanX Kuo Sent: Monday, October 18, 2021 12:21 PM To: devel@edk2.groups.io Cc: Chan, Amy ; Ni, Ray ; Kuo, IanX ; Yao,

Re: [edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread Xu, Wei6
Reviewed-by: Wei6 Xu -Original Message- From: devel@edk2.groups.io On Behalf Of gaoliming Sent: Tuesday, October 19, 2021 9:47 AM To: devel@edk2.groups.io; Yang, Jie Cc: Kinney, Michael D ; Jiang, Guomin ; Xu, Wei6 Subject: 回复: [edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new

Re: [edk2-devel] [PATCH v6 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-18 Thread Ni, Ray
Reviewed-by: Ray Ni -Original Message- From: Kuo, IanX Sent: Monday, October 18, 2021 12:21 PM To: devel@edk2.groups.io Cc: Chan, Amy ; Ni, Ray ; Kuo, IanX ; Dong, Eric ; Kumar, Rahul1 Subject: [PATCH v6 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib From: IanX

回复: [edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread gaoliming
Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Yang Jie > 发送时间: 2021年10月18日 13:14 > 收件人: devel@edk2.groups.io > 抄送: gaolim...@byosoft.com.cn; michael.d.kin...@intel.com; > guomin.ji...@intel.com; wei6...@intel.com; yangjie > 主题: [edk2-devel][PATCH] FmpDevicePkg/FmpDxe:

[edk2-devel] Cancelled Event: TianoCore Bug Triage - APAC / NAMO - Tuesday, October 19, 2021 #cal-cancelled

2021-10-18 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

回复: [edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 10/19/2021 #cal-reminder

2021-10-18 Thread gaoliming
Few issues are submitted this week. Let’s cancel the meeting. ID

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 10/19/2021 #cal-reminder

2021-10-18 Thread devel@edk2.groups.io Calendar
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20201011T015911Z

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Replace MEMROY_ENTRY by MEMORY_ENTRY

2021-10-18 Thread Moritz Fischer via groups.io
On Wed, May 5, 2021 at 8:55 PM Guo Dong wrote: > > > Reviewed-by: Guo Dong How does this get picked up? > > > -Original Message- > > From: Moritz Fischer > > Sent: Wednesday, May 5, 2021 8:44 PM > > To: devel@edk2.groups.io > > Cc: Moritz Fischer ; Ma, Maurice > > ; Dong, Guo ; You, >

Re: [edk2-devel] [PATCH 0/2] work area fixes

2021-10-18 Thread Min Xu
Jiewen I just create a new PR based on the latest commit (2108698346) for the patch-set of "work area fixes" and it seems all checks have passed. https://github.com/tianocore/edk2/pull/2078 I suspect the previous failure was caused by the un-stability of EDK2 CI system. Maybe you can create a

[edk2-devel] [PATCH v2 5/5] Platform/RaspberryPi: Disconnect/shutdown all drivers before reboot

2021-10-18 Thread Jeremy Linton
In theory we should be properly cleaning up all the device drivers before hitting the big reset. The partition manager will issue flush commands to attached disks as it goes down. This assures that devices running in WB mode, which correctly handle flush/sync/etc commands, are persisted to

[edk2-devel] [PATCH v2 4/5] Platform/RaspberryPi: Normal memory should not be marked as uncached

2021-10-18 Thread Jeremy Linton
The efi spec seems to indicate that the efi uncacheable attribute should be mapped to device memory rather than normal-nc. This means that the uefi mem attribute for the >3G ram doesn't match the remainder of the RAM in the machine. So, lets remove the uncacheable attribute to make it more

[edk2-devel] [PATCH v2 2/5] Platform/RaspberryPi: Fix vfr warning caused by two defaults

2021-10-18 Thread Jeremy Linton
The build has been tossing a warning about having two defaults for a while now, lets fix it. Signed-off-by: Jeremy Linton Reviewed-by: Andrei Warkentin --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH v2 3/5] Platform/RaspberryPi: Expand locking to cover return data

2021-10-18 Thread Jeremy Linton
It appears that the locking for many of the mailbox commands is incorrect. All UEFI firmware calls to the RPi mailbox share a single mDmaBuffer. That buffer is used to fill out the command passed to the vc firmware, and record its response. The buffer is protected by mMailboxLock, yet in many

[edk2-devel] [PATCH v2 0/5] Platform/Rpi: Various cleanups + DT booting

2021-10-18 Thread Jeremy Linton
From: Jeremy Linton This set is a few patches I've been collecting to fix minor issues I've seen while debugging other problems, or just various things I think should probably be changed. It also includes the patch to adjust the PCIe/XHCI dma-attributes which fixes DT booting on recent Linux

[edk2-devel] [PATCH v2 1/5] Platform/RaspberryPi: Always use non translating DMA in DT mode

2021-10-18 Thread Jeremy Linton
One of the many issues with the PCIe on this platform is its inbound DMA is either constrained to the lower 3G, or on later SOC's a translation may be used. That translation is problematic with some of the OS's expected to boot on this platform. So, across the board a 3G DMA limit is enforced

[edk2-devel] [PATCH] MdeModulePkg/DxeCapsuleLibFmp: Capsule on Disk file name capsule

2021-10-18 Thread Bob Morgan via groups.io
Enhance RelocateCapsuleToRam() to skip creation of the Capsule on Disk file name capsule if PcdSupportUpdateCapsuleReset feature is not enabled. This avoids an EFI_UNSUPPORTED return status from UpdateCapsule() when the file name capsule is encountered and PcdSupportUpdateCapsuleReset is FALSE.

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

2021-10-18 Thread Vineel Kovvuri via groups.io
Hi Jiewen, Sorry for the build break. I will fix this locally and send you the patch. Thanks, Vineel -Original Message- From: Yao, Jiewen Sent: Saturday, October 16, 2021 7:49 PM To: Vineel Kovvuri ; devel@edk2.groups.io; Sean Brogan ; Bret Barkelew ; Mike Turner Cc: Vineel Kovvuri

[edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread Yang Jie
From: yangjie REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3655 The code in FmpDevicePkg called the deprecated interface VariableLockRequestToLock. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated interface. Signed-off-by: Yang Jie

[edk2-devel][PATCH] FmpDevicePkg/FmpDxe: Use new Variable Lock interface

2021-10-18 Thread Yang, Jie
From: yangjie mailto:jie.y...@intel.com>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3655 The code in FmpDevicePkg called the deprecated interface VariableLockRequestToLock. So I changed the code in FmpDevicePkg using RegisterBasicVariablePolicy, instead of the deprecated

Re: [edk2-devel] [`edk2-devel][PATCH v2] UefiPayloadPkg: Fix ECC reported issues

2021-10-18 Thread Ma, Maurice
Reviewed-by: Maurice Ma > -Original Message- > From: devel@edk2.groups.io On Behalf Of Guo > Dong > Sent: Friday, October 15, 2021 16:35 > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Ma, > Maurice ; You, Benjamin > > Subject: [edk2-devel] [`edk2-devel][PATCH v2]

Re: [edk2-devel] [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-10-18 Thread Jeremy Linton
Hi, On 10/18/21 10:10 AM, Chris Jones via groups.io wrote: Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, remove support for parsing PPTT type 2 ID structure. Signed-off-by: Chris Jones ---

Re: [edk2-devel] [PATCH v2 8/8] DynamicTablesPkg: IORT generator updates for Rev E.b spec

2021-10-18 Thread PierreGondois
Hi Sami, With the small modification: Reviewed-by: Pierre Gondois On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > Bugzilla: 3458 - Add support IORT Rev E.b specification updates > (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) > > The IO Remapping Table, Platform Design

Re: [edk2-devel] [PATCH v2 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.b

2021-10-18 Thread PierreGondois
Hi Sami, With the small modifications: Reviewed-by: Pierre Gondois On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > Bugzilla: 3458 - Add support IORT Rev E.b specification updates > (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) > > The IO Remapping Table, Platform

Re: [edk2-devel] [PATCH v2 7/8] DynamicTablesPkg: Update ArmNameSpaceObjects for IORT Rev E.b

2021-10-18 Thread PierreGondois
Hi Sami, With the small modifications: Reviewed-by: Pierre Gondois On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > Bugzilla: 3458 - Add support IORT Rev E.b specification updates > (https://bugzilla.tianocore.org/show_bug.cgi?id=3458) > > The IO Remapping Table, Platform

Re: [edk2-devel] [PATCH v2 6/8] DynamicTablesPkg: IORT set reference to interrupt array if present

2021-10-18 Thread PierreGondois
Hi Sami, With the small modification: Reviewed-by: Pierre Gondois On 6/17/21 10:55, Sami Mujawar via groups.io wrote: > The IORT generator is populating the reference field for Context and > PMU interrupts even if their count is zero. > > Update the IORT generator to set the references only

[edk2-devel] [PATCH 2/2] ArmPkg: Add Library/MpInitLib to support EFI_MP_SERVICES_PROTOCOL

2021-10-18 Thread Rebecca Cran
Add support for EFI_MP_SERVICES_PROTOCOL during the DXE phase under AArch64. PSCI_CPU_ON is called to power on the core, the supplied procedure is executed and PSCI_CPU_OFF is called to power off the core. Minimal setup is done before calling the supplied procedure: for example the MMU and

[edk2-devel] [PATCH 1/2] ArmPkg: Replace CoreId and ClusterId with Mpidr in ARM_CORE_INFO struct

2021-10-18 Thread Rebecca Cran
Remove the ClusterId and CoreId fields in the ARM_CORE_INFO structure in favor of a new Mpidr field. Update code in ArmPlatformPkg/PrePeiCore/MainMPCore and ArmPlatformPkg/PrePi/MainMPCore.c to use the new field and call new macros GET_MPIDR_AFF0 and GET_MPIDR_AFF1 instead. Signed-off-by: Rebecca

[edk2-devel] [PATCH 0/2] Add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-18 Thread Rebecca Cran
Patch 1/2 is the start of addressing the issue that the Aff0 field of the MPIDR is no longer guaranteed to be the core, and should be referred to in a more generic way: for example it could be the thread, with Aff1 being the core and Aff2 the cluster. Clearly much more work is needed to fully

[edk2-devel] [PATCH v1 7/7] DynamicTablesPkg: Add CacheId to PPTT generator

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator with the CacheId field as defined in table 5.140 of the ACPI 6.4 specification. Also add validations to ensure that the cache id generated is unique. Signed-off-by: Chris Jones ---

[edk2-devel] [PATCH v1 6/7] DynamicTablesPkg: Update PPTT generator to ACPI 6.4

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the PPTT generator to use Acpi64.h. Signed-off-by: Chris Jones --- DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c | 44 ++-- 1 file changed, 22 insertions(+), 22 deletions(-) diff

[edk2-devel] [PATCH v1 5/7] DynamicTablesPkg: Remove PPTT ID structure from ACPI 6.4 generator

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) ACPI 6.3A deprecated PPTT ID (type 2) structure which was subsequently removed in ACPI 6.4. Therefore remove support for generating PPTT ID structures. Signed-off-by: Chris Jones ---

[edk2-devel] [PATCH v1 3/7] ShellPkg: Update Acpiview PPTT parser to ACPI 6.4

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser to use Acpi64.h. As part of the changes, remove support for parsing PPTT type 2 ID structure. Signed-off-by: Chris Jones ---

[edk2-devel] [PATCH v1 4/7] ShellPkg: Add Cache ID to PPTT parser

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Update the Acpiview PPTT parser with the Cache ID field and relevant validations as defined in tables 5.140 and 5.141 of the ACPI 6.4 specification. Signed-off-by: Chris Jones ---

[edk2-devel] [PATCH v1 1/7] MdePkg: Add missing Cache ID (in)valid define

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) Add Cache ID valid/invalid defines to Acpi64.h which were not initially added when the CacheIdValid field was added to EFI_ACPI_6_4_PPTT_STRUCTURE_CACHE_FLAGS. Signed-off-by: Chris Jones ---

[edk2-devel] [PATCH v1 0/7] Support ACPI 6.4 PPTT changes

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) This patch series updates the Acpiview PPTT parser and DynamicTablesPkg PPTT generator to support ACPI 6.4. This consists of two main changes: - The addition of the 'Cache ID' field. - The removal of the PPTT ID (type 2)

[edk2-devel] [PATCH v1 2/7] MdePkg: Remove PPTT ID type structure

2021-10-18 Thread Chris Jones
Bugzilla: 3697 (https://bugzilla.tianocore.org/show_bug.cgi?id=3697) The ACPI 6.3A specification deprecated the PPTT ID type structure (type 2) therefore remove it from Acpi64.h. Mantis ID: 2072 (https://mantis.uefi.org/mantis/view.php?id=2072) Signed-off-by: Chris Jones ---

Re: [edk2-devel] [PATCH 0/2] work area fixes

2021-10-18 Thread Yao, Jiewen
That is weird. But I am not tool person. HI Liming/Mike/Sean Would you please take a look and help us understand what's happening? Thank you Yao Jiewen > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh > Singh via groups.io > Sent: Monday, October 18, 2021 10:45 PM

Re: [edk2-devel] [PATCH 0/2] work area fixes

2021-10-18 Thread Brijesh Singh via groups.io
On 10/18/21 8:14 AM, Yao, Jiewen wrote: > Hi > This patch failed in PR - >

[edk2-devel] [edk2platforms][PATCH v2 1/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-18 Thread Maciej Czajkowski
Added IntelDieInfoProtocol header into IntelSiliconPkg tree. The purpose is to have generic and unified interface for getting information about dies installed in the system. It will be implemented by silicon code. Change-Id: Iedc414d435c27f37e6f12e7affd046a0a9e7e19d Cc: Ray Ni Cc: Rangasai V

[edk2-devel] [edk2platforms][PATCH v2 0/1] IntelSiliconPkg: Add IntelDieInfoProtocol

2021-10-18 Thread Maciej Czajkowski
This commit will add a protocol/PPI definition which will provide a generic and unified way to get information about dies installed in the system(PCH, SoC, CPU). It will be implemented per generation in silicon packages. v2 changes: - added interface description - added die specific GUIDs into

Re: [edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Support CLANGPDB builds

2021-10-18 Thread Ard Biesheuvel
On Mon, 18 Oct 2021 at 03:18, Steven Shi wrote: > > Acked-by: Shi Steven > > > Hello Ard, > Could you review and check-in this patch? It blocks our clang build. > > Merged as #2077 Thanks, Ard. > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Marvin > > Häuser >

Re: [edk2-devel] [PATCH 0/2] work area fixes

2021-10-18 Thread Yao, Jiewen
Hi This patch failed in PR - https://github.com/tianocore/edk2/pull/2076 Please take a look. You are encouraged to try PR before submit next time. Thank you Yao Jiewen > -Original Message- > From: Yao, Jiewen > Sent: Monday, October 18, 2021 12:53 PM > To: devel@edk2.groups.io;

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

2021-10-18 Thread Yao, Jiewen
Sure. It works fine. May I know *when* I can get your initial feedback ? I hope in days or 1 or 2 weeks. I don’t want to wait for several months, as we have features depend upon it. Thank you Yao Jiewen > -Original Message- > From: Sami Mujawar > Sent: Monday, October 18, 2021 9:00 PM

Re: [edk2-devel] [PATCH V2 0/3] Introduce TdProtocol into EDK2

2021-10-18 Thread Sami Mujawar
Hi Jiewen, We don't have publicly available documentation to share in this area, however we strongly prefer an architecture agnostic solution, and my initial suggestions takes us in that direction. I am happy to work on mailing list with you to make these changes and review necessary code

Re: [edk2-devel] [edk2-rfc] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-18 Thread Leif Lindholm
On Mon, Oct 18, 2021 at 10:21:59 +0100, Sami Mujawar wrote: > > In fact ... we could use more help on ArmPkg in general. Would you be > > up for becoming an additional Maintainer or Reviewer? > [SAMI] I can start helping with the review of the patches to start with, and > we can revisit the

Re: [edk2-devel] [edk2-rfc] [RFC] [PATCH 0/2] Proposal to add EFI_MP_SERVICES_PROTOCOL support for AARCH64

2021-10-18 Thread Sami Mujawar
Hi Leif, Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 14/10/2021 02:14 PM, Leif Lindholm wrote: On Mon, Oct 11, 2021 at 21:52:13 +, Samer El-Haj-Mahmoud wrote: For the RFC itself, I personally do not have any objection, and welcome the addition of this protocol

[edk2-devel] [PATCH v2] IntelSiliconPkg/IntelVTdDxe: Support Multi PCI Root Bus

2021-10-18 Thread Sheng Wei
Some system may has multi PCI root bus. It needs to use function PciHostBridgeGetRootBridges () to get the root bus count. Then, scan each root bus to get all devices. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3695 Signed-off-by: Robert Kowalewski Signed-off-by: Sheng Wei Cc: Jenny

[edk2-devel] [PATCH] IntelSiliconPkg/IntelVTdDxe: Support Multi PCI Root Bus

2021-10-18 Thread Sheng Wei
Some system may has multi PCI root bus. It needs to use function PciHostBridgeGetRootBridges () to get the root bus count. Then, scan each root bus to get all devices. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3695 Change-Id: I0c647d03dff574d1d2a12e7c8a1426d29217fa5c Signed-off-by:

Re: [edk2-devel] [PATCH V2 24/28] OvmfPkg: Add TdxDxe driver

2021-10-18 Thread Min Xu
On October 12, 2021 7:50 PM, Gerd Hoffmann wrote: > Hi, > > > Besides above features, TdxDxe driver will update the ACPI MADT > > Mutiprocessor Wakeup Table. > > > + ACPI_MADT_MPWK_STRUCT *MadtMpWk; > > > + NewBufferSize = 1 * sizeof (*Madt)

[edk2-devel] [PATCH 1/1] NetworkPkg/HttpBootDxe: make file extension check case-insensitive

2021-10-18 Thread Lin, Gary (HPS OE-Linux)
https://bugzilla.tianocore.org/show_bug.cgi?id=3694 HttpBootCheckImageType() was using the case-sensitive AsciiStrCmp() to check the file extensions and this could reject the images with upper-case file names. Using the case-insensitive AsciiStriCmp() to avoid the issue. Cc: Maciej Rabeda Cc:

Re: [edk2-devel] [PATCH 1/2] Ovmfpkg: update Ia32 build to use new work area

2021-10-18 Thread Min Xu
On October 15, 2021 2:17 AM, Brijesh Singh wrote: > > The commit 80e67af9afca added support for the generic work area concept > used mainly by the encrypted VMs. In the past, the work area was preliminary > used by the SEV-ES VMs. The SEV-ES support is available for the X64 builds > only. > But

Re: [edk2-devel] [PATCH 2/2] OvmfPkg/AmdSev: update the fdf to use new workarea PCD

2021-10-18 Thread Min Xu
On October 15, 2021 2:17 AM, Brijesh Singh wrote: > The commit 80e67af9afca added support for the generic work area concept > used mainly by the encrypted VMs but missed update the AmdSev package. > > Fixes: 80e67af9afca ("OvmfPkg: introduce a common work area") > Cc: James Bottomley > Cc: Min

Re: [edk2-devel] [PATCH v9 30/32] OvmfPkg/PlatformPei: mark cpuid and secrets memory reserved in EFI map

2021-10-18 Thread Gerd Hoffmann
Hi, > The MEMFD range is outside of the firmware image map,  MEMFD begins with > 0x80 [1] and in my boots I don't see it reserved in e820. Ah, ok. > Here is the snippet. > > [ ... ] > [    0.00] BIOS-e820: [mem 0x0080-0x00807fff] ACPI NVS > [    0.00]