Re: [edk2-devel] [PATCH] MdeModulePkg/FPDT: Lock boot performance table address variable at EndOfDxe

Sure. Pull request is created. https://github.com/tianocore/edk2/pull/2200 Thanks, Dandan > -Original Message- > From: gaoliming > Sent: Friday, November 12, 2021 9:21 AM > To: devel@edk2.groups.io; Bi, Dandan > Cc: Wu, Hao A ; Wang, Jian J > Subject: 回复: [edk2-devel] [PATCH] MdeModule

Re: [edk2-devel] [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations

Sorry for the confusing. My word is not accurate. When I say "internal" in this context, I really mean: it is produced and consumed by OVMF. The API will not be called by *third party*, such as OS loader, or Option ROM. If so, it is OK to add ASSERT. If you look at the BaseLib, many functions a

Re: [edk2-devel] [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations

On November 12, 2021 10:42 AM, Yao Jiewen wrote: > BTW: Is this internal API? > I feel we should add ASSERT() for invalid page size as well, to catch issue > earlier. TdAcceptPages () is not an internal API. It is exposed in TdxLib. Sure, I will add more check to the input parameter in the code.

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

Hi Ray, Thank you very much for the help. BR Sheng Wei > -Original Message- > From: Ni, Ray > Sent: 2021年11月12日 11:21 > To: Sheng, W ; devel@edk2.groups.io > Cc: Dong, Eric ; Kumar, Rahul1 > > Subject: RE: [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM > Interrupt Shadow Stack > > Review

Re: [edk2-devel] [PATCH v12 20/32] MdePkg: Define ConfidentialComputingGuestAttr

thank you, Ray! thank you! Yao, Jiewen > 在 2021年11月12日，上午11:19，Ni, Ray 写道： > > Jiewen, > Sure. I am ok with this. > Acked-by: Ray Ni > It doesn't make the code worse. Dynamic PCD was there already. > > Thanks, > Ray > > > >> -Original Message- >> From: Yao, Jiewen >> Sent: Frida

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

Hi Ray, Thanks for pointing this out. That makes sense. I should make the commit message from community perspective instead of platform. I will make this change. Best Regards, Gao -Original Message- From: Ni, Ray Sent: Thursday, November 11, 2021 9:50 PM To: Cheng, Gao ; devel@edk2.gr

Re: [edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

Reviewed-by: Ray Ni I will create PR by end of my today since this patch fixes a critical issue when enabling CET in SMM. > -Original Message- > From: Sheng, W > Sent: Friday, November 12, 2021 9:40 AM > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul1 > Subject:

Re: [edk2-devel] [PATCH v12 20/32] MdePkg: Define ConfidentialComputingGuestAttr

Jiewen, Sure. I am ok with this. Acked-by: Ray Ni It doesn't make the code worse. Dynamic PCD was there already. Thanks, Ray > -Original Message- > From: Yao, Jiewen > Sent: Friday, November 12, 2021 10:29 AM > To: Brijesh Singh ; Ni, Ray ; > devel@edk2.groups.io > Cc: James Bottomle

Re: [edk2-devel] [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations

BTW: Is this internal API? I feel we should add ASSERT() for invalid page size as well, to catch issue earlier. Thank you > -Original Message- > From: Xu, Min M > Sent: Friday, November 12, 2021 10:39 AM > To: Erdem Aktas > Cc: devel@edk2.groups.io; Kinney, Michael D ; > Liming Gao ; L

Re: [edk2-devel] [PATCH V3 02/29] MdePkg: Add TdxLib to wrap Tdx operations

On November 10, 2021 6:38 PM, Erdem Aktas wrote: > On Mon, Nov 1, 2021 at 6:16 AM Min Xu wrote: > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429 > > > > > +**/ > > +UINT32 > > +GetGpaPageLevel ( > > + UINT32 PageSize > > + ) > > +{ > > + UINT32 Index; > > + > > + for (Inde

Re: [edk2-devel] [PATCH v12 20/32] MdePkg: Define ConfidentialComputingGuestAttr

Brijesh and Ray I don’t disagree the disadvantage of dynamic PCD. However, dynamic PCD is widely used in today's solution. If developers know clearly when this PCD value is finalized, then it won't be a problem. Otherwise, I prefer we drop the dynamic PCD support in EDKII infrastructure. That w

Re: [edk2-devel] [PATCH v12 32/32] UefiCpuPkg/MpInitLib: Use SEV-SNP AP Creation NAE event to launch APs

Acked-by: Ray Ni 3 comments: 1. It seems to me that the latest SevSnp doesn't need much special handling in AP waking up flow. Is there a plan to drop the old SevEs so that the MpInitLib logic can have a chance to be back to normal? > [Sources.IA32] > + Ia32/AmdSev.c >Ia32/MpFuncs.

Re: [edk2-devel] [PATCH v12 27/32] UefiCpuPkg/MpInitLib: use BSP to do extended topology check

3 comments: > --- a/UefiCpuPkg/Library/MpInitLib/MpLib.h > +++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h > @@ -224,6 +224,7 @@ typedef struct { >BOOLEAN SevEsIsEnabled; >BOOLEAN SevSnpIsEnabled; >UINTN GhcbBase; > + BOOLEAN ExtTop

Re: [edk2-devel] [PATCH v12 26/32] UefiCpuPkg/MpLib: add support to register GHCB GPA when SEV-SNP is enabled

1 comment: Can you please group the SevEsIsEnabled/SevSnpIsEnabled to a "2 boolean" struct or just one UINT8 field "SevEsEnable"? Through this way, MpLib.c can know less knowledge of SEV-ES. (I appreciate your effort to group the SEV-ES logic to separate files😊) > >BOOLEAN

Re: [edk2-devel] [PATCH v12 02/32] UefiCpuPkg/MpInitLib: move SEV specific routines in AmdSev.c

Reviewed-by: Ray Ni Thank you very much for separating SEV logics! > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh Singh > via groups.io > Sent: Thursday, November 11, 2021 6:14 AM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Yao, Jiewen ; >

[edk2-devel] [PATCH v4] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

When CET shadow stack feature is enabled, it needs to use IST for the exceptions, and uses interrupt shadow stack for the stack switch. Shadow stack should be 32 bytes aligned. Check IST field, when clear shadow stack token busy bit when using retf. REF: https://bugzilla.tianocore.org/show_bug.cg

Re: [edk2-devel] [PATCH v12 25/32] MdePkg/GHCB: increase the GHCB protocol max version

Acked-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Brijesh Singh > via groups.io > Sent: Thursday, November 11, 2021 6:15 AM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Yao, Jiewen ; > Tom Lendacky ; Justen, Jordan L > ; Ard Biesheuvel

Re: [edk2-devel] [PATCH v12 23/32] UefiCpuPkg: add PcdGhcbHypervisorFeatures

Acked-by: Ray Ni > -Original Message- > From: Brijesh Singh > Sent: Thursday, November 11, 2021 6:15 AM > To: devel@edk2.groups.io > Cc: James Bottomley ; Xu, Min M ; > Yao, Jiewen ; > Tom Lendacky ; Justen, Jordan L > ; Ard Biesheuvel > ; Erdem Aktas ; Michael > Roth ; Gerd > Hoffman

Re: [edk2-devel] [PATCH v12 22/32] UefiCpuPkg/MpInitLib: use PcdConfidentialComputingAttr to check SEV status

2 minor comments. > + switch (Attr) { > +case CCAttrAmdSev: > + return CurrentAttr >= CCAttrAmdSev; > +case CCAttrAmdSevEs: > + return CurrentAttr >= CCAttrAmdSevEs; > +case CCAttrAmdSevSnp: > + return CurrentAttr == CCAttrAmdSevSnp; 1. Can you put comments to explai

回复: [edk2-devel] [PATCH] MdeModulePkg/FPDT: Lock boot performance table address variable at EndOfDxe

Dandan and WuHao: This patch has reviewed-by before soft feature freeze. Can you help merge it? Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Dandan Bi > 发送时间: 2021年10月11日 11:49 > 收件人: devel@edk2.groups.io > 抄送: Dandan Bi ; Liming Gao > ; Hao A Wu ; Jian J Wang > > 主题: [edk2-de

回复: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Rebecca: Thanks for your reminder. Now, we have open CI. I think we can create the binary ShellPkg based on CI build result. Mike: Can open CI upload the generated EFI image as the artifacts? If so, the binary ShellPkg can be created from CI build result. Thanks Liming 发件人: devel@edk

回复: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

I am ok to merge them for edk2-stable202111. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Andrew Fish > via groups.io > 发送时间: 2021年11月12日 5:41 > 收件人: Leif Lindholm > 抄送: Mike Kinney ; devel@edk2.groups.io; > gaolim...@byosoft.com.cn; Teng, Lynn L > 主题: Re: [edk2-devel] Soft Fea

Re: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Do we have a task or reminder to generate the UEFI Shell binaries for this release, and to upload ShellBinPkg.zip to Github? https://bugzilla.tianocore.org/show_bug.cgi?id=3178 was opened but apparently never resolved, and the latest ShellBinPkg.zip is still from the edk2-stable202002 release.

[edk2-devel] Cancelled Event: TianoCore Design Meeting - APAC/NAMO - Friday, November 12, 2021 #cal-cancelled

BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:CANCELLED REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:Asia/Shanghai LAST-MODIFIED:20201011T015911Z TZURL:http://tzurl.org/zoneinfo-outlook/Asia/Shanghai X-LIC-LOC

Re: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

Me too. > On Nov 11, 2021, at 1:22 PM, Leif Lindholm wrote: > > These look fine to me. > > / >Leif > > On Thu, Nov 11, 2021 at 05:27:14 +, Kinney, Michael D wrote: >> Hi Liming, >> >> There are 2 issues that I would like to recommend get committed for the >> edk2-stable20211 tag. >>

Re: [edk2-devel] Soft Feature Freeze will start on 2021-11-08 for edk2-stable202111

These look fine to me. / Leif On Thu, Nov 11, 2021 at 05:27:14 +, Kinney, Michael D wrote: > Hi Liming, > > There are 2 issues that I would like to recommend get committed for the > edk2-stable20211 tag. > The code reviews were sent on the Soft Freeze start day, so I want to follow > t

[edk2-devel] [Patch edk2-stable202111 1/1] OvmfPkg/Library/ResetSystemLib: Fix Microvm VS2019 NOOPT build issue

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3731 Fix VS2019 NOOPT build issues with OvmfPkg/Microvm/MicrovmX64.dsc by fixing typecast of MICROVM_GED_MMIO_BASE_REGS to a VOID *. Cc: Gerd Hoffmann Cc: Ard Biesheuvel Cc: Jiewen Yao Signed-off-by: Michael D Kinney --- OvmfPkg/Library/Res

Re: [edk2-devel] [Patch 1/1] OvmfPkg/Xen: Fix VS2019 build issues

> -Original Message- > From: devel@edk2.groups.io On Behalf Of Philippe > Mathieu-Daudé > Sent: Thursday, November 11, 2021 2:24 AM > To: devel@edk2.groups.io; Kinney, Michael D > Cc: Anthony Perard ; Julien Grall > ; Ard Biesheuvel ; > Yao, Jiewen ; Justen, Jordan L > ; Gerd Hoffman

Re: [edk2-devel] [PATCH v12 20/32] MdePkg: Define ConfidentialComputingGuestAttr

Hi Ray, On 11/11/21 8:00 AM, Ni, Ray wrote: I don't prefer to use a dynamic PCD for passing data. Because developers don't know when this PCD value is finalized (PCD always has a default value). If the value is determined in PEI and consumed in DXE, HOB is a better choice. If the value is det

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: invalid values for SetWakeupTime()

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2529 According to the UEFI specification EFI_TIME.YEAR may take values in the range 1900-. The specification does not forbid to set a wakeup time in the past. We should not expect EFI_INVALID_PARAMETER to be returned by SetWakeupTime() for th

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote: Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Unfortunately this mail is not a valid patch: $ wget https://patchew.org/EDK2/20211026114226.30761-1-abdat...@amd.com/mbox $ git am mbox --kee

Re: [edk2-devel] TianoCore edk2-test Bug Triage Meeting

Hello All, Thank you for attending the meeting. Below is the MOM Tickets closed in this meeting: ID▼

Re: [edk2-devel] [PATCH V3 3/3] OvmfPkg: Move LocalApicTimerDxe to UefiCpuPkg

On Mon, Nov 08, 2021 at 02:08:00PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > OvmfPkg.dec is removed from [Packages] because it doesn't depend > on OvmfPkg. LocalApicTimerDxe is moved to UefiCpuPkg. > > Cc: Jiewen Yao > Cc: Gerd Hoffmann > Cc: Anthony Per

Re: [edk2-devel] [PATCH V3 1/3] OvmfPkg: Rename XenTimerDxe to LocalApicTimerDxe

On Mon, Nov 08, 2021 at 02:07:58PM +0800, Min Xu wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3711 > > XenTimerDxe is a local Apic timer driver and it has nothing to do > with Xen. So rename it to LocalApicTimerDxe. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh

Re: [edk2-devel] [PATCH v12 20/32] MdePkg: Define ConfidentialComputingGuestAttr

I don't prefer to use a dynamic PCD for passing data. Because developers don't know when this PCD value is finalized (PCD always has a default value). If the value is determined in PEI and consumed in DXE, HOB is a better choice. If the value is determined in PEI and consumed in PEI, PPI is a be

Re: [edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

Gao, The patch content looks good to me. However the commit message is misleading. " UefiPayloadPkg will override platform's DXE A Priori file and miss these two modules in its DXE A Priori file, so just add them back." Apriori file decides the dispatch order for each FV. I don't think the UefiP

Re: [edk2-devel] [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

Wei, All other logics look good to me. Thanks for refining the NASM further using struct. One minor comment about the logic that determines stack size. Can you check the below code? I added more comments and tried to make the new logic be consistent to original logic. // // Allocate SMI st

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Sorry, I don't mean: one platform uses 2 different configuration. That might be worse, because we lose the benefit on compression. Ideally, no matter how many *same* copies you have, the compression algo will handle it and make only *one* copy. If you have two *different* copies, then compressio

Re: [edk2-devel] [PATCH 1/2] Reconfigure OpensslLib to add elliptic curve chipher algorithms

Hi, > The difference I see without ecc change and with the change is the increase > in file sizes for below ffs files,(other .ffs files remained unchanged) > > Without ecc change: > 794742 > /home/ubuntu/src/edk2/Build/Ovmf3264/NOOPT_GCC5/FV/Ffs/F80697E9-7FD6-4665-8646-88E33EF71DFCSecurityStubD

Re: [edk2-devel] [PATCH edk2-platforms 0/2] Socionext housekeeping

On Thu, 11 Nov 2021 at 12:59, Leif Lindholm wrote: > > Masami - while looking at your set from last Friday, patch 1/5 fails > to apply since the file being modified has the wrong line endings in > the tree. > > 2/2 fixes that. > (Obviously, the patch looks nonsensical since SMTP strips the added C

[edk2-devel] [PATCH edk2-platforms 2/2] Silicon/Socionext: fix line endings

SynQuacerI2cDxe.c (and no other Socionext source files) has LF instead of CRLF line endings, so fix that. Signed-off-by: Leif Lindholm Cc: Masami Hiramatsu --- Silicon/Socionext/SynQuacer/Drivers/SynQuacerI2cDxe/SynQuacerI2cDxe.c | 1162 ++-- 1 file changed, 581 insertions(+),

[edk2-devel] [PATCH edk2-platforms 0/2] Socionext housekeeping

Masami - while looking at your set from last Friday, patch 1/5 fails to apply since the file being modified has the wrong line endings in the tree. 2/2 fixes that. (Obviously, the patch looks nonsensical since SMTP strips the added CR back out.) 1/2 adds you as a reviewer to the Socionext platfor

[edk2-devel] [PATCH edk2-platforms 1/2] Maintainers.txt: add Masami as Socionext reviewer

Masami is the main contributor to these platforms, and would be useful to have listed as a reviewer. Signed-off-by: Leif Lindholm Cc: Masami Hiramatsu --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index c839c71b2262..093d36e4088d 10064

[edk2-devel] [PATCH] UefiPayloadPkg/UefiPayloadPkg.fdf: Update DXE A Priori file

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3729 Platform desires to load ReportStatusCodeRouterRuntimeDxe and StatusCodeHandlerRuntimeDxe early in DXE to make DEBUG() via serial port work thereafter since DXE will use PeiDxeDebugLibReportStatusCode as default DebugLib instance. However, w

[edk2-devel] [PATCH 4/4] Platform/RaspberryPi: Add menu item to enable/disable GPIO

Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - Platform/RaspberryPi/Drivers/ConfigDx

[edk2-devel] [PATCH 2/4] Platform/RaspberryPi: Give the user control over the XHCI mailbox

Its a complete tossup whether removing the mailbox call after we have set up the XHCI works for a given kernel+distro in DT mode. So lets give users which want to try DT the option of flipping this on/off. Users that don't want to have to deal with DT, can use ACPI. Signed-off-by: Jeremy Linton

[edk2-devel] [PATCH 3/4] Platform/RaspberryPi: Move GPIO/SPI/I2C to SSDT

The UEFI firmware uses the GPIO port for the fan and real soon now the runtime SPI variable store. As such we need to be able to either isolate those devices from the OS or we risk clashing with OS's that reconfigure the GPIO pins. Ideally we would just rip this out and use _DSM() or just individua

[edk2-devel] [PATCH 1/4] Platform/RaspberryPi: Cleanup menu visibility

Lets allow some of these options to change when the system is in ACPI+DT mode. Plus the fan temp should be disabled when ACPI isn't enabled. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxeHii.vfr | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[edk2-devel] [PATCH 1/1] Platform/RaspberryPi: Add menu item to enable/disable GPIO

Now that the GPIO devices are in their own SSDT lets add a menu item for the rpi4 to enable/disable it. For the rpi3 the SSDT is always exported. Signed-off-by: Jeremy Linton --- Platform/RaspberryPi/Drivers/ConfigDxe/ConfigDxe.c | 17 - Platform/RaspberryPi/Drivers/ConfigDx

[edk2-devel] [PATCH 0/4] Platform/RaspberryPi: new GPIO and DT menu items

Its been reported that some kernel versions still need the XHCI reload while others only work if the reload isn't present. Lets give the user the ability to control that for DT systems. Further, there is now an example persistent variable store implementation that uses the on-board SPI flash rathe

Re: [edk2-devel] [Patch 1/1] OvmfPkg/Xen: Fix VS2019 build issues

Hi Michael, On 11/8/21 17:22, Michael D Kinney wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3722 > > Fix VS2019 NOOPT build issues related to converting > a larger integer value to a smaller integer value. > > Cc: Anthony Perard > Cc: Julien Grall > Cc: Ard Biesheuvel > Cc: Ji

[edk2-devel] [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

When CET shadow stack feature is enabled, it needs to use IST for the exceptions, and uses interrupt shadow stack for the stack switch. Shadow stack should be 32 bytes aligned. Check IST field, when clear shadow stack token busy bit when using retf. REF: https://bugzilla.tianocore.org/show_bug.cg

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

Sorry , please ignore this patch V2. I will update to V3. Thank you BR Sheng Wei > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sheng > Wei > Sent: 2021年11月11日 17:04 > To: devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Kumar, > Rahul1 > Subject: [edk2-devel] [PATCH v2]

[edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Use SMM Interrupt Shadow Stack

When CET shadow stack feature is enabled, it needs to use IST for the exceptions, and uses interrupt shadow stack for the stack switch. Shadow stack should be 32 bytes aligned. Check IST field, when clear shadow stack token busy bit when using retf. REF: https://bugzilla.tianocore.org/show_bug.cg