From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3619
Adds libraries implemented in MinPlatformPkg to the [Components]
section in MinPlatformPkg.dsc so they are included in the package
build.
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc: Liming Gao
Cc: Eric Dong
Maciej, Jiaxin and Siyuan:
Can you help review this fix?
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Oliver Steffen
> 发送时间: 2022年3月22日 21:30
> 收件人: devel@edk2.groups.io
> 抄送: maciej.rab...@linux.intel.com; jiaxin...@intel.com;
> siyuan...@intel.com; kra...@redhat.com; Oliver
Min:
I have no comments on this patch. Reviewed-by: Liming Gao
Ray:
Have you any comments on this patch?
Thanks
Liming
> -邮件原件-
> 发件人: Xu, Min M
> 发送时间: 2022年3月22日 11:02
> 收件人: devel@edk2.groups.io; Gao, Liming
> 抄送: Ni, Ray ; Kinney, Michael D
> ; Liu, Zhiguang ;
> Brijesh Singh
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Groups.io Inc//Groups.io Calendar//EN
METHOD:PUBLISH
REFRESH-INTERVAL;VALUE=DURATION:PT1H
X-PUBLISHED-TTL:PT1H
CALSCALE:GREGORIAN
BEGIN:VTIMEZONE
TZID:America/Los_Angeles
LAST-MODIFIED:20220317T223602Z
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3612
Printing corruption can occur if the DumpHsti helper function
encounters a structure from the IHV (i.e. one that contains
the 'Required' field).
Co-authored-by: Bret Barkelew
Cc: Chasel Chiu
Cc: Nate DeSimone
Cc:
Hi all,
I'm Benjamin Doron. Last year, I worked on a board port to MinPlatform.
This year, I hope to pick up where I left off and help improve MinPlatform
by adding support for S3 resume (time permitting and if my skills are
sufficient, etc). Previously, I worked a little on coreboot (mainly a
Considering all my branches are badly broken because of the Uncrustify
changes, there have been many changes to the existing PE/COFF libraries
in the mean time (and more external dependencies incoming with PMR), and
even this non-invasive patch has been mostly ignored (thanks for the
review,
From: Michael Kubacki
Updates the Readme.md files to remove information that was specific
to the package in edk2-staging and adds key definitions being added
for PRM support in the ACPI Specification.
Adds PrmPkg/PrmPkg.ci.yaml to support CI.
Adds PrmPkg to .pytool/CISettings.py.
Adds PrmPkg
From: Michael Kubacki
Adds a link to the PRM Specification now that it is available on uefi.org.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc: Ankit Sinha
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
---
From: Michael Kubacki
OS services are no longer supported as of the current PRM design.
1. Removes OS services from PrmSampleHardwareAccessModule
2. Removes the PrmOsServices.h file
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
From: Michael Kubacki
This sample module is removed since it directly depends on OS
services which are no longer supported as of the current PRM
design.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc: Ankit Sinha
From: Michael Kubacki
Removes PrmSampleMemoryAllocationModule since the module depends
upon the deprecated concept of OS services.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc: Ankit Sinha
Cc: Nate DeSimone
From: Michael Kubacki
Bugzilla request https://bugzilla.tianocore.org/show_bug.cgi?id=2969
was recently completed which causes the PLATFORM_GUID value from the
DSC file to be placed into Autogen file .c & .h files. With this
change, the PRM Platform GUID can be directly matched to the DSC
From: Michael Kubacki
Adds a note that the build now depends on an ASL compiler supporting
PlatformRtMechanism by default. The minimum iASL version supported
is noted in addition to an alternative to remove the code that
requires the new OperationRegion.
Also, a link is provided to an example
From: Liu Yun Y
1. Enable new PRM OpRegion structure
2. Add PRM Handler Update Lock/Unlock support
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc: Ankit Sinha
Cc: Nate DeSimone
Signed-off-by: Liu Yun
---
From: Michael Kubacki
Adds a "platform GUID" field to the PRM ACPI table. This field
is used by a platform to uniquely identify itself such that it
can be targeted by runtime PRM module updates for that platform.
Platforms using PRM are currently required to set a unique value
for
From: Michael Kubacki
Adds host-based unit tests for DxePrmModuleDiscoveryLib. This is
an initial set of support, more tests should be added in the
future.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc: Ankit Sinha
From: Michael Kubacki
Adds host-based unit tests for DxePrmContextBufferLib. This tests
each function in DxePrmContextBufferLib.
Any changes to DxePrmContextBufferLib moving forward must pass the unit
tests. The unit tests should be updated as needed if the library API
changes.
Cc: Andrew Fish
From: Michael Kubacki
Adds a host-based specific implementation of UefiBootServicesTableLib.
This library implements relatively simple versions of the functionality
in the actual boot services implementation and does not depend on
dynamic linking to the boot services table.
Most unit tests can
From: Michael Kubacki
Adds a new DSC file that will be used to build host-based unit tests
in PrmPkg.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc: Ankit Sinha
Cc: Nate DeSimone
Signed-off-by: Michael Kubacki
From: Michael Kubacki
Makes the following changes to enforce stricter types:
1. PrmPkg/PrmConfigDxe
The function PrmConfigEndOfDxeNotification () is used as a notify
function (of type EFI_EVENT_NOTIFY), however it has a return type
of EFI_STATUS whereas the return type should actually
From: Michael Kubacki
Adds a new UEFI application called "PrmInfo" that allows a user
to display and test Platform Runtime Mechanism (PRM) modules.
Execute the application help command for detailed usage
instructions and examples of how to use the application:
"PrmInfo -?"
This application
From: Michael Kubacki
This change breaks out two sets of responsibilities in
PrmLoaderDxe into libraries:
* PE/COFF functions -> PrmPeCoffLib
* PRM module discovery functions -> PrmModuleDiscoveryLib
This is core infrastructure code for PRM functionality that needs
to be directly reused and
From: Michael Kubacki
Adds a Readme.md file for the Samples to help a user get started
building and using the PRM sample modules.
Includes a reference to the Samples/Readme.md file in the top-level
file to help make the reader aware the file exists.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D
From: Michael Kubacki
Adds a PRM module configuration library for PrmSampleHardwareAccessModule
that demonstrates marking a runtime MMIO range. In the case of this
sample module, the range used is for HPET.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif
From: Michael Kubacki
Adds a new PRM module called SampleAcpiParameterBufferModule that
demonstrates how a PRM module can use an ACPI parameter buffer with
a PRM handler.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
From: Michael Kubacki
For each PRM handler that is currently present, a corresponding PRM
handler is added that does not print. This allows a caller to execute
a sample hardware access PRM handler without requiring that caller to
provide a debug print service.
Cc: Andrew Fish
Cc: Kang Gao
Cc:
From: Michael Kubacki
Removes the expectation that the parameter buffer contain an OS
debug print service at the beginning of the buffer. All supporting
code related to printing is also removed.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc:
From: Michael Kubacki
Adds support to PrmLoaderDxe to move the ACPI parameter buffer
address for a given PRM handler to the corresponding field
in the PRM handler information structure (PRMT ACPI table).
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
From: Michael Kubacki
Adds a new type ACPI_PARAMETER_BUFFER_DESCRIPTOR that can be
used by PRM module configuration code to associate a PRM handler
GUID with an ACPI parameter buffer allocated by the PRM module
configuration code.
The ACPI parameter buffer descriptors for a given PRM module
are
From: Michael Kubacki
The POR is firmly to use an OS allocated context buffer now so the
build flag that allows firmware to allocate the context buffer
is removed along with supporting code.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc:
From: Michael Kubacki
Per latest design direction, we've abandoned treating the PRM Module
Update Lock as an exported object. There was concern sharing the PRM
module address space (where the lock structure resided in a data section)
with the OS kernel mode driver. The lock will now be entirely
From: Michael Kubacki
Adds a new module that installs a PRM SSDT.
Note: A library class would allow a high degree of flexibility for
platforms that choose:
1. To not install a PRM SSDT at all (using a NULL library instance)
2. To install a specific PRM SSDT implementation
However, it is
From: Liu
PRMT ACPI defined major version and minor version for each PRM module.
PRM module will build its major/minor version in its PE COFF header.
In boot time, PRM loader will collect the major/minor version from PE COFF
header and fill them into PRMT ACPI table.
Cc: Andrew Fish
Cc: Kang
From: Liu
A PRM Handler has a 1-to-1 mapping to the corresponding _DSM method.
The UUID of the _DSM Method will be passed by the ASL code to the
OpRegionHandler which will look up the PRMT Table to extract the
pointer of the corresponding PRM Handler.
PRM loader pre-builds an SSDT that includes
From: Michael Kubacki
There's currently two approaches being considered for how to allocate the
context buffer passed to PRM handlers:
1. The context buffer is allocated and populated in firmware. As such, the
FW converts all pointers internal to the buffer to virtual memory
addresses at
From: Michael Kubacki
The PRM_MODULE_EXPORT parameterized macro allows a caller to produce
a static PRM module export descriptor structure in the binary by
simply passing PRM_HANDLER_EXPORT_ENTRY arguments with each argument
representing a PRM handler to be exported by the module.
Previously,
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
Adds the following content to Readme.md:
1. A basic explanation of how the package is organized and where to
find important items.
2. Adds instructions for building PrmPkg with edk2.
3. Adds a "Build Flags"
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
Adds the PrmPkg DSC file so all of the contents can be built as a
stand-alone package.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
Cc:
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
Adds a sample PRM module that demonstrates:
1. How to write a PRM module
2. How to use a basic PRM OS services
3. How to use a basic PRM module configuration library
4. How to use a context buffer during PRM
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
Adds a sample PRM module that demonstrates:
1. How to write a PRM module
2. How to use multiple PRM handlers in a module
3. How to use a basic PRM OS service
4. MSR access at OS runtime
Note: This module
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
DEPRECATED: This module is no longer relevant since OS Services that
allow memory allocation have been removed. It is still present in the
source tree in the event dynamic memory allocation at OS runtime is
needed
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
Adds a simple sample PRM module that demonstrates:
1. How to write a PRM module
2. How to use multiple PRM handlers in a module
3. How to use a basic PRM OS service
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
This driver serves as a generic PRM configuration driver. Its primary
role is to prepare PRM resources published by PRM module configuration
libraries for OS runtime. As such, it locates all PRM Configuration
Protocol
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
This library is introduced to add a general abstraction for PRM context
buffer management.
Cc: Andrew Fish
Cc: Kang Gao
Cc: Michael D Kinney
Cc: Michael Kubacki
Cc: Leif Lindholm
Cc: Benjamin You
Cc: Liu Yun
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
The PRM Configuration protocol is used by PRM module configuration
libraries to describe their resources so that a generic PRM Configuration
DXE driver can prepare those resources for OS runtime.
Therefore, multiple
From: Michael Kubacki
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3812
Adds a new package to maintain Platform Runtime Mechanism (PRM)
support.
This package is intended to include generic code that provides a
common infrastructure to support PRM in firmware and a collection
of sample
From: Michael Kubacki
This patch series adds a new package called PrmPkg. An RFC was sent
to the edk2 mailing list on January 28, 2022 detailing the proposal,
see https://edk2.groups.io/g/devel/message/86181.
Platform Runtime Mechanism (PRM) is a new firmware solution that has
been developed in
Hi Michael,
Should this be broken up into 2 series? One for pytool change and one for
OvmfPkg?
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Monday, March 21, 2022 6:58 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Sean Brogan
> ;
Michael,
One comment below.
Mike
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Monday, March 21, 2022 6:58 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Sean Brogan
> ; Bret Barkelew
> Subject: [PATCH v1 2/4]
Hi Michael,
I meant to ask. Is there a reason you are not normalizing the
file paths os.path.normpath() before performing the path comparison?
I am concerned that a mix of '/', '\' and '..' in YAML file may
not detect what is supposed to be a matching path.
Perhaps this is a topic that
Reviewed-by: Michael D Kinney
Mike
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael Kubacki
> Sent: Monday, March 21, 2022 6:58 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Gao, Liming
> ; Sean Brogan
> ; Bret Barkelew
> Subject: [edk2-devel] [PATCH
Hi Marvin,
Please find my inline comments with [Ted2].
Thanks,
Ted
-Original Message-
From: Marvin Häuser
Sent: Tuesday, March 22, 2022 5:27 PM
To: Kuo, Ted
Cc: devel@edk2.groups.io; Kinney, Michael D ; Bi,
Dandan ; Gao, Liming ; De,
Debkumar ; Han, Harry ; West,
Catharine ; Wang,
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Add ConnectionClose flag to HTTP_PROTOCOL.
This boolean is FALSE by default. If set to TRUE, a reconfigure
of the Http instance is forced on the next request. The flag
is then reset.
Signed-off-by: Oliver Steffen
---
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Force connection close before the next request if
the server identifies as version 1.0.
Signed-off-by: Oliver Steffen
---
NetworkPkg/HttpDxe/HttpImpl.c | 8
1 file changed, 8 insertions(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Force connection close before the next request if
the server sends the 'Connection: close' header.
Signed-off-by: Oliver Steffen
---
NetworkPkg/HttpDxe/HttpImpl.c | 11 +++
1 file changed, 11 insertions(+)
diff --git
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
This set of patches fixes booting from HTTP/1.0 servers.
It also improves the interaction with HTTP/1.1 servers by recognizing
the 'Connection: close' header field, which fixes a problem with
servers that close the connection after a
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or
HTTP_STATE_TCP_CLOSED and de-configure the Tcp6 instance before
configuring it again.
Signed-off-by: Oliver Steffen
---
NetworkPkg/HttpDxe/HttpProto.c | 12
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720
Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or
HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before
configuring it again.
Signed-off-by: Oliver Steffen
---
NetworkPkg/HttpDxe/HttpProto.c | 12
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3881
LibraryClass MmServicesTableLib SynchronizationLib in SmmCryptLib.inf should be
listed in CryptoPkg.dsc.
Cc: Jiewen Yao
Cc: Jian J Wang
Cc: Zhihao Li
Signed-off-by: yi1 li
---
CryptoPkg/CryptoPkg.dsc | 2 ++
1 file changed, 2
Good day,
Thanks for the updates!
> On 22. Mar 2022, at 08:23, Kuo, Ted wrote:
>
> Hi Marvin,
>
> Good day. Thanks for your valuable comments. After checking all of your
> comments, I decide to drop the patches and close the bugzilla ticket since
> the changes should be specific to X64 in
On Mon, Mar 21, 2022 at 09:58:14PM -0400, Michael Kubacki wrote:
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>
> The following files:
> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
> OvmfPkg/QemuVideoDxe/VbeShim.h
>
> Are auto generated by the following
On Mon, Mar 21, 2022 at 09:58:13PM -0400, Michael Kubacki wrote:
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>
> Reverts changes automatically applied by Uncrustify in commit
> ac0a286.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc:
On Fri, Mar 18, 2022 at 08:45:41AM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
>
> MaxCpuCountInitialization is splitted into two:
> - PlatformMaxCpuCountInitialization is for PlatformInitLib
> - MaxCpuCountInitialization is for PlatformPei. It calls
>
On Fri, Mar 18, 2022 at 08:45:40AM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
>
> From this patch we start to restruct the functions which set PCDs into
> two, one for PlatformInitLib, one for PlatformPei.
>
> AddressWidthInitialization is the first one. It is
On Fri, Mar 18, 2022 at 08:45:37AM +0800, Min Xu wrote:
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3863
>
> The intention of PlatformInitLib is to extract the common function used
> in OvmfPkg/PlatformPei. This lib will be used not only in PEI phase but
> also in SEC phase. SEC phase
Patch pushed:
https://github.com/tianocore/edk2/commit/ec0b54849b23efa25caf0055b0eef8bf9b4dec98
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, March 14, 2022 12:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
>
On Fri, Mar 18, 2022 at 08:45:20AM +0800, Min Xu wrote:
> RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3429
>
> Guest software can be designed to run either as a TD, as a legacy virtual
> machine, or directly on the CPU, based on enumeration of its run-time
> environment. [TDX-Module] Chap
Thanks Ted!
Reviewed-by: Chasel Chiu
> -Original Message-
> From: Kuo, Ted
> Sent: Monday, March 14, 2022 12:23 PM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S,
> Ashraf Ali
> Subject: [edk2-devel][PATCH] IntelFsp2Pkg: BaseFspCommonLib
From: Yi Li
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
FeatureFlagExpression Support in Source section of INF file. The Pcd
value in the expression is from INF or DEC.
When a FeatureFlagExpression is present,if the expression evaluates
to TRUE,then the entry is valid. If the
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3828
FeatureFlagExpression Support in Source section of INF file. The Pcd
value in the expression is from INF or DEC.
When a FeatureFlagExpression is present,if the expression evaluates
to TRUE,then the entry is valid. If the expression evaluates
Hi Marvin,
Good day. Thanks for your valuable comments. After checking all of your
comments, I decide to drop the patches and close the bugzilla ticket since the
changes should be specific to X64 in IntelFspPkg. You still can find my inline
comments with [Ted] for your questions.
Thanks,
Ted
On 03/22/22 02:58, mikub...@linux.microsoft.com wrote:
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>
> The following files:
> OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.h
> OvmfPkg/QemuVideoDxe/VbeShim.h
>
> Are auto generated by the following generators:
>
On 03/22/22 02:58, mikub...@linux.microsoft.com wrote:
> From: Michael Kubacki
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3875
>
> Reverts changes automatically applied by Uncrustify in commit
> ac0a286.
>
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Gerd
74 matches
Mail list logo
