Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add Platform and Silicon Intel maintainers

2022-06-07 Thread Ni, Ray
Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oram, Isaac W > Sent: Wednesday, June 8, 2022 10:33 AM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Leif Lindholm > ; Kinney, Michael D > ; Chaganty, Rangasai V > ; Desimone, Nathaniel L > >

[edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add Platform and Silicon Intel maintainers

2022-06-07 Thread Oram, Isaac W
Enable maintainers for Platform/Intel/ subtree. Enable maintainers for Silicon/Intel/ subtree. This is consistent with Features/Intel/ subtree. Cc: Leif Lindholm Cc: Michael D Kinney Cc: Sai Chaganty Cc: Nate DeSimone Signed-off-by: Isaac Oram --- Maintainers.txt | 12 1 file

[edk2-devel][edk2-platforms][PATCH V1 1/1] Maintainters.txt: Add Isaac Oram to common Intel packages

2022-06-07 Thread Oram, Isaac W
Isaac Oram is actively maintaining Platform/Intel and Silicon/Intel common packages. Cc: Leif Lindholm Cc: Michael D Kinney Signed-off-by: Isaac Oram --- Maintainers.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Maintainers.txt b/Maintainers.txt index da6abc7344..a85bfcf2a5

Re: [edk2-devel] [PATCH v6 1/6] MdeModulePkg/PciHostBridge: io range is not mandatory

2022-06-07 Thread Abner Chang
Reviewed-by: Abner Chang > -Original Message- > From: Gerd Hoffmann > Sent: Monday, April 25, 2022 6:35 PM > To: devel@edk2.groups.io > Cc: Jiewen Yao ; Oliver Steffen > ; Leif Lindholm ; Pawel > Polawski ; Hao A Wu ; Chang, > Abner (HPS SW/FW Technologist) ; Liming Gao > ; Ray Ni ;

Re: [edk2-devel] [edk2-platforms] [PATCH V1] KabylakeOpenBoardPkg/GalagoPro3: Add FSP Dispatch Mode PCDs

2022-06-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 7, 2022 7:09 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Sinha, Ankit > ; > Kubacki, Michael ; Soller, Jeremy > > Subject: [edk2-platforms] [PATCH V1]

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - 06/07/2022 #cal-reminder

2022-06-07 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* 06/07/2022 6:30pm to 7:30pm (UTC-07:00) America/Los Angeles *Where:*

Re: [edk2-devel] [edk2-platforms] [PATCH V2 3/4] CometlakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

2022-06-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 7, 2022 7:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael > ; Chaganty, Rangasai V > ; Kethi Reddy, Deepika > ; Esakkithevar, Kathappan > >

Re: [edk2-devel] [edk2-platforms] [PATCH V2 2/4] WhiskeylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

2022-06-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 7, 2022 7:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael > > Subject: [edk2-platforms] [PATCH V2 2/4] WhiskeylakeOpenBoardPkg: Indicate > width

Re: [edk2-devel] [edk2-platforms] [PATCH V2 1/4] KabylakeOpenBoardPkg: Indicate width of CLK duty cycle in FADT

2022-06-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Tuesday, June 7, 2022 7:17 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel ; Kubacki, Michael > ; Benjamin Doron > ; Soller, Jeremy > Subject: [edk2-platforms] [PATCH V2 1/4]

Re: [edk2-devel] [PATCH V2 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

2022-06-07 Thread Chiu, Chasel
Reviewed-by: Chasel Chiu Thanks, Chasel > -Original Message- > From: Desimone, Nathaniel L > Sent: Wednesday, June 8, 2022 7:23 AM > To: devel@edk2.groups.io > Cc: Sinha, Ankit ; Chiu, Chasel > ; > Gao, Liming ; Dong, Eric ; > Kubacki, Michael > Subject: [PATCH V2 1/1]

Re: [edk2-devel] [PATCH] UefiPayloadPkg: Always split page table entry to 4K if it covers stack.

2022-06-07 Thread Ni, Ray
> Hi, > > > yes:) Actually there is no split at all. The 4K page table is created in > > the very beginning(before setting to cr3). > > So, no TLB cache issue at all. > > > > I think doing a linux-style page split will be the more robust solution. > > > > Thanks for explaining the linux

Re: [edk2-devel] [PATCH 12/14] MdePkg: The prototype definition of EfiMemoryAcceptProtocol

2022-06-07 Thread Min Xu
On June 6, 2022 11:22 AM, Yao Jiewen wrote: > > Hi > I don't remember it is accepted in UEFI protocol. > As such, we cannot use EFI_ prefix, and we cannot put it to MdePkg. > > I recommend we use EDKII_ prefix, and move it to MdeModulePkg as first > step. > Thanks for the reminder. It will be

Re: [edk2-devel] [PATCH 08/14] OvmfPkg: Use PcdOvmfWorkAreaBase instead of PcdSevEsWorkAreaBase

2022-06-07 Thread Min Xu
On June 7, 2022 6:48 PM, Gerd Hoffmann wrote: > On Mon, Jun 06, 2022 at 10:59:56AM +0800, Min Xu wrote: > > From: Min M Xu > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > > > It is an typo error that HobList pointer should be stored at > > PcdOvmfWorkAreaBase, not

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-07 Thread Min Xu
On June 7, 2022 6:46 PM, Gerd Hoffmann wrote: > On Mon, Jun 06, 2022 at 10:59:55AM +0800, Min Xu wrote: > > From: Min M Xu > > > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > > > Lazy accept page can be controlled in build time like below: > > -D LAZY_ACCEPT_PARTIAL_MEM=512 > >

Re: [edk2-devel] [PATCH 02/14] MdePkg: Increase EFI_RESOURCE_MAX_MEMORY_TYPE

2022-06-07 Thread Min Xu
On June 7, 2022 6:40 PM, Gerd Hoffmann wrote: > On Mon, Jun 06, 2022 at 10:59:50AM +0800, Min Xu wrote: > > --- a/MdePkg/Include/Pi/PiHob.h > > +++ b/MdePkg/Include/Pi/PiHob.h > > @@ -232,7 +232,16 @@ typedef UINT32 EFI_RESOURCE_TYPE; #define > > EFI_RESOURCE_MEMORY_MAPPED_IO_PORT 0x0004 > >

[edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout

2022-06-07 Thread Oram, Isaac W
V2: Use UINT8 instead of BOOLEAN for DmiStopAndScreamEnable and Rsvdbits2 V1: Disambiguate the PCH_DMI_CONFIG and PCH_TRACE_HUB_CONFIG structure definitions such that compilers generate same binary layouts. Cc: Nate DeSimone Cc: Chasel Chiu Signed-off-by: Isaac Oram ---

[edk2-devel] [PATCH V2 1/1] MinPlatformPkg: Add PCDs to update FADT entries from board package

2022-06-07 Thread Nate DeSimone
From: Ankit Sinha Adds new PCDs to allow entries in FADT to be customized during platform integration. Board packages will can update these PCDs during boot. Cc: Chasel Chiu Cc: Nate DeSimone Cc: Liming Gao Cc: Eric Dong Cc: Michael Kubacki Signed-off-by: Ankit Sinha ---

Re: [edk2-devel] [edk2-platforms]Vlv2TbltDevicePkg built failed.

2022-06-07 Thread Michael D Kinney
Hi, The current required NASM version is 2.15.05 https://github.com/tianocore/tianocore.github.io/wiki/Nasm-Setup Please retry with that release and let me know if it still fails. Thanks, Mike From: devel@edk2.groups.io On Behalf Of gordon...@gmail.com Sent: Sunday, May 29, 2022 8:38 PM

Re: [edk2-devel] Coverity test for CryptoPkg

2022-06-07 Thread Michael D Kinney
Hi Prarthana, There are already some TianoCore BZs open on this topic. Please see if the issues you want to fix are already noted and waiting for an owner. https://bugzilla.tianocore.org/show_bug.cgi?id=1702 Also, Felix at AMI has a proposal to add Coverity for all EDK II packages. I

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg/JunctionCity : Enabled Network and IPMI features for JunctionCity

2022-06-07 Thread Nate DeSimone
Pushed: https://github.com/tianocore/edk2-platforms/commit/b98dfd5 > -Original Message- > From: Sureshkumar Ponnusamy > Sent: Wednesday, May 25, 2022 8:32 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; DOPPALAPUDI, HARIKRISHNA > ; KARPAGAVINAYAGAM,

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleyOpenBoardPkg/Build: Compress CpuMpPei.inf

2022-06-07 Thread Oram, Isaac W
Pushed as b98dfd5736..c546cc01f1 -Original Message- From: Desimone, Nathaniel L Sent: Tuesday, June 7, 2022 1:55 PM To: Oram, Isaac W ; devel@edk2.groups.io Cc: Chiu, Chasel Subject: RE: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleyOpenBoardPkg/Build: Compress CpuMpPei.inf

Re: [edk2-devel] [edk2-platforms] [PATCH V1] WhitleyOpenBoardPkg/JunctionCity : Enabled Network and IPMI features for JunctionCity

2022-06-07 Thread Nate DeSimone
Reviewed-by: Nate DeSimone > -Original Message- > From: Sureshkumar Ponnusamy > Sent: Wednesday, May 25, 2022 8:32 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W ; Desimone, Nathaniel L > ; DOPPALAPUDI, HARIKRISHNA > ; KARPAGAVINAYAGAM, MANICKAVASAKAM > > Subject: [edk2-platforms]

Re: [edk2-devel][edk2-platforms][PATCH V1 1/1] WhitleySiliconPkg/PchPolicyPpi: Fix binary structure layout

2022-06-07 Thread Nate DeSimone
Hi Isaac, Please see feedback inline. Thanks, Nate > -Original Message- > From: Oram, Isaac W > Sent: Friday, May 27, 2022 2:47 PM > To: devel@edk2.groups.io > Cc: Desimone, Nathaniel L ; Chiu, Chasel > > Subject: [edk2-devel][edk2-platforms][PATCH V1 1/1] >

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleyOpenBoardPkg/Build: Compress CpuMpPei.inf

2022-06-07 Thread Nate DeSimone
Reviewed-by: Nate DeSimone -Original Message- From: Oram, Isaac W Sent: Monday, May 23, 2022 4:05 PM To: devel@edk2.groups.io Cc: Desimone, Nathaniel L ; Chiu, Chasel Subject: [edk2-devel][edk2-platforms][PATCH V2 1/1] WhitleyOpenBoardPkg/Build: Compress CpuMpPei.inf Compressing

Re: [edk2-devel] [PATCH v8 3/6] OvmfPkg/BaseMemEncryptLib: Invoke page encryption state change hypercall

2022-06-07 Thread Ashish Kalra via groups.io
[AMD Official Use Only - General] Hello Nikunj, Yes we can move MemEncryptSevLiveMigrationIsEnabled() check here before calling SetMemoryEncDecHypercall3() but then we also need to remove the same check from inside SetMemoryEncDecHypercall3() function. Thanks, Ashish From: nikunj via

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch

2022-06-07 Thread Yao, Jiewen
OK. Let's get it work at first. Acked-by: Jiewen Yao > -Original Message- > From: kra...@redhat.com > Sent: Tuesday, June 7, 2022 10:45 PM > To: Yao, Jiewen > Cc: devel@edk2.groups.io; Pawel Polawski ; Brijesh > Singh ; Oliver Steffen ; James > Bottomley ; Ard Biesheuvel ; > Aktas,

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch

2022-06-07 Thread Gerd Hoffmann
On Tue, Jun 07, 2022 at 01:43:00PM +, Yao, Jiewen wrote: > Hello > As far as I know the TemporaryRamMigration() is an optional PPI according to > PI spec, I forget why we add it in the beginning. git log isn't very helpful here either, seems to date back to pre-git times without descriptive

Re: [edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch

2022-06-07 Thread Yao, Jiewen
Hello As far as I know the TemporaryRamMigration() is an optional PPI according to PI spec, I forget why we add it in the beginning. To reduce the maintenance effort, can we try to remove it? As such the PEI core can perform the migration in

[edk2-devel] [PATCH v4 1/1] OvmfPkg/Sec: fix stack switch

2022-06-07 Thread Gerd Hoffmann
The ebp/rbp register can either be used for the frame pointer or as general purpose register. With gcc (and clang) this depends on the -f(no-)omit-frame-pointer switch. This patch updates tools_def.template to explicitly set the compiler option and also add a define to allow conditionally

[edk2-devel] [PATCH v2 4/4] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-06-07 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

[edk2-devel] [PATCH v2 3/4] CI: Use Fedora 35 container (Linux only)

2022-06-07 Thread Oliver Steffen
Run all Linux based jobs in a container, using a custom Fedora 35 image (gcc 11). The image is hosted on ghcr.io and the Dockerfiles are here: https://github.com/tianocore/containers Do not run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these.

[edk2-devel] [PATCH v2 2/4] CI: add ~/.local/bin to PATH (Linux only)

2022-06-07 Thread Oliver Steffen
Fix pip install. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-build-run-steps.yml

[edk2-devel] [PATCH v2 1/4] CI: don't force python verison (Linux only)

2022-06-07 Thread Oliver Steffen
Use the Python supplied by the container image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 1 + .azurepipelines/templates/pr-gate-steps.yml| 1 + 2 files changed, 2 insertions(+) diff --git

[edk2-devel] [PATCH v2 0/4] CI: Use Fedora 35 container for Linux jobs

2022-06-07 Thread Oliver Steffen
Update CI, run all Linux (aka Ubuntu-GCC5) bases jobs in custom containers. The container image provides the required compiler toolchains and Qemu for the supported architectures. These are then no longer downloaded at runtime, avoiding CI failures due to download errors. This approach also

Re: [edk2-devel] Need clarification about UEFI Strings

2022-06-07 Thread Ayush Singh
Ok, Thanks for all the help. On Tue, Jun 7, 2022 at 3:28 PM Pedro Falcato wrote: > > I'd say that it depends. But 98% of the strings you'll find in UEFI > (including APIs) are UCS-2 CHAR16 strings. > > On Tue, Jun 7, 2022 at 9:19 AM Ayush Singh wrote: >> >> Thanks, Pedro, >> >> However,

Re: [edk2-devel] [PATCH 0/3] Introduce SecTpmMeasurementLibTdx

2022-06-07 Thread Yao, Jiewen
The previous patch created a new instance SecTpmMeasurementLibTdx, which is not a best idea. If we can use the existing instance, there is no need to create a new one. Just create a new instance. Thank you Yao Jiewen > -Original Message- > From: Gerd Hoffmann > Sent: Tuesday, June 7,

Re: [edk2-devel] [PATCH 0/3] Introduce SecTpmMeasurementLibTdx

2022-06-07 Thread Yao, Jiewen
Merged https://github.com/tianocore/edk2/pull/2951 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Yao, Jiewen > Sent: Sunday, June 5, 2022 10:10 AM > To: Xu, Min M ; devel@edk2.groups.io > Cc: Wang, Jian J ; Aktas, Erdem > ; James Bottomley ; Tom > Lendacky ; Gerd

Re: [edk2-devel] ovmf miscompiles with gcc-12

2022-06-07 Thread Gerd Hoffmann
On Tue, Jun 07, 2022 at 12:38:46PM +0200, Jiri Slaby wrote: > Hi, > > On 07. 06. 22, 12:31, Gerd Hoffmann wrote: > > > The reason is TemporaryRamMigration() overwrites rbp unconditionally -- it > > > adds an offset to rbp even if rbp is NOT used as a frame pointer > > > > > Now, what is the

Re: [edk2-devel] [PATCH 08/14] OvmfPkg: Use PcdOvmfWorkAreaBase instead of PcdSevEsWorkAreaBase

2022-06-07 Thread Gerd Hoffmann
On Mon, Jun 06, 2022 at 10:59:56AM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > It is an typo error that HobList pointer should be stored at > PcdOvmfWorkAreaBase, not PcdSevEsWorkAreaBase. How does that relate to lazy accept? To me

Re: [edk2-devel] [PATCH 07/14] OvmfPkg: Add PCD and DEFINEs for Lazy Accept page.

2022-06-07 Thread Gerd Hoffmann
On Mon, Jun 06, 2022 at 10:59:55AM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > Lazy accept page can be controlled in build time like below: > -D LAZY_ACCEPT_PARTIAL_MEM=512 > > The unit is MB. If it is 0 then it means Lazy-accept is

Re: [edk2-devel] [PATCH 02/14] MdePkg: Increase EFI_RESOURCE_MAX_MEMORY_TYPE

2022-06-07 Thread Gerd Hoffmann
On Mon, Jun 06, 2022 at 10:59:50AM +0800, Min Xu wrote: > From: Min M Xu > > RFC: https://bugzilla.tianocore.org/show_bug.cgi?id=3937 > > EFI_RESOURCE_MEMORY_UNACCEPTED is defined for unaccepted memory. > But this defitinion has not been officially in the PI spec. Base > on the code-first we

Re: [edk2-devel] [PATCH 0/3] Introduce SecTpmMeasurementLibTdx

2022-06-07 Thread Gerd Hoffmann
On Sun, Jun 05, 2022 at 09:02:45AM +0800, Min Xu wrote: > SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC phase. > It provides RTMR based measurement functions for Intel Tdx guest. > > Commit a708536dce introduces SecMeasurementLibTdx which provides the same > functions. But

Re: [edk2-devel] ovmf miscompiles with gcc-12

2022-06-07 Thread Gerd Hoffmann
Hi, > The reason is TemporaryRamMigration() overwrites rbp unconditionally -- it > adds an offset to rbp even if rbp is NOT used as a frame pointer > Now, what is the right way to fix this? Do the SetJump/LongJump in assembly > and wrap it into push rbp/pop rbp? push/pop rbp will break in

Re: [edk2-devel] Need clarification about UEFI Strings

2022-06-07 Thread Pedro Falcato
I'd say that it depends. But 98% of the strings you'll find in UEFI (including APIs) are UCS-2 CHAR16 strings. On Tue, Jun 7, 2022 at 9:19 AM Ayush Singh wrote: > Thanks, Pedro, > > However, according to the specs, it is possible to construct ASCII > Strings as well. So when would ASCII Strings

Re: [edk2-devel] Need clarification about UEFI Strings

2022-06-07 Thread Ayush Singh
Thanks, Pedro, However, according to the specs, it is possible to construct ASCII Strings as well. So when would ASCII Strings be used over normal UCS-2 Strings? Ayush Singh On Tue, Jun 7, 2022 at 1:13 PM Pedro Falcato wrote: > > Hi Ayush, > > In the latest UEFI 2.9 spec, it's specified under

Re: [edk2-devel] Need clarification about UEFI Strings

2022-06-07 Thread Pedro Falcato
Hi Ayush, In the latest UEFI 2.9 spec, it's specified under 2.3.1 that CHAR8 strings/characters are (usually) ASCII, and CHAR16 strings/characters are (usually) UCS-2 (*not* UTF-16). On Tue, Jun 7, 2022 at 7:02 AM Ayush Singh wrote: > Hello everyone, I am trying to write an implementation for

[edk2-devel] Need clarification about UEFI Strings

2022-06-07 Thread Ayush Singh
Hello everyone, I am trying to write an implementation for UEFI strings in Rust and just wanted clarification about some things. Are UEFI Strings UTF-16 encoded? I have looked at some previous Rust implementations for this and it seems UEFI does not support the whole UTF-16 but rather only UCS-2