Re: [edk2-devel] [PATCH v1 0/2] Add support to disable VirtIo net at runtime

2022-08-03 Thread Laszlo Ersek
On 08/04/22 04:52, Yuan Yu wrote: > Currently networking can only be enabled/disabled at compile time. This > patch series will add support to disable VirtIo net at runtime even if > the functionality is built into binary at compile time. > > This will enable VMM to reduce attack surface without

Re: [edk2-devel] [PATCH 1/2] UefiCpuPkg: Simplify InitializeSeparateExceptionStacks

2022-08-03 Thread Ni, Ray
1. Old code contains a picture that describes the buffer layout. It seems the picture disappears in new code. 2. When TSS is enabled, there is one descriptor in GDT that points to the TSS. But TSS is not part of GDT. New code contains comments to treat TSS as part of GDT. 3. Did you run ECC and

Re: [edk2-devel] [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC

2022-08-03 Thread Michael Kubacki
For the series: Reviewed-by: Michael Kubacki The patch formatting seems a little strange: 1. The patches don't have "Cc" lines. 2. What is this GUID message at the bottom of each patch? 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' By the way, I tested the AARCH64 PRM build with sample

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: AcpiTables: Add additional thread mapping in MADT

2022-08-03 Thread Oram, Isaac W
Generally, convention for "Pkg-Module" is "Pkg/Module: " not "Pkg: Module: ". Kind of a nit, but using : as separator will make parsing tools harder to write. Convention for comments is "no newline between comment block and code block" is that the comment applies to that block. A blank line

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS

2022-08-03 Thread Oram, Isaac W
Pushed as d09dafd0b9..a6b7458972 (fixed author format and trailing whitespace) -Original Message- From: devel@edk2.groups.io On Behalf Of Oram, Isaac W Sent: Wednesday, August 3, 2022 4:07 PM To: devel@edk2.groups.io; Sinha, Ankit Cc: Desimone, Nathaniel L ; Dong, Eric Subject: Re:

Re: [edk2-devel][edk2-platforms][PATCH V2 1/1] MinPlatformPkg: Add and re-arrange PCDs to configure FADT and FACS

2022-08-03 Thread Oram, Isaac W
Reviewed-by: Isaac Oram Please run \edk2\BaseTools\Scripts\PatchCheck.py on commits to identify whitespace and other simple issues. There are also typically editor settings to clean these automatically. I will clean up trailing whitespace on push. Regards, Isaac -Original Message-

[edk2-devel] [edk2-staging][PATCH v4 1/2] EDK2 Code First: PI Specification: New error codes of Host Software class

2022-08-03 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 This change includes specification update markdown file that describes the proposed PI Specification v1.7 Errata A in detail and potential impact to the existing codebase. Cc: Andrew Fish Cc: Leif Lindholm Cc: Michael D Kinney Cc:

[edk2-devel] [edk2-staging][PATCH v4 0/2] EDK2 Code First: PI Specification: Expand PI Status Codes

2022-08-03 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 This patch series is a rebase of previous submission: https://edk2.groups.io/g/devel/message/86374 This change is sent for review to reflect the industry standard forum discussion outcome. During the PIWG meeting, the forum agreed with

[edk2-devel] [edk2-staging][PATCH v4 2/2] MdePkg: MmCommunication: Add new Host Software class Error Code to MdePkg

2022-08-03 Thread Kun Qin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3794 This change introduces a new error code definitions under Host Software class. The new error code definition will cover system reboot events under the conditions of inconsistent memory map from one boot to another. These error codes could

Re: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Load Boot Logo into ACPI table

2022-08-03 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Tuesday, August 2, 2022 1:00 PM To: devel@edk2.groups.io Cc: Rhodes, Sean ; Dong, Guo ; Ni, Ray Subject: [edk2-devel] [PATCH 2/2] UefiPayloadPkg: Load Boot Logo into ACPI table If the

Re: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a Macro to enable Boot Logo

2022-08-03 Thread Guo Dong
Reviewed-by: Guo Dong -Original Message- From: devel@edk2.groups.io On Behalf Of Sean Rhodes Sent: Tuesday, August 2, 2022 1:00 PM To: devel@edk2.groups.io Cc: Rhodes, Sean ; Dong, Guo ; Ni, Ray Subject: [edk2-devel] [PATCH 1/2] UefiPayloadPkg: Add a Macro to enable Boot Logo Add

[edk2-devel] Build fail error 7000

2022-08-03 Thread 游驣智
Hi EDK team, I am trying to build a capsule driver image for update in UEFI shell, But not success. The tool chain is VS2019, log as attach file. Could you help on it ? Thanks, Eric.Yiu Engineer Software R Department Tel: 886-2-89131312 ext. 132 GIGAIPC CO., LTD -=-=-=-=-=-=-=-=-=-=-=-

Re: [edk2-devel] [PATCH v3 0/6] Enhance DynamicTablesPkg modules

2022-08-03 Thread Kun Qin
Hi DynamicTablePkg maintainers, Do you have any further feedback on this patch series? Any input is appreciated. Thanks, Kun On 7/30/2022 10:37 PM, Kun Qin via groups.io wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3996 REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3997

[edk2-devel] [PATCH v1 4/5] PrmPkg: Support AArch64 builds using GCC

2022-08-03 Thread Sami Mujawar
From: Jose Marinho Add support to build PrmPkg for AArch64 using the GCC compiler. Add AARCH64 architecture to the list of supported architectures. Add BaseStackCheck library to allow for Prm module builds on AARCH64. Also update the CI to add dependency on ArmPkg. Signed-off-by: Jose Marinho

[edk2-devel] [PATCH v1 0/5] Add support to build PRM for AARCH64 using GCC

2022-08-03 Thread Sami Mujawar
This patch series adds support to build PRM for AARCH64 using GCC. The changes can be seen at: https://github.com/samimujawar/edk2/tree/2238_aarch64_prm_support_v1 Jose Marinho (5): Basetools/GenFw: Allow AARCH64 builds to use the --prm flag PrmPkg: Enable external visibility on PRM symbols

[edk2-devel] [PATCH v1 2/5] PrmPkg: Enable external visibility on PRM symbols

2022-08-03 Thread Sami Mujawar
From: Jose Marinho Enable GCC compilations to keep external symbols when generating a PRM module. Signed-off-by: Jose Marinho Signed-off-by: Sami Mujawar --- PrmPkg/Include/Prm.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/PrmPkg/Include/Prm.h b/PrmPkg/Include/Prm.h index

[edk2-devel] [PATCH v1 3/5] PrmPkg: Build Prm Samples with GCC for AARCH64

2022-08-03 Thread Sami Mujawar
From: Jose Marinho - Add the --prm flag to the GENFW_FLAGS - Add the --no-gc-section to the linker flags so that apparently unreferenced symbols are not prematurely removed from the .dll which is used to generate the Prm module .efi. - Force the linker to maintain the PrmModuleExportDescriptor

[edk2-devel] [PATCH v1 1/5] Basetools/GenFw: Allow AARCH64 builds to use the --prm flag

2022-08-03 Thread Sami Mujawar
From: Jose Marinho The GenFw invocation with the --prm flag was previously reserved for X64. AArch64 platforms, built with GCC5, can also deploy PRM modules, hence the --prm flag is also applicable in builds targeting the AARCH64 architecture. This commit enables the --prm flag to be used for

[edk2-devel] [PATCH v1 5/5] PrmPkg: Add details on AArch64 build to the Readme.

2022-08-03 Thread Sami Mujawar
From: Jose Marinho Specify how to build the PrmPkg for the AArch64 architecture. Make the 2 following notes: - the PrmPkg has only been tested on AArch64 using the GCC5 toolchain. - All symbols to be listed in the PRMT as well as the PrmModuleExportDescriptor must be explicitly preserved by

Re: [edk2-devel] [PATCH] Add support for SMBIOS Spec 3.6.0 to SmBios.h

2022-08-03 Thread Samer El-Haj-Mahmoud
A quick compare against the SMBIOS 3.6.0. Looks good! Thanks for adding this. Reviewed-By: Samer El-Haj-Mahmoud > -Original Message- > From: devel@edk2.groups.io On Behalf Of Sainadh > Nagolu via groups.io > Sent: Wednesday, August 3, 2022 12:52 AM > To: devel@edk2.groups.io; Sainadh

[edk2-devel] [PATCH EDK2 v1 0/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning

2022-08-03 Thread wenyi,xie via groups.io
Main Changes : 1.Change the type of gTimeOut to UINT32. Wenyi Xie (1): EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning EmbeddedPkg/Library/GdbSerialDebugPortLib/GdbSerialDebugPortLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.20.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=-

[edk2-devel] [PATCH EDK2 v1 1/1] EmbeddedPkg/GdbSerialDebugPortLib:fix compile warning

2022-08-03 Thread wenyi,xie via groups.io
The value of gTimeOut is from PcdGdbMaxPacketRetryCount, and this PCD is UINT32. So change the declaratrion of gTimeOut to UINT32 to fix compile warning. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Wenyi Xie ---

Re: [edk2-devel] [PATCH v1 1/5] ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier

2022-08-03 Thread Ard Biesheuvel
On Tue, 2 Aug 2022 at 20:04, wrote: > > From: Michael Kubacki > > These debug messages are repeated in both NorFlashBlockIoReadBlocks() > and NorFlashBlockIoWriteBlocks(): > > "NorFlashBlockIoWriteBlocks(MediaId=0x%x, Lba=%ld, BufferSize=0x%x" > "bytes (%d kB), BufferPtr @ 0x%08x)\n" > >

Re: [edk2-devel] [PATCH V2 3/8] EmbeddedPkg: Add AllocateRuntimePages in PrePiMemoryAllocationLib

2022-08-03 Thread Ard Biesheuvel
On Sun, 26 Jun 2022 at 05:06, Min Xu wrote: > > From: Min M Xu > > AllocateRuntimePages is used to allocate one or more 4KB pages of > type EfiRuntimeServicesData. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Abner Chang > Cc: Daniel Schaefer > Cc: Gerd Hoffmann > Signed-off-by: Min Xu