Re: [edk2-devel] [PATCH v2 2/2] OvmfPkg/OvmfPkgX64: Allow runtime control of IPv4 and IPv6 support

Hi, > > Looks good to me, but should be reflected to the other DSC files, and > > perhaps (see Gerd's comments) factored out to some common include snippet. > > Fair enough, although I'm not sure where to look for Gerd's comments? > Did they make it to the list? Was a reply to v1 series. Summ

[edk2-devel] [PATCH 0/5] CryptoPkg: Add HMAC-SHA384 cipher support.

HmacSha256 is already supported on Edk2. This patchset is to add HmacSha384 support. With this change, the size increase of BaseCyrptLib is about 7K bytes. HmacSha384 function is verifed by the Host UnitTest. And also it has been integratd in https://github.com/tianocore/edk2-staging/tree/DeviceSe

[edk2-devel] [PATCH 1/5] CryptoPkg: Add new hmac definition to cryptlib

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Include/Library/BaseCryptLib.h | 188 + .../Pcd/PcdCryptoServiceFamilyEnable.h| 13 ++ CryptoPkg/Private/

[edk2-devel] [PATCH 3/5] CryptoPkg: Update CryptLib inf as the file name changed.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf | 2 +- CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf | 2 +- CryptoPkg/Library

[edk2-devel] [PATCH 2/5] CryptoPkg: Add HMAC-SHA384 cipher support.

Rename file from CryptHmacSha256 to CryptHmac and add HmacSha384 and HmacSha256All funcitons. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../Library/BaseCryptLib/Hmac/CryptHmac.c | 62

[edk2-devel] [PATCH 4/5] CryptoPkg: Add new hmac SHA api to Crypto Service.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- CryptoPkg/CryptoPkg.dsc | 3 + CryptoPkg/Driver/Crypto.c | 221 ++ .../BaseCryptLibOn

[edk2-devel] [PATCH 5/5] CryptoPkg: add Hmac Sha384 to host UnitTest.

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4025 Signed-off-by: Qi Zhang Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang --- .../BaseCryptLib/UnitTestHostBaseCryptLib.inf | 2 +- .../UnitTest/Library/BaseCryptLib/HmacTests.c | 19 +++ 2 files changed, 2

[edk2-devel] [PATCH] Maintainers.txt: Update reviewers for IntelSiliconPkg

Add Ashraf Ali S as IntelSiliconPkg reviewers Signed-off-by: Ashraf Ali S Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 5e403ce851..e2ca67a0f2 100644 --- a/Maintainers.txt +++ b

[edk2-devel] [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg

Add Ashraf Ali S as IntelSiliconPkg reviewers Signed-off-by: Ashraf Ali S Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram --- Maintainers.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Maintainers.txt b/Maintainers.txt index 5e403ce851..3fe5dc21a8 100644 --- a/Maintainers.txt +++ b

Re: [edk2-devel] [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg

Reviewed-by: Ray Ni > -Original Message- > From: S, Ashraf Ali > Sent: Tuesday, August 23, 2022 3:27 PM > To: devel@edk2.groups.io > Cc: S, Ashraf Ali ; Ni, Ray ; > Chaganty, Rangasai V ; Oram, Isaac W > > Subject: [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg > > Ad

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

Hi, > Ah, I forget to reserve the work-area as RT_Data in below code: > BuildMemoryAllocationHob ( > (EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 (PcdOvmfWorkAreaBase), > (UINT64)(UINTN)FixedPcdGet32 (PcdOvmfWorkAreaSize), > PlatformInfoHob->S3Supported ? EfiACPIMemor

Re: [edk2-devel] MdeModulePkg build fails for AARCH64 on Ubuntu 22.04

Hi Liming, Reverting patch may not a good idea, some platforms have done the implementation based on the DSC spec, if revert, those platforms build will break. This commit 039bdb4d3e96f9c9264abf135b8a0eef2e2b4860 make the Basetools behavior be consistent with DSC spec so I don't think it's a re

Re: [edk2-devel] [PATCH] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation

Hello Jeff, On 8/22/22 18:21, Jeff Brasen wrote: Expose the UID value to GeneratePciSlots(). This is needed for some cases for example: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports I guess the UID would be

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

On August 23, 2022 3:38 PM, Gerd Hoffmann wrote: > Hi, > > > Ah, I forget to reserve the work-area as RT_Data in below code: > > BuildMemoryAllocationHob ( > > (EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 > (PcdOvmfWorkAreaBase), > > (UINT64)(UINTN)FixedPcdGet32 (PcdOvmfWorkA

Re: [edk2-devel] [PATCH v1-resend 1/1] ShellPkg: Add revision check for DSDT Header on Arm

Hi Zhichao, Would it be possible to get some feedback on this patch? Regards, Edward On 20/07/2022 09:59, Edward Pickup via groups.io wrote: Bugzilla: 3995 (https://bugzilla.tianocore.org/show_bug.cgi?id=3995) ACPI 6.4 spec states that if the revision field in the DSDT header is less than 2,

[edk2-devel] [PATCH 0/6] ArmPkg/SMBIOS fixes and improvements

This patchset is to update the ArmPkg/SMBIOS for fixes and improvements. Minh Nguyen (5): ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02" ArmPkg/Smbios

[edk2-devel] [PATCH 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib

From: Minh Nguyen In some scenarios, the processor version may be updated dynamically from pre-UEFI firmware during booting. But the processor version is fixed with PCD (PcdProcessorVersion), so it can not be updated it dynamically. This patch will support setting that value both statically and d

[edk2-devel] [PATCH 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call

From: Minh Nguyen According to "SMC Calling Convention" specification, section 7.4, return value of Arm Architecture Calls is stored at first argument of SMC aguments (ARM_SMC_ARGS). This value can be negative values indicating error or positive values (including zero) indicating success. Positiv

[edk2-devel] [PATCH 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"

From: Minh Nguyen This patch fixes typo from "AssertTagType02" to "AssetTagType02". Signed-off-by: Nhi Pham --- ArmPkg/Include/Library/OemMiscLib.h | 2 +- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 3 ++-

[edk2-devel] [PATCH 3/6] ArmPkg/SmbiosMiscDxe: Support fetching System UUID

This adds an API to OemMiscLib for fetching the system UUID according to the platform. Signed-off-by: Nhi Pham --- ArmPkg/Include/Library/OemMiscLib.h | 12 ArmPkg/Universal/Smbios/OemMiscLibNull/OemMiscLib.c | 18

[edk2-devel] [PATCH 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2

From: Minh Nguyen This patch removes redundant updates of "BoardManufacturerType02" and "SerialNumberType02". Signed-off-by: Nhi Pham --- ArmPkg/Universal/Smbios/SmbiosMiscDxe/Type02/MiscBaseBoardManufacturerFunction.c | 10 -- 1 file changed, 10 deletions(-) diff --git a/ArmPkg/Un

[edk2-devel] [PATCH 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib

From: Minh Nguyen In some scenarios, the information of Bios Version, Bios Release and Embedded Controller Firmware Release are fetched during UEFI booting. This patch supports updating those fields dynamically when the PCDs are empty. Signed-off-by: Nhi Pham --- ArmPkg/Include/Library/OemMisc

[edk2-devel] [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4027 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Cc: Ovais F Pir Signed-off-by: Singh Deepak5x --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDx

[edk2-devel] [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4027 Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: S, Ashraf Ali Cc: Pir, Ovais F Signed-off-by: Singh Deepak5x diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/PcieSecurity/IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c

[edk2-devel] [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4027 Signed-off-by: Deepak Singh Cc: Ray Ni Cc: Rangasai V Chaganty Cc: Isaac Oram Cc: Ashraf Ali S Cc: Ovais F Pir --- .../IntelPciDeviceSecurityDxe/IntelPciDeviceSecurityDxe.c | 2 +- .../Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDxe/Vt

Re: [edk2-devel] [PATCH] Maintainers.txt: Update maintainers list

Reviewed-by: Nickle Wang Thanks, Nickle Sunil V L 於 2022年8月23日 週二 中午12:21寫道： > On Mon, Aug 22, 2022 at 11:13:00AM +0800, abner.ch...@amd.com wrote: > > From: Abner Chang > > > > Update package maintainers for below package/arch, > > > > 1. RISCV64 Architecture: > >Abner is stepping out fro

Re: [edk2-devel] [PATCH] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments

Reviewed-by: Ashraf Ali S Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.  -Original Message- From: Singh, DeepakX Sent: Tuesday, August 23, 2022 3:42 PM To: devel@edk2.groups.io Cc: Singh, DeepakX ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S, Ashraf Ali ; Pir, Ovais

Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Reserve the Ovmf work area as RT_DATA

On 8/23/22 03:40, Xu, Min M wrote: On August 23, 2022 3:38 PM, Gerd Hoffmann wrote: Hi, Ah, I forget to reserve the work-area as RT_Data in below code: BuildMemoryAllocationHob ( (EFI_PHYSICAL_ADDRESS)(UINTN)FixedPcdGet32 (PcdOvmfWorkAreaBase), (UINT64)(UINTN)Fixe

Re: [edk2-devel] [PATCH 0/6] ArmPkg/SMBIOS fixes and improvements

Thanks. For the series: Reviewed-by: Rebecca Cran On 8/23/22 04:59, Nhi Pham via groups.io wrote: This patchset is to update the ArmPkg/SMBIOS for fixes and improvements. Minh Nguyen (5): ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib ArmPkg: Correct return value of

Re: [edk2-devel] [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg

Reviewed-by: Sai Chaganty -Original Message- From: S, Ashraf Ali Sent: Tuesday, August 23, 2022 12:27 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W Subject: [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg Add Ashraf A

Re: [edk2-devel] [PATCH 0/6] ArmPkg/SMBIOS fixes and improvements

Hello, Some of the patches are modifying: ArmPkg/Universal/Smbios/SmbiosMiscDxe/ This folder has been ignored by the EccCheck done in the CI in order to enable uncrustify: https://edk2.groups.io/g/devel/topic/87268735#83984 Indeed, the EccCheck is only run on the code which is modified, and a

[edk2-devel] [PATCH 01/24] .pytool: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Sean Brogan Cc: Bret Barkelew Signed-off-by: Pierre Gondois --- .pytool/Plugin/UncrustifyCheck/Readme.md | 2 +- .pytool/Plugin/UncrustifyCheck/uncrustify.cfg | 2 +- 2 files

[edk2-devel] [PATCH 03/24] ArmPlatformPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Pierre Gondois --- .../Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[edk2-devel] [PATCH 04/24] ArmVirtPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ard Biesheuvel Signed-off-by: Pierre Gondois --- .../Fdt16550SerialPortHookLib/EarlyFdt16550SerialPortHookLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[edk2-devel] [PATCH 00/24] Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the below packages, remove duplicated words. The following command was used to find the occurrence of duplicated words: egrep "(\b[a-zA-Z]+) \1\b" The patches can be seen at: https://github.com/PierreARM/edk2/tree/pg/duplicated_w

[edk2-devel] [PATCH 02/24] ArmPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Leif Lindholm Cc: Ard Biesheuvel Signed-off-by: Pierre Gondois --- ArmPkg/Drivers/ArmScmiDxe/Scmi.c | 4 ++-- ArmPkg/Library/ArmMmuLib/AArch64/ArmMmuLibCore.c | 2 +

[edk2-devel] [PATCH 05/24] BaseTools: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Bob Feng Cc: Liming Gao Signed-off-by: Pierre Gondois --- BaseTools/Source/C/Common/FirmwareVolumeBuffer.c| 6 +++--- BaseTools/Source/C/DevicePath/DevicePathUtilities.c | 2 +-

[edk2-devel] [PATCH 06/24] CryptoPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Pierre Gondois --- CryptoPkg/Library/BaseCryptLib/Hash/CryptCShake256.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[edk2-devel] [PATCH 07/24] DynamicTablesPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Sami Mujawar Cc: Alexei Fedorov Signed-off-by: Pierre Gondois --- DynamicTablesPkg/Include/Library/HwInfoParserLib.h | 2 +- .../Library/Acpi/Arm/AcpiSsdtCmn600LibArm/

[edk2-devel] [PATCH 09/24] EmulatorPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Pierre Gondois --- EmulatorPkg/FvbServicesRuntimeDxe/FWBlockService.c | 2 +- EmulatorPkg/Win/Host/WinThunk.c| 2 +- 2 fil

[edk2-devel] [PATCH 08/24] EmbeddedPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Signed-off-by: Pierre Gondois --- EmbeddedPkg/GdbStub/SerialIo.c | 2 +- EmbeddedPkg/Include/Libr

[edk2-devel] [PATCH 10/24] FatPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ray Ni Signed-off-by: Pierre Gondois --- FatPkg/EnhancedFatDxe/UnicodeCollation.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/FatPkg/EnhancedFatDxe/UnicodeCo

[edk2-devel] [PATCH 12/24] MdeModulePkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Jian J Wang Cc: Liming Gao Signed-off-by: Pierre Gondois --- MdeModulePkg/Bus/Pci/EhciDxe/Ehci.c | 2 +- MdeModulePkg/Bus/Pci/EhciPei/EhcPeim.c | 2

[edk2-devel] [PATCH 14/24] NetworkPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Maciej Rabeda Signed-off-by: Pierre Gondois --- NetworkPkg/DnsDxe/ComponentName.c | 4 ++-- NetworkPkg/HttpBootDxe/HttpBootComponentName.c

[edk2-devel] [PATCH 13/24] MdePkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Pierre Gondois --- MdePkg/Include/Guid/GraphicsInfoHob.h | 2 +- MdePkg/Include/Library/DevicePathLib.h

[edk2-devel] [PATCH 15/24] OvmfPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ard Biesheuvel Cc: Jiewen Yao Signed-off-by: Pierre Gondois --- OvmfPkg/Library/PeilessStartupLib/X64/VirtualMemory.c | 6 +++--- OvmfPkg/Library/PlatformDebugLibIoPort/DebugLi

[edk2-devel] [PATCH 11/24] IntelFsp2WrapperPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Chasel Chiu Cc: Nate DeSimone Signed-off-by: Pierre Gondois --- IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Inte

[edk2-devel] [PATCH 17/24] RedfishPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Abner Chang Signed-off-by: Pierre Gondois --- RedfishPkg/RedfishDiscoverDxe/ComponentName.c | 4 ++-- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 +- RedfishPkg/Redf

[edk2-devel] [PATCH 16/24] PcAtChipsetPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ray Ni Signed-off-by: Pierre Gondois --- .../Bus/Pci/IdeControllerDxe/ComponentName.c | 4 ++-- .../Bus/Pci/IdeControllerDxe/IdeController.h | 4 ++-- PcAtChip

[edk2-devel] [PATCH 18/24] SecurityPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Jiewen Yao Cc: Jian J Wang Signed-off-by: Pierre Gondois --- SecurityPkg/Include/Library/Tpm2CommandLib.h | 2 +- .../Library/DxeTpmMeasurementLib/DxeTpmMeasuremen

[edk2-devel] [PATCH 19/24] ShellPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ray Ni Cc: Zhichao Gao Signed-off-by: Pierre Gondois --- ShellPkg/Include/Library/ShellCommandLib.h| 2 +- ShellPkg/Include/Library/ShellLib.h

[edk2-devel] [PATCH 21/24] StandaloneMmPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Signed-off-by: Pierre Gondois --- StandaloneMmPkg/Library/StandaloneMmMemLib/StandaloneMmMemLib.c | 2 +- .../Library/StandaloneMmMe

[edk2-devel] [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Hao A Wu Signed-off-by: Pierre Gondois --- .../Library/DebugAgent/SmmDebugAgent/SmmDebugAgentLib.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Sourc

[edk2-devel] [PATCH 22/24] UefiCpuPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Eric Dong Cc: Ray Ni Signed-off-by: Pierre Gondois --- .../Library/RegisterCpuFeaturesLib/RegisterCpuFeatures.h | 2 +- .../Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesL

[edk2-devel] [PATCH 23/24] UefiPayloadPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Guo Dong Cc: Ray Ni Cc: Sean Rhodes Signed-off-by: Pierre Gondois --- UefiPayloadPkg/Include/Library/SpiFlashLib.h| 2 +- UefiPayloadPkg/Library/SpiFlashLib/SpiFlashLib.c

[edk2-devel] [PATCH 24/24] UnitTestFrameworkPkg: Remove duplicated words

From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Also change in/out tag to pass the EccCheck. Cc: Michael D Kinney Cc: Michael Kubacki Signed-off-by: Pierre Gondois --- .../Library/Posix/DebugLibPosix/DebugLibPosix.c | 2

Re: [edk2-devel] [PATCH 1/6] ArmPkg/ProcessorSubClassDxe: Get processor version from OemMiscLib

Hi Nhi, Thank you for this patch. Please find my response inline marked [SAMI]. Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: From: Minh Nguyen In some scenarios, the processor version may be updated dynamically from pre-UEFI firmware during booting. But the processor versi

Re: [edk2-devel] [PATCH 2/6] ArmPkg: Correct return value of "SMCCC_ARCH_SOC_ID" Function ID call

Hi Nhi, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: From: Minh Nguyen According to "SMC Calling Convention" specification, section 7.4, return value of Arm Architecture Calls is stored at first argument of SMC aguments (A

Re: [edk2-devel] [PATCH 3/6] ArmPkg/SmbiosMiscDxe: Support fetching System UUID

Hi Nhi, These change look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: This adds an API to OemMiscLib for fetching the system UUID according to the platform. Signed-off-by: Nhi Pham --- ArmPkg/Include/Library/OemMiscLib.h

Re: [edk2-devel] [PATCH 4/6] ArmPkg/SmbiosMiscDxe: Fix typo of "AssetTagType02"

Hi Nhi, Thank you for this fix. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: From: Minh Nguyen This patch fixes typo from "AssertTagType02" to "AssetTagType02". Signed-off-by: Nhi Pham --- ArmPkg/Include/Library/OemMiscLib.h

Re: [edk2-devel] [PATCH 5/6] ArmPkg/SmbiosMiscDxe: Remove redundant updates in SMBIOS Type 2

Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: From: Minh Nguyen This patch removes redundant updates of "BoardManufacturerType02" and "SerialNumberType02". Signed-off-by: Nhi Pham --- ArmPkg/Universal/Smbios/

Re: [edk2-devel] [PATCH 11/24] IntelFsp2WrapperPkg: Remove duplicated words

Thanks for fixing the typo! Reviewed-by: Chasel Chiu > -Original Message- > From: pierre.gond...@arm.com > Sent: Tuesday, August 23, 2022 9:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Chiu, Chasel > ; Desimone, Nathaniel L > > Subject: [PATCH 11/24] IntelFsp2WrapperPkg: R

Re: [edk2-devel] [PATCH 6/6] ArmPkg/SmbiosMiscDxe: Get SMBIOS information from OemMiscLib

Hi Nhi, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 11:59 am, Nhi Pham wrote: From: Minh Nguyen In some scenarios, the information of Bios Version, Bios Release and Embedded Controller Firmware Release are fetched during UEFI booting. This patch

Re: [edk2-devel] [PATCH 07/24] DynamicTablesPkg: Remove duplicated words

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 05:00 pm, pierre.gond...@arm.com wrote: From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Sami Mujawar Cc: Alexei Fedorov Sig

Re: [edk2-devel] [PATCH 21/24] StandaloneMmPkg: Remove duplicated words

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 05:00 pm, pierre.gond...@arm.com wrote: From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc:

Re: [edk2-devel] [PATCH 04/24] ArmVirtPkg: Remove duplicated words

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote: From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Ard Biesheuvel Signed-off-by: P

Re: [edk2-devel] [PATCH 03/24] ArmPlatformPkg: Remove duplicated words

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote: From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Leif Lindholm Cc: Ard Biesheuve

Re: [edk2-devel] [PATCH 02/24] ArmPkg: Remove duplicated words

Hi Pierre, Thank you for this patch. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 23/08/2022 05:00 pm, PierreGondois via groups.io wrote: From: Pierre Gondois In an effort to clean the documentation of the above package, remove duplicated words. Cc: Leif Lindholm Cc: Ard Biesheuve

Re: [edk2-devel] [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg

Reviewed-by: Isaac Oram -Original Message- From: S, Ashraf Ali Sent: Tuesday, August 23, 2022 12:27 AM To: devel@edk2.groups.io Cc: S, Ashraf Ali ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W Subject: [PATCH V2] Maintainers.txt: Update reviewers for IntelSiliconPkg Add Ashraf Ali

[edk2-devel] [GSoC 22] Rust std PR Update

Hello everyone. This is a quick update about the Google Summer of Code Rust Std project. The Draft PR, which I opened a week ago, has now been marked Ready for Review [1]. I have also started the API change proposal required for adding new public APIs to Rust [2]. So feel free to chime in there to

[edk2-devel] email issues resolved

Hi everyone, As some of you might have noticed, my email setup broke a little over a month ago. At the time I was on leave, so did not notice for a while. And upon my return, it turned out it had broken in New and Exciting ways - so it took some time to restore. This has now been achieved, and I

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

Implementing this way will break the build for most of the open MinPlatform ports. At minimum, please add the CompressLib to CoreCommonLib.dsc next to the UefiDecompressLib instantiation so that it is included automatically for most boards. Regarding the design, I agree this is a good capabili

Re: [edk2-devel] [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments

Reviewed-by: Isaac Oram Note that comparing the two patches shows no delta other than timestamp and title. -Original Message- From: Singh, DeepakX Sent: Tuesday, August 23, 2022 1:44 AM To: devel@edk2.groups.io Cc: Singh, DeepakX ; Ni, Ray ; Chaganty, Rangasai V ; Oram, Isaac W ; S,

Re: [edk2-devel] [PATCH V2] IntelSiliconPkg: Fix DEBUG macros having incorrect number of arguments

Pushed as 9769bf28d1..e12240390f Note that I had to fixup your author and signed off messages. Author can be configured in groups.io settings I believe. Signed off indicates an issue with your git config settings for name and email. Also, I now notice the patch email was missing "[edk2-devel]" and

Re: [edk2-devel] [PATCH 2/2] Dynamic Tbl Mgr: MPAM: MPAM Generator and supporting files

Hello, Just a reminder to provide feedback on this patch. Thanks, Swati swatis...@nvidia.com From: Name Sent: Tuesday, August 16, 2022 2:18 PM To: devel@edk2.groups.io ; sami.muja...@arm.com ; alexei.fedo...@arm.com ; michael.d.kin...@intel.com ; gaolim...@byo

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

Just a reminder to provide feedback on this patch. Thanks, Swati swatis...@nvidia.com From: Name Sent: Tuesday, August 16, 2022 2:18 PM To: devel@edk2.groups.io ; sami.muja...@arm.com ; alexei.fedo...@arm.com ; michael.d.kin...@intel.com ; gaolim...@byosoft.co

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

Agreed with Isaac that having the compression capability be more general use would be nice. However, I think it would better match the EDK II design style if we had a second implementation of LargeVariable*Lib that added the compression capability on top of the original LargeVariable*Lib. I als

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

> On Aug 19, 2022, at 1:26 AM, Rohit Mathew wrote: > > Hi Swatisri, > > Thanks for the patch. Please find my comments inline marked [Rohit] - > >> -Original Message- >> From: devel@edk2.groups.io >> mailto:devel@edk2.groups.io>> On Behalf Of Name >> via

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

Hi Andrew, From: Andrew Fish Sent: 23 August 2022 21:11 To: devel@edk2.groups.io; Rohit Mathew Cc: usern...@nvidia.com; Sami Mujawar ; Alexei Fedorov ; Mike Kinney ; gaolim...@byosoft.com.cn; zhiguang@intel.com; Swatisri Kantamsetti ; Thomas Abraham ; Thanu Rangarajan ; nd Subject: Re:

Re: [edk2-devel] [PATCH 1/2] Mde Pkg: Support for MPAM ACPI Table

Rohit, FYI I seem to remember when we added the bitfield verbiage to the UEFI Spec it was because there was lots of platform code that was using it. We did not really want to encourage its use it in public interfaces. Given there is lots of code 1st kind of things going on I’d figured I’d ment

Re: [edk2-devel] [PATCH 15/24] OvmfPkg: Remove duplicated words

Reviewed-by: Jiewen Yao > -Original Message- > From: pierre.gond...@arm.com > Sent: Wednesday, August 24, 2022 12:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Ard Biesheuvel > ; Yao, Jiewen > Subject: [PATCH 15/24] OvmfPkg: Remove duplicated words > > From: Pierre Gondois >

Re: [edk2-devel] [PATCH 21/24] StandaloneMmPkg: Remove duplicated words

Reviewed-by: Jiewen Yao > -Original Message- > From: pierre.gond...@arm.com > Sent: Wednesday, August 24, 2022 12:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Ard Biesheuvel > ; Sami Mujawar ; Yao, > Jiewen > Subject: [PATCH 21/24] StandaloneMmPkg: Remove duplicated words >

Re: [edk2-devel] [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words

Reviewed-by: Hao A Wu Best Regards, Hao Wu > -Original Message- > From: pierre.gond...@arm.com > Sent: Wednesday, August 24, 2022 12:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Wu, Hao A > > Subject: [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words > > From: Pier

Re: [edk2-devel] [edk2-platforms][PATCH v2 1/1] MinPlatformPkg: Add FspNvsBuffer compression option

A PCD to control library class instance seems redundant. The build already has capabilities to control library class instance per driver, per driver type, per architecture, etc. Let me know if there is some benefit to overriding PCD in board DSC vs overriding library class in board DSC that I

Re: [edk2-devel] [PATCH 20/24] SourceLevelDebugPkg: Remove duplicated words

> + if it exists, debug agent wiil copied it into the local Mailbox in SMM > space. There are more errors in the original text. E.g.: wiil -> will copied -> copy Can you help to fix them all? > -Original Message- > From: devel@edk2.groups.io On Behalf Of Wu, Hao A > Sent: Wednesday, Au

Re: [edk2-devel] [PATCH v1-resend 1/1] ShellPkg: Add revision check for DSDT Header on Arm

Hi Edward, Sorry, I missed this patch. Please feel free to inform the maintainers/reviewers if the patch didn't get response for a long time. The patch looks good to me. Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: devel@edk2.groups.io On Behalf Of Edward > Pi

[edk2-devel] [PATCH v1 0/1] Check arguments to be compliant with spec

Some function doesn't have certain checks to be compliant with UEFI specification. This series adds a check to return EFI_INVALID_PARAMETER if certain argument is NULL. The changes can be seen at: https://github.com/yyu/edk2/tree/return_value_fix_v1 Cc: Ard Biesheuvel Cc: Jordan Justen Cc: Las

[edk2-devel] [PATCH v1 1/1] OvmfPkg/PlatformDxe: Check RouteConfig arguments for spec compliance

Per UEFI Spec 2.9, EFI_HII_CONFIG_ROUTING_PROTOCOL.RouteConfig() should return EFI_INVALID_PARAMETERS if caller passes in a NULL for the Configuration parameter (see 35.4 EFI HII Configuration Routing Protocol). Add a check to return EFI_INVALID_PARAMETERS when Configuration is NULL. Cc: Ard Bies

Re: [edk2-devel][PATCH] Maintainers.txt: Update Maintainers/reviewers for universal payload

Reviewed-by: James Lu Thanks, James -Original Message- From: Guo, Gua Sent: Tuesday, August 23, 2022 8:45 AM To: Dong, Guo ; devel@edk2.groups.io Cc: Ni, Ray ; Kinney, Michael D ; Rhodes, Sean ; Lu, James ; Liu, Zhiguang Subject: RE: [edk2-devel][PATCH] Maintainers.txt: Update Main

Re: [edk2-devel][PATCH] Maintainers.txt: Update Maintainers/reviewers for universal payload

Reviewed-by: Ray Ni > -Original Message- > From: Dong, Guo > Sent: Tuesday, August 23, 2022 8:06 AM > To: devel@edk2.groups.io > Cc: Dong, Guo ; Ni, Ray ; Kinney, > Michael D ; Rhodes, Sean > ; Lu, James ; Guo, Gua > ; Liu, Zhiguang > Subject: [edk2-devel][PATCH] Maintainers.txt: Update

[edk2-devel] [PATCH v2] DynamicTablesPkg: AcpiSsdtPcieLibArm : Add UID to slot creation

Expose the UID value to GeneratePciSlots(). This is needed for some cases for example: https://docs.microsoft.com/en-us/windows-hardware/drivers/pci/dsd-for-pcie-root-ports#identifying-externally-exposed-pcie-root-ports Name (_DSD, Package () { ToUUID("EFCC06CC-73AC-4BC3-BFF0-76143807C389")

Re: [edk2-devel] [PATCH 19/24] ShellPkg: Remove duplicated words

Reviewed-by: Zhichao Gao Thanks, Zhichao > -Original Message- > From: pierre.gond...@arm.com > Sent: Wednesday, August 24, 2022 12:00 AM > To: devel@edk2.groups.io > Cc: Pierre Gondois ; Ni, Ray ; > Gao, Zhichao > Subject: [PATCH 19/24] ShellPkg: Remove duplicated words > > From: Pier